Posted	Nick	Remark
#openstack-nova - 2020-09-11
10:23:11	sean-k-mooney	right but that is not what i tought we used
10:23:25	sean-k-mooney	i tought we only had https://wiki.openstack.org/wiki/Nova/BugTriage
10:23:31	sean-k-mooney	the tag owners
10:23:42	lyarwood	we don't use CODEOWNERS for that, I'm suggesting we do so we can keep this in the actual git tree vs a random wiki page
10:24:08	sean-k-mooney	right but i dont think the peopel section makes sense
10:24:13	sean-k-mooney	the tags might
10:24:35	sean-k-mooney	the bullets in the people section dont correspond to files or subsystmes
10:26:39	lyarwood	ah sorry I was thinking about Developer Contacts
10:27:02	lyarwood	but anyway I'd rather this lived in tree as there appears to be tooling to do quick lookups locally
10:27:10	lyarwood	without relying on a given platform
10:27:47	sean-k-mooney	also did not know that existed
10:28:11	sean-k-mooney	but ya i can see it just bing a file in the git repo i guess
10:28:35	sean-k-mooney	just a simiple yaml file or rst in the docs under the contibutors section
10:29:06	sean-k-mooney	lyarwood: i wonder how much traffic if any the wiki gets
10:29:27	sean-k-mooney	i have very very rearly checked any of the wikis since we started using specs
10:30:00	sean-k-mooney	i do if google brings be there but that is very rare
10:30:40	lyarwood	sean-k-mooney: yeah we could also render it somehow in the docs I'm sure
10:31:01	lyarwood	sean-k-mooney: I also hardly ever go there, just had a patch against stable that needed to go to master first so went looking for docs
10:31:15	lyarwood	sean-k-mooney: found the wiki pages and recalled reading about CODEOWNERS somewhere the other day
10:31:21	sean-k-mooney	and the wiki was the only place?
10:31:56	sean-k-mooney	i dont know if we even mention the wiki in the contibutors guide anymore
10:32:03	lyarwood	sean-k-mooney: no I've linked to the contrib guide
10:32:18	lyarwood	sean-k-mooney: it links to the wiki in places iirc
10:32:23	sean-k-mooney	the only wiki page i check semi regularly is https://wiki.openstack.org/wiki/Meetings/Nova
10:34:15	brinzhang_	gibi: hi
10:34:36	brinzhang_	gibi: https://review.opendev.org/#/c/729563/13/nova/tests/unit/compute/test_api.py@7685 here, what did your mean?
10:36:48	gibi	brinzhang_: I don't expect any change in your patch due to that comment
10:37:13	gibi	it is just a note why we are collecting arqs for shelve even if during shelve we dont use them
10:37:18	brinzhang_	gibi: ack, thanks, I misunderstand that words
10:37:29	brinzhang_	yes
10:37:31	gibi	sorry, I could have been clearer in my words
10:37:55	brinzhang_	np, I will update later
10:39:05	gibi	thanks
10:39:07	brinzhang_	gibi: https://review.opendev.org/#/c/729563/13/nova/tests/fixtures.py@2601 this can't change to arq_host_rp_list = CyborgFixture.bindings_by_instance.get(instance_uuid, [])
10:39:09	openstackgerrit	Stephen Finucane proposed openstack/nova stable/queens: [placement] Add status and links fields to version document at / https://review.opendev.org/751239
10:39:33	brinzhang_	in Line2601, if the arq_host_rp_list==[], that will be an error
10:39:42	brinzhang_	so I will keep this not change yet
10:40:02	brinzhang_	if arq_host_rp_list ==[], return []
10:41:47	openstackgerrit	Hemanth Nakkina proposed openstack/nova master: Update pci stat pools based on PCI device changes https://review.opendev.org/749175
10:42:39	openstackgerrit	Stephen Finucane proposed openstack/nova stable/pike: [placement] Add status and links fields to version document at / https://review.opendev.org/751240
10:42:46	gibi	brinzhang_: you are right, my mistake I mixed arq_host_rp_list with bound_arq_list
10:42:52	brinzhang_	gibi: https://review.opendev.org/#/c/729563/13/nova/tests/fixtures.py@2557
10:42:59	brinzhang_	gibi: ack
10:56:25	openstackgerrit	Lee Yarwood proposed openstack/nova master: Support old & new versions of svm and vmx traits https://review.opendev.org/660515
10:56:37	lyarwood	^ kashyap / stephenfin ; fixed up some nits quickly if you can review and ack
10:56:47	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Follow up for I67504a37b0fe2ae5da3cba2f3122d9d0e18b9481 https://review.opendev.org/750184
10:57:56	stephenfin	lyarwood: Done. Assume kashyap will comment if he's not happy with it
10:58:03	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Cleanup unused code https://review.opendev.org/750947
11:00:32	openstackgerrit	Lee Yarwood proposed openstack/nova master: trivial: Remove useless comment https://review.opendev.org/748475
11:00:53	lyarwood	stephenfin: ^ and that
11:01:10	stephenfin	also done :)
11:14:03	openstackgerrit	Merged openstack/nova master: Spell out 3pp in vmware undeprecation reno https://review.opendev.org/751188
11:15:03	sean-k-mooney	stephenfin: just took another pass at https://review.opendev.org/#/c/749175/3 it now has a functional test. still want a reno but could you also take a look
11:16:13	stephenfin	sean-k-mooney: will do
11:21:33	hemanth_n	sean-k-mooney: thanks for the quick review, i will work on your comments
11:23:55	openstackgerrit	Brin Zhang proposed openstack/nova master: Cyborg shelve/unshelve support https://review.opendev.org/729563
11:25:37	sean-k-mooney	ill be deploying an sriov env later this after noon so ill try and test it there too
11:25:49	sean-k-mooney	i wont actully be able to test the device type changeing
11:26:02	sean-k-mooney	but i can atleast assert it works fine normally
11:26:16	openstackgerrit	Lee Yarwood proposed openstack/nova stable/stein: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/747611
11:26:40	sean-k-mooney	which i expect it will but i want to see if this fixes an edgecase i found when looking at sriov atach/detach
11:26:56	openstackgerrit	Lee Yarwood proposed openstack/nova stable/rocky: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/747612
11:27:47	openstackgerrit	Lee Yarwood proposed openstack/nova stable/queens: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/751249
11:27:53	sean-k-mooney	hemanth_n: i assume you would like this to be backported to all maintained branches too by the way
11:28:44	sean-k-mooney	i didnt see anything that would prevent that but we might want to updat the bug with the other branches since i did not do that when i triaged it
11:30:37	kashyap	stephenfin: Just reading the scroll, is it realted to VMX traits?
11:32:28	kashyap	(Ans: yes)
11:35:26	lyarwood	stephenfin: https://review.opendev.org/#/c/747746/4/nova/compute/resource_tracker.py - question in here, couldn't we use `reverting` here?
11:35:32	lyarwood	brb
11:43:56	stephenfin	lyarwood: replied
11:44:03	hemanth_n	sean-k-mooney: yes would like to backport, will do
11:44:42	openstackgerrit	Merged openstack/nova master: Add regression test for bug 1893284 https://review.opendev.org/748779
11:44:42	openstack	bug 1893284 in OpenStack Compute (nova) "Per-user quotas not scoped correctly when creating a server" [Low,In progress] https://launchpad.net/bugs/1893284 - Assigned to melanie witt (melwitt)
11:46:38	openstackgerrit	Federico Ressi proposed openstack/nova master: Log stack trace when fails launching a defined domain https://review.opendev.org/750652
11:46:44	openstackgerrit	Federico Ressi proposed openstack/nova master: Log stack trace when fails launching a defined domain https://review.opendev.org/750652
12:31:38	openstackgerrit	Merged openstack/nova master: Default user_id when not specified in check_num_instances_quota https://review.opendev.org/748550
12:31:44	openstackgerrit	Merged openstack/nova master: Fix an erroneous grammar in explanatory notes https://review.opendev.org/730176
12:45:33	openstackgerrit	Merged openstack/nova master: func: Remove references to attachment_id when volume_id is used https://review.opendev.org/749664
13:11:20	openstackgerrit	Stephen Finucane proposed openstack/nova master: xenapi: Remove driver and tests https://review.opendev.org/749304
13:11:21	openstackgerrit	Stephen Finucane proposed openstack/nova master: virt: Remove 'is_xenapi' helper https://review.opendev.org/749305
13:11:21	openstackgerrit	Stephen Finucane proposed openstack/nova master: xenapi: Remove Xen-only code paths https://review.opendev.org/749306
13:11:22	openstackgerrit	Stephen Finucane proposed openstack/nova master: objects: Remove 'XenapiLiveMigrateData' https://review.opendev.org/749307
13:11:22	openstackgerrit	Stephen Finucane proposed openstack/nova master: trivial: Final cleanup https://review.opendev.org/749308
13:11:23	openstackgerrit	Stephen Finucane proposed openstack/nova master: virt: Remove 'get_console_pool_info' API https://review.opendev.org/749311
13:11:23	openstackgerrit	Stephen Finucane proposed openstack/nova master: virt: Remove 'post_interrupted_snapshot_cleanup' API https://review.opendev.org/749313
13:11:24	openstackgerrit	Stephen Finucane proposed openstack/nova master: virt: Remove 'set_bootable' API https://review.opendev.org/749314
13:11:24	openstackgerrit	Stephen Finucane proposed openstack/nova master: virt: Remove various aggregate APIs https://review.opendev.org/749317
13:11:25	openstackgerrit	Stephen Finucane proposed openstack/nova master: virt: Remove 'get_per_instance_usage' API https://review.opendev.org/749318
13:11:25	openstackgerrit	Stephen Finucane proposed openstack/nova master: api: Remove 'os-agents' API https://review.opendev.org/749309
13:11:26	openstackgerrit	Stephen Finucane proposed openstack/nova master: objects: Remove Agent, AgentList https://review.opendev.org/749310
13:11:26	openstackgerrit	Stephen Finucane proposed openstack/nova master: virt: Remove 'get_all_bw_counters' API https://review.opendev.org/749312
13:11:27	openstackgerrit	Stephen Finucane proposed openstack/nova master: virt: Remove 'reset_network' API https://review.opendev.org/749315
13:11:27	openstackgerrit	Stephen Finucane proposed openstack/nova master: virt: Remove 'change_instance_metadata' API https://review.opendev.org/749316
13:16:59	openstackgerrit	Stephen Finucane proposed openstack/nova stable/queens: [placement] Add status and links fields to version document at / https://review.opendev.org/751239
13:20:19	openstackgerrit	Stephen Finucane proposed openstack/nova stable/pike: [placement] Add status and links fields to version document at / https://review.opendev.org/751240
13:49:42	lyarwood	stephenfin: https://review.opendev.org/#/c/747746/4/nova/compute/resource_tracker.py - final clarification
13:52:23	stephenfin	lyarwood: responded
13:56:08	lyarwood	stephenfin: ack thanks LGTM then
14:10:01	openstackgerrit	Merged openstack/nova master: Support old & new versions of svm and vmx traits https://review.opendev.org/660515
14:25:44	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Correctly disable greendns https://review.opendev.org/751302

Earlier   Later