Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-09-10
15:48:20 gibi nova meeting will start in 12 minutes on openstack-meeting-3
15:48:29 lyarwood bauzas / elod ; would you mind hitting this for artom please https://review.opendev.org/#/q/topic:bug/1879787+branch:stable/ussuri+status:open
15:49:12 bauzas lyarwood: I can,
15:49:29 bauzas but rushing up to finish the prelude before the meeting
15:54:42 artom I'm gonna have to skip the meeting, need lunch before running a time-sensitive errand
15:56:26 gibi artom: ack
15:56:32 gibi artom: enjoy
15:56:54 elod lyarwood: will do after the meeting, if I'm still needed there :)
15:58:28 sean-k-mooney what the env argument to get extra loging in func test
15:58:36 sean-k-mooney is it OS_DEBUG?
15:59:04 artom sean-k-mooney, yarp
15:59:19 artom But remember that if it passes, nothing is printed
15:59:35 sean-k-mooney its failing
15:59:43 sean-k-mooney also holy crap that a lot of logs
16:00:12 artom One might say it's a forrest :D
16:00:41 bauzas sean-k-mooney: OS_DEBUG=1
16:00:50 bauzas and asserFalse
16:01:00 bauzas assertFalse(True) if you wanna get'em
16:01:05 bauzas or pdb
16:01:21 sean-k-mooney yep OS_DEBUG=True tox -e functional -- 1815153 works
16:01:29 sean-k-mooney but it pring all the db migration too
16:01:33 bauzas right
16:01:46 bauzas I generally pipe the output in a file
16:02:00 bauzas 2>&1 | tee myfile
16:02:03 sean-k-mooney ya i think ill send it to lnav or something
16:02:35 bauzas but most of the time, it's just for debugging purpose and in this case, I pdb directly
16:02:48 bauzas way faster
16:03:04 sean-k-mooney ya so the issue not really simple to pdb debug
16:03:38 sean-k-mooney i mean i can but if im going that far ill proaly just run it in a ide
16:04:22 sean-k-mooney for some reason changing form using the az filter to using placement for az is chaning the behviaor fo some tests
16:04:36 sean-k-mooney not in all cases but in like 8 tests
16:05:01 sean-k-mooney well also the compute status filter
16:05:43 sean-k-mooney this particalar case is not az related
16:13:28 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: Support old & new versions of svm and vmx traits https://review.opendev.org/660515
16:17:37 bauzas stephenfin: can't see xenapi removal notes in https://docs.openstack.org/releasenotes/nova/unreleased.html
16:17:46 bauzas stephenfin: could you please point to me the patch itself ?
16:18:25 stephenfin bauzas: https://review.opendev.org/#/c/749304/ It was approved before I hit a merge conflict and lyarwood is waiting for a green gate before re-approving
16:18:45 bauzas stephenfin: k thanks, I'll proactively add this in the prelude section
16:19:35 bauzas actually, I'll hold on it
16:27:30 openstackgerrit Sylvain Bauza proposed openstack/nova master: Victoria 22.0.0 prelude section https://review.opendev.org/751045
16:35:45 openstackgerrit Merged openstack/python-novaclient master: Update master for stable/victoria https://review.opendev.org/750935
16:39:34 bauzas gibi: https://review.opendev.org/751045
16:39:41 bauzas it's a start
16:39:54 gibi bauzas: thanks
16:40:05 gibi I will read it tomorrow
16:42:54 lyarwood \o
16:52:17 sean-k-mooney so ya there are races in these tests...
16:53:37 sean-k-mooney specificlaly looks like we are not waiting for the service to be forced_down before doing the evacuate
16:53:52 sean-k-mooney we are just calling the api then continuing
17:08:02 lyarwood sean-k-mooney: which tests are these?
17:08:59 openstackgerrit Merged openstack/nova master: docs: Remove resize, cold migration from vTPM limitations https://review.opendev.org/750675
17:10:37 lyarwood oh gate/test_evacuate.sh doesn't wait until the service is down for the first round of evacuations
17:15:49 openstackgerrit Merged openstack/nova master: functional: Add 'start_compute' helper https://review.opendev.org/746943
17:15:55 openstackgerrit Merged openstack/nova master: functional: Use tempdir for CONF.instances_path https://review.opendev.org/746944
17:16:03 openstackgerrit Merged openstack/nova master: functional: Clean up PCI tests https://review.opendev.org/746945
17:16:04 openstackgerrit Luyao Zhong proposed openstack/nova master: Rollback when reset running live migration https://review.opendev.org/747899
17:16:04 openstackgerrit Luyao Zhong proposed openstack/nova master: Improve orphans tracking in resource tracker https://review.opendev.org/745282
17:16:14 openstackgerrit Merged openstack/nova master: functional: Add cold migration tests for PCI servers https://review.opendev.org/746946
17:21:16 stephenfin sean-k-mooney: did you get that patch reworked?
17:24:03 sean-k-mooney stephenfin: no
17:24:30 sean-k-mooney lyarwood: on sec ill provid the link
17:24:54 sean-k-mooney stephenfin: some of the func test are not correct
17:25:13 sean-k-mooney stephenfin: they are not waiting for palcment to be updated after we set teh comptue service down
17:26:16 sean-k-mooney lyarwood: stephenfin https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1815153.py#L108
17:26:32 sean-k-mooney we put the service down
17:26:56 sean-k-mooney but form the debug logs i am not seing us update placment before we then do the migrate or eveacuate in the next test
17:27:46 sean-k-mooney https://review.opendev.org/#/c/654596/8/nova/compute/api.py@5156 should have made the api call update placment
17:28:09 sean-k-mooney and the tests are using the latest microverion
17:29:00 lyarwood sean-k-mooney: that's not due to something with the placement fixture?
17:29:08 sean-k-mooney it might be
17:29:12 sean-k-mooney im going to mock _update_compute_provider_status
17:29:17 sean-k-mooney and see if its called
17:29:31 sean-k-mooney but i dont think it is being called
17:29:45 sean-k-mooney well i dont see a http request to placment to update the traits
17:29:46 openstackgerrit Lee Yarwood proposed openstack/nova master: test_evacuate: Wait until subnode is disabled before starting tests https://review.opendev.org/751065
17:30:35 lyarwood anyway ^ is what I thought you were talking about, we should be waiting there as well tbh
17:31:17 sean-k-mooney ya so i was debating just pooling for the api to show the service down and sleeping
17:31:58 sean-k-mooney i tried runing the periodic task to have update resouce provider un too but it didnt help
17:32:08 sean-k-mooney i think since the compute service is stopped that is why
17:32:21 sean-k-mooney since we both stop it and set force down
17:33:26 sean-k-mooney lyarwood: but yes waiting there also makes sense
17:33:41 sean-k-mooney lyarwood: we have similar logic in whitebox now for when we update the config
17:35:37 openstackgerrit Lee Yarwood proposed openstack/nova master: test_evacuate: Wait until subnode is disabled before starting tests https://review.opendev.org/751065
17:44:40 openstackgerrit Merged openstack/python-novaclient master: Add Python3 wallaby unit tests https://review.opendev.org/750937
17:45:41 openstackgerrit Stephen Finucane proposed openstack/nova master: Support SRIOV interface attach and detach https://review.opendev.org/740995
17:45:41 openstackgerrit Stephen Finucane proposed openstack/nova master: Make PCI claim NUMA aware during live migration https://review.opendev.org/748453
17:49:49 sean-k-mooney oh this is just doing self.rpcapi.set_host_enabled(context, service.host, enabled)
17:50:10 sean-k-mooney so the api is relying on the compute node to update it? that cant be right
18:49:21 openstackgerrit Merged openstack/nova master: Move confirm resize under semaphore https://review.opendev.org/747745
18:52:32 openstackgerrit Merged openstack/nova stable/ussuri: Reject resize operation for accelerator https://review.opendev.org/749701
18:52:41 openstackgerrit Merged openstack/nova master: Undeprecate the vmwareapi driver https://review.opendev.org/742407
18:52:56 openstackgerrit Merged openstack/nova stable/ussuri: func: Introduce a server_expected_state kwarg to InstanceHelperMixin._live_migrate https://review.opendev.org/746527
18:53:06 openstackgerrit Merged openstack/nova stable/ussuri: Add regression test for bug 1879787 https://review.opendev.org/746528
18:53:06 openstack bug 1879787 in OpenStack Compute (nova) "post_live_migration does not handle Neutron errors" [Medium,Fix released] https://launchpad.net/bugs/1879787 - Assigned to Artom Lifshitz (notartom)
19:11:07 openstackgerrit Lee Yarwood proposed openstack/nova master: test_evacuate: Wait until subnode is down before starting tests https://review.opendev.org/751065
19:15:19 sean-k-mooney lyarwood: oh right force down changes the state field
19:26:32 lyarwood sean-k-mooney: yup my bad
19:26:38 lyarwood sean-k-mooney: should be correct this time
19:26:50 lyarwood sean-k-mooney: was going to hack around with the evacuate job anyway this evening
19:33:20 openstackgerrit Merged openstack/nova stable/ussuri: post live migration: don't call Neutron needlessly https://review.opendev.org/750374

Earlier   Later