| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-09-10 | |||
| 13:08:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Remove Agent, AgentList https://review.opendev.org/749310 | |
| 13:08:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove 'get_all_bw_counters' API https://review.opendev.org/749312 | |
| 13:09:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove 'reset_network' API https://review.opendev.org/749315 | |
| 13:09:00 | openstackgerrit | Stephen Finucane proposed openstack/nova master: virt: Remove 'change_instance_metadata' API https://review.opendev.org/749316 | |
| 13:14:39 | lyarwood | stephenfin: this is not helping my +ratio ^_^ | |
| 13:14:44 | lyarwood | stephenfin: what happened there? | |
| 13:15:20 | stephenfin | lyarwood: https://review.opendev.org/#/c/749304/2/nova/exception.py@1293 :( | |
| 13:15:39 | stephenfin | it should be trivially reapprovable O:) | |
| 13:16:09 | stephenfin | and for the SR-IOV series, see last comment from me on https://review.opendev.org/#/c/746943/ | |
| 13:16:48 | lyarwood | ACK I'll let CI run on both and reapprove once we are sure it's passing | |
| 13:17:17 | stephenfin | cool | |
| 13:17:50 | stephenfin | addressed your comment on https://review.opendev.org/#/c/746946/ too while I was respinning | |
| 13:19:35 | lyarwood | yup thanks | |
| 13:23:38 | stephenfin | gibi, lyarwood: One of you want to hit this vTPM doc change real quick? https://review.opendev.org/#/c/750675/ | |
| 13:23:54 | stephenfin | (basically note that resize and cold migrate are supported ops now) | |
| 13:24:53 | lyarwood | yup looking | |
| 13:33:26 | openstackgerrit | Artom Lifshitz proposed openstack/nova stable/queens: post live migration: don't call Neutron needlessly https://review.opendev.org/750993 | |
| 13:38:19 | stephenfin | sean-k-mooney: Once this is released, we can turn on parallel builds, afaict https://review.opendev.org/750973 | |
| 13:39:40 | stephenfin | I'm not sure about whether we'll need to bump our lower-constraints or not. On one hand, if we add '-j auto' then we'll no longer be able to build docs using the older versions, but on the other hand, docs could still be build (just omit '-j auto') | |
| 13:41:28 | sean-k-mooney | yes that is what was failing | |
| 13:41:45 | sean-k-mooney | the feature classification | |
| 13:43:57 | sean-k-mooney | i could check i might see if we could make it conditional based on the sphinx version | |
| 13:44:26 | stephenfin | ah no, I wouldn't go that far | |
| 13:44:42 | sean-k-mooney | ill see what version of sphinx added it | |
| 13:45:05 | sean-k-mooney | if its not supper new then i think a min version bump would be fine | |
| 13:45:25 | stephenfin | sorry, I wasn't clear. I'm talking about lower-constraints for the various oslo packages plus sphinx-feature-classification | |
| 13:45:30 | sean-k-mooney | otherwise we can make it configurable via an environmnet varable or just postional arg | |
| 13:45:37 | sean-k-mooney | oh | |
| 13:45:43 | sean-k-mooney | not of sphinx build | |
| 13:45:49 | stephenfin | if you tried to build with '-j auto' using sphinx-feature-classification < 1.1.0, it'll fail | |
| 13:46:01 | sean-k-mooney | yes | |
| 13:46:03 | stephenfin | because it emits a warning saying this extension doesn't support parallel stuff | |
| 13:46:04 | sean-k-mooney | it did | |
| 13:46:10 | sean-k-mooney | yep | |
| 13:46:21 | sean-k-mooney | release nodes totally works | |
| 13:46:23 | stephenfin | so does that mean we need to set out lower-constraint for s-f-c to 1.1.0? | |
| 13:46:43 | stephenfin | or just assume people building docs with older versions will drop the '-j auto' | |
| 13:46:48 | sean-k-mooney | ya we would in wallaby | |
| 13:47:06 | sean-k-mooney | be can add -j auto to the other envs | |
| 13:47:12 | sean-k-mooney | that dont use that already | |
| 13:47:13 | bauzas | gibi: any notes you'd like to see in the prelude ? | |
| 13:47:46 | gibi | bauzas: I have nothing specific in my mind right now | |
| 13:48:04 | gibi | but I will do a scan of merged renos to get a view | |
| 13:48:07 | stephenfin | bauzas: have you noted that XenAPI is gone? | |
| 13:48:13 | stephenfin | that's merging as we spak | |
| 13:48:15 | stephenfin | *speak | |
| 13:48:23 | bauzas | gibi: I'll use your own cycle highlits as a base | |
| 13:48:30 | bauzas | stephenfin: ah, no, gtk | |
| 13:48:48 | bauzas | stephenfin: in general, I take a look at the main reno master page | |
| 13:48:58 | bauzas | so I'll see it, I guess ;) | |
| 13:49:00 | gibi | bauzas: cool | |
| 13:49:15 | sean-k-mooney | stephenfin: i started reviewin the xenapi removeal then stop as i realed it mainly just code deletion and lyarwood and gibi? had alredy reviewed most of it | |
| 13:49:49 | sean-k-mooney | im glad that is going to make it :) | |
| 13:50:33 | stephenfin | sean-k-mooney: you might be interested in https://review.opendev.org/#/c/748533/ | |
| 13:51:08 | sean-k-mooney | didnt i reveiew an previous version | |
| 13:51:16 | sean-k-mooney | i do need to take another look | |
| 13:51:22 | stephenfin | oh, so you did | |
| 13:51:24 | stephenfin | my bad | |
| 13:51:36 | sean-k-mooney | no its good to remind me to look again | |
| 13:52:54 | stephenfin | https://review.opendev.org/745605 still needs to be respun too :) | |
| 13:53:15 | sean-k-mooney | oh the filters | |
| 13:53:21 | sean-k-mooney | actully ill go do that now | |
| 13:53:31 | lyarwood | sean-k-mooney: some additional review on these would also be good btw, slightly out of my area tbh https://review.opendev.org/#/c/746949/ | |
| 13:53:40 | lyarwood | artom: ^ also if you have bandwidth | |
| 13:54:06 | sean-k-mooney | oh the fixture change | |
| 13:54:24 | lyarwood | and the series on top adding the actual tests | |
| 13:54:32 | sean-k-mooney | am yes are they mergeragbe after today/feature freeze | |
| 13:54:56 | sean-k-mooney | if so ill do the filter deprecation first then ill take a look at those | |
| 13:55:43 | lyarwood | ah yeah of course sorry | |
| 13:56:04 | sean-k-mooney | no its fine i really should have reviewd that series properly by now | |
| 13:56:10 | sean-k-mooney | i have been putting it off | |
| 13:56:51 | sean-k-mooney | mainly for lack of brain power and opertunity to sit down and do it properly | |
| 13:57:28 | artom | lyarwood, ah, yeah, I'm slowly working my way up that series | |
| 14:05:30 | lyarwood | artom: cool thanks, I was fine with the house keeping stuff up until that point FWIW, I just don't have the context to know if we are asserting the right things in the actual LM tests | |
| 14:07:33 | artom | lyarwood, ack | |
| 14:39:05 | sean-k-mooney | smcginnis: oh you create the non clinet lib stable branches already | |
| 14:39:09 | sean-k-mooney | that is good to know. | |
| 14:40:03 | sean-k-mooney | we have 2 patches for os-vif to backprot to stable/victoria but they are not merged on master yet and i was going to wait a little while to ensure we dont have any issue before mergeing them anyway | |
| 14:40:32 | sean-k-mooney | but i guess this means i dont strictly have to wait to rc1 for master to be open for wallaby in os-vif | |
| 14:41:09 | sean-k-mooney | sill going to hold off for a bit however | |
| 14:48:48 | smcginnis | sean-k-mooney: Yep, non-client library freeze was last week. So those are already done for victoria. | |
| 14:49:04 | smcginnis | Sneaks up quick. | |
| 14:53:50 | sean-k-mooney | oh ya i know i am just used to waiting till the main project reach rc1 for the master branch to reopen and stable brances to be created | |
| 14:54:14 | sean-k-mooney | smcginnis: but creating the branch early also works | |
| 14:54:45 | sean-k-mooney | smcginnis: also its nice to not have to manually do this in gerrit anymore although i guess i have not done that in a few releases at this point | |
| 14:55:24 | smcginnis | Unofficial projects would need to, but anything official should all be going through the releases repo. | |
| 14:55:42 | sean-k-mooney | yep | |
| 15:24:38 | bauzas | lyarwood: gibi: we don't have better docs for glance image cloning but a spec ? https://specs.openstack.org/openstack/nova-specs/specs/victoria/approved/nova-image-download-via-rbd.html | |
| 15:26:39 | gibi | bauzas: there is an open doc patch https://review.opendev.org/#/c/731577/ | |
| 15:27:20 | bauzas | uh ok | |
| 15:28:08 | bauzas | gibi: so we have 2 different things related to RBD | |
| 15:28:14 | bauzas | gibi: one is the glance multistore | |
| 15:28:16 | gibi | yes | |
| 15:28:24 | bauzas | the other being the precaching | |
| 15:28:29 | gibi | yes | |
| 15:28:36 | bauzas | honestly, I'd then write two different bullets | |
| 15:28:56 | bauzas | because most ops probably don't give a clue about what a glance multistore is | |
| 15:29:06 | bauzas | and both are independent | |
| 15:29:27 | bauzas | ie. you can precache with or without multistore, and the other way too | |
| 15:29:35 | bauzas | dansmith: amirite ? | |