Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-09-09
15:05:35 gibi yeah I working from home so the code I push is basically a homework :D
15:05:38 bauzas and fwiw, the above series is functional tests adds, right? if so, we don't need to merge them before tomorrow's FF
15:05:51 stephenfin bauzas: correct
15:06:10 bauzas kk all good, back to gerrit and github
15:06:54 stephenfin gibi: I assume XenAPI-removal will have to be punted come M3? :-\
15:07:14 stephenfin I'm waiting on the Tempest fix to merge but gate failures are killing me :-(
15:07:49 gibi stephenfin: if nobody else showing up reviewing that series then I'm affraid so
15:08:13 gibi ohh the tempest part is still open that does not help either
15:09:21 lyarwood sorry been stuck downstream for a while but let me know if I can help with anything
15:09:45 bauzas stephenfin: well, if that's not a Facebook poke, you can surely do it
15:09:58 bauzas but I'm already married fwiw
15:10:59 stephenfin bauzas: keep your smut off IRC, plz
15:11:07 stephenfin ;)
15:12:42 stephenfin lyarwood: It's clearly not the highest priority, but I have two series that I'd like to close off: the XenAPI-removal and the SR-IOV tests. Former is feature'ish so that's more important rn and starts here https://review.opendev.org/#/c/749300/
15:13:25 stephenfin You won't be able to look at anything above the 'remove os-agents' change until the Tempest change merges but the first half should be good to go
15:26:10 openstackgerrit Stephen Finucane proposed openstack/nova master: network: Remove unused 'affect_auto_assigned' parameter https://review.opendev.org/744871
15:26:11 openstackgerrit Stephen Finucane proposed openstack/nova master: network: Add type hints for various allocate functions https://review.opendev.org/744870
15:31:16 bauzas gibi: couple of questions in https://review.opendev.org/#/c/740995/17/nova/compute/manager.py
15:31:25 gibi looking
15:31:41 bauzas gibi: mostly about exception handling in order to make sure we have correct error behaviours
15:32:01 bauzas the overall logic looked to me good
16:15:20 gibi bauzas: replied in https://review.opendev.org/#/c/740995
16:21:44 gibi I can do the changes tomorrow morning
16:27:31 bauzas gibi: k, no worries, I will continue the review for the func test part
16:27:46 bauzas gibi: I'm okay with having those as a FUP since it's like a bugfix
16:27:50 bauzas ie. closing the gaps
16:36:19 gibi bauzas: cool o/
16:40:58 bauzas gibi: sent to the gate
16:41:09 bauzas I'll hold reviewing the FUP for now
16:41:15 bauzas ++
16:41:55 gibi thanks
16:42:05 openstackgerrit Merged openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934
16:42:20 openstackgerrit Merged openstack/nova master: Migrate default policy file from JSON to YAML https://review.opendev.org/748059
16:42:28 openstackgerrit Merged openstack/nova master: Only unplug vif after the device is detached from libvirt https://review.opendev.org/744934
16:46:44 openstackgerrit Ghanshyam Mann proposed openstack/nova master: [Trivial] Replace ref of policy.json to policy.yaml https://review.opendev.org/749821
19:41:03 openstackgerrit Merged openstack/nova master: [Trivial] Replace ref of policy.json to policy.yaml https://review.opendev.org/749821
#openstack-nova - 2020-09-10
01:21:52 openstackgerrit Brin Zhang proposed openstack/nova master: Cyborg shelve/unshelve support https://review.opendev.org/729563
02:41:01 openstackgerrit Merged openstack/nova master: Set migrate_data.vifs only when using multiple port bindings https://review.opendev.org/742180
04:39:07 openstackgerrit MIKI Nobuhiro proposed openstack/nova master: libvirt: add IP address to libvirt guest metadata https://review.opendev.org/750552
05:31:04 openstackgerrit Luyao Zhong proposed openstack/nova master: Track error migrations in resource tracker https://review.opendev.org/745281
05:31:04 openstackgerrit Luyao Zhong proposed openstack/nova master: Rollback when reset running live migration https://review.opendev.org/747899
05:31:05 openstackgerrit Luyao Zhong proposed openstack/nova master: Improve orphans tracking in resource tracker https://review.opendev.org/745282
05:57:01 openstackgerrit Federico Ressi proposed openstack/nova master: Log stack trace when fails launching a defined domain https://review.opendev.org/750652
06:57:04 gibi good morning Nova
07:26:27 bauzas gibi: good morning
07:29:13 bauzas gibi: I need to go off for around 2 hours this morning for an appointment, ping me your new revision for the FUP and I'll try to look at it around noon
07:29:29 gibi bauzas: OK, I will ping you
08:31:46 openstackgerrit Merged openstack/nova master: Use UUID as vif and network_id in vif tests https://review.opendev.org/748722
09:08:18 openstackgerrit Balazs Gibizer proposed openstack/nova master: Follow up for I67504a37b0fe2ae5da3cba2f3122d9d0e18b9481 https://review.opendev.org/750184
09:08:55 gibi bauzas: the friendly ping I promised ^^
09:15:52 luyao stephenfin: Hi, I reply you at https://review.opendev.org/#/c/745281/, thanks for review
09:17:39 luyao alex_xu: could you have a look at https://review.opendev.org/#/q/topic:bp/vpmem-enhancement+(status:open+OR+status:merged) if you get time, there are some updates and discussion. thanks in advance.
09:36:58 bauzas gibi: +2d
09:37:13 bauzas stephenfin: your +2 is needed https://review.opendev.org/750184
09:37:44 bauzas taxiing
09:38:54 gibi bauzas: thanks
09:45:31 openstackgerrit OpenStack Release Bot proposed openstack/os-vif stable/victoria: Update .gitreview for stable/victoria https://review.opendev.org/750924
09:45:32 openstackgerrit OpenStack Release Bot proposed openstack/os-vif stable/victoria: Update TOX_CONSTRAINTS_FILE for stable/victoria https://review.opendev.org/750925
09:45:34 openstackgerrit OpenStack Release Bot proposed openstack/os-vif master: Update master for stable/victoria https://review.opendev.org/750926
09:45:35 openstackgerrit OpenStack Release Bot proposed openstack/os-vif master: Add Python3 wallaby unit tests https://review.opendev.org/750927
09:46:18 openstackgerrit OpenStack Release Bot proposed openstack/python-novaclient stable/victoria: Update .gitreview for stable/victoria https://review.opendev.org/750932
09:46:19 openstackgerrit OpenStack Release Bot proposed openstack/python-novaclient stable/victoria: Update TOX_CONSTRAINTS_FILE for stable/victoria https://review.opendev.org/750933
09:46:21 openstackgerrit OpenStack Release Bot proposed openstack/python-novaclient master: Update master for stable/victoria https://review.opendev.org/750935
09:46:23 openstackgerrit OpenStack Release Bot proposed openstack/python-novaclient master: Add Python3 wallaby unit tests https://review.opendev.org/750937
10:05:17 openstackgerrit Balazs Gibizer proposed openstack/nova master: Cleanup unused code https://review.opendev.org/750947
10:08:38 admin0 hi all .. is there a way to remove a entry from the host list ..like that host is removed and will not be added back
10:08:41 openstackgerrit wu.shiming proposed openstack/os-vif master: Remove Babel requirement https://review.opendev.org/750948
10:08:53 admin0 host as in hypervisor
10:09:34 admin0 google search lists direct database commands
10:39:51 lyarwood admin0: https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/compute-service.html
10:47:05 lyarwood stephenfin: is the ordering wrong between https://review.opendev.org/#/c/749303/ and https://review.opendev.org/#/c/749304/1
10:47:22 lyarwood stephenfin: actually it doesn't matter
10:47:30 stephenfin I don't think so
10:47:40 stephenfin tooling is no use without the driver. Drive doesn't depend on tooling
10:47:47 stephenfin The driver
10:49:26 lyarwood stephenfin: oh sorry I thought the driver was using that
10:49:32 lyarwood stephenfin: so it's just stand alone tooling?
10:49:46 stephenfin afaict yes
10:49:49 lyarwood ah my bad
10:54:27 lyarwood stephenfin: remind me again, what were we waiting on for https://review.opendev.org/#/c/749308/ to start passing?
10:59:46 stephenfin lyarwood:
10:59:46 stephenfin <admin0> google search lists direct database commands
10:59:49 stephenfin whoops
10:59:57 stephenfin lyarwood: https://review.opendev.org/#/c/749527/
11:01:07 stephenfin Well that's needed for the next change. It looks like https://review.opendev.org/#/c/749308/ removes an exception that's still required until the following patch.
11:01:25 stephenfin I'll reshuffle that series later today to put the patches that break tempest to the end, if possible
11:02:22 lyarwood stephenfin: ack yeah sorry I didn't look into the failure, I just recalled you saying something about tests being borked after a certain point and assumed I had found it ^_^
11:04:15 lyarwood stephenfin: https://review.opendev.org/#/q/topic:sriov-functional-tests was the other series you wanted reviews on right?
11:04:39 admin0 @stephenfin, thanks .. it worked
11:04:59 admin0 @lyarwood, that worked :)
11:05:02 admin0 thanks guys
11:05:34 lyarwood np
11:17:17 sean-k-mooney wait xenapi is the reason os-agents is a thing. that always confused me since all the agents are listed under os-services
11:18:18 sean-k-mooney at least when using libvirt
11:29:27 lyarwood stephenfin: https://review.opendev.org/#/c/746946/ - small nit here, shouldn't you hit the resize API in these tests even if the eventual codepaths are the same at the moment
11:43:56 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: compute: refactor volume bdm rollback error handling https://review.opendev.org/749225
11:43:59 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: Add regression tests for bug #1889108 https://review.opendev.org/749226
11:43:59 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/749227
11:44:00 openstack bug 1889108 in OpenStack Compute (nova) rocky "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood)
11:54:03 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration https://review.opendev.org/747976

Earlier   Later