| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-09-08 | |||
| 11:41:13 | gibi | yeah, I will do a scan of launchpad at m3 definitely | |
| 11:41:33 | gibi | I tend to do the PM work on Thursday mornings when I refresh the meeting agenda | |
| 12:08:41 | kashyap | lyarwood: Unrelated, on Q35 CI job: while we're dealing with CI, the last comment from you on the Q35 job review was "tempest.api.compute.admin.test_volume_swap.TestVolumeSwap" failing due to use of blockRebase() instead of blockCopy() | |
| 12:08:53 | kashyap | Your comment on Apr 21: https://review.opendev.org/#/c/708701/ | |
| 12:09:26 | kashyap | Since then, upstream now uses blockCopy() - https://review.opendev.org/#/c/696834/ | |
| 12:09:48 | kashyap | Ah, no - that's only when using -blockdev. | |
| 12:10:49 | artom | lyarwood, one last (hopefully) look at https://review.opendev.org/#/c/747451/ pretty please? | |
| 12:16:19 | lyarwood | artom: ack'd | |
| 12:17:42 | artom | Cheers! | |
| 12:17:46 | artom | Let's hope CI cooperates | |
| 12:19:02 | luyao | stephenfin: hi are you around? | |
| 12:19:03 | lyarwood | artom: I'd be very worried if I was your first born child right about now | |
| 12:54:51 | luyao | stephenfin: Hi stephenfin, I'm going to leave, I reply you at the https://review.opendev.org/#/c/714653/ and https://review.opendev.org/#/c/745281, I think you mean we still need adding a new driver interface , right? I have a candidate name "cleanup_lingering_instance_resources", please leave your comments if you think it's ok or have a better name, then I could update the patches soon.Thanks in advance.:) | |
| 12:55:40 | bauzas | gibi: I sent most of the SRIOV attach/detach series to the gate but I left the top one with is hairy | |
| 12:56:00 | bauzas | gibi: I'll be looking at stephenfin's patches and then I'll back to your main change | |
| 12:56:42 | gibi | bauzas: thanks. do you have comments already for https://review.opendev.org/#/c/740995/ ? | |
| 12:57:41 | bauzas | nope, tbh, I turned my feet around when I saw the number of mofications :p | |
| 12:57:46 | gibi | I see | |
| 12:57:53 | gibi | yeah, that is a bigger patch | |
| 12:58:01 | bauzas | I need to have some time for your patch | |
| 13:18:56 | bauzas | stephenfin: I'm done with your deprecation/remove changes, what's the status for the vTPM series ? | |
| 13:20:26 | gibi | bauzas: the last 3 patches needs review as far as I know | |
| 13:20:45 | bauzas | kk, stephenfin told me yesterday to wait a bit until today | |
| 13:21:32 | gibi | he needed to fix a bug | |
| 13:21:33 | gibi | https://review.opendev.org/#/c/750186 | |
| 13:21:41 | gibi | that was caught by the gate | |
| 13:22:00 | gibi | but now it is fixed | |
| 13:23:19 | gibi | the current redness of the last patch seems unrelated | |
| 13:25:35 | stephenfin | bauzas: yeah, it's good to go | |
| 13:47:41 | sean-k-mooney | gibi: can you take a look at https://review.opendev.org/#/c/747454/4 and https://review.opendev.org/#/c/742180/12 again i adressed stephens nits and updated the functional teest so it now assert the vm is active on the dest | |
| 13:51:24 | gibi | sean-k-mooney: looking | |
| 14:01:57 | gibi | sean-k-mooney: done, thanks | |
| 14:02:28 | openstackgerrit | Merged openstack/nova master: post live migration: don't call Neutron needlessly https://review.opendev.org/747451 | |
| 14:02:40 | sean-k-mooney | :) im just happy that i could shameless steal stephens mirgrate url hack to make migration work in the functional tests | |
| 14:03:07 | sean-k-mooney | its nice to have the assert assert the correct behavior | |
| 14:08:19 | sean-k-mooney | artom: https://review.opendev.org/#/c/747451/ is merged. so does this mean your first born is saved or sacrafied to the gate gods :) | |
| 14:15:09 | sean-k-mooney | oh you can run tempest with tox that is much easier | |
| 14:15:55 | sean-k-mooney | full is proably overkill but whatever its running now | |
| 14:16:23 | sean-k-mooney | anyone know if tox will create the testresuts html too? | |
| 14:42:22 | openstackgerrit | Artom Lifshitz proposed openstack/nova stable/ussuri: post live migration: don't call Neutron needlessly https://review.opendev.org/750374 | |
| 14:46:36 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Migrate default policy file from JSON to YAML https://review.opendev.org/748059 | |
| 14:47:13 | gmann | stephenfin: ^^ updated | |
| 14:47:57 | openstackgerrit | Merged openstack/nova master: libvirt: Deprecate support for non-QEMU/KVM backends https://review.opendev.org/749055 | |
| 15:31:48 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Rework how we check for neutron extensions https://review.opendev.org/705792 | |
| 15:40:02 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Rework how we check for neutron extensions https://review.opendev.org/705792 | |
| 15:43:48 | admin0 | hi all .. how hard is it to add a bit more details on "openstack server show " command .. like what the routerid is, which agent/host that router is hosted, what are its dhcp agents for the network etc ? or if there is a shortcut to get this info | |
| 15:44:06 | admin0 | what happens is when a vm is not pinging, it takes 5-6 commands just to gather all info about this | |
| 15:44:37 | sean-k-mooney | admin0: that is all info that nova does not have | |
| 15:44:59 | sean-k-mooney | admin0: and we have a policy of not adding proxy apis | |
| 15:45:15 | admin0 | correct .. so then, to rephrase, if i want to add a command that takes info from all and shows the data, how should this proceed ? | |
| 15:45:31 | sean-k-mooney | admin0: add a command to the openstack client | |
| 15:45:45 | admin0 | that is a diff project ? | |
| 15:45:49 | sean-k-mooney | yes | |
| 15:45:52 | admin0 | ah .. ok | |
| 15:46:06 | admin0 | is there a group/chat for this ? | |
| 15:46:08 | sean-k-mooney | https://github.com/openstack/python-openstackclient | |
| 15:46:35 | sean-k-mooney | #openstack-sdks | |
| 15:48:18 | admin0 | thanks sean-k-mooney | |
| 15:50:34 | openstackgerrit | Merged openstack/nova master: libvirt: Remove '[vnc] keymap', '[spice] keymap' options https://review.opendev.org/749056 | |
| 15:51:56 | bauzas | gibi: stephenfin: I'm done for the day but I left your two main changes not accepted yet, but I'll look at them tomorrow | |
| 15:52:04 | stephenfin | ack | |
| 15:52:09 | gibi | bauzas: ack | |
| 15:52:21 | bauzas | (vTPM main change, and SRIOV attach/detach hairy patch) | |
| 15:52:37 | bauzas | hopefully, we can close two blueprints tomorrow | |
| 16:16:38 | openstackgerrit | Elod Illes proposed openstack/nova stable/train: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/747610 | |
| 16:20:54 | openstackgerrit | Elod Illes proposed openstack/nova stable/train: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/747610 | |
| 16:44:28 | stephenfin | sean-k-mooney: Does my understanding of https://review.opendev.org/#/c/738432/ make sense? | |
| 16:44:37 | stephenfin | Or rather is it correct? | |
| 16:45:30 | sean-k-mooney | reading your commnet on sec | |
| 16:46:12 | sean-k-mooney | yes we are uring the name lookup on the source host with the adress form the dest | |
| 16:46:16 | sean-k-mooney | which is totally broken | |
| 16:46:28 | stephenfin | okay, phew | |
| 16:46:37 | stephenfin | I've been staring at that patch for weeks, heh | |
| 16:47:47 | sean-k-mooney | and yes if the destination device does not exist on the source things explode | |
| 16:48:27 | sean-k-mooney | and more annoyingly sometimes the device on the souce and dest match and this just work by acident | |
| 16:48:35 | sean-k-mooney | untill they dont | |
| 16:48:54 | sean-k-mooney | this is only an issue for macvtap since it does not have the pci adress in teh xml | |
| 16:49:02 | sean-k-mooney | it uses the nic name istead | |
| 16:51:30 | sean-k-mooney | stephenfin: ya moving thie logic up one level would also make sense | |
| 16:51:56 | sean-k-mooney | i.e. caluatle the devname before calling set_vif_host_backend_hw_veb | |
| 16:52:34 | openstackgerrit | Merged openstack/nova master: add functional regression test for bug #1888395 https://review.opendev.org/747454 | |
| 16:52:34 | openstack | bug 1888395 in OpenStack Compute (nova) "shared live migration of a vm with a vif is broken in train" [High,In progress] https://launchpad.net/bugs/1888395 - Assigned to sean mooney (sean-k-mooney) | |
| 17:04:13 | openstackgerrit | Merged openstack/nova master: Expand generic reproducer for bug #1879878 https://review.opendev.org/750186 | |
| 17:04:13 | openstack | bug 1879878 in OpenStack Compute (nova) "VM become Error after confirming resize with Error info CPUUnpinningInvalid on source node " [Medium,In progress] https://launchpad.net/bugs/1879878 - Assigned to Stephen Finucane (stephenfinucane) | |
| 17:33:20 | ganso | Hi Nova folks, could someone please review this small bugfix if you have a few minutes https://review.opendev.org/#/c/748533 thanks in advance! | |
| 17:57:53 | openstackgerrit | Merged openstack/nova master: Set 'old_flavor', 'new_flavor' on source before resize https://review.opendev.org/750187 | |
| 18:40:28 | openstackgerrit | Merged openstack/nova master: Move equality check into LibvirtConfigGuestInterface https://review.opendev.org/744524 | |
| 20:49:00 | artom | This is not making any sense... | |
| 20:49:16 | artom | USE_NEUTRON = True | |
| 20:49:55 | artom | if self.USE_NEUTRON: | |
| 20:49:57 | artom | self.neutron = self.useFixture(nova_fixtures.NeutronFixture(self)) | |
| 20:50:29 | artom | self.test.stub_out( | |
| 20:50:31 | artom | 'nova.network.neutronv2.api.API.setup_networks_on_host' | |
| 20:50:46 | artom | And yet | |
| 20:50:56 | artom | File "nova/network/neutronv2/api.py", line 332, in setup_networks_on_host | |
| 20:50:57 | artom | data = self.list_ports(context, **search_opts) | |
| 20:51:01 | artom | So it didn't get stubbed out | |
| 20:57:20 | artom | Ah, I think it's happening async in the rollback, presumably after the tearDown() has cleanup up the stubs/mocks | |
| 20:59:28 | artom | Aha, yep, adding self.test.flags(vif_plugging_timeout=0) has done it. | |
| 20:59:39 | artom | (From https://review.opendev.org/#/c/696245/2/nova/tests/fixtures.py, which I'm not even going to attempt to backprot) | |