| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-09-04 | |||
| 13:28:22 | dansmith | er a NON-remotable on | |
| 13:28:30 | bauzas | yup, now I remember | |
| 13:28:53 | bauzas | only decorated methods need to have a major version to be removed or renamed | |
| 13:29:51 | bauzas | that's what happens when you stay too much in libvirt :) | |
| 13:35:41 | dansmith | heh | |
| 13:42:12 | sean-k-mooney | dansmith: added you to this https://review.opendev.org/#/c/747395/ | |
| 13:42:31 | sean-k-mooney | dansmith: its an oslo messigning change to move the heartbeat to a real thread | |
| 13:42:42 | dansmith | oh boy | |
| 13:42:48 | sean-k-mooney | i know you had concens about that and wsgi before | |
| 13:43:06 | sean-k-mooney | mainly breaking the wsgi server thread lifecycle | |
| 13:43:50 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add type hints to 'nova.virt.libvirt.utils' https://review.opendev.org/742865 | |
| 13:43:51 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934 | |
| 13:47:13 | dansmith | sean-k-mooney: yeah, I just added native threading support to glance's API so that they could do the things they need to do in wsgi mode and it seems to be fine | |
| 13:47:26 | dansmith | dug into what uwsgi expects you to do for threading more so I have a better handle on it | |
| 13:53:50 | sean-k-mooney | ok just wanted to keep you in the loop incase that could cause issues there is a FFE request on the mailing list related to it | |
| 13:58:37 | dansmith | ugh, well, *rushing* that doesn't seem like a good plan | |
| 13:59:05 | dansmith | oh, I see, | |
| 13:59:19 | dansmith | it's already there, just not defaulted | |
| 13:59:37 | dansmith | have we tried turning that on for nova with wsgi api to see if it solves our rabbit heartbeating problem? | |
| 14:00:19 | dansmith | in glance, I avoided the eventlet setup if we were in pure wsgi mode, but I think nova is always doing it right now | |
| 14:05:28 | sean-k-mooney | it is because fo the multi cell scatter gatther | |
| 14:05:46 | sean-k-mooney | before that the api did not use eventlets at all | |
| 14:05:54 | sean-k-mooney | in wsig mode at least | |
| 14:06:27 | sean-k-mooney | it id with the console_srcipt entrypoint by being in the cmd module | |
| 14:06:34 | dansmith | eh? it has always used eventlet for greenthreading right? you mean we didn't call any of the eventlet primitives ourselves before that | |
| 14:06:39 | sean-k-mooney | we monkey patch in __init__.py | |
| 14:06:45 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support SRIOV interface attach and detach https://review.opendev.org/740995 | |
| 14:06:54 | sean-k-mooney | dansmith: it did not use anyting directly ya | |
| 14:07:19 | dansmith | sure, but otherwise we'd be limited to a single request per worker which'd be pretty limiting | |
| 14:07:21 | sean-k-mooney | but when it was not run by the console_script and was run under uswigi id was not mokeypatched at all in that config | |
| 14:07:32 | dansmith | are you sure? | |
| 14:07:37 | sean-k-mooney | pretty sure | |
| 14:07:53 | sean-k-mooney | i didnt see the monkeypatch call in that code path before | |
| 14:08:08 | dansmith | so we relied on uwsgi spawning enough worker processes to handle any blocking calls we made? that seems unlikely to me | |
| 14:08:12 | sean-k-mooney | i could have missed it but it was not obvious if it was beeing monkey patched | |
| 14:08:40 | dansmith | like any long-running rpc call would block up that worker in the api, so two on a two-worker system wouldn't be able to handle anything else | |
| 14:09:03 | sean-k-mooney | in the api | |
| 14:09:28 | sean-k-mooney | perhaps i just recall we had all those issue that mdbooth tried to fix when we started monkeypatching | |
| 14:09:35 | sean-k-mooney | which seamed to indiecate we were not before | |
| 14:09:54 | dansmith | no, I thought it was just a matter of when we patched | |
| 14:10:22 | sean-k-mooney | perhaps but i tought it was that we did not patch before but now needed to due to the scatter gather | |
| 14:10:43 | sean-k-mooney | in anycase i jsut wnated to get your input on the default change | |
| 14:11:00 | sean-k-mooney | it feel kind of late to chagne the default in oslo | |
| 14:11:13 | sean-k-mooney | deprecating it im more ok with | |
| 14:11:31 | dansmith | well, we might have only noticed that we weren't patching when the cells stuff was added, we weren't really running in real wsgi mode much before that, | |
| 14:11:41 | dansmith | so perhaps we weren't but didn't notice in a devstack that it mattered | |
| 14:12:15 | sean-k-mooney | ya that is more or less my feels on it too | |
| 14:12:37 | dansmith | but yeah, I dunno about changing the default.. especially if it's configureable back, it doesn't seem *that* bad to me | |
| 14:13:11 | sean-k-mooney | i guess we just need to test it and flag it to ooo if we see it causing gate issue | |
| 14:13:20 | sean-k-mooney | or in our donwstream testing | |
| 14:13:34 | dansmith | aye | |
| 14:16:28 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support SRIOV interface attach and detach https://review.opendev.org/740995 | |
| 14:17:24 | gibi | sean-k-mooney, stephenfin: I finished adding functional tests. I consider this patch ready for review ^^ | |
| 14:19:55 | sean-k-mooney | gibi: cool on downstream call but ill look after | |
| 14:20:02 | gibi | thanks | |
| 14:31:04 | gibi | stephenfin: here is a simple doc patch to light up your Friday https://review.opendev.org/#/c/744492 | |
| 14:48:31 | stephenfin | gibi: done the latter, looking at the former now | |
| 14:49:50 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Add a routed networks scheduler pre-filter https://review.opendev.org/749068 | |
| 14:49:51 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add requested_networks field to RequestSpec object https://review.opendev.org/749977 | |
| 14:49:57 | bauzas | gibi: sean-k-mooney: ^ routed networks | |
| 14:50:15 | bauzas | still a WIP because I wanted to make better functional tests | |
| 14:50:32 | bauzas | but this seems to work for migrating too \o/ | |
| 14:51:08 | bauzas | gibi: stephenfinat least, you can get another segment from the same network, right? | |
| 14:51:11 | bauzas | whoops | |
| 14:51:17 | bauzas | gibi: sean-k-mooney: ^ | |
| 14:54:12 | sean-k-mooney | bauzas: you can have multiple segment in an network yes | |
| 14:54:18 | bauzas | I know | |
| 14:54:20 | sean-k-mooney | you will have 1 per subnet | |
| 14:54:29 | bauzas | but then it's okay | |
| 14:54:39 | sean-k-mooney | but ya ill take a look after i look at gibis patches | |
| 14:54:52 | bauzas | np, just wanted to make sure this was an expected behaviour | |
| 14:55:02 | bauzas | ie. to not limit to the existing segment | |
| 14:55:08 | bauzas | (for moves) | |
| 14:55:24 | bauzas | sean-k-mooney: amirite ? | |
| 14:57:29 | openstackgerrit | Merged openstack/nova master: Revert "Handle Neutron errors in _post_live_migration()" https://review.opendev.org/747443 | |
| 14:59:12 | gibi | stephenfin: thanks | |
| 14:59:19 | gibi | bauzas: I will check soon | |
| 14:59:32 | bauzas | cool, ta | |
| 14:59:42 | sean-k-mooney | bauzas: for move you have to move ot the same segment | |
| 14:59:50 | sean-k-mooney | bauzas: you cannot move to another segment | |
| 15:00:06 | bauzas | ah | |
| 15:00:11 | sean-k-mooney | bauzas: since the ip cannot change and is only valid in the specific segment it is allcoated form | |
| 15:00:16 | bauzas | then it's not good | |
| 15:00:38 | bauzas | sean-k-mooney: yeah, I was thinking of this | |
| 15:00:52 | sean-k-mooney | thats the main point of the feature to only migrate in the same segment | |
| 15:01:52 | sean-k-mooney | by the way this part of why i want to put the segment in the vif object | |
| 15:02:25 | sean-k-mooney | bauzas: right now without that you need to check which subnet the ip is from and hten use that to figure out which segment it is | |
| 15:02:56 | bauzas | again I need to verify why I got a host from another segment then | |
| 15:03:21 | bauzas | that's not me who wrote the functest so I need to verify a few things | |
| 15:03:22 | sean-k-mooney | i havent looked at your code but ill keep an eye out for that | |
| 15:35:34 | gmann | dansmith: any reason we did not add nova-ceph-multistore in gate pipeline though it is voting | |
| 15:36:06 | sean-k-mooney | gmann: do we need it there. we dont add all jobs to gate | |
| 15:36:15 | dansmith | gmann: I think because the ceph job wasn't there, right? but no reason not to, IMHO | |
| 15:36:16 | gmann | sean-k-mooney: we need to add if voting | |
| 15:36:30 | sean-k-mooney | we have several voting jobs that are not in gate | |
| 15:36:41 | gmann | dansmith: ohk, and ceph job was made voting later. | |
| 15:37:20 | dansmith | the ceph-multistore job vastly increases coverage of nova and ceph and glance, IMHO, so it's not bad to have it gating, IMHO | |
| 15:37:45 | sean-k-mooney | gmann: compare https://github.com/openstack/nova/blob/master/.zuul.yaml#L480-L494 vs https://github.com/openstack/nova/blob/master/.zuul.yaml#L425-L479 | |
| 15:37:57 | sean-k-mooney | dansmith: im not against adding it | |
| 15:38:09 | sean-k-mooney | just the idea that voting = in gate and check | |