Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-09-03
10:16:42 brinzhang stephenfin: ack, let me try
10:19:05 stephenfin alex_xu: Could I ask you to review https://review.opendev.org/#/c/747745/ with the expectation that I'll fix the live migration path also but in a separate, follow-up change?
10:20:14 brinzhang stephenfin: I cannot run git commit, if I run git commit -s, is it ok?
10:20:22 brinzhang root@ubuntu-OpenStack:/home/my_work/code/backup/nova# git commit
10:20:22 brinzhang Unova/compute/api.py
10:20:22 brinzhang Unova/tests/unit/compute/test_compute_api.py
10:20:22 brinzhang error: Committing is not possible because you have unmerged files.
10:20:22 brinzhang hint: Fix them up in the work tree, and then use 'git add/rm <file>'
10:20:22 brinzhang hint: as appropriate to mark resolution and make a commit.
10:20:24 brinzhang fatal: Exiting because of an unresolved conflict.
10:20:44 stephenfin oh, sorry, 'git add <changed files>'
10:20:45 stephenfin then commit
10:20:56 brinzhang ^
10:21:35 stephenfin I think 'git cherry-pick --continue' will work instead of 'git commit', but that also needs the merge conflict marked as resolved using 'git add' or whatever
10:22:11 openstackgerrit Brin Zhang proposed openstack/nova stable/ussuri: Reject resize operation for accelerator https://review.opendev.org/749701
10:22:49 brinzhang stephenfin: yes, we cannot run "git cherry-pick --continue", that will generate a new commit message
10:23:55 brinzhang and I tried many times in my evn, I think I get the way to cherry-pick if there is a conflict in the stable release
10:27:07 brinzhang stephenfin: good guideline, thanks ^^
10:31:05 openstackgerrit Lee Yarwood proposed openstack/nova master: Adapt the admin guide to describe the direct RBD export https://review.opendev.org/728411
10:31:06 lyarwood stephenfin: ^ sorry had to deal with something downstream
10:32:10 songwenping__ bauzas: hi, my ubuntu env is ok now. i set two vgpu_types and vgpu_nvidia-180 and vgpu_nvidia-181 in nova-compute.conf, but i cant get vgpu_nvidia-180 and vgpu-nvidia-181 group.
10:36:38 songwenping__ i find the _get_supported_vgpu_types function is first called and then register_dynamic_opts is called.
10:38:25 songwenping__ so when i boot vm with vgpu flavor, i cant get device_addresses.
10:46:50 songwenping__ sean-k-mooney: hi, i reinstall vgpu-kvm.run package and restart my host, i can find nvidia-* at /sys/class/mdev_bus/0000\:af\:00.0/mdev_supported_types/.
11:10:18 alex_xu stephenfin: yea, will take a look at
11:24:10 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Bump MIN_{LIBVIRT,QEMU}_VERSION and NEXT_MIN_{LIBVIRT,QEMU}_VERSION https://review.opendev.org/746981
11:24:11 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_FILE_BACKED_DISCARD_VERSION https://review.opendev.org/746982
11:24:12 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_NATIVE_TLS_VERSION https://review.opendev.org/746983
11:24:12 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_BETTER_SIGKILL_HANDLING https://review.opendev.org/746984
11:24:13 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_VIDEO_MODEL_VERSIONS https://review.opendev.org/746985
11:24:13 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_{LIBVIRT,QEMU}_PMEM_SUPPORT https://review.opendev.org/746986
11:24:14 openstackgerrit Lee Yarwood proposed openstack/nova master: fakelibvirt: Use versionutils to set min versions found in the driver https://review.opendev.org/749707
11:24:14 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_QEMU_VTPM https://review.opendev.org/749708
11:59:07 CeeMac afternoon
11:59:44 CeeMac is it possible to 'retrofit' a qemu guest agent channel to a volume backed instance after deployment?
12:00:17 CeeMac if i dumpxml for the domain of an instance that has it enabled and working in can see the unix device with the sock binding etc
12:00:40 CeeMac this device is missing from the other instance that weren't deployed from an image with the guest agent metadata tag
12:00:59 CeeMac wasn't sure if there was a way to generate the sock and binding manually and update the xml / refresh the instance?
12:01:35 CeeMac I've tried adding the metadata item to the instance and power cycling but no dice
12:03:05 openstackgerrit Stephen Finucane proposed openstack/nova master: Add reproducer for bug #1894095 https://review.opendev.org/749713
12:03:05 openstack bug 1894095 in OpenStack Compute (nova) "Running periodic task during live migration results in incorrect usage" [Medium,Confirmed] https://launchpad.net/bugs/1894095 - Assigned to Stephen Finucane (stephenfinucane)
12:03:05 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: Move live migration rollback under semaphore https://review.opendev.org/749714
12:07:56 stephenfin CeeMac: There isn't any way to modify that kind of configuration without a rebuild (new image) or resize (new flavor), unfortunately
12:08:19 stephenfin and the latter isn't an option because, weirdly, there's no equivalent flavor extra spec for the image metadata property
12:08:25 CeeMac ah
12:08:36 CeeMac boo, i was about to jump on that as a workable option
12:08:46 CeeMac its an odd one
12:08:49 stephenfin Well I don't see any reason we couldn't add the latter
12:08:57 stephenfin though I'm not sure about backportability
12:09:23 CeeMac as just having the metadata on the image isn't sufficient for it to work on a volume backed image, the metadata also needs adding to the instance at point of deployment from what I can see
12:09:37 stephenfin if it was reasonable to do but not backportable, you'd have to carry that yourself/prod your vendor to carry the backport downstream
12:09:59 CeeMac sure
12:10:13 CeeMac thanks stephenfin very helpful, if not much help :D
12:10:30 CeeMac I figured this would be the case though, just wanted some validation I wasn't going mad
12:10:42 CeeMac now I know, so I'll need to work around it
12:11:34 CeeMac i'm still on rocky, so I'm not sure the backport option would be acceptable, its probably fairly niche as far as requirements go
12:30:21 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: compute: Validate a BDMs disk_bus when provided https://review.opendev.org/744552
13:49:14 dansmith gibi: ++ for mentioning in the highlights, especially since a lot of cross-project collab has come out of it
13:49:47 dansmith gibi: I was kinda waiting for lyarwood to come back (which he did a while ago) and hopefully get some more meat in that doc about general rbd setup instructions and choices
13:50:15 dansmith gibi: since it's not as helpful to have a "so assume you already know a lot about a not-very-well-documented feature, here's some more details" doc
13:55:58 lyarwood dansmith: yeah sorry did you have a draft change somewhere for that?
13:56:05 dansmith lyarwood: yeah
13:56:13 dansmith lyarwood: https://review.opendev.org/#/c/731577/
13:56:29 lyarwood dansmith: cool thanks, I'll try to sort something out shortly
13:56:45 dansmith lyarwood: thanks, sorry to play the "shame is a powerful motivator" card :P
13:57:34 lyarwood dansmith: np I said I would do this and totally forgot so it's valid :)
13:57:42 artom gibi, was a func test for https://review.opendev.org/#/c/748453/ ever discussed?
13:57:44 dansmith :)
13:59:41 sean-k-mooney artom: not for that but there are some func tests later in the series
13:59:52 sean-k-mooney in https://review.opendev.org/#/c/740995/14
14:00:24 CeeMac stephenfin: I managed to find a workable solution!
14:00:29 sean-k-mooney for what its worth i do think the first 4 patches in the series are ready to merge if we can get more core eyes on them
14:00:51 sean-k-mooney the following 3 im re reviewing
14:01:03 artom sean-k-mooney, afaict those tests don't have both SRIOV and NUMA in the same instance
14:01:12 stephenfin CeeMac: Nice. What did you do?
14:01:15 artom And don't test live migration
14:01:33 artom sean-k-mooney, would be reasonable to ask for that, no?
14:01:49 sean-k-mooney it would be valid
14:01:52 artom We should have the framework(s) in place already...
14:02:07 sean-k-mooney i cloud re run my sriov testing with numa guest too i guess
14:02:21 sean-k-mooney i tested live migration with seriov but not of a numa instance
14:03:13 sean-k-mooney i still suspect "Make PCI claim NUMA aware during live migration" is incomplte but its strictly better then what we did before
14:03:40 CeeMac stephenfin: as the instance is volume backed, I removed the instance (keeping the volume), set the hw_qemu_guest_agent=yes image-property on the volume. Launched a new instance from the volume settings hw_qemu_guest_agent=yes as customer meta-data.
14:04:03 lyarwood elod / melwitt ; thanks for the reviews again! https://review.opendev.org/#/q/topic:bug/1889108+branch:stable/stein should be ready now if you have time
14:04:07 CeeMac unix socket is created, guest-ping works from host :D
14:04:43 sean-k-mooney CeeMac: ya that shoudl work
14:05:08 sean-k-mooney since we will pull the volume metadata for the new isntance
14:05:09 stephenfin CeeMac: Great to hear :) If you've time and are set up for Gerrit, that'd be a nice little footnote to include in the 'doc/source/admin/configuration/hypervisor-kvm.rst' doc.
14:05:26 stephenfin If not, at least you're sorted
14:06:03 CeeMac stephenfin: i have gerrit set up
14:06:13 CeeMac whats the process for updating the doc?
14:06:21 CeeMac haven't done that yet
14:06:41 stephenfin CeeMac: you'll want to clone the nova repo and edit the source doc at 'doc/source/admin/configuration/hypervisor-kvm.rst'
14:06:57 CeeMac just master?
14:07:12 stephenfin That's rendered and results in https://docs.openstack.org/nova/latest/admin/configuration/hypervisor-kvm
14:07:23 stephenfin Yeah, we can cherry-pick it back then
14:07:27 elod lyarwood: will do! to tell you the truth it's a bit too many refactoring patch backport for my taste :/
14:07:30 stephenfin backport it
14:08:32 CeeMac i'll give it a go!
14:09:13 lyarwood elod: yeah I appreciate that, some of these should've already been backported as bugfixes tbh

Earlier   Later