Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-09-02
14:05:42 sean-k-mooney basically i would like that fucntion to be testable on its own is all im really asking for
14:05:51 sean-k-mooney so we dont have to do complicated mocking in unit tests
14:14:12 openstackgerrit Merged openstack/nova master: Provider Config File: Coding style and test cases improvement https://review.opendev.org/748939
14:40:14 lyarwood stephenfin: https://review.opendev.org/#/c/639934 LGTM, asked a quick question wrt to actual gate testing, I assume this isn't something we could wire up right now correct?
14:45:57 stephenfin looking
14:53:49 sean-k-mooney lyarwood: vtpm can be tested in the gate
14:54:21 sean-k-mooney we just need tempest tests with a new compute feature flag
14:54:45 sean-k-mooney to contol running them then we need to update devstack to install teh swtpm software and configure it
14:55:11 sean-k-mooney so it could be tested but we would need to do the automation
14:55:29 sean-k-mooney maybe this is somethign we can work with our qe folks to do
14:56:10 sean-k-mooney e.g. the tempest tests
14:56:53 lyarwood sean-k-mooney: wouldn't we need the clouds we are using to have vTPM enabled instances for us to passthrough?
14:56:53 sean-k-mooney extenting devstack is really just adding a new flag and apt/dnf instaling the package
14:57:01 sean-k-mooney no
14:57:01 lyarwood sean-k-mooney: or is it fully emulated
14:57:07 sean-k-mooney this is fully emulated
14:57:23 lyarwood gah sorry I got confused reading the libvirt docs
14:57:31 openstackgerrit Akhil Gudise proposed openstack/nova master: Introduced a service UP check for host to the Rebuild path https://review.opendev.org/749531
14:58:05 lyarwood if it's fully emulated then it would've been nice to have a WIP posted already for this tbh
14:58:49 sean-k-mooney i could wip up a temp patch but we dont normally require tempest for a featre to merge
14:59:14 sean-k-mooney e.g. jsut chnage the tempest flaovrs and hardcode the tpm extra specs
14:59:22 sean-k-mooney and manulaly install swtpm
14:59:31 lyarwood sean-k-mooney: we have required tempest changes in the past FWIW
14:59:44 sean-k-mooney not that im aware of
14:59:59 sean-k-mooney we have said they shoudl be added but we have merged the code before hand
14:59:59 stephenfin swtpm isn't packaged on Ubuntu yet :(
15:00:03 lyarwood sean-k-mooney: I've had encrypted volume and stable rescue stuff held up in the past
15:00:08 stephenfin so we'd need to enable some PPAs
15:00:13 sean-k-mooney really
15:00:18 lyarwood stephenfin: well we also have Fedora ;)
15:00:18 sean-k-mooney stephenfin: ya that is easy to do
15:01:05 sean-k-mooney any way moving on form that crazy fedora idea :P
15:01:25 sean-k-mooney am do we want a quick DNM patch to hack in a full tempest run
15:01:44 stephenfin also, the version of QEMU and libvirt on Ubuntu 18.04 is too old
15:01:49 sean-k-mooney like we have done for numa before
15:01:56 stephenfin I had to use Fedora 31 for testing this locally
15:01:57 lyarwood *cough* Fedora *cough*
15:02:00 sean-k-mooney stephenfin: we are ment to be on ubuntu 20.04
15:02:03 sean-k-mooney before m3
15:02:11 lyarwood yeah good luck with that
15:02:17 sean-k-mooney its a comuntiy goal
15:02:25 sean-k-mooney and we really really should have done it already
15:02:34 stephenfin there a issues with some storage-related tests
15:02:42 stephenfin lyarwood has the specifics, iirc
15:02:47 sean-k-mooney that also affects cento8 and fedora
15:02:57 sean-k-mooney since they use teh same version of libvirt and qemu
15:03:02 stephenfin lyarwood: do we have a Fedora job I can hack on?
15:03:13 sean-k-mooney at least centos 8 and ubuntu 20.04 do
15:03:21 sean-k-mooney fedora might be newer
15:04:15 lyarwood well I could at least reproduce it with bionic and the UCA
15:04:15 stephenfin lyarwood, sean-k-mooney: oh, more fun, cirros doesn't support TPM so we'd have to use different guest images too
15:04:47 lyarwood stephenfin: >< okay well this is getting harder, I just wanted to ensure the file copying part worked tbh
15:05:24 stephenfin lyarwood: I can reproduce locally with DevStack master on Fedora 31, if that would help? Just go paste the results somewhere.
15:05:48 stephenfin Happy to get whitebox tests going post-M3 then. We'll need them at some point anyway
15:06:32 lyarwood stephenfin: yeah sure it's not worth holding this up for
15:08:07 lyarwood stephenfin: the -1 was for the commit nit btw not this testing
15:10:03 openstackgerrit Stephen Finucane proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934
15:10:20 stephenfin lyarwood: ta-da ^
15:11:45 jsuchome lyarwood: adapted https://review.opendev.org/#/c/748212/
15:12:51 gibi sean-k-mooney: as https://review.opendev.org/#/c/744816/ merged, will you propose an os-vif relase before the lib freeze?
15:13:14 sean-k-mooney am yes although i want to review two other patches today
15:13:25 sean-k-mooney ill propose a patch by eod
15:20:52 stephenfin gibi, sean-k-mooney: I can do it. Major or minor release, given the change in behavior?
15:20:59 stephenfin I'm tempted to say major
15:21:34 sean-k-mooney its minor we have not broke backwards compatblity
15:21:44 gibi sean-k-mooney, stephenfin: It is OK to have it done tomorrow, no rush.
15:22:18 stephenfin sean-k-mooney: cool
15:22:20 sean-k-mooney https://review.opendev.org/#/c/746673/ and https://review.opendev.org/#/c/745895/ are the two i want to re review
15:22:41 stephenfin gibi: It was a 1 minute job (I timed it :)) https://review.opendev.org/749535
15:22:49 stephenfin releasing-as-code++
15:22:51 gibi stephenfin: because you are fast :D
15:23:09 sean-k-mooney ya there is a tool you can run
15:23:17 sean-k-mooney that generate the patch for you
15:23:24 gibi stephenfin: thanks anyhow
15:23:27 stephenfin I know hberaud had one alright. Didn't know there was a generic one
15:23:39 sean-k-mooney its in the repo
15:23:43 sean-k-mooney you just use tox
15:23:47 gibi sean-k-mooney: hit me up with any of those patches if need a push on them before the freeze
15:24:09 sean-k-mooney i need to see if the previous comments have been adressed
15:24:27 sean-k-mooney it is a bug fix so we could backported anyway
15:25:55 stephenfin gibi: Could you carry your +2 from https://review.opendev.org/#/c/741995/10 to https://review.opendev.org/#/c/744958/8 ? They should be identical, commit message aside
15:25:58 stephenfin I had them separate to avoid intertwining two series, but that's not an issue now as the base patches for both have merged
15:26:16 stephenfin I'll abandon https://review.opendev.org/#/c/741995/10 now
15:27:20 gibi done
15:27:34 stephenfin thanks
15:27:35 gibi thanks for that ping, I forget about these duplications
15:29:03 stephenfin and while I have you (last one, promise) - this has two changes since your last +2: a change to some mocks to mock out the new "does this user/group exist" check, and a commit message nit from lyarwood https://review.opendev.org/#/c/639934/
15:29:14 stephenfin if you could revisit and close out the vTPM series \o/
15:29:17 gibi sure
15:29:19 gibi on it
15:29:28 gibi closing features before the FF week is nice :D
15:30:21 gibi and I'm planning for asking favors on the SRIOV series soon (as it is getting close to be ready)...
15:30:47 stephenfin fire 'em at me
15:31:17 gibi stephenfin: I will, working on functional tests now
15:33:12 gibi +2
15:34:11 sean-k-mooney gibi: i havent reviewd the WIP patch fully although i tested it. are you ready to remove the WIP status from it
15:34:37 sean-k-mooney i do think its close too
15:35:07 gibi sean-k-mooney: from code perspective it is ready (and my next push will remove the WIP tag) from test perspective I will push the unit test coverage today, but the functional test needs another day
15:35:34 sean-k-mooney ok thanks ill start reviewing the code so.
15:35:56 gibi cool, thanks

Earlier   Later