| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-08-31 | |||
| 17:13:05 | bauzas | sean-k-mooney: bye and thanks for all the fish | |
| 17:27:42 | sean-k-mooney | yum fish.... i was ment to get sushi yesterday but resturant nice resturant was not delivering. i think they are still offline today but someday this week ill will order some and it will be awsome. for now im just oging to go make dinner o/ | |
| 18:05:27 | sean-k-mooney | gibi: ill try to test your sriov series tomorrow but feel free to remind me to if i forget. | |
| 18:27:38 | sean-k-mooney | artom: added a few more details to https://review.opendev.org/#/c/747451/4 but im +1 on the patch | |
| 18:27:59 | sean-k-mooney | basically i just noted the binding point for the singel port binding workflow to show that that is also valid | |
| 18:28:15 | sean-k-mooney | and responded to lee's question regarding asserting the host | |
| 18:28:47 | sean-k-mooney | melwitt: ^ if you want me to expand on anything in particalar let me know but it looks correct. | |
| 18:31:21 | artom | sean-k-mooney, so when I tested this I didn't have any of the binding stuff in the vifs | |
| 18:31:31 | artom | Though in retrospect maybe I was running without the extension? | |
| 18:32:40 | sean-k-mooney | how do you mean | |
| 18:33:09 | sean-k-mooney | when you tested this with devstack or unit/functional tests | |
| 18:33:16 | artom | sean-k-mooney, devstack | |
| 18:33:30 | sean-k-mooney | which vifs did you check | |
| 18:33:39 | artom | sean-k-mooney, all of them :P | |
| 18:34:08 | artom | sean-k-mooney, even the network_info from the Neutron API didn't have them | |
| 18:34:28 | sean-k-mooney | which binding info are you looking for | |
| 18:34:45 | sean-k-mooney | the host id is not in the nova.network.model.VIF object | |
| 18:34:57 | sean-k-mooney | which is what is in the network info | |
| 18:35:09 | artom | sean-k-mooney, I guess it converts | |
| 18:35:24 | artom | Err, dad taxi time | |
| 18:35:27 | artom | Back in a bit | |
| 18:35:29 | sean-k-mooney | do you mean the migrating_to fields were not in the binding profile | |
| 18:35:32 | sean-k-mooney | sure | |
| 18:35:53 | artom | sean-k-mooney, that was there | |
| 18:35:54 | artom | http://paste.openstack.org/ | |
| 18:35:56 | artom | Err | |
| 18:36:01 | artom | http://paste.openstack.org/show/797304/ | |
| 18:36:07 | artom | I actually saved it at the time | |
| 18:36:19 | artom | To compare the nw_info from the API vs the one from the cache | |
| 18:36:23 | artom | That link is the one from the API | |
| 18:36:28 | artom | It has migrating_to | |
| 18:36:31 | artom | But that's it | |
| 18:36:36 | artom | The one in the cache didn't have it | |
| 18:36:42 | sean-k-mooney | ah ok | |
| 18:36:52 | sean-k-mooney | then ya i guess you could assert that | |
| 18:37:01 | artom | http://paste.openstack.org/show/797305/ is from the cache | |
| 18:37:04 | sean-k-mooney | the one in the cache has not been update at all then | |
| 18:37:19 | artom | OK, really have to bounce | |
| 18:37:43 | sean-k-mooney | artom: cool but just so you know you just showed there is something you can test in a follow up patch :P | |
| 18:38:07 | sean-k-mooney | you also showed that its doint the right thing | |
| 18:38:37 | artom | sean-k-mooney, checking that "migrating_to" is *not* in the VIF? | |
| 18:38:39 | sean-k-mooney | since the cache does not have any of the chagne done during migration | |
| 18:38:43 | sean-k-mooney | yep | |
| 18:38:50 | artom | Ah, yeah true :) | |
| 18:39:14 | sean-k-mooney | go do dad taxi :) | |
| 20:27:36 | mnaser | is there a 'pre-release' checklist for nova | |
| 20:28:02 | mnaser | it'd be nice if some migrations that hit the same table were combined, s=>t includes adding vpmem and resources to instance_extra | |
| 20:28:14 | mnaser | so going through that painful migration once might be nicer/easier | |
| 20:33:00 | mriedem | mnaser: closest is probably here now https://docs.openstack.org/nova/latest/contributor/ptl-guide.html | |
| 20:33:20 | mriedem | https://wiki.openstack.org/wiki/Nova/ReleaseChecklist is older | |
| 20:34:26 | mriedem | with what your asking for there it's probably hard to do when you're working on separate features, db schema migrations aren't rolled together at the end of the release, they happen as features land | |
| 20:35:02 | mriedem | *you're | |
| 20:35:16 | mnaser | mriedem: yeah i guess going on the 'every commit is releasable' makes this a little impossible | |
| 20:36:19 | mriedem | those didn't actually migrate data did they? just alter table to add the column on a big table? | |
| 20:36:46 | mnaser | mriedem: yeah alter table on a big table indeed | |
| 20:38:07 | mnaser | in this case two migrations on instance_extra | |
| #openstack-nova - 2020-09-01 | |||
| 01:23:58 | openstackgerrit | Tony Su proposed openstack/nova master: Provider Config File: Coding style and test cases improvement https://review.opendev.org/748939 | |
| 01:34:15 | openstackgerrit | Brin Zhang proposed openstack/nova master: Reject resize operation for accelerator https://review.opendev.org/748560 | |
| 03:06:19 | tony_su | stephenfin: gibi: the remaining comments follow-up patch is at https://review.opendev.org/748939. no code logic change and it will take 15 minutes to review it. Thanks. | |
| 03:21:03 | openstackgerrit | Kaifeng Wang proposed openstack/nova master: [PoC] Implements snapshot interface for ironic https://review.opendev.org/749174 | |
| 04:10:22 | openstackgerrit | Hemanth Nakkina proposed openstack/nova master: Update pci stat pools based on PCI device changes https://review.opendev.org/749175 | |
| 06:51:10 | openstackgerrit | Mamduh proposed openstack/os-vif master: Refactor code of linux_net to more cleaner and increase performace https://review.opendev.org/746673 | |
| 07:04:35 | openstackgerrit | Mamduh proposed openstack/os-vif master: Refactor code of linux_net to more cleaner and increase performace https://review.opendev.org/746673 | |
| 07:10:17 | gibi | sean-k-mooney: thanks in advance for the sriov tests :) | |
| 07:39:15 | openstackgerrit | Mamduh proposed openstack/os-vif master: Refactor code of linux_net to more cleaner and increase performace https://review.opendev.org/746673 | |
| 08:36:27 | brinzhang | gibi: if you have free time today, hope you can review the cyborg evacuate patch https://review.opendev.org/#/c/715326/ | |
| 08:36:35 | brinzhang | thanks \o/ | |
| 08:37:12 | brinzhang | and this follow-up patch:https://review.opendev.org/#/c/748560/ | |
| 08:40:20 | lyarwood | elod: re https://review.opendev.org/#/q/topic:bug/1887946+branch:stable/stein yeah please if we could land and then release that would be awesome | |
| 08:40:46 | lyarwood | jsuchome: just catching up with the patch now, if stephenfin and artom are happy we should finally be good | |
| 08:41:52 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Cyborg evacuate support https://review.opendev.org/715326 | |
| 08:46:37 | jsuchome | lyarwood: good. I pushed the changes suggesed by stephenfin into the main patch yesterday, I did not update the release notes patch yet | |
| 08:48:40 | gibi | brinzhang: done | |
| 08:51:11 | brinzhang | gibi: thanks | |
| 08:51:13 | lyarwood | jsuchome: kk, I'll wait for CI to turn green again and then review in full | |
| 08:53:57 | openstackgerrit | Alexandre Arents proposed openstack/nova master: Update image_base_image_ref during rebuild. https://review.opendev.org/749205 | |
| 08:58:17 | brinzhang | gibi, stephenfin: https://review.opendev.org/#/c/748560/ this patch, I saw stephenfin wants us to report a bug in launchpad to backport this change to Ussuri, do we need to do this? | |
| 08:58:35 | brinzhang | if necessary, I can report a bug fastly | |
| 09:00:07 | gibi | brinzhang: sure let's have a bug and a backport | |
| 09:00:11 | elod | lyarwood: OK, meanwhile there was the weekend and afterwards gate issue... so I was not in a hurry to prepare the stein release patch. :) | |
| 09:00:15 | brinzhang | gibi: will do | |
| 09:00:24 | gibi | thanks | |
| 09:00:31 | brinzhang | np | |
| 09:01:57 | elod | lyarwood: actually, I don't know yet, whether gate is OK on stable... | |
| 09:04:38 | lyarwood | elod: kk | |
| 09:06:45 | viks____ | hi, how to upgrade the cloud-init in the image when creating a fresh instance.. i want this to happen before cloud-init user data being run.. | |
| 09:07:28 | openstackgerrit | Brin Zhang proposed openstack/nova master: Reject resize operation for accelerator https://review.opendev.org/748560 | |
| 09:07:59 | brinzhang | gibi, stephenfin: done | |
| 09:30:51 | bauzas | oh man, children are back to school, /me needs to be go they again noxw | |
| 09:53:07 | openstackgerrit | Merged openstack/nova master: fakelibvirt: Remove nova-network remnants https://review.opendev.org/737329 | |
| 09:55:51 | stephenfin | ooh, the new zuul result page is pretty <3 | |
| 09:57:57 | stephenfin | gibi: In the same spirit as that just-merged fakelibvirt change, care to stick https://review.opendev.org/730866 and https://review.opendev.org/732725 on your queue? | |
| 09:58:24 | stephenfin | oh, and https://review.opendev.org/740922 pretty please :) | |
| 10:29:20 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: Improve CinderFixtureNewAttachFlow https://review.opendev.org/749222 | |
| 10:29:21 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: Robustify attachment tracking in CinderFixtureNewAttachFlow https://review.opendev.org/749223 | |
| 10:29:22 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: compute: Use source_bdms to reset attachment_ids during LM rollback https://review.opendev.org/749224 | |
| 10:29:23 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: compute: refactor volume bdm rollback error handling https://review.opendev.org/749225 | |
| 10:29:26 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: Add regression tests for bug #1889108 https://review.opendev.org/749226 | |
| 10:29:26 | openstack | bug 1889108 in OpenStack Compute (nova) train "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood) | |
| 10:29:27 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/749227 | |