| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-08-31 | |||
| 13:07:18 | sean-k-mooney | stephenfin: if we just use that waring as a depercation warning then all of libvirt arm and power support would be deprecated and its not | |
| 13:08:36 | gibi | that warning was added 7 years ago https://review.opendev.org/#/c/69919/ | |
| 13:09:17 | gibi | I agree with sean-k-mooney here to state the deprecation explicitly for these first | |
| 13:09:36 | stephenfin | Okay, fair. I'll do that now and -W what's there for another few months | |
| 13:09:39 | stephenfin | Thanks for the reviews :) | |
| 13:09:56 | sean-k-mooney | :) | |
| 13:10:15 | gibi | sean-k-mooney: vmware undeprecation is still open https://review.opendev.org/#/c/742407/ but I think we have a good chance to merge that | |
| 13:12:00 | gibi | dansmith: could you check back to the vmware undeprecation patch ^^ ? | |
| 13:13:01 | openstackgerrit | Brin Zhang proposed openstack/nova master: Refactor check and exception https://review.opendev.org/749052 | |
| 13:16:44 | openstackgerrit | Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | |
| 13:19:16 | gibi | sean-k-mooney: I have no idea how image_base_image_ref can be None for a qcow2 instance | |
| 13:19:47 | gibi | sean-k-mooney: we should make a reproduction of the tripleo test case | |
| 13:22:12 | openstackgerrit | Brin Zhang proposed openstack/nova master: Refactor check and exception https://review.opendev.org/749052 | |
| 13:24:49 | sean-k-mooney | gibi: it failed on one of your patches too | |
| 13:24:52 | sean-k-mooney | https://review.opendev.org/#/c/739246/ | |
| 13:24:58 | sean-k-mooney | http://logstash.openstack.org/#/dashboard/file/logstash.json?query=message:%5C%22_finalize_unshelve_qcow2_image%5C%22&from=30d | |
| 13:25:14 | sean-k-mooney | there are only 2 hits in logstach so far in the last month | |
| 13:25:16 | openstackgerrit | Wenping Song proposed openstack/nova master: Reject resize operation for accelerator https://review.opendev.org/748560 | |
| 13:29:06 | sean-k-mooney | gibi: so apparently the filed is not set in the system metadata | |
| 13:32:20 | gibi | so we have a tempes test that can reproduce the problem but it only does it really infrequently | |
| 13:37:48 | gibi | sean-k-mooney: nope, the error that was in my patch has a different stack trace https://zuul.opendev.org/t/openstack/build/de80ec8f00204a92b5e667bdf7a72cee/log/controller/logs/screen-n-cpu.txt#24116 | |
| 13:38:49 | gibi | also the another nova hit in kibana is different too https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_990/739246/3/check/tempest-integrated-compute/990dace/controller/logs/screen-n-cpu.txt | |
| 13:39:28 | sean-k-mooney | gibi: kibana found that error too however | |
| 13:39:43 | sean-k-mooney | on patchset 3 and 4 | |
| 13:40:34 | gibi | the two error I see in kibana on review 739246 have different stack traces | |
| 13:40:51 | sean-k-mooney | oh they do | |
| 13:41:05 | gibi | it does hit _finalize_unshelve_qcow2_image but different way | |
| 13:41:06 | sean-k-mooney | just the same function | |
| 13:41:07 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Drop support for UML https://review.opendev.org/743230 | |
| 13:41:08 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Drop support for Xen https://review.opendev.org/743231 | |
| 13:41:08 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove 'hypervisor_version' from 'libvirt_info' https://review.opendev.org/744199 | |
| 13:41:09 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Deprecate support for non-QEMU/KVM backends https://review.opendev.org/749055 | |
| 13:41:09 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove '[vnc] keymap', '[spice] keymap' options https://review.opendev.org/749056 | |
| 13:41:29 | gibi | one of the errors I even recognize as a rebase issue from my patch | |
| 13:41:38 | stephenfin | sean-k-mooney: gibi: There you go. I'll mark the actual removal patch as -W for six months or so, heh | |
| 13:42:30 | gibi | stephenfin: thanks | |
| 13:43:16 | gibi | stephenfin: if you are itcign for a real removal then the xenserver driver can be removed I tihnk :) | |
| 13:43:47 | stephenfin | Sure, if you're happy to review it, I'm happy to do it :) | |
| 13:44:11 | dansmith | gibi: the ciwatch page shows more red than green for vmware lately, but I'm not sure how to figure out what is failing because the log dump isn't complete | |
| 13:44:26 | gibi | stephenfin: sure, why not | |
| 13:44:54 | dansmith | gibi: oh actually, I guess I'm missing a bunch of green to the right | |
| 13:45:08 | gibi | dansmith: looking.. | |
| 13:45:17 | dansmith | but I'm not sure what to make of the fails that have no logs, maybe those are aborts due to a new patch rev going up or something? | |
| 13:46:44 | dansmith | okay, I found a fail that looks like a real fail, so I dunno what those other ones are, if not aborts | |
| 13:47:16 | dansmith | I just wanted to find something that looks like a real failure to contrast it to a passing run, and also to make sure it's actually reporting failures | |
| 13:47:46 | gibi | yeah, me neither | |
| 13:48:12 | gibi | I'm trying to figure out if Yingji Sun or jhui@vmware.com is on IRC or not | |
| 13:48:44 | gibi | so we can ask them | |
| 13:53:48 | sean-k-mooney | dansmith: they might be hitting the same keystone error that is breaking the first party ci | |
| 13:54:09 | dansmith | sean-k-mooney: and reporting empty logs? seems weird, but okay | |
| 13:55:09 | sean-k-mooney | well no that is likely another issue | |
| 13:55:23 | sean-k-mooney | i just noticed they started failing when the upstream jobs also started failng | |
| 14:00:05 | sean-k-mooney | hum the hyperv ci also seams to be broken | |
| 14:00:20 | sean-k-mooney | its been red for at least the last 7 days | |
| 14:33:24 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Add a routed networks scheduler pre-filter https://review.opendev.org/749068 | |
| 14:33:37 | bauzas | gibi: sean-k-mooney: there it is ^ | |
| 14:36:02 | bauzas | gibi: sean-k-mooney: I now use a pre-filter that looks at the existing physnets that were provided by https://github.com/openstack/nova/blob/master/nova/network/neutron.py#L2082 | |
| 14:39:16 | bauzas | I mean the network metadata that isn't persisted in the spec object but reused by every move operation | |
| 15:08:49 | gibi | bauzas: then I think you have to resolve TODO in the codepath that gather the physnets https://github.com/openstack/nova/blob/b5d48043466b53fbdfe7b93c2e4efd449904e593/nova/network/neutron.py#L2020 | |
| 15:09:06 | gibi | as today it only get one physnet per network, even if there are multiple | |
| 15:09:32 | bauzas | holy shit. | |
| 15:14:13 | bauzas | gibi: in a meeting | |
| 15:25:31 | bauzas | gibi: actually, looking at vladik's comment, I'm not expert, but do we really support multiple networks per vlans? | |
| 15:25:49 | bauzas | multiple physnets* | |
| 15:27:34 | gibi | as far as I know in neutron nothing prevents you to create two vlan segments with different physnets in the same network | |
| 15:47:28 | bauzas | gibi: okay, then I don't feel enough expert to fix this TODO | |
| 15:48:05 | bauzas | gibi: the other way would be to find a way to pass requested networks down in the request spedc | |
| 15:48:07 | bauzas | spec* | |
| 15:48:19 | bauzas | which is something we don't do | |
| 15:49:39 | gibi | the way the pervious patches did it was to pass the aggregates via request_spec.request_level_params.member_of | |
| 15:50:04 | gibi | and do the network segment -> host aggregate translation in an upper layer (conductor) | |
| 15:50:20 | bauzas | gibi: I know | |
| 15:50:33 | bauzas | but a pre-filter is better, right? | |
| 15:50:55 | bauzas | and we don't need to pass the aggregates by a new field | |
| 15:51:08 | bauzas | the destination object already contains what we need | |
| 15:51:26 | gibi | this is still a pre-filter as the aggregate filterin happens in the a_c query | |
| 15:51:53 | gibi | also I don't think request_spec.request_level_params.member_of is a new field at all | |
| 15:52:03 | bauzas | gibi: matt added it | |
| 15:52:11 | gibi | the member_of parts? | |
| 15:52:16 | gibi | that could be | |
| 15:52:30 | gibi | but the request_level_params object should be on master I think | |
| 15:52:30 | bauzas | gibi: we already have pre-filters that add specific aggregates to verify | |
| 15:52:45 | bauzas | so, the problem is not how to ask placement | |
| 15:52:59 | bauzas | but rather, how to pass the networks to the pre-filter | |
| 15:53:36 | gibi | you have to pass in new information so you have to extend an passed object or pass a new object | |
| 15:53:37 | bauzas | gibi: see, https://github.com/openstack/nova/blob/b5d48043466b53fbdfe7b93c2e4efd449904e593/nova/scheduler/request_filter.py#L121 | |
| 15:54:00 | bauzas | gibi: this way, from the pre-filter, you can pass the list of aggregates to require | |
| 15:54:11 | bauzas | so this is a solved problem | |
| 15:54:34 | bauzas | but since we only have the request spec object that is passed down to the pre-filter, we need to get the networks from it | |
| 15:54:43 | bauzas | my proposal was to use the network metadata info | |
| 15:55:02 | bauzas | but we only provide a list of physnets | |
| 15:55:49 | gibi | so you can extend the NetworkMetadata if you wish, or you can extend the RequestLevelParams of the RequestSpec | |
| 15:56:17 | bauzas | or I could get the info like this https://github.com/openstack/nova/blob/b5d48043466b53fbdfe7b93c2e4efd449904e593/nova/objects/request_spec.py#L547 | |
| 15:56:35 | bauzas | (from the vif) | |
| 15:56:48 | gibi | do we have the instance info cache populated before reaching the compute? | |
| 15:57:27 | bauzas | no, that's only for a move op | |
| 15:57:34 | bauzas | AFAIK | |
| 15:57:43 | bauzas | anyway, I need to think about the problem more | |
| 15:57:45 | gibi | yeah, for the move you can reach into the info cache | |
| 15:58:36 | bauzas | gibi: I need to balance all the options | |