| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-08-27 | |||
| 08:37:07 | stephenfin | thanks | |
| 08:39:38 | bauzas | gibi: I want to provide the implementation for the routed networks spec, can I supersed https://review.opendev.org/#/c/656885/7 ? | |
| 08:39:52 | bauzas | I mean, not providing a new revision, rather a new change | |
| 08:43:53 | gibi | bauzas: sure | |
| 08:44:10 | bauzas | thanks | |
| 08:44:11 | gibi | sean-k-mooney: do you have ideas what happenening here https://bugs.launchpad.net/nova/+bug/1892361 ? | |
| 08:44:11 | openstack | Launchpad bug 1892361 in OpenStack Compute (nova) "SRIOV instance gets type-PF interface, libvirt kvm fails" [Undecided,New] | |
| 08:46:31 | gibi | it seems libvirt driver generates wrong xml for a PF dev | |
| 08:51:20 | stephenfin | gibi: btw, finally got around to this https://review.opendev.org/#/c/748377/ | |
| 08:52:01 | stephenfin | It's the backport-candidate label change for Gerrit. I think that's how one does it. I've asked hberaud (who did it for oslo) for advice | |
| 08:52:03 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP compute: Only call _local_delete_cleanup when scheduled instance is found https://review.opendev.org/748380 | |
| 08:53:21 | lyarwood | now to work out how to exercise that in a regression test | |
| 08:56:17 | gibi | stephenfin: ack, thanks | |
| 09:02:17 | gibi | artom, bauzas: there is a vGPU related bugs in the tracker https://bugs.launchpad.net/nova/+bug/1887380 | |
| 09:02:17 | openstack | Launchpad bug 1887380 in OpenStack Compute (nova) "Attaching virtual GPU devices to guests in nova" [Undecided,New] | |
| 09:03:42 | bauzas | gibi: ack | |
| 09:21:58 | openstackgerrit | Vlad Gusev proposed openstack/nova stable/ussuri: docs: Resolve issue with deprecated extra specs https://review.opendev.org/748386 | |
| 09:22:19 | openstackgerrit | Vlad Gusev proposed openstack/nova stable/ussuri: replace the "hide_hypervisor_id" to "hw:hide_hypervisor_id" https://review.opendev.org/747189 | |
| 09:35:05 | openstackgerrit | Alexandre Arents proposed openstack/nova master: Add a lock to prevent race during detach/attach of interface https://review.opendev.org/747957 | |
| 09:46:53 | jsuchome | Hi stephenfin, could we get https://review.opendev.org/#/c/574301/ merged? I think your ,ain concerns were adressed | |
| 10:01:22 | stephenfin | jsuchome: I think lyarwood might have accidentally regressed your changes from PS37 when updating the patch below it. That's why my -1 is still there | |
| 10:01:30 | stephenfin | the docs are still wrong here https://review.opendev.org/#/c/574301/39/nova/conf/glance.py | |
| 10:03:09 | stephenfin | jsuchome: Also, would it impact you if I asked for a new boolean config option to turn on rbd direct download instead of reviving 'allowed_direct_url_schemes'? The more I think about it, the less I like it /o\ | |
| 10:03:30 | stephenfin | that would let you drop the following patch and finish this in one patch | |
| 10:05:09 | gibi | stephenfin, jsuchome: if it matters I can quickly re-review the patch(s) after such change | |
| 10:05:26 | lyarwood | stephenfin: did I? | |
| 10:05:33 | lyarwood | stephenfin: crap my bad sorry | |
| 10:06:02 | stephenfin | easily fixed | |
| 10:09:52 | stephenfin | I really do think the new option is better idea though. Much easier to discover and just better UX in general, IMHO. Looks like it'll have a minimal impact of the patch too | |
| 10:14:57 | jsuchome | I'm not exactly in favor of that ... I think reusing that old option was described as a way to go in the blueprint | |
| 10:20:04 | stephenfin | jsuchome: Right, but the spec was first proposed in Queens when that option wasn't yet deprecated. I realize the approved spec notes the deprecation and its impact, but is there a clear technical reason for undeprecating the option or was it simply inertia? | |
| 10:22:29 | jsuchome | I don't think there's technical reason, main reason is that it all takes so much time... | |
| 10:24:45 | jsuchome | I hear there are some users using this patch already so I would think it's nice to just keep the option the same, but that's just it. Maybe the inconsistency with the bp is not an issue, it just looks ugly in a different way | |
| 10:29:48 | openstackgerrit | Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | |
| 10:55:07 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Introduce '[glance] enable_rbd_download' https://review.opendev.org/748411 | |
| 10:55:18 | stephenfin | jsuchome, (lyarwood): ^ | |
| 11:10:45 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use absolute path during qemu img rebase https://review.opendev.org/739246 | |
| 11:12:48 | gibi | stephenfin, lyarwood: rebased and fixed up ^^ | |
| 11:18:55 | tony_su | stephenfin: gibi: thanks for your kind assistance for code review and all patches were merged today. | |
| 11:19:27 | gibi | tony_su: thanks for taking care of those patches. nicely done! | |
| 11:20:49 | tony_su | I will continue to take care of any remaining nit comments as a follow-up patch. | |
| 11:22:52 | gibi | thanks | |
| 11:37:22 | jsuchome | stephenfin: I understand it can be done and that the change is small (altough you see youreself that it is affecting the testsuite) ... it just means back to the step 1 with reviews after months getting it to the current state... | |
| 11:55:33 | stephenfin | jsuchome: Hardly. The idea is sound. Just a tweak to the config option | |
| 11:56:08 | stephenfin | and the change is to the new test, not to anything existing | |
| 11:56:43 | stephenfin | gibi: Done | |
| 12:05:01 | gibi | stephenfin: thanks | |
| 12:23:57 | brinzhang_ | stephenfin: hope you can review the cyborg evacuate support patch, it has +2 by gibi, https://review.opendev.org/#/c/715326/ | |
| 12:24:09 | brinzhang_ | stephenfin, gibi: thanks | |
| 12:27:09 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Only unplug vif after the device is detached from libvirt https://review.opendev.org/744934 | |
| 13:22:23 | stephenfin | brinzhang_: Done. I'm -1 but it's just a collection of mostly trivial stuff | |
| 13:29:32 | brinzhang_ | stephenfin: thanks, I will update tomorrow | |
| 13:30:16 | brinzhang_ | stephenfin: https://review.opendev.org/#/c/715326/22/nova/accelerator/cyborg.py@313 this function I would not like to change, and Iwant keep it in the cyborg file | |
| 13:30:49 | brinzhang_ | and I think it's easy to maintain in the furture | |
| 13:31:49 | brinzhang_ | s/furture/future | |
| 13:31:58 | stephenfin | okay, it just seemed unnecessary when it's only one line long and has a single caller. If you're planning to add additional callers, then maybe it makes sense to keep | |
| 13:32:34 | brinzhang_ | stephenfin: yes, the cyborg shelve/unshelve patch also need to use this function | |
| 13:32:59 | stephenfin | okay, just leave a comment in the patch then (y) | |
| 13:33:04 | stephenfin | *a reply | |
| 13:33:55 | brinzhang_ | stephenfin: thanks | |
| 13:34:28 | stephenfin | Is anyone else see "Code Review - Error Server Unavailable" occasionally from Gerrit? | |
| 13:34:34 | brinzhang_ | it's the shelve/unshelve patch https://review.opendev.org/#/c/729563/8/nova/compute/api.py@4033 | |
| 13:35:30 | sean-k-mooney | given where you are currently working its proably your internet | |
| 13:42:06 | bauzas | stephenfin: I do, lots of time | |
| 13:42:21 | bauzas | but... I can't say my Internet is the better, right? | |
| 13:42:34 | stephenfin | heh, yeah, no | |
| 13:42:36 | stephenfin | :P | |
| 13:43:00 | bauzas | and the answer is sadly "yes, but not for your zone" | |
| 13:43:30 | bauzas | but I don't know which one | |
| 13:44:24 | bauzas | stephenfin: that being said, this error seems very server-side to me | |
| 13:44:29 | gibi | stephenfin: I do get Server Unavailable about 5 times per day from gerrit on an otherwise stable internet connection | |
| 13:44:42 | bauzas | gibi: do you accept a coworker ? | |
| 13:44:49 | stephenfin | I'm getting it every 30 seconds or so at the moment | |
| 13:45:02 | bauzas | yesterday was bad on this now that I remember | |
| 13:45:22 | bauzas | they're probably exhausting the number of java processes | |
| 13:45:31 | gibi | bauzas: I do, but I repeatedly failed to get more headcount on OpenStack upstream | |
| 13:46:02 | bauzas | gibi: well, I just need a seat and a decent connection, a contract is too much :p | |
| 13:47:10 | gibi | bauzas: the seating would be a problem. MY 33m^2 flat does not even serve me well on seating | |
| 13:48:43 | bauzas | gibi: I invested on a small Swedish company which I don't remember the name | |
| 13:49:02 | bauzas | gibi: but they are good at providing you decent chairs around 200€ that are worth it | |
| 13:49:38 | bauzas | Ike-something | |
| 13:49:50 | gibi | bauzas: :) | |
| 13:50:16 | bauzas | stephenfin can speak of how my house is just an Ikea showroom | |
| 13:51:18 | gibi | I have no problem with Ikea stuff, my kichen is from there | |
| 13:51:26 | bauzas | you know that you frequented too much Ikea when you're able to name furniture by their Ikea names | |
| 13:52:31 | bauzas | gibi: worth saying, the Markus chair is very decent for the price | |
| 13:52:58 | bauzas | this saves my butt 5 times a week, 10 hours per day | |
| 13:53:24 | gibi | thanks for the suggestion | |
| 13:54:29 | gibi | do you happen to have one of those Ikea Skarsta desk? | |
| 13:54:43 | bauzas | nope but I know them | |
| 13:55:08 | gibi | is it worth the price tag? | |
| 13:55:14 | bauzas | looks like, yes | |
| 13:55:21 | bauzas | some coworkers have them | |
| 13:56:55 | gibi | cool, thanks. | |
| 13:57:15 | bauzas | (I personnally have the Linnmon desk, cheap but large) | |
| 13:59:39 | bauzas | gibi: still homeoffice, I guess ? | |
| 13:59:57 | gibi | yes. It seems this year I don't have to go back to the office if I don't want to | |
| 14:02:49 | bauzas | this seems reasonable | |
| 14:07:03 | artom | lyarwood, https://review.opendev.org/#/c/720769/5 -0.5 I guess? | |
| 14:07:14 | artom | I left it voteless, take it or leave it :P | |