| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-08-26 | |||
| 13:04:12 | gibi | finding even | |
| 13:04:15 | sean-k-mooney | right but type hints are not a style change | |
| 13:04:20 | sean-k-mooney | they are a type of testing | |
| 13:04:46 | lyarwood | have to say I disagree bauzas, we'd never be able to move the codebase forward otherwise | |
| 13:04:55 | sean-k-mooney | its technically a liniting enhancement | |
| 13:05:11 | stephenfin | as someone who's paid to work on the libvirt module, so do I | |
| 13:05:14 | bauzas | gibi: the story of my life https://i.pinimg.com/564x/c5/de/f4/c5def4bd565b44f4d27e1b7478dfa528.jpg | |
| 13:05:17 | stephenfin | so. much. cruft. | |
| 13:05:28 | sean-k-mooney | bauzas: hehe | |
| 13:05:33 | lyarwood | awww ./me hugs nova.virt.libvirt | |
| 13:05:45 | stephenfin | heh | |
| 13:05:47 | bauzas | lyarwood: stephenfin: I don't say we shouldn't modify code | |
| 13:06:08 | sean-k-mooney | bauzas: worst part of git blame. who wrote this crap.. damb it was was me... | |
| 13:06:21 | stephenfin | bauzas: well, take things like this https://review.opendev.org/#/c/631363/61/nova/tests/unit/virt/libvirt/fakelibvirt.py@135 | |
| 13:06:32 | efried | Hah! Yes! I get to blame Chris! https://review.opendev.org/#/c/639934/7..8/nova/virt/libvirt/utils.py@630 | |
| 13:06:35 | stephenfin | personally, I think that's a good thing | |
| 13:07:24 | gibi | efried: good, he is not around to pass it forward :) | |
| 13:07:32 | efried | Perfect | |
| 13:07:56 | sean-k-mooney | oh recursive=true | |
| 13:08:03 | stephenfin | I mean, I'm touching that code and the additional change makes the whole thing better | |
| 13:08:13 | bauzas | stephenfin: again, no disagreement, just saying that the more we can decouple style changes from implementation changes, the better it would be as we could pull those style changes down to the stable branches without also pulling fancy new features | |
| 13:08:35 | sean-k-mooney | stephenfin: did you see if this is need for livemiration by the way. i think we dont have too copy for live migration but we never validated that | |
| 13:08:49 | sean-k-mooney | stephenfin: so currently we do just to be safe | |
| 13:09:04 | stephenfin | sean-k-mooney: Currently I have live migration blocked because I haven't validated it | |
| 13:09:20 | sean-k-mooney | ok well when you do can you try commenting out the tpm data copy | |
| 13:09:22 | stephenfin | I do have a DevStack env on your cluster that I'll use to validate it once the rest has merged though | |
| 13:09:23 | sean-k-mooney | and see if it works | |
| 13:09:28 | bauzas | stephenfin: fortunately, git is smart enough to handle conflicts on blank lines | |
| 13:09:39 | stephenfin | sean-k-mooney: If we're talking about the same thing, then that's for cold migration | |
| 13:09:43 | bauzas | (or it should) | |
| 13:09:51 | sean-k-mooney | https://review.opendev.org/#/c/639934/30/nova/virt/libvirt/utils.py@691 | |
| 13:09:56 | sean-k-mooney | the save and restore | |
| 13:10:16 | stephenfin | Yes, that is necessary. I checked the libvirt docs and included the relevant snippet in the commit message | |
| 13:10:31 | sean-k-mooney | its needed for cold migration | |
| 13:10:37 | stephenfin | Libvirt | |
| 13:10:38 | stephenfin | won't do this automatically for us since cold migrations, or offline | |
| 13:10:38 | stephenfin | migrations in libvirt lingo, do not currently support "copying | |
| 13:10:38 | stephenfin | non-shared storage or other file based storages", which includes the | |
| 13:10:38 | stephenfin | vTPM device [1]. | |
| 13:10:43 | sean-k-mooney | stephenfin: but the qemu example seamed to imply it is not for live | |
| 13:10:55 | sean-k-mooney | but there was not clear statement of that | |
| 13:11:01 | stephenfin | ah, yes | |
| 13:11:02 | stephenfin | well | |
| 13:11:04 | stephenfin | <stephenfin> sean-k-mooney: Currently I have live migration blocked because I haven't validated it | |
| 13:11:10 | stephenfin | so I can try when I do the validation, sure :) | |
| 13:11:17 | sean-k-mooney | stephenfin: cool | |
| 13:11:38 | sean-k-mooney | stephenfin: it was an open question in the spec to be figured out when we do the implemnation so jsut reminding you | |
| 13:11:42 | stephenfin | bauzas: Fair. I guess it's just a matter of where to draw the line | |
| 13:11:59 | stephenfin | I'd be less conservative about this stuff that you are, I suspect | |
| 13:12:14 | bauzas | stephenfin: if any of us can just think every time we write on maintainability and upgrades, this would just be perfect. | |
| 13:12:35 | bauzas | stephenfin: totally, and I recognize me being a lame coworker | |
| 13:12:36 | bauzas | :p | |
| 13:13:43 | stephenfin | yeah, stop being so lame! | |
| 13:13:45 | stephenfin | ;) | |
| 13:14:17 | sean-k-mooney | stephenfin: https://github.com/qemu/qemu/blob/master/docs/specs/tpm.rst#migration-with-the-tpm-emulator | |
| 13:15:23 | sean-k-mooney | since there is no copy in those steps i was sepcualtign it was in the testvm.bin file | |
| 13:16:23 | sean-k-mooney | but its also posible this was on the same host so -tpmstate dir=/tmp/mytpm1 could be acceable | |
| 13:18:41 | openstackgerrit | Lucas Alvares Gomes proposed openstack/nova master: DO NOT REVIEW: Test OVN devstack module https://review.opendev.org/748226 | |
| 13:50:30 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Ensure source compute is up when confirming a resize https://review.opendev.org/699291 | |
| 13:50:36 | lyarwood | gibi: ^ would you be able to take a look at this when you have time? | |
| 13:50:45 | gibi | lyarwood: sue | |
| 13:50:49 | lyarwood | gibi: thanks | |
| 13:50:51 | gibi | sure | |
| 13:51:14 | lyarwood | stephenfin: the rebase to remove the merge conflict just removed your +2 if you can readd | |
| 13:54:11 | stephenfin | will do | |
| 13:54:45 | lyarwood | thanks | |
| 14:10:35 | openstackgerrit | Merged openstack/nova master: libvirt: Add emulated TPM support to Nova https://review.opendev.org/631363 | |
| 14:10:42 | openstackgerrit | Merged openstack/nova master: docs: Add docs for vTPM support https://review.opendev.org/739213 | |
| 14:10:50 | lyarwood | bauzas / melwitt: https://review.opendev.org/#/c/747973/ - should be ready if either of you have time today. | |
| 14:10:58 | openstackgerrit | Merged openstack/nova master: tests: Add reproducer for bug #1889633 https://review.opendev.org/744020 | |
| 14:10:58 | openstack | bug 1889633 in OpenStack Compute (nova) "Pinned instance with thread policy can consume VCPU" [High,In progress] https://launchpad.net/bugs/1889633 - Assigned to Stephen Finucane (stephenfinucane) | |
| 14:11:07 | openstackgerrit | Merged openstack/nova master: hardware: Reject requests for no hyperthreads on hosts with HT https://review.opendev.org/744021 | |
| 14:29:23 | bauzas | lyarwood: ack, will look | |
| 14:31:03 | openstackgerrit | Alexandre Arents proposed openstack/nova master: Add a lock to prevent race during detach/attach of interface https://review.opendev.org/747957 | |
| 14:36:04 | lyarwood | bauzas: thanks :) | |
| 14:39:32 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add type hints to 'nova.virt.libvirt.utils' https://review.opendev.org/742865 | |
| 14:39:33 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934 | |
| 14:44:56 | stephenfin | gibi: Turns out a more granular mocking of migrate_disk_and_power_off is quite the bit of work. Have pushed up all the other fixes. Will keep working on that to get full coverage | |
| 14:50:00 | gmann | sean-k-mooney: noonedeadpunk: RE on policy for flavor ephemeral storage control. we can add policy rule for that and allow everyone by default so that we do not break existing usage but my concern is, if restricted by policy then it will control all request not specific to host or storage, is that fine? | |
| 14:50:22 | bauzas | stephenfin: https://review.opendev.org/#/c/744958/7 and https://review.opendev.org/#/c/741995/10 look the same, I guess it's PEBKAC ? | |
| 14:50:25 | sean-k-mooney | gmann: flavor creation is admin only by default | |
| 14:50:47 | sean-k-mooney | gmann: so the new policy would also have to be the same | |
| 14:50:57 | gmann | sean-k-mooney: ah yeah with current default. | |
| 14:51:09 | openstackgerrit | Lucian Petrut proposed openstack/nova master: Avoid invalid file name, preventing git clone on win32 https://review.opendev.org/748250 | |
| 14:51:23 | bauzas | stephenfin: wow https://review.opendev.org/#/q/owner:stephenfin%2540redhat.com+status:open | |
| 14:51:27 | bauzas | do you sleep overnight? | |
| 14:51:32 | sean-k-mooney | gmann: can we make default dynamic | |
| 14:51:37 | gmann | sean-k-mooney: but i was reading chat, is noonedeadpunk use case for specific host to control such VM creation? | |
| 14:51:45 | sean-k-mooney | gmann: e.g. default it to whatever teh current flavor create policy is | |
| 14:51:47 | gmann | sean-k-mooney: dynamic? | |
| 14:51:57 | gmann | sean-k-mooney: yeah, we can do that | |
| 14:52:04 | sean-k-mooney | gmann: no i dont think so | |
| 14:52:26 | sean-k-mooney | gmann: i think noonedeadpunk wanted to restrct who could create flavors with local storage | |
| 14:52:46 | sean-k-mooney | there are ways to prevent host from booting gues with local sotrage alredy | |
| 14:52:48 | lpetrut | hi, looks like we have an unusual issue on Windows: https://review.opendev.org/#/c/748250/ a release note filename containing pipes prevents Nova from being cloned on Windows :) | |
| 14:52:59 | gmann | sean-k-mooney: i see | |
| 14:53:11 | sean-k-mooney | gmann: either via config or using a trait and isolated aggreates feature | |
| 14:53:21 | noonedeadpunk | to be exact, I wanted to restrict users who can create VMs with ephemeral storages | |
| 14:53:26 | gmann | ok | |
| 14:53:37 | sean-k-mooney | noonedeadpunk: that is slightly different then | |