| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-08-18 | |||
| 21:45:50 | iurygregory | or nope? | |
| 21:45:55 | sean-k-mooney | its updating them after it creates the instance | |
| 21:46:17 | sean-k-mooney | https://review.opendev.org/#/c/741445/23/ironic_tempest_plugin/tests/scenario/baremetal_manager.py@190 | |
| 21:46:23 | sean-k-mooney | https://review.opendev.org/#/c/741445/23/ironic_tempest_plugin/tests/scenario/baremetal_manager.py@197 | |
| 21:46:32 | sean-k-mooney | the node is not update until 205 | |
| 21:47:10 | sean-k-mooney | so you need to do it before creating the nova instance | |
| 21:47:17 | sean-k-mooney | so move it to 183 | |
| 21:47:20 | iurygregory | wow | |
| 21:48:19 | sean-k-mooney | am i reading that right | |
| 21:48:58 | iurygregory | this would be strange | |
| 21:49:11 | iurygregory | since nova is doing the things with the ironic virt driver | |
| 21:49:41 | iurygregory | the node is only ready on line 228 | |
| 21:49:41 | sean-k-mooney | how do you mean | |
| 21:50:18 | iurygregory | when nova is enable it uses the nova.virt.ironic https://opendev.org/openstack/nova/src/branch/master/nova/virt/ironic/ | |
| 21:50:24 | sean-k-mooney | well right now everything that happens after 200 | |
| 21:50:36 | sean-k-mooney | is waiting for ironcit to finish proviioning the servier | |
| 21:50:46 | sean-k-mooney | but you need to add the cabpiltiy before calling nova | |
| 21:51:24 | iurygregory | hummm | |
| 21:51:27 | sean-k-mooney | so the cap need to be set on one of the hosts before nova tries to find a node using the flavor | |
| 21:52:04 | iurygregory | so if I set on devstack/lib/ironic to grab one node and set it will work | |
| 21:52:20 | sean-k-mooney | this test also cant run in parallel with other tests since its cahanging capablities | |
| 21:52:56 | sean-k-mooney | sure it proably will work | |
| 21:53:39 | sean-k-mooney | to test both case in 1 job you would need two ironic compute nodes | |
| 21:53:54 | sean-k-mooney | then hard code one to each boot mode | |
| 21:55:09 | iurygregory | yeah | |
| 21:55:14 | iurygregory | tks for the help sean-k-mooney =) | |
| #openstack-nova - 2020-08-19 | |||
| 06:00:49 | openstackgerrit | Mamduh proposed openstack/os-vif master: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/746836 | |
| 06:07:57 | openstackgerrit | Mamduh proposed openstack/os-vif master: Refactor code of linux_net to more cleaner and increase performace https://review.opendev.org/746673 | |
| 06:24:59 | openstackgerrit | Mamduh proposed openstack/os-vif master: Fix - os-vif fails to get the correct UpLink Representor https://review.opendev.org/745895 | |
| 08:11:40 | lyarwood | gmann: with the switch to focal, are we dropping support for bionic? | |
| 08:35:35 | stephenfin | lyarwood++ Ta for reviewing those six patches by the way. I'm sure Takashi-san appreciates :) | |
| 08:35:39 | stephenfin | *the reviews | |
| 08:59:29 | lyarwood | stephenfin: np | |
| 09:56:16 | openstackgerrit | Stephen Finucane proposed openstack/os-vif master: mypy: Add type annotations https://review.opendev.org/745162 | |
| 09:56:17 | openstackgerrit | Stephen Finucane proposed openstack/os-vif master: mypy: Extend type annotations to 'vif_plug_noop' https://review.opendev.org/745163 | |
| 09:56:18 | openstackgerrit | Stephen Finucane proposed openstack/os-vif master: windows: Add missing return https://review.opendev.org/746870 | |
| 10:05:55 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Log exception when unable to import rbd https://review.opendev.org/746873 | |
| 10:08:55 | stephenfin | lyarwood: https://review.opendev.org/#/c/734734/ might be of interest | |
| 10:19:15 | lyarwood | stephenfin: reviewed, issue with the test but agree with blocking that in the API | |
| 10:33:13 | lyarwood | stephenfin: https://review.opendev.org/#/c/574301/ - Can you take a look at my notes/question in this, tl;dr we end up relying on [libvirt] specific configurables within nova.image.glance *if* the default ceph config doesn't provide access to the RBD pool hosting glance images. | |
| 10:33:53 | lyarwood | stephenfin: I'm fine addressing that in FUPs in the future by introducing [glance] specific configurables for this | |
| 10:34:03 | stephenfin | sure | |
| 10:34:11 | lyarwood | stephenfin: but wanted other cores to agree with that approach before merging this | |
| 10:34:21 | lyarwood | stephenfin: kk thanks | |
| 10:36:36 | lyarwood | ah right cinder volumes | |
| 10:38:48 | openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM zuul: Enable [glance]/allowed_direct_url_schemes within nova-ceph-multistore https://review.opendev.org/743220 | |
| 10:47:47 | stephenfin | lyarwood: yup, agreed with not using libvirt-specific stuff in a generic place. Left my comments on the patch | |
| 11:12:47 | sean-k-mooney | stephenfin: wehn you write c/c++ do you put the { on a new line after the funtion signiture followed by another new line before starting the body | |
| 11:13:34 | stephenfin | Python isn't C | |
| 11:13:43 | stephenfin | and I haven't written a lot of C in quite some time :( | |
| 11:15:27 | sean-k-mooney | i know but you are formating things like peopel that do that. i have all been in the void myfunc(int arg) { camp or "auto myfunc(int arg) -> void {" where the code base is following almost always auto | |
| 11:15:43 | tosky | sean-k-mooney: if you change existing code, follow that style; there are different styles around | |
| 11:16:16 | sean-k-mooney | tosky: yes i do | |
| 11:16:20 | tosky | tl;dr there is no correct answer :) | |
| 11:16:49 | sean-k-mooney | well stephenfin is pushing to change the styple of every function in os-vif to a new one which i dislike | |
| 11:16:55 | sean-k-mooney | but im still thinking about it | |
| 11:17:14 | sean-k-mooney | it just reminds me of a c codeing style i always hateded | |
| 11:17:51 | stephenfin | I'll win you over eventually :P | |
| 11:17:56 | sean-k-mooney | i was just wondering if that was the style stephenfin was familar with | |
| 11:18:04 | stephenfin | In other news, I got the live migration with SR-IOV test working \o/ | |
| 11:18:05 | sean-k-mooney | which woudl explain his perfernce | |
| 11:18:14 | sean-k-mooney | stephenfin: awsome | |
| 11:18:36 | sean-k-mooney | i tought we had some limited functional test before but maybe that was numa | |
| 11:18:46 | stephenfin | NUMA, yeah | |
| 11:18:51 | stephenfin | artom wrote them | |
| 11:18:59 | sean-k-mooney | cool | |
| 11:19:05 | stephenfin | but no other live migration in nova.tests.functional.libvirt | |
| 11:19:32 | sean-k-mooney | ya there were a few gaps which i guess you have not finished | |
| 11:19:51 | sean-k-mooney | in the neutron fixture as well as pci code? | |
| 11:20:20 | stephenfin | the gaps were in mocking | |
| 11:20:21 | sean-k-mooney | althoguh i think we more or less had covered the pci stuff with numa | |
| 11:20:25 | sean-k-mooney | yes | |
| 11:20:30 | sean-k-mooney | that is what i ment | |
| 11:20:32 | stephenfin | with the neutron fixture mostly, yeah | |
| 11:20:41 | stephenfin | we had no SR-IOV with neutron coverage | |
| 11:20:46 | sean-k-mooney | correct | |
| 11:20:59 | sean-k-mooney | that is why i did not add the functional tests in the first plance | |
| 11:21:27 | sean-k-mooney | it was trying to get it laned befor m3 and it then got pushed to early train | |
| 11:21:56 | sean-k-mooney | anyway got a link i can review | |
| 11:24:57 | stephenfin | just touching up the last few bits, making sure stuff passes | |
| 11:25:45 | sean-k-mooney | we dont have a good way to simultate different config right i know i did an example that everyone hated | |
| 11:26:01 | sean-k-mooney | but can we easily simulate different hardware toplogies on idfferent nodes | |
| 11:26:13 | sean-k-mooney | we would just need different pci info objects right | |
| 11:26:22 | stephenfin | yup, exactly | |
| 11:27:46 | sean-k-mooney | i was wondering how easy it would be to create a repoducer for https://review.opendev.org/#/c/738432/3 | |
| 11:29:00 | sean-k-mooney | i feel like it will be a little tricky as i dont think we mock the eth device lookup but it also might be simipale if that all i have to mock | |
| 11:29:30 | sean-k-mooney | we just need the netdev names to be different on each host which i think we can do with mocks | |
| 11:30:11 | stephenfin | that's the main reason for doing these tests | |
| 11:30:22 | stephenfin | I haven't got a test case for that yet though | |
| 11:30:25 | stephenfin | baby steps and all that | |
| 11:30:52 | sean-k-mooney | i know how that bug happens i repoduced it on my local setup and the v1 patch fixed it | |
| 11:30:59 | sean-k-mooney | i should proably test v3 | |
| 12:09:49 | openstackgerrit | Merged openstack/os-vif master: update tox envs and support pdf docs https://review.opendev.org/728037 | |
| 12:21:52 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | |
| 12:21:52 | openstackgerrit | Lee Yarwood proposed openstack/nova master: rbd: Move rbd_utils out of libvirt driver under nova.storage https://review.opendev.org/746904 | |
| 12:28:51 | stephenfin | lyarwood: I know you've started that already, but does this rbd direct download scheme make sense for other virt drivers? | |
| 12:29:05 | stephenfin | i.e. did you give thought to my suggestion on making this virt driver-configurable? | |
| 12:29:42 | stephenfin | sean-k-mooney: what's the expected behavior rn if you try to live migrate an instance with PCI devices attached? | |
| 12:30:01 | sean-k-mooney | via an alias | |
| 12:30:05 | stephenfin | yes | |