Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-08-15
07:46:23 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys https://review.opendev.org/727757
07:46:37 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte https://review.opendev.org/727777
07:46:54 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types https://review.opendev.org/728094
07:47:08 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.text_type (1/2) https://review.opendev.org/728109
07:47:45 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.text_type (2/2) https://review.opendev.org/728117
#openstack-nova - 2020-08-16
15:41:36 openstackgerrit Takashi Natsume proposed openstack/nova-specs master: Create specs directory for Wallaby https://review.opendev.org/746408
16:24:25 openstackgerrit Ghanshyam Mann proposed openstack/nova master: [goal] Migrate testing to ubuntu focal https://review.opendev.org/738126
#openstack-nova - 2020-08-17
00:55:29 brinzhang gibi_pto_24th, gmann, stephenfin, alex_xu, bauzas: I was update the runway slot, because some patches have reached the dealine in the slot
07:50:16 openstackgerrit Harshavardhan Metla proposed openstack/nova master: Raising a failure in case of 403 https://review.opendev.org/735068
09:12:35 lyarwood stephenfin: https://review.opendev.org/#/c/746210/ - would you mind hitting this today? simple fup from https://review.opendev.org/#/q/I7eb86edc130d186a66c04b229d46347ec5c0b625 as we all missed we are using < v4.1.0 in CI at the moment.
09:12:48 openstackgerrit Stephen Finucane proposed openstack/nova stable/ussuri: [Trivial] Remove wrong format_message() conversion https://review.opendev.org/746464
09:13:57 stephenfin sure
09:25:13 lyarwood stephenfin: are you rebasing the vtpm stuff today btw?
09:25:34 stephenfin yup, in the middle of that atm
09:25:38 lyarwood wonderful
09:30:58 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Add helpers for suspend, resume and reboot of server https://review.opendev.org/741285
09:30:59 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Pass context, instance to '_create_guest' https://review.opendev.org/741286
09:30:59 openstackgerrit Stephen Finucane proposed openstack/nova master: api: Reject non-spawn operations for vTPM https://review.opendev.org/741500
09:31:03 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Add emulated TPM support to Nova https://review.opendev.org/631363
09:31:03 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Add docs for vTPM support https://review.opendev.org/739213
09:31:04 openstackgerrit Stephen Finucane proposed openstack/nova master: Add type hints to 'nova.compute.manager' https://review.opendev.org/742863
09:31:05 openstackgerrit Stephen Finucane proposed openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/741995
09:31:05 openstackgerrit Stephen Finucane proposed openstack/nova master: privsep: Add support for recursive chown, move_tree operations https://review.opendev.org/742864
09:31:06 openstackgerrit Stephen Finucane proposed openstack/nova master: Add type hints to 'nova.virt.libvirt.utils' https://review.opendev.org/742865
09:31:09 openstackgerrit Stephen Finucane proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.opendev.org/639934
11:32:01 openstackgerrit Hao Sun proposed openstack/nova master: Add checks for volume status when rebuilding https://review.opendev.org/734734
11:41:55 lyarwood stephenfin: do you plan on blocking non-owner ops with vTPM instances in the API?
12:07:08 openstackgerrit Merged openstack/nova master: Remove dead volume driver code https://review.opendev.org/745393
13:33:08 lyarwood melwitt: https://review.opendev.org/#/c/746210/ - Morning, when you're online would you mind taking a look at this please?
14:20:29 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Mock LoopingCallBase._sleep in rbd tests https://review.opendev.org/745512
14:20:45 lyarwood stephenfin: ^ trivial one for you if you have bandwidth
14:22:28 stephenfin lyarwood: done
14:23:17 stephenfin as for your earlier question (sorry, missed it then), yeah, that probably makes sense. I assume all non-owner ops except delete, of course
14:29:45 lyarwood stephenfin: well any move ops really
14:30:02 lyarwood stephenfin: hard reboot as well thinking about it
14:32:30 gmann lyarwood: stephenfin can you check this, Focal migration patch is ready- https://review.opendev.org/#/c/738126/
14:36:24 openstackgerrit Merged openstack/nova stable/ussuri: [Trivial] Remove wrong format_message() conversion https://review.opendev.org/746464
14:36:39 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in baremetal nodes policies https://review.opendev.org/741716
14:36:52 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the actual target in baremetal nodes policy https://review.opendev.org/741717
14:40:32 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add scope and new default roles in extensions policies https://review.opendev.org/743046
14:42:47 lyarwood gmann: so what about that change moves us to focal? Wouldn't it be better to say that this is just bumping our reqs so we *can* move to focal in the future?
14:44:06 gmann lyarwood: with the depends-on in previous PS tested all devstack based jobs on focal to it also made sure everything worked fine here so whenever base jobs moves to Focal nova automatically start tested on Focal
14:47:36 lyarwood gmann: shouldn't we have a .DNM change on top of this to ensure it's still working?
14:48:02 lyarwood gmann: oh I see the PS now
14:48:16 gmann lyarwood: Patch Set 14 was that
14:48:43 gmann yeah, i am testing first and then removing the depensd-on to merge it before base job migrate and break the gate
14:48:49 lyarwood gmann: hmm but that had a depends-on of https://review.opendev.org/#/c/746327/ ?
14:49:00 lyarwood gmann: that doesn't seem right
14:49:17 lyarwood oh and that was the tip of the focal changes
14:49:22 gmann yeah
14:51:36 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in networks policies https://review.opendev.org/742566
14:52:22 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the actual target in networks policy https://review.opendev.org/742568
14:53:40 openstackgerrit Artom Lifshitz proposed openstack/nova stable/ussuri: func: Introduce a server_expected_state kwarg to InstanceHelperMixin._live_migrate https://review.opendev.org/746527
14:53:44 openstackgerrit Artom Lifshitz proposed openstack/nova stable/ussuri: Add regression test for bug 1879787 https://review.opendev.org/746528
14:53:44 openstackgerrit Artom Lifshitz proposed openstack/nova stable/ussuri: Handle Neutron errors in _post_live_migration() https://review.opendev.org/746529
14:53:44 openstack bug 1879787 in OpenStack Compute (nova) "post_live_migration does not handle Neutron errors" [Medium,Fix released] https://launchpad.net/bugs/1879787 - Assigned to Artom Lifshitz (notartom)
14:56:38 lyarwood gmann: some quick nits in the commit message otherwise it LGTM
14:57:16 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in FIP policies https://review.opendev.org/742030
14:58:04 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the actual target in FIP policy https://review.opendev.org/742570
14:59:20 gmann stephenfin: gibi_pto_24th I have rebased the policy pacthes due to conflict. please re-approve those. I have made them in series to avoid any future conflict. - https://review.opendev.org/#/q/topic:bp/policy-defaults-refresh-deprecated-apis+status:open
14:59:26 gmann lyarwood: thanks, checking
15:00:45 openstackgerrit Ghanshyam Mann proposed openstack/nova master: [goal] Prepare for job migration to Ubuntu Focal (20.04) https://review.opendev.org/738126
15:00:57 gmann lyarwood: ^^
15:03:17 melwitt lyarwood: ack will do
15:11:54 openstackgerrit Luyao Zhong proposed openstack/nova master: track error migrations in resource tracker https://review.opendev.org/745281
15:11:54 openstackgerrit Luyao Zhong proposed openstack/nova master: improve orphans tracking in resource tracker https://review.opendev.org/745282
15:14:17 openstackgerrit Luyao Zhong proposed openstack/nova master: improve orphans tracking in resource tracker https://review.opendev.org/745282
15:29:47 openstackgerrit Merged openstack/nova master: Remove monotonic usage https://review.opendev.org/725425
15:29:55 openstackgerrit Merged openstack/nova master: Rebase qcow2 images when unshelving an instance https://review.opendev.org/696084
15:31:35 prometheanfire any work nova side to support mock 4.0.2? https://review.opendev.org/712713
15:35:26 melwitt prometheanfire: I spent a lot of time on it, didn't get anywhere, got discouraged. working up the will to try again
15:37:03 prometheanfire fair
17:45:06 kegorov35 hey! my supervisor told me that this review https://review.opendev.org/#/c/742180/ should be merged. can you please merge it or explain to me why can't you merge it
17:56:04 kegorov35 #openstack-nova urgent question
17:58:52 prometheanfire kegorov35: better to ask for a review than a merge (a review allows the review to say no, a merge kinda expects a yes)
17:58:53 dansmith kegorov35: it can't be merged because it hasn't been reviewed, and definitely because it has no tests, and also because it claims there's a bug being fixed, with non referenced and no reproducer information
18:01:38 dansmith oh I see it's jammed in the subject, but still..
18:10:13 openstackgerrit Luigi Toscano proposed openstack/nova master: zuul: use the new barbican simple-crypto job https://review.opendev.org/746583
18:46:16 prometheanfire melwitt: for mock, my stance is that if nova is not gonna use the python builtin unittest.mock then it needs to update :|
18:49:05 melwitt prometheanfire: we want to and we can, but the snag is that the fixtures library we use (https://pypi.org/project/fixtures/) prefers the third-party mock library when it imports mock, and then it creates mocks using that library, and so when we "switch" to unittest.mock in some places, we end up with third-party mocks + unittest.mocks that don't know about each other and we can't "stop" a third-party mock embedded inside the fixtures
18:49:05 melwitt library without importing third-party mock
18:49:53 prometheanfire melwitt: understood, I wasn't knocking you at all :D
18:50:07 melwitt everything works fine if the third-party mock library is not installed in the venv at all but if it's present, fixtures prefers it and causes problems
18:50:41 melwitt I tried a bunch of workarounds and none worked, I ran out of ideas and I haven't been back yet to see if I could find some other way around
18:50:43 prometheanfire eww, uses launchpad :P
18:51:48 melwitt maybe if I did something like fixtures.<whatever>.mock.stopall() that might work
18:53:28 mriedem hack idea: monkey patch the 3rd party lib with the std lib if found
18:53:57 melwitt yesss mriedem
18:54:07 melwitt this is right up your alley
18:54:16 melwitt thanks. I will try that too
18:55:11 prometheanfire hmm, I don't see fixtures itself calling mock, so I guess it's in how nova calls fixtures?
18:56:17 mriedem my guess is it's this down in here https://github.com/testing-cabal/fixtures/blob/41774d58ed86b92dd60d727f00f1040f862c8ed1/fixtures/_fixtures/mockpatch.py#L22
18:56:46 melwitt mriedem: yup, that's exactly it
18:57:12 mriedem could probably also avoid using those fixtures, there are other ways of doing those
18:57:17 mriedem but their usage might be pervasive
18:57:26 melwitt yeah, fair
18:57:49 mriedem not sure how you _prevent_ their usage later without a hacking check
18:58:10 prometheanfire hmm, ya, guess I was looking at what pypi linked to (launchpad) and not testing-cabal's org
18:59:16 mriedem i remember quite a bit of this in nova which isn't using mock https://github.com/openstack/nova/blob/master/nova/test.py#L352 but _can_ be replaced with mock
18:59:36 mriedem and stuff like https://github.com/openstack/nova/blob/master/nova/test.py#L423 could be replaced to just be mock rather than fixtures

Earlier   Later