Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-08-05
21:31:13 smcginnis So then zuul playbooks would also need to be updated to use that profile.
21:31:16 sean-k-mooney just if you are using os-brick ?
21:31:28 smcginnis Yeah, so probably only applicable to compute nodes.
21:31:58 sean-k-mooney ya only compute nodes and if cinder is deployed
21:32:26 sean-k-mooney what you propose is probaly ok but just said i would ask since its not really a dep of nova
21:32:48 smcginnis Yeah, makes sense.
21:33:02 smcginnis I don't have time now, but I may be able to follow up later to make it better.
21:33:04 sean-k-mooney we are not really strick about listing the min dpes in bindeps
21:33:17 smcginnis It is a small package, so at least it's not pulling down the world for this.
21:33:24 sean-k-mooney ya
21:33:33 sean-k-mooney i would kind of prefer if we use profiles more
21:33:50 sean-k-mooney e.g. add a mysql and postgress profile
21:33:51 smcginnis That could speed things up overall if we did.
21:34:01 smcginnis I wonder how many places we would need to update playbooks now though. :/
21:34:29 sean-k-mooney we would need a way to pass info from the job in a declaritive way
21:35:17 sean-k-mooney if we used it more optimally where we have a profile for each of the configurable backend a project used and then listed the profiles that correstpond to the deployment we ar testing that would be nice but also a lot of work :)
21:36:11 smcginnis Yeah. Good idea though.
21:42:50 openstackgerrit Merged openstack/nova master: Removed the host FQDN from the exception message https://review.opendev.org/743950
22:53:54 openstackgerrit Merged openstack/nova master: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/743319
22:54:01 openstackgerrit Merged openstack/nova master: func: Add CinderFixture to _IntegratedTestBase https://review.opendev.org/743535
23:56:39 openstackgerrit Lee Yarwood proposed openstack/nova stable/ussuri: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/744162
#openstack-nova - 2020-08-06
00:04:14 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP zuul: nova-evacuate https://review.opendev.org/744883
03:20:27 openstackgerrit Tony Su proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460
05:54:57 brinzhang_ alex_xu: hi, do you know why this patch didnot run zuul +2? https://review.opendev.org/#/c/744280/
05:55:39 brinzhang_ is it due to the tag of Signed-off-by？
07:18:29 gibi brinzhang0: I don't think that Signed-off stops zuul.
07:20:49 brinzhang0 gibi: thanks. I dont know which stoped zuul to go :(
07:21:10 brinzhang0 gibi: Do you have time to check?
07:34:04 gibi brinzhang_: honestly I don't know where to look. I suggest to do a recheck, or even better fix the commit message according to stephenfin's comments and that will retrigger zuul
08:01:36 openstackgerrit Brin Zhang proposed openstack/nova master: [Trivial] Remove wrong format_message() conversion https://review.opendev.org/744280
08:02:42 brinzhang gibi: thanks, updated, and removed the singned-off-by, can you +2 for it?
08:03:25 gibi sure
08:04:29 brinzhang gibi: thanks ^^
08:04:59 gibi doen
08:05:00 gibi done
08:05:13 gibi I hope zuul will pick it up this time
08:06:27 brinzhang gibi: cool, looks the zuu can be run
08:07:32 brinzhang before I rechecked it, and it also in zuul +1 status, I guess because of the signed-of-by, but Iam not sure
08:54:31 openstackgerrit Stephen Finucane proposed openstack/nova master: Follow up for Ibf8dca4bd57b3bddb39955b53cc03564506f5754 https://review.opendev.org/745095
09:52:00 openstackgerrit Stephen Finucane proposed openstack/nova master: Don't unset Instance.old_flavor, new_flavor until necessary https://review.opendev.org/744958
10:00:55 kashyap stephenfin: I think you used the change ID in the commit summary because it is not yet merged?
10:01:24 stephenfin kashyap: No. I just wanted something to link back to the original patch for context
10:01:26 kashyap I personally find it strange to see such a large change ID as part of commit summary. How about "Follow-up for "Lookup nic feature by PCI address" patch
10:02:40 stephenfin I could, though the change ID allows you to click through to the original change
10:03:52 kashyap Yeah, I see the value; but recall: we also have to bear in mind the "guy working from the woods" w/ no internet connection :-) - all needed info present w/ no clicking required
10:05:33 kashyap I'd personally put it in the commit body. But I let you decide here.
10:19:37 sean-k-mooney stephenfin: they are on the same topic so at least in gerrit its easy to find
10:20:30 sean-k-mooney oh you are folding back in the funcion
10:20:36 sean-k-mooney ya makes sense
10:27:18 sean-k-mooney stephenfin: by the way you realise that mypy support ducktyping
10:27:50 stephenfin I do. What's the context?
10:28:09 sean-k-mooney your responce to melwitt about not using mypy in tests
10:28:22 sean-k-mooney so ducktyping would not be an issue
10:28:27 sean-k-mooney mock proably would be
10:28:46 stephenfin It would if the code expects a Instance object and we're passing a dict or a string
10:28:50 sean-k-mooney but if we create a local class and implement the same interface it would pass
10:28:52 stephenfin which we do in placement
10:28:54 stephenfin *places
10:29:11 stephenfin Possibly, but that would be so much work
10:29:20 sean-k-mooney i know
10:29:41 sean-k-mooney i just mean if the thing we pass ducktypes to the real thing it will pass
10:29:55 sean-k-mooney if it does not we proably should not be passing it now :)
10:30:37 sean-k-mooney im hoping we ill graduly stop passing incorrect types in tests
10:30:56 sean-k-mooney im not going to hold my breath but i can hope
10:33:15 openstackgerrit Merged openstack/nova master: Lookup nic feature by PCI address https://review.opendev.org/739131
10:33:27 sean-k-mooney :)
10:44:15 mlycka Hello, would anyone be kind enough to advise me on how one would go about getting a freeze exception for a spec?
10:46:00 gibi mlycka: what is the spec in question?
10:46:23 gibi mlycka: in general we will make decisions about spec freeze exception request on the today's nova meeting
10:46:29 mlycka gibi: https://review.opendev.org/#/c/702810/
10:46:55 mlycka I was told by a Mr. Yarwood to go ahead and ask for an exception
10:48:18 lyarwood \o ./me waves
10:48:31 sean-k-mooney mlycka: johnthetubaguy still had some concerns about why we are now taking a different approch then was previously apporved
10:48:58 gibi mlycka, lyarwood: does the sync - async problem was resolved in the spec?
10:50:25 mlycka gibi: I think the idea was to treat is as sync for now and see where that gets us. The spec allows for a change later on during implementation.
10:51:35 gibi mlycka: I will add it to the meeting agenda. but we would need johnthetubaguy and Groka to check your answers to their questions as now we have -1s on the patch
10:52:11 mlycka gibi: Right right, thank you. Should I contact them directly or are they likely to be present in the meeting?
10:52:38 lyarwood mlycka: well the os-server-external-events API that you're using is async so I don't see how this could ever be sync tbh
10:52:55 sean-k-mooney that api is not for enduser to invoke
10:53:01 sean-k-mooney its for other services
10:53:15 lyarwood and that's also a valid point that I missed
10:53:20 gibi mlycka: given that it is summer I don't think they will get back to the spec today or tomorrow
10:53:21 mlycka Yeah, I think a separate endpoint is probably the way to go.
10:53:43 sean-k-mooney mlycka: quiesing a vm shoudl be a server action
10:53:59 sean-k-mooney as would undoing it
10:54:08 sean-k-mooney like pause and unpause
10:54:24 mlycka sean-k-mooney: What do you mean? Yeah, it would have to be done by the VM.
10:54:42 sean-k-mooney https://docs.openstack.org/api-ref/compute/#servers-run-an-action-servers-action
10:55:13 sean-k-mooney i mean you should be extending /servers/{server_id}/action
10:57:05 mlycka Okay, that doesn't sound unreasonable. Any objections?
10:57:32 sean-k-mooney i object to you using the event api :) but other then that no :)
10:58:58 mlycka Sure, makes sense. I won't have the time change the spec today, but I should be able to get to it tomorrow
10:59:58 lyarwood mlycka: would you also be able to start posting code for this?
11:00:25 mlycka lyarwood: I mean, not tomorrow but yeah, by next week I could start producing code.
11:00:35 lyarwood kk
11:03:13 sean-k-mooney mlycka: by the way the fact you used the service only external events api is proably why peopel assume this is only for use with cinder
11:04:01 mlycka sean-k-mooney: Might be. I think I misunderstood the use of that endpoint when I first found out about it.
11:04:27 sean-k-mooney ya that is why we have the warning https://docs.openstack.org/api-ref/compute/?expanded=add-associate-floating-ip-addfloatingip-action-deprecated-detail#create-external-events-os-server-external-events
11:05:34 mlycka Yep yep, clearly a reading comprehension failure on my part.
11:21:43 openstackgerrit sean mooney proposed openstack/os-vif master: support pyroute2 0.5.13 https://review.opendev.org/744809

Earlier   Later