| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-08-03 | |||
| 08:04:45 | gibi | nightmare_unreal: after a quick glance. Did you mocked too many things there? e.g. you set the api version in the setUp and then mock the api_version.APIVersion in the test case | |
| 08:06:48 | nightmare_unreal | gibi yes , I was trying to mock api version . I am mocking 2 things the migration list methods and api_version methods. | |
| 08:07:40 | nightmare_unreal | if I don't provide @mock.patch , Then i get this error : ' TypeError: '<Mock name='mock.api_version' id='140452243441928'>' should be an instance of '<class 'novaclient.api_versions.APIVersion'>' | |
| 08:07:41 | gibi | I'm not at all familiar with the openstackclient unit tests but seems strange to set api version here https://review.opendev.org/#/c/742210/7/openstackclient/tests/unit/compute/v2/test_migration_list.py@65 and then mock it also here https://review.opendev.org/#/c/742210/7/openstackclient/tests/unit/compute/v2/test_migration_list.py@68 | |
| 08:08:24 | nightmare_unreal | true. | |
| 08:28:03 | nightmare_unreal | Solved gibi :) . Thanks | |
| 08:28:46 | gibi | cool ;0 | |
| 08:28:48 | gibi | ;) | |
| 08:32:56 | mlycka | Hullo | |
| 09:06:31 | lyarwood | Morning all | |
| 09:06:33 | lyarwood | gibi: welcome back | |
| 09:06:52 | lyarwood | is anyone working on the lower-constraints job failure on master? | |
| 09:07:40 | lyarwood | https://zuul.opendev.org/t/openstack/builds?job_name=openstack-tox-lower-constraints&project=openstack%2Fnova&branch=master | |
| 09:07:48 | lyarwood | if not I'll take a swing at it now | |
| 09:27:19 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/743319 | |
| 09:27:19 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP lower-constraints: Bump dogpile.cache to 1.0.1 and decorator to 4.0.0 https://review.opendev.org/744426 | |
| 09:41:05 | luyao | stephenfin: I replied your comments on https://review.opendev.org/#/c/714653/5, please let me know if you still have question about it. | |
| 09:41:59 | lyarwood | luyao: FYI stephenfin is out today | |
| 09:44:59 | kashyap | It's a holiday in Ireland, IIRC | |
| 09:47:02 | luyao | lyarwood: OK, thanks | |
| 10:16:22 | brinzhang_ | lyarwood: the CI report a bug of importError, see bug 1890064 | |
| 10:16:22 | openstack | bug 1890064 in OpenStack Compute (nova) "CI failture: ImportError: cannot import decorate" [High,In progress] https://launchpad.net/bugs/1890064 - Assigned to Brin Zhang (zhangbailin) | |
| 10:16:58 | brinzhang_ | lyarwood: I submit a patch, but is seems not right, pls review https://review.opendev.org/#/c/744385/ | |
| 10:26:32 | lyarwood | brinzhang_: yeah that's isn't right | |
| 10:26:45 | lyarwood | brinzhang_: https://review.opendev.org/#/c/744426/ - the issue is in lower-constraints | |
| 10:27:07 | lyarwood | brinzhang_: for some reason in the job we are pulling in a newer version of dogpile.cache | |
| 10:27:21 | lyarwood | brinzhang_: I couldn't reproduce it on Fedora, trying again on bionic now | |
| 10:30:45 | brinzhang_ | lyarwood: ok, left comment in the patch | |
| 10:43:01 | gibi | lyarwood: o/ | |
| 10:49:18 | lyarwood | does anyone know the version of setuptools used on our jobs? | |
| 10:49:31 | lyarwood | in the lower-constraint 18.04 based jobs | |
| 10:51:06 | lyarwood | with the distro provided 39.0.1-2 version lower-constraints fails on MarkupSafe==1.0 | |
| 10:52:34 | lyarwood | ah wait lower-constraints is pulling it in | |
| 10:55:40 | lyarwood | what a total shower | |
| 10:55:59 | lyarwood | so we can't reproduce these jobs on a freshly installed 18.04 because all of the workarounds in the image | |
| 10:56:02 | lyarwood | gah! | |
| 11:45:57 | openstackgerrit | Elod Illes proposed openstack/nova stable/pike: Fix os-simple-tenant-usage result order https://review.opendev.org/709600 | |
| 11:58:08 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Delete non tag related device metadata during detach https://review.opendev.org/741436 | |
| 12:40:38 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP lower-constraints: Update and address cyclic dependencies https://review.opendev.org/744426 | |
| 12:40:38 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP lower-constraints: Pin to python3.6 https://review.opendev.org/744458 | |
| 12:57:56 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP lower-constraints: Update and address cyclic dependencies https://review.opendev.org/744426 | |
| 12:57:58 | lyarwood | gibi: ^ if you have time btw, I need to drop for a few hours in ~30mins but will pick this back up this evening if it's still broken. | |
| 12:58:16 | gibi | lyarwood: thanks | |
| 12:58:21 | gibi | I will try to look | |
| 13:01:44 | gibi | lyarwood: is there a way to reproduce the dependency problem locally? | |
| 13:02:47 | lyarwood | gibi: tox -e lower-constraints --notests | |
| 13:02:53 | gibi | ack | |
| 13:02:54 | gibi | thanks | |
| 13:03:11 | lyarwood | gibi: ^ but even then I had to update lower-contraints.txt for it to even build that env for me locally | |
| 13:03:29 | lyarwood | gibi: to use MarkupSafe==1.1.0 | |
| 13:03:55 | lyarwood | gibi: as somthing here is pulling in the latest version of setuptools | |
| 13:05:14 | gibi | I do not promise to get to it but it sounds juicy | |
| 13:07:10 | lyarwood | gibi: yup cool no issues, I'll work on it this evening either way | |
| 13:37:24 | openstackgerrit | Kevin Zhao proposed openstack/nova master: [WIP] CI: add tempest-integrated-compute-aarch64 job https://review.opendev.org/714439 | |
| 14:01:32 | smcginnis | lyarwood: Responded on the ML, but I'd hold off on playing whack a mole with packages. The job itself appears to be broken somehow. | |
| 14:02:14 | smcginnis | lyarwood: Would be interesting to know what version you have locally if you are able to reproduce this (.tox/lower-constraints/bin/pip --version) | |
| 14:08:07 | smcginnis | Unable to repro on f32. Tried upgrading to latest pip in my env, but it still installs the correctly constrained versions. | |
| 14:35:08 | openstackgerrit | Bence Romsics proposed openstack/nova master: doc: Add IPv6 metadata address https://review.opendev.org/744492 | |
| 15:09:48 | openstackgerrit | Sean McGinnis proposed openstack/nova master: Fix lower-constraints conflicts https://review.opendev.org/744506 | |
| 15:11:30 | mnaser | dansmith: i'd appreciate your feedback when you're free on this fun one -- https://bugs.launchpad.net/nova/+bug/1890057 | |
| 15:11:30 | openstack | Launchpad bug 1890057 in OpenStack Compute (nova) "EC2 instance_id_mappings are never deleted" [Undecided,New] | |
| 15:17:31 | melwitt | mnaser: that should have been fixed in stein https://bugzilla.redhat.com/show_bug.cgi?id=1726256#c22 | |
| 15:17:31 | openstack | bugzilla.redhat.com bug 1726256 in openstack-nova "nova-manage archive_deleted_rows doesn't cleanup nova_cell0.instance_id_mappings, nova_api.request_specs, nova_api.consumers, nova_api.instance_mappings, nova.instance_id_mappings and nova.task_log" [High,Closed: errata] - Assigned to mwitt | |
| 15:18:49 | mnaser | melwitt: oooou | |
| 15:19:25 | mnaser | i will mark as duplicate in that case | |
| 15:19:37 | mnaser | i wonder how i miss that | |
| 15:19:55 | mnaser | i tried to search but didn't see much matches for `InstanceIdMapping` but i think i was trying to look for an ec2_* function | |
| 15:20:24 | melwitt | I dunno, you commented on the duplicate too heh https://bugs.launchpad.net/nova/+bug/1786298 | |
| 15:20:24 | openstack | Launchpad bug 1786298 in OpenStack Compute (nova) rocky "nova-manage db archive_deleted_rows does not cleanup table instance_id_mappings" [Medium,Fix committed] - Assigned to Matt Riedemann (mriedem) | |
| 15:20:40 | mnaser | wtf, really | |
| 15:20:54 | mnaser | wow | |
| 15:20:55 | mnaser | i did | |
| 15:21:08 | mnaser | old me did a good thing | |
| 15:21:22 | melwitt | haha | |
| 15:22:02 | mnaser | melwitt: marked as duplicate, that's my bad. i did a whole bunch of db trimming for an upcoming upgrade | |
| 15:22:22 | mnaser | went from 70G database down to 6GB.. we have very bad reasons why our shadow tables are still big that i won't admit yet | |
| 15:22:23 | melwitt | thanks! | |
| 16:23:53 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: [WIP] Support SRIOV interface attach and detach https://review.opendev.org/740995 | |
| 16:23:53 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Move equality check into LibvirtConfigGuestInterface https://review.opendev.org/744524 | |
| 16:52:53 | elod | lyarwood smcginnis : maybe this is related to the lower-constraints issue you are investigating: http://eavesdrop.openstack.org/irclogs/%23openstack-infra/%23openstack-infra.2020-08-03.log.html#t2020-08-03T16:34:00 | |
| 16:57:07 | smcginnis | elod: Yeah, I'm seeing that on a Cinder failure too. | |
| 16:57:24 | smcginnis | That may be it. Like mentioned in that log, might need to add a --no-deps to that step. | |
| 17:11:24 | elod | smcginnis: probably yes. however I'm still trying to reproduce that locally, but locally I have just one phase (?) | |
| 18:09:13 | smcginnis | elod: Yeah, I'm not sure where that multiple phase things comes from. | |
| 18:09:32 | smcginnis | elod: The main log makes it look like it's just called tox --notest to set up the venv, then running the tests. | |
| 18:09:48 | smcginnis | elod: So it must be somewhere in the zuul job configuration that it does some extra steps. | |
| 18:12:56 | openstackgerrit | Sean McGinnis proposed openstack/nova master: Fix lower-constraints conflicts https://review.opendev.org/744506 | |
| 19:41:45 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/743319 | |
| 19:41:46 | openstackgerrit | Lee Yarwood proposed openstack/nova master: func: Add CinderFixture to _IntegratedTestBase https://review.opendev.org/743535 | |
| 19:41:46 | openstackgerrit | Lee Yarwood proposed openstack/nova master: func: Introduce a server_expected_state kwarg to InstanceHelperMixin._live_migrate https://review.opendev.org/743710 | |
| 19:41:49 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug 1879787 https://review.opendev.org/741230 | |
| 19:41:49 | openstack | bug 1879787 in OpenStack Compute (nova) "post_live_migration does not handle Neutron errors" [Medium,In progress] https://launchpad.net/bugs/1879787 - Assigned to Artom Lifshitz (notartom) | |
| 19:41:49 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Handle Neutron errors in _post_live_migration() https://review.opendev.org/729763 | |
| 20:08:31 | lyarwood | dansmith: https://bugs.launchpad.net/glance/+bug/1890193 - btw I've just seen nova-ceph-multistore fail again with this, it's the same issue as stephenfin pointed out last week. | |
| 20:08:31 | openstack | Launchpad bug 1890193 in Glance "nova-ceph-multistore fails with rbd.OSError: [errno 116] error removing image" [Undecided,New] | |
| 20:31:37 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: compute: Validate a BDMs disk_bus when provided https://review.opendev.org/744550 | |
| 20:47:23 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: compute: Validate a BDMs disk_bus when provided https://review.opendev.org/744552 | |
| 20:56:57 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: Should not skip volume_size check for bdm.image_id == image_ref case https://review.opendev.org/744553 | |
| 20:56:57 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/stein: compute: Validate a BDMs disk_bus when provided https://review.opendev.org/744554 | |
| 23:55:04 | openstackgerrit | Merged openstack/nova stable/queens: zuul: remove legacy-tempest-dsvm-neutron-dvr-multinode-full https://review.opendev.org/742668 | |