Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-07-30
16:18:27 jangutter sean-k-mooney: can we achieve full coverage with just unit tests? I'm almost leaning yeah.
16:18:49 sean-k-mooney we could
16:18:56 sean-k-mooney although that is not the goal
16:19:19 sean-k-mooney but i do want to more or less know what is and is not tested
16:19:49 sean-k-mooney 100% coverage is not need but if we are low in one module it would be good to look at why
16:22:15 jangutter I agree - full coverage might might just be for bragging rights (and can be done badly). My feeling is that unit testing should be slightly more than functional, but if we don't measure it we won't know it.
16:23:06 sean-k-mooney so are you ok with the coverage job just doing unit. i could add a second coverage-all that ran both
16:23:33 sean-k-mooney i would like to enable coverage by default when you run just tox
16:23:49 sean-k-mooney but if its runing the functional test i would prefer not to
16:24:08 sean-k-mooney basically i want you to be able to jsut git clone and then run "tox"
16:24:13 sean-k-mooney without args and have it work
16:24:27 jangutter Same for me: I tend to run just unit when I dev, but rely on the CI to run functional.
16:24:42 sean-k-mooney i run the fucnational test but not on my laptop
16:24:46 sean-k-mooney i do it in my devstack vms
16:25:00 sean-k-mooney so for small change i dont want to have to instlal ovs
16:25:58 openstackgerrit Sylvain Bauza proposed openstack/nova-specs master: Offline Reshape tool spec https://review.opendev.org/742908
16:26:08 jangutter I'm OK with adding more non-sudo stuff to the default tox run.
16:27:22 sean-k-mooney in os-vif the test are really fast so i was going to enable py3,pep8,docs,releasenotes,cover
16:27:38 sean-k-mooney by default
16:28:43 sean-k-mooney basically that is what i would like peple to run before pushing
16:29:01 jangutter I'm in agreement.
16:30:03 sean-k-mooney ok ill remvoe the functional test from cover so for now at least
16:30:41 sean-k-mooney stephenfin: jangutter ralonsoh as a head up i also want to change the default ovsdb backend in os-vif this cycle
16:30:54 sean-k-mooney i ment to do it af ew releases ago
16:31:02 sean-k-mooney but we are still defaulting to ovs-vsctl
16:31:18 ralonsoh sean-k-mooney, in os-vif?
16:31:32 sean-k-mooney ralonsoh: ya
16:31:36 ralonsoh we removed ovs-vsctl, we only have native now
16:31:51 sean-k-mooney no
16:31:56 ralonsoh in neutron
16:32:03 sean-k-mooney in neutron yes
16:32:08 ralonsoh just to let you know
16:32:13 sean-k-mooney we never got around to doing it in os-vif
16:32:22 sean-k-mooney it was planed for train
16:32:37 sean-k-mooney but we forot to defualt in trian and hten remove in ussui
16:32:45 ralonsoh it doesn't makes sense to keep both
16:32:54 sean-k-mooney so im going to push a patch to do it now in victoria and remove in W
16:32:59 ralonsoh cool
16:33:22 sean-k-mooney i would remove it now but we have to have a deprecation cycle
16:33:39 ralonsoh at least default to native, I think so
16:34:23 sean-k-mooney yep anyway ill push a patch for that shortly
16:34:40 sean-k-mooney just tought ye would like to know
16:42:30 sean-k-mooney is this pep failure new http://paste.openstack.org/show/796470/
16:42:37 sean-k-mooney *pep8
16:43:13 sean-k-mooney looks like py38 and pyflakes are unhappy
16:46:39 stephenfin sean-k-mooney: tox -e pep8 --recreate
16:46:46 stephenfin you're using an old version of the library, I suspect
16:46:53 stephenfin that or constraints isn't properly set up
16:47:06 sean-k-mooney i did recreate it
16:47:15 sean-k-mooney but i might need to rebase
16:47:39 sean-k-mooney oh this is the train branch
16:47:43 sean-k-mooney im backporting
16:47:55 sean-k-mooney it need python 3.6
16:48:03 sean-k-mooney on train not 3.8
16:49:05 gmann sean-k-mooney: for 3.8 you need pyflakes 2.1.1 as min
16:49:46 sean-k-mooney ya i just happened to use one of my 20.04 ubuntu vms to do the backport and i forgot it does not have a python old enough to run the train env
16:50:04 stephenfin Fedora has multiple Python versions...
16:50:06 sean-k-mooney i could update it to 2.1.1
16:50:09 openstackgerrit Harshavardhan Metla proposed openstack/nova master: Raising a failure in case of 403 https://review.opendev.org/735068
16:50:21 sean-k-mooney ubunutu normally does as well
16:50:27 sean-k-mooney i just did not want to instal older ones
17:14:37 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Add reproducer for bug #1889633 https://review.opendev.org/744020
17:14:37 openstack bug 1889633 in OpenStack Compute (nova) ussuri "Pinned instance with thread policy can consume VCPU" [High,Triaged] https://launchpad.net/bugs/1889633
17:14:37 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Reject requests for no hyperthreads on hosts with HT https://review.opendev.org/744021
17:14:40 stephenfin sean-k-mooney: ^
17:14:58 stephenfin Needs a unit test, I suspect. Will address tomorrow
17:15:00 stephenfin For now, run ti,me
17:45:08 openstackgerrit Harshavardhan Metla proposed openstack/nova master: Removed the host FQDN from the exception message https://review.opendev.org/743950
18:10:39 sean-k-mooney stephenfin: one suggestion inline and a request for a release note
18:11:03 sean-k-mooney stephenfin: but ya that should work, i think it can be slightly cleaner
18:13:26 sean-k-mooney are we ment to include a release not with every bug fix by the way
18:13:43 sean-k-mooney i forget if its all fixes or just some
18:14:16 sean-k-mooney i kind of feel like i shoudl ask for one but its also a 6 line patch so it also feels like over kill
18:14:18 sean-k-mooney https://review.opendev.org/#/c/743950/2
18:15:11 sean-k-mooney it is for a public security hardening bug however https://bugs.launchpad.net/nova/+bug/1851587 which is why i think operator might care to see it in a release note
18:15:11 openstack Launchpad bug 1851587 in OpenStack Compute (nova) "HypervisorUnavailable error leaks compute host fqdn to non-admin users" [Undecided,In progress] - Assigned to Harshavardhan Metla (harsha24)
18:28:00 openstackgerrit Harshavardhan Metla proposed openstack/nova master: Moved the quoted section https://review.opendev.org/737215
19:16:01 openstackgerrit Merged openstack/nova stable/ussuri: Handle multiple 'vcpusched' elements during live migrate https://review.opendev.org/743804
19:16:46 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: Handle multiple 'vcpusched' elements during live migrate https://review.opendev.org/743805
22:18:54 openstackgerrit sean mooney proposed openstack/nova master: Lookup nic feature by PCI address https://review.opendev.org/739131
22:49:31 openstackgerrit Ghanshyam Mann proposed openstack/os-vif master: [goal] migrate testing to ubuntu focal https://review.opendev.org/738130
23:16:14 openstackgerrit Merged openstack/nova master: libvirt: Remove blockjob.end == 0 workaround resolved in libvirt v2.3.0 https://review.opendev.org/729596
23:16:21 openstackgerrit Merged openstack/nova master: compute: Validate a BDMs disk_bus when provided https://review.opendev.org/724842
23:40:00 openstackgerrit Merged openstack/nova master: func: Add live migration rollback volume attachment tests https://review.opendev.org/743534
23:40:08 openstackgerrit Merged openstack/nova master: Add regression tests for bug #1889108 https://review.opendev.org/743289
23:40:08 openstack bug 1889108 in OpenStack Compute (nova) "failures during driver.pre_live_migration remove source attachments during rollback" [High,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood)
#openstack-nova - 2020-07-31
00:30:05 rambo_li If anyone can help me review the https://review.opendev.org/#/c/739349/, thank you very much!
02:38:44 openstackgerrit Merged openstack/nova stable/train: Handle multiple 'vcpusched' elements during live migrate https://review.opendev.org/743805
06:27:50 openstackgerrit Harshavardhan Metla proposed openstack/nova master: Raising a failure in case of 403 https://review.opendev.org/735068
06:36:28 openstackgerrit Harshavardhan Metla proposed openstack/nova master: Moved the quoted section https://review.opendev.org/737215
08:05:03 nightmare_unreal hello can someone leave their comment on this ticket. https://review.opendev.org/#/c/742210/ . Also suggestion on test cases
08:05:04 nightmare_unreal thanks
08:26:10 aarents good morning nova,
08:27:02 aarents lyarwood thanks for review! I fixed the nit on : https://review.opendev.org/#/c/696084/ and https://review.opendev.org/#/c/743708/ , I will be off next week, so I will be able to re-submit only after if needed.
10:00:06 openstackgerrit Harshavardhan Metla proposed openstack/nova master: Raising a failure in case of 403 https://review.opendev.org/735068
10:59:44 lyarwood aarents: ack I'll take a look today
11:20:35 songwenping_ bauzas: hi, i test create server with vgpu, and encounter error with "Verify all devices in group 71 are bound to vfio-<bus> or pci-stub and not already in use". Do you have any idea?
11:21:53 jsuchome lyarwood: hi, me again ... anything else we need for that rbd-download job? besides https://review.opendev.org/#/c/743220/
11:30:07 openstackgerrit Takashi Natsume proposed openstack/python-novaclient master: Remove unused code https://review.opendev.org/744136
12:03:29 lyarwood melwitt: thanks for the master reviews btw, https://review.opendev.org/#/c/743493/ is ready for stable/queens btw if you have time today.

Earlier   Later