| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-07-27 | |||
| 17:04:32 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove unused attributes https://review.opendev.org/743284 | |
| 17:04:33 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove warning filters for legacy Python version https://review.opendev.org/743285 | |
| 17:42:01 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug #1889108 https://review.opendev.org/743289 | |
| 17:42:01 | openstack | bug 1889108 in OpenStack Compute (nova) "failures during driver.pre_live_migration remove source attachments during rollback" [High,Confirmed] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood) | |
| 17:42:02 | lyarwood | ^ fun times. | |
| 17:52:44 | openstackgerrit | Merged openstack/nova master: Delete ARQs by UUID if Cyborg ARQ bind fails. https://review.opendev.org/716186 | |
| 19:15:11 | openstackgerrit | melanie witt proposed openstack/nova master: Change default num_retries for glance to 3 https://review.opendev.org/740389 | |
| 19:21:36 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Don't delete the original attachment during live migration rollback https://review.opendev.org/743319 | |
| 19:26:14 | lyarwood | ^ now with the correct change IDs | |
| 19:26:20 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Don't delete the original attachment during live migration rollback https://review.opendev.org/743319 | |
| 19:26:22 | lyarwood | ops ^ | |
| 19:26:37 | lyarwood | artom: ^ that's the fix for the earlier func test if you fancy taking a look | |
| 19:32:34 | artom | lyarwood, yep, thanks | |
| 19:32:44 | artom | Might help me understand the problem better (in detail) | |
| 19:32:58 | artom | That's kinda why I was asking for a more specific exception | |
| 19:50:54 | artom | lyarwood, reviewed, looks OK to me. | |
| 20:15:18 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Don't delete the original attachment during live migration rollback https://review.opendev.org/743319 | |
| 20:27:28 | openstackgerrit | sean mooney proposed openstack/os-vif master: update tox envs and support pdf docs https://review.opendev.org/728037 | |
| 20:31:41 | sean-k-mooney | /join #openstack-infra | |
| 22:15:29 | openstackgerrit | Alex Deiter proposed openstack/nova master: Detach is broken for multi-attached fs-based volumes https://review.opendev.org/741712 | |
| 22:49:21 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Don't age swap files in the image cache https://review.opendev.org/641093 | |
| 22:58:53 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove blockjob.end == 0 workaround resolved in libvirt v2.3.0 https://review.opendev.org/729596 | |
| 22:58:58 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Validate a BDMs disk_bus when provided https://review.opendev.org/724842 | |
| 23:11:37 | openstackgerrit | Merged openstack/nova stable/pike: Check cherry-pick hashes in pep8 tox target https://review.opendev.org/742212 | |
| 23:13:01 | openstackgerrit | sean mooney proposed openstack/nova master: Lookup nic feature by PCI address https://review.opendev.org/739131 | |
| #openstack-nova - 2020-07-28 | |||
| 01:26:37 | openstackgerrit | Brin Zhang proposed openstack/nova master: Optimize _create_and_bind_arqs logic in conducor https://review.opendev.org/726564 | |
| 02:48:35 | openstackgerrit | Tony Su proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341 | |
| 05:36:59 | openstackgerrit | Brin Zhang proposed openstack/nova master: Optimize _create_and_bind_arqs logic in conducor https://review.opendev.org/726564 | |
| 08:54:52 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add instance project_id for cyborg arq https://review.opendev.org/738428 | |
| 09:06:26 | awalender | Hi there, using ubuntu stein packages for OpenStack and recently we are having troubles with randomly aborting live-migrations with libvirt and qemu. Target hosts periodacly shows: Timed out during operation: cannot acquire state change lock (held by monitor=remoteDispatchDomainMigratePrepare3Params) | |
| 09:07:29 | awalender | Followed by: internal error: Missing monitor reply object.....afterwards libvirtd crashes with SEGV. Both hosts have same packages (libvirtd: 5.0.0-1). Anyone had similiar issues with this? | |
| 09:18:10 | openstackgerrit | Tony Su proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341 | |
| 09:19:07 | lyarwood | stephenfin: https://review.opendev.org/#/q/topic:bug/1889108 - would you mind taking a swing at this today? | |
| 09:21:04 | tony_su | stephenfin: alex_xu: I unified the exception message coding style, hopefully for readibiliy, and updated patch according to other comments. | |
| 09:29:21 | brinzhang_ | gibi, sean-k-mooney: did you see this patch https://review.opendev.org/#/c/7384? Adding project_id to the binding API, when server call _create_and_and_arq that we can verify user permissions, | |
| 09:30:13 | brinzhang_ | gibi, sean-k-mooney: we will introduce it to cyborg too, see https://review.opendev.org/#/c/738427/ | |
| 09:31:18 | brinzhang_ | if you are free, please review these patch, the cyborg patch depends-on the nova patch, otherwise the create_server test in cyborg cannot pass. | |
| 09:36:33 | stephenfin | brinzhang0: gibi is on PTO for the next two weeks | |
| 09:36:37 | stephenfin | just FYI | |
| 09:37:37 | brinzhang0 | stephenfin: thanks, got it~ | |
| 09:38:25 | brinzhang0 | stephenfin: hope you can review that patch too, it just add an field we request accelerator with boot instance | |
| 09:39:48 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug #1889108 https://review.opendev.org/743289 | |
| 09:39:48 | openstack | bug 1889108 in OpenStack Compute (nova) "failures during driver.pre_live_migration remove source attachments during rollback" [High,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood) | |
| 09:39:48 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Don't delete the original attachment during live migration rollback https://review.opendev.org/743319 | |
| 09:40:27 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: ironic: add instance_uuid before any other spawn activity https://review.opendev.org/743493 | |
| 09:50:20 | stephenfin | tony_su: Reviewed again :) Let me know if anything doesn't make sense | |
| 10:05:21 | sean-k-mooney | brinzhang0: let me take a look but you should not need to add project_id to the api itsself it will be valiable in the keystone atuth token so i need to see what you have acatully done | |
| 10:05:38 | sean-k-mooney | brinzhang_: ^ | |
| 10:07:40 | sean-k-mooney | brinzhang_: my initall feeling is that you should not really need the project id | |
| 10:13:27 | brinzhang_ | sean-k-mooney: Cyborg is about to introduce a new policy, I think this is needed. | |
| 10:13:47 | sean-k-mooney | brinzhang_: is cyborg currently using api microversions | |
| 10:13:48 | brinzhang_ | https://review.opendev.org/#/q/project:openstack/cyborg+branch:master+topic:policy-popup | |
| 10:14:07 | sean-k-mooney | because it need to continue to supprot old novas that dont send it | |
| 10:14:24 | sean-k-mooney | meaning they need to either do a major api verion bump and maintian both | |
| 10:14:34 | sean-k-mooney | or the need to add a microversions | |
| 10:14:54 | sean-k-mooney | or treat it as optional in someother way so that older novas can work with it | |
| 10:16:10 | brinzhang_ | Yes, this will change the cyborg api, we need a new microversion to support project_id in cyborg arq api | |
| 10:16:41 | sean-k-mooney | i dont see that in https://review.opendev.org/#/c/738427/2 | |
| 10:17:38 | sean-k-mooney | in factr i dont see any microversion code in cyborg | |
| 10:17:48 | sean-k-mooney | i have not looked very hard | |
| 10:17:58 | brinzhang_ | I will ask him to add microversion, we have introduced microversion in v2 API, this must be done. | |
| 10:19:42 | sean-k-mooney | it looks like it will be the first microversion https://github.com/openstack/cyborg/blob/369abe8dd06aa6648298c3256f444a63ee6268d0/cyborg/api/controllers/v2/api_version_request.py#L49 | |
| 10:20:12 | sean-k-mooney | is this the first api change since v2 | |
| 10:20:30 | brinzhang_ | I would like this patch can add the microversion too https://review.opendev.org/#/c/698190/ | |
| 10:20:47 | brinzhang_ | I am trying my best.. | |
| 10:21:11 | sean-k-mooney | brinzhang_: i know | |
| 10:21:21 | sean-k-mooney | brinzhang_: its not just your responsiblity | |
| 10:21:29 | sean-k-mooney | all cyborg cores shoudl be reviewing for this | |
| 10:21:34 | sean-k-mooney | even non cores | |
| 10:21:46 | brinzhang_ | sean-k-mooney: yes, thanks | |
| 10:21:59 | brinzhang_ | hope you can leave comment inline too | |
| 10:22:32 | brinzhang_ | In contrast, you have more experience in this area, which is worth learning from. | |
| 10:22:34 | stephenfin | lyarwood: Reviewed those, btw | |
| 10:22:47 | sean-k-mooney | yes i can i was hoping to point them to a patch that previously raised the microversion so that they had an example but since they are the first i guess i cant | |
| 10:23:39 | sean-k-mooney | well nova does i try to avoid making api change when i can. its a lot less work if you dont have to modify the api to implemente a feature | |
| 10:23:43 | sean-k-mooney | :) | |
| 10:24:05 | sean-k-mooney | ill leave a comment on both patches shortly | |
| 10:24:29 | brinzhang_ | sean-k-mooney: yeah, I can understand, but the current two patches inevitably need to modify the API. | |
| 10:25:14 | brinzhang_ | Thanks, so that I can ask again^^ | |
| 10:31:37 | sean-k-mooney | brinzhang_: basically we need to copy https://docs.openstack.org/nova/latest/contributor/microversions.html into the cyborg docs and do a find and replace | |
| 10:32:21 | sean-k-mooney | brinzhang_: gmann and alex_xu are two of the experts on api microversioning | |
| 10:32:44 | brinzhang_ | sean-k-mooney: thanks, I will review this, and do a copy later | |
| 10:33:24 | brinzhang_ | yeah, if I have some problem, Iill ask them for help | |
| 10:37:49 | lyarwood | stephenfin: ta | |
| 10:56:13 | stephenfin | sean-k-mooney: Left comments on https://review.opendev.org/#/c/739131/. I have those type hints worked out locally if you want me to push them somewhere? | |
| 10:59:01 | sean-k-mooney | oh i just fixed the ones you commented on before i proablyshould have checked all the types | |
| 10:59:24 | sean-k-mooney | on the styple nit putting each paramater on its onw line is something im happy to fight you over | |
| 10:59:35 | sean-k-mooney | i hate that more then anything else | |
| 11:00:39 | sean-k-mooney | wasting vertical space like that is deeply wrong in my view. | |
| 11:01:24 | sean-k-mooney | im assumeing that is what you want here https://review.opendev.org/#/c/739131/8/nova/virt/libvirt/driver.py@6894 | |
| 11:22:04 | stephenfin | sean-k-mooney: I think putting it on its own line helps visually group the function definition stuff neatly together. It also allows for maximum width wrt annotating the return type (which can often be quite lengthy, as you're seeing) | |
| 11:23:15 | sean-k-mooney | right but i think your thinking about type hints wrong | |
| 11:23:24 | sean-k-mooney | we should not in all cases fully qualify the type | |
| 11:23:38 | sean-k-mooney | that is not how they are ment to be used | |
| 11:23:40 | stephenfin | why ever not? | |
| 11:23:52 | sean-k-mooney | have you ever used c++ templates | |
| 11:24:10 | sean-k-mooney | and tried to fully quallify a template that multipel template args | |
| 11:24:38 | stephenfin | no, I've barely touched C++ | |
| 11:24:40 | sean-k-mooney | type hints are most useful when they specify the interface of the type you expect | |
| 11:24:57 | stephenfin | right | |