| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-07-27 | |||
| 08:16:55 | stephenfin | o/ | |
| 08:33:25 | kashyap | (Not that this kind of info be mentioned openly on a publicly logged channel. Where is my good sense...) | |
| 08:49:26 | openstackgerrit | Tony Su proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341 | |
| 08:49:45 | openstackgerrit | Luyao Zhong proposed openstack/nova master: vpmem enhancement for resource cleanup https://review.opendev.org/714653 | |
| 08:54:22 | tony_su | alex_xu: stephenfin: I updated the first patch for Provider Config File accordingly and answered all comments.. It would be grateful for you to spare some time to make a new round of review. Thanks. | |
| 08:54:55 | tony_su | I am going on the remaining patches ... | |
| 09:33:12 | stephenfin | tony_su: Hey o/ I've left a new review on that. Much better, but it still needs some work. Let me know if anything is unclear :) | |
| 09:57:16 | stephenfin | sean-k-mooney: did ye get to the bottom of the failing ceph-multistore job last week? | |
| 09:59:15 | stephenfin | lyarwood: Care to look at this again and possibly fast approve in gibi's absence (a trivial merge conflict resulted in loss of votes) https://review.opendev.org/#/c/742651/ | |
| 10:03:30 | brinzhang | stephenfin: there is a patch about nova-cyborg internaction, hope you can review https://review.opendev.org/#/c/716186/ | |
| 10:04:28 | brinzhang | stephenfin: gibi has +2 for that, and sean-k-mooney is one of the modifiers. | |
| 10:11:18 | stephenfin | brinzhang: I can try but realistically I know very little about Cyborg, so I don't know how much help I'll be. bauzas or similar might be a better shout | |
| 10:11:24 | lyarwood | stephenfin: ./me looks | |
| 10:12:55 | brinzhang | stephenfin: thanks, I will ask bauzas and dansmith give some help too. | |
| 10:14:06 | brinzhang | bauzas, dansmith: hope you can review the nova-cyborg interaction patch, and there is the cyborg operatcion support patch (evacuate, shelve/unshelve patch), thanks | |
| 10:16:21 | lyarwood | stephenfin: https://review.opendev.org/#/c/742961/ - re ceph-multistore, that's the fix. | |
| 10:25:34 | sean-k-mooney | stephenfin: yes we swapped to the bluestore backend and created a 10G backing file inside the normally backing file and were just running out of space | |
| 10:25:40 | stephenfin | lyarwood: thanks | |
| 10:26:22 | sean-k-mooney | stephenfin: so now we are setting the undocumented test only config option in ceph to set it to loopback device -4g | |
| 10:26:25 | sean-k-mooney | so 20G | |
| 10:26:32 | sean-k-mooney | that seam to solve the issue | |
| 10:27:24 | stephenfin | makes sense | |
| 10:27:25 | sean-k-mooney | brinzhang: ill review the cyborg patch again now | |
| 10:27:40 | lyarwood | sean-k-mooney: https://github.com/openstack/devstack/blob/e799770f59dfa81c78599bc4313503815b210b52/.zuul.yaml#L343 - any idea if we can move that into the ceph plugin .zuul.yaml? | |
| 10:28:26 | lyarwood | I'd like to add /etc/ceph/ to the list but adding it in devstack feels wrong | |
| 10:28:38 | sean-k-mooney | that is a good question i think i have done that before once sec | |
| 10:29:25 | sean-k-mooney | https://opendev.org/x/networking-ovs-dpdk/src/branch/master/.zuul.yaml#L27-L28 | |
| 10:29:33 | sean-k-mooney | so yes i think we can do it like this | |
| 10:29:58 | sean-k-mooney | so it could be moved to the base ceph job instead | |
| 10:30:16 | lyarwood | cool thanks | |
| 10:31:02 | brinzhang | sean-k-mooney: cool, thanks | |
| 10:31:25 | tosky | lyarwood: iirc zuul_copy_output is a dictionary so you can extend it, but it makes sense to add that to devstack-plugin-ceph jobs | |
| 10:32:04 | sean-k-mooney | tosky: right you can add more keys but not remove keys set by parent jobs | |
| 10:32:26 | lyarwood | ack cool I'll add it and remove it from the original with a depends-on now | |
| 11:12:40 | jsuchome | lyarwood: hi, once you have time, please take a look at https://review.opendev.org/#/c/574301/ again, it's rebased on top of recently merged change | |
| 11:34:52 | openstackgerrit | Lee Yarwood proposed openstack/nova master: nova-live-migration: Add encrypted volume to BFV evacuation test https://review.opendev.org/743067 | |
| 11:35:32 | lyarwood | jsuchome: ack will do | |
| 11:36:54 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742415 | |
| 11:46:30 | sean-k-mooney | brinzhang_: i thinik the current iteration of https://review.opendev.org/#/c/716186/17 is good | |
| 11:47:09 | sean-k-mooney | bauzas: dansmith can ye take a look if ye have time ^ | |
| 12:09:55 | openstackgerrit | Merged openstack/nova master: scheduler: Default request group to None https://review.opendev.org/742651 | |
| 12:12:24 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Further usage of new server helpers https://review.opendev.org/743204 | |
| 12:16:17 | bauzas | sean-k-mooney: ack, will try | |
| 12:16:24 | openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add type hints for 'nova.compute.api' https://review.opendev.org/741623 | |
| 12:16:25 | openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add 'nova.compute.API.migrate' https://review.opendev.org/741624 | |
| 12:16:25 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Duplicate '_test_resize' to '_test_migrate' https://review.opendev.org/743206 | |
| 12:16:26 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Remove unnecessary logic from resize, migrate tests https://review.opendev.org/743207 | |
| 12:16:26 | openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Split 'nova.compute.API._resize' https://review.opendev.org/743208 | |
| 12:22:27 | stephenfin | sean-k-mooney: did you see https://review.opendev.org/#/c/738432/ ? | |
| 12:22:37 | stephenfin | full disclosure: I haven't reviewed it yet | |
| 12:26:41 | bauzas | lyarwood: simple question : when we FFU, does the compute still has libvirtd running ? | |
| 12:26:48 | bauzas | when migrating ? | |
| 12:26:56 | bauzas | I don't think so tho | |
| 12:27:24 | lyarwood | bauzas: yeah if the compute is up then libvirtd is running | |
| 12:27:44 | bauzas | lyarwood: ahah, good to know for my offline reshape tool | |
| 12:27:54 | bauzas | so, say you want to upgrade from Stein | |
| 12:28:25 | bauzas | you need to FFU to Victoria, but then you will only have computes that are Stein | |
| 12:28:42 | bauzas | and then you need to upgrade directly before restarting the services | |
| 12:29:14 | bauzas | once you upgrade to Victoria, then you need to upgrade the DB by nova-manage | |
| 12:29:30 | lyarwood | bauzas: no, you upgrade through each release | |
| 12:29:30 | bauzas | and once you're done, then you restart all the compute services | |
| 12:29:40 | lyarwood | bauzas: for the db migrations | |
| 12:29:48 | bauzas | oh yeah of course you're right | |
| 12:29:58 | lyarwood | bauzas: the classic FFU approach is to stop all openstack services on S | |
| 12:30:05 | lyarwood | bauzas: roll through the db migrations to V | |
| 12:30:09 | bauzas | but during this time, do you have libvirtd running ? | |
| 12:30:10 | lyarwood | bauzas: bring the control plane up on V | |
| 12:30:15 | lyarwood | bauzas: and then computes on V | |
| 12:30:23 | bauzas | on computes | |
| 12:30:26 | lyarwood | bauzas: and yeah assuming there's no underlying host upgrade libvirtd will continue to run | |
| 12:30:59 | bauzas | lyarwood: okay, so, we *could* expect libvirtd to be around when we want to nova-manage a specific compute for reshapes | |
| 12:31:06 | bauzas | that's then acceptable | |
| 12:31:20 | sean-k-mooney | stephenfin: not yes no | |
| 12:31:25 | bauzas | if so, that's simplier | |
| 12:31:25 | lyarwood | bauzas: are you running nova-manage on the compute itself | |
| 12:31:36 | bauzas | lyarwood: I'm about to provide a new spec for it | |
| 12:31:41 | bauzas | for reshapes | |
| 12:32:03 | bauzas | lyarwood: anyway, I'll upload my new revision and you could review it | |
| 12:32:15 | lyarwood | bauzas: yeah happy to | |
| 12:35:05 | sean-k-mooney | * not yet | |
| 12:38:32 | lyarwood | jsuchome: the change LGTM now, did we talk about getting this tested somewhere in the gate previously? | |
| 12:38:54 | lyarwood | jsuchome: would you be able to wire it up in the ceph job? | |
| 12:39:07 | sean-k-mooney | stephenfin: im not sure how there patch and that bug are related | |
| 12:40:00 | sean-k-mooney | i need to check but i did not think we used the devname | |
| 12:40:15 | sean-k-mooney | we should be using just the pci address in nova | |
| 12:41:02 | openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Offline Reshape tool spec https://review.opendev.org/742908 | |
| 12:42:02 | jsuchome | lyarwood: I think that was that test job you created previously ... I lost the link | |
| 12:43:21 | jsuchome | lyarwood: I think this one https://review.opendev.org/#/c/727225/ ? | |
| 12:43:59 | sean-k-mooney | hum i guess we do use the device name | |
| 12:44:27 | jsuchome | lyarwood: for release nodes we have this I think https://review.opendev.org/#/c/728095/ ... | |
| 12:50:15 | lyarwood | jsuchome: yeah I wonder if we want to enable this all of the time in the ceph job? | |
| 12:51:11 | jsuchome | lyarwood: unfortunatelly I do not really know how this test infrustructure works ... I remember the job always failed but it does not seem to be related to the change | |
| 12:51:31 | lyarwood | jsuchome: k, let me just wire it up quickly | |
| 12:51:48 | lyarwood | jsuchome: ack on the other change having a releasenote for this | |
| 12:51:54 | lyarwood | jsuchome: as long as it's somewhere I'm okay | |
| 12:52:57 | jsuchome | you even commented back in May about the possible reason for the job failure (https://review.opendev.org/#/c/727225/) | |
| 12:54:51 | bauzas | lyarwood: the spec I raised to you https://review.opendev.org/742908 | |
| 12:55:01 | bauzas | (the offline reshape one) | |
| 12:56:44 | lyarwood | bauzas: ack thanks queued | |
| 12:59:56 | artom | What's the reverse of Depends-On again? | |