| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-07-15 | |||
| 17:38:02 | dansmith | basically, I will configure glance to auto-add a piece of metadata to images that get added, and then in post, just check that the cirros image has that metadata set, and if not, explode | |
| 17:38:17 | sean-k-mooney | so you can decied if a taks should mark the post playbook as a failure or not | |
| 17:38:39 | sean-k-mooney | dansmith: yep that should be failrly simple | |
| 17:38:43 | dansmith | yup | |
| 17:39:10 | sean-k-mooney | you are already doing most of it with your multistore job | |
| 17:39:20 | sean-k-mooney | in this case you need to enable the metadata plugin | |
| 17:39:35 | sean-k-mooney | then have a post job that just checks for it | |
| 17:39:37 | dansmith | yup | |
| 17:39:44 | dansmith | but I'm going to do it for glance jobs, not mine | |
| 17:39:51 | sean-k-mooney | sure | |
| 17:39:52 | dansmith | just because they're not testing any of that stuff right now, | |
| 17:40:05 | sean-k-mooney | it would be nice to do multi store for them too | |
| 17:40:08 | dansmith | and it requires config, not something tempest can do, so I want to example them towards actually testing that stuff :) | |
| 17:40:24 | dansmith | I think we're going to make the nova job global so they can run it too, right gmann ? | |
| 17:40:31 | gmann | if you do it via role the nova or other job can reuse that | |
| 17:40:35 | sean-k-mooney | dansmith: it already is | |
| 17:40:43 | sean-k-mooney | they just need to add it to there check pipeline | |
| 17:40:50 | sean-k-mooney | any repo can run any others jobs | |
| 17:40:52 | gmann | dansmith: right, even on devstack-plugin-ceph gate | |
| 17:40:57 | dansmith | sean-k-mooney: well, not yet because it's not landed | |
| 17:41:04 | dansmith | but yeah | |
| 17:41:09 | sean-k-mooney | dansmith: it can with depend on but ya | |
| 17:41:18 | dansmith | well, anyway :) | |
| 17:41:32 | sean-k-mooney | zuul is awsome that way | |
| 17:59:31 | openstackgerrit | Merged openstack/nova stable/queens: Add functional test for bug 1550919 https://review.opendev.org/732715 | |
| 17:59:31 | openstack | bug 1550919 in OpenStack Compute (nova) queens "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Elod Illes (elod-illes) | |
| 19:29:59 | openstackgerrit | Merged openstack/nova stable/queens: libvirt: Fix misleading debug msg "Instance is running" https://review.opendev.org/732716 | |
| 19:56:42 | artom | mordred, just wanted to bring your attention to https://review.opendev.org/#/c/741295/ and the corresponding story | |
| 19:59:56 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Reject boot request for unsupported images https://review.opendev.org/708609 | |
| 20:52:30 | openstackgerrit | Sean McGinnis proposed openstack/nova master: Use unittest.mock instead of third party mock https://review.opendev.org/714676 | |
| 21:59:11 | mordred | artom: awesome - lgtm - thanks! | |
| 22:09:15 | openstackgerrit | Merged openstack/nova master: virt: Add 'context', drop 'network_info' parameters for 'unrescue' https://review.opendev.org/730382 | |
| 22:27:20 | prometheanfire | it looks like it's just nova that fails with mock-4.0.2 https://review.opendev.org/741091 | |
| 22:35:00 | openstackgerrit | Merged openstack/nova master: crypto: Add type hints https://review.opendev.org/739207 | |
| 22:52:03 | melwitt | prometheanfire: will look | |
| 22:53:12 | melwitt | I wrote that test 😝 | |
| 22:57:47 | prometheanfire | :D | |
| #openstack-nova - 2020-07-16 | |||
| 00:42:37 | rouk | i cant seem to make nova-serialproxy work correctly past stein, on train it logs that its connecting to the backend, but my client gets punted. with "remote host closed connection: Connection is already closed" | |
| 00:43:13 | rouk | dont see any bugreports on it, and the logs are pretty silent, can anyone verify that it works for them on train? | |
| 01:02:44 | openstackgerrit | melanie witt proposed openstack/nova master: Use unittest.mock instead of mock in test_websocketproxy https://review.opendev.org/741351 | |
| 01:45:03 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.PY2 and six.PY3 https://review.opendev.org/726512 | |
| 01:45:26 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.add_metaclass https://review.opendev.org/726565 | |
| 01:45:37 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.reraise https://review.opendev.org/726898 | |
| 01:53:37 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224 | |
| 01:53:58 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys https://review.opendev.org/727757 | |
| 01:54:07 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte https://review.opendev.org/727777 | |
| 01:54:18 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types https://review.opendev.org/728094 | |
| 01:54:32 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.text_type (1/2) https://review.opendev.org/728109 | |
| 01:54:50 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.text_type (2/2) https://review.opendev.org/728117 | |
| 06:45:05 | gibi | jsuchome: will check | |
| 07:17:55 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936 | |
| 07:17:56 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: release note: add new features introduces by use-pcpu-and-vcpu-in-one-instance https://review.opendev.org/736997 | |
| 07:17:56 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: test: add some notes and new tests for mixed instance https://review.opendev.org/741395 | |
| 07:45:31 | openstackgerrit | Brin Zhang proposed openstack/nova-specs master: migrate testing to ubuntu focal https://review.opendev.org/740863 | |
| 08:39:54 | bauzas | good morning Nova | |
| 08:40:05 | bauzas | (after a few PTOs) | |
| 08:43:14 | aarents | good morning | |
| 08:44:29 | gibi | ||
| 08:44:34 | gibi | bauzas, aarents o/ | |
| 08:46:36 | huaqiang | gibi: morning | |
| 08:47:48 | huaqiang | can you review https://review.opendev.org/728480, stephen and alex mentioned that it's better to let you have a look. | |
| 08:48:26 | gibi | huaqiang: ack, I will check | |
| 08:48:36 | huaqiang | thanks! | |
| 08:54:39 | aarents | bauzas: FYI, I updated https://etherpad.opendev.org/p/nova-libvirt-subteam, I re-propose something to fix this bug: https://bugs.launchpad.net/nova/+bug/1732428 here: https://review.opendev.org/#/c/696084/3 I implemented rebase of backing file suggested by lyarwood kashyap | |
| 08:54:39 | openstack | Launchpad bug 1732428 in OpenStack Compute (nova) "Unshelving a VM breaks instance metadata when using qcow2 backed images" [Medium,In progress] - Assigned to Alexandre arents (aarents) | |
| 08:54:59 | kashyap | aarents: Hi | |
| 08:55:35 | bauzas | aarents: ack, will look | |
| 08:55:47 | aarents | kashyap: Hi | |
| 08:55:51 | aarents | bauzas: thks | |
| 08:55:58 | kashyap | Thx for the reminder; been buried w/ other stuff. WIll look | |
| 08:56:27 | aarents | kashyap: ok cool | |
| 08:57:00 | gibi | huaqiang: approved the patch | |
| 08:57:26 | huaqiang | gibi: cool, appreciate! | |
| 09:01:02 | gibi | huaqiang, stephenfin, alex_xu: extended the runway slot of bp/use-pcpu-and-vcpu-in-one-instance with an additional week as I see good progress there | |
| 09:03:24 | huaqiang | gibi: nice to hear this! | |
| 09:04:39 | gibi | nice to see the progress :) | |
| 09:42:50 | stephenfin | bauzas: I'm working on https://review.opendev.org/#/c/741282/ and noticed a potential bug in one of the vGPU functional tests | |
| 09:43:31 | bauzas | stephenfin: a-ha ? | |
| 09:43:41 | stephenfin | sec, getting the links | |
| 09:43:42 | bauzas | yeah, i tried to provide some methods for the func tests | |
| 09:43:54 | stephenfin | bauzas: very small one | |
| 09:44:08 | stephenfin | these tests use v2.1 + latest microversion https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L132-L137 | |
| 09:44:17 | stephenfin | these tests do not https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L300 | |
| 09:44:40 | stephenfin | both are inheriting from nova.tests.functional.test_servers.ServersTestBase https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L41 | |
| 09:44:49 | stephenfin | which uses API version 2 (.0) by default | |
| 09:45:03 | stephenfin | any reason those later tests shouldn't be using v2.1 + latest microversion too? | |
| 09:45:23 | stephenfin | you need the latest microversion so you can request a host https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L330 | |
| 09:45:30 | stephenfin | well, a reasonably new one | |
| 09:46:25 | bauzas | stephenfin: yeah, we need a specific microversion for at least one test AFAICU | |
| 09:47:27 | bauzas | stephenfin: at least for the resize tests : https://github.com/openstack/nova/commit/d2e0afc1f72db5cb56ed987e2873798fc1e89545 | |
| 09:49:01 | stephenfin | bauzas: okay, so I'm going to move this https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L134-L137 | |
| 09:49:14 | stephenfin | to the base class https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L42 | |
| 09:49:36 | stephenfin | doesn't sound like you wanted to use the legact API v2 for the VGPUMultipleTypesTests tests | |
| 09:50:40 | bauzas | stephenfin: I just wanted to provide some tests for vGPU by using the v2 API, but then when I wanted to provide the resize ones, it needed the microversion | |
| 09:50:58 | bauzas | stephenfin: so, no worries if you want to use the latest API for all of them, it should work | |
| 09:51:09 | stephenfin | okay, sweet. Thanks | |
| 09:52:34 | bauzas | the main issue I had with the tests was the fact that I needed to move some methods to the InstanceHelperMixin one | |
| 09:52:59 | stephenfin | You'll probably be interested in https://review.opendev.org/#/c/741283/1 so | |
| 09:53:12 | bauzas | stephenfin: hence the https://github.com/openstack/nova/blob/d2e0afc1f72db5cb56ed987e2873798fc1e89545/nova/tests/functional/integrated_helpers.py#L538 | |
| 09:53:45 | stephenfin | bauzas: You're *definitely* interested in the above so | |