| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-07-09 | |||
| 10:01:38 | openstackgerrit | XiaolinZhao proposed openstack/nova master: Add USB keyboard to support for MIPS architecture https://review.opendev.org/740213 | |
| 10:01:56 | bauzas | and who would say +1/-1 ? stable cores or master cores ? | |
| 10:02:16 | hrw | bauzas: in kolla we have just cores | |
| 10:02:17 | bauzas | either way, not saying I disagree, just it looks to me something we don't really *need* | |
| 10:02:21 | stephenfin | bauzas: I mean, if I was given a list of stuff to backport and promised reviews then I'd be happy to skim the backport candidate list occasionally | |
| 10:02:42 | stephenfin | and it's backport candidate - not actual backport - so normal cores | |
| 10:02:48 | stephenfin | though we could conceivably do both | |
| 10:03:13 | hrw | bauzas: as you have master and stable cores then I would say that master core suggests backport and stable core may accept/reject | |
| 10:03:24 | stephenfin | yeah, that ^ | |
| 10:03:37 | bauzas | okay I see, it's then just yet another process... | |
| 10:04:01 | bauzas | some people would use it, some not | |
| 10:04:07 | stephenfin | Yes and no. It's just another checkbox in the review dropdown | |
| 10:04:24 | stephenfin | Personally, everyone is using it in oslo land because it's really low friction | |
| 10:04:43 | stephenfin | Certainly less than going to Launchpad and setting metadata there (which I don't currently do because I didn't know I was supposed to) | |
| 10:05:02 | hrw | xiaolin: nice to see that some other arch follows aarch64 steps | |
| 10:06:15 | stephenfin | bauzas: If it means we remember to backport even a few more bugfixes then I think it's a good thing, personally | |
| 10:06:22 | stephenfin | lyarwood: Have you been looking at https://review.opendev.org/739349 ? | |
| 10:06:37 | bauzas | okay okay, let's discuss tonight anyway | |
| 10:06:46 | stephenfin | seems tangentially related to stuff you've been working on recently | |
| 10:09:21 | lyarwood | stephenfin: on my list | |
| 10:10:15 | xiaolin | hrw: thanks : ) We just started | |
| 10:11:51 | hrw | xiaolin: check https://review.opendev.org/#/c/538003/ as you need to add test cases | |
| 10:17:41 | xiaolin | hrw: Thanks :) I will add test cases | |
| 10:21:00 | hrw | xiaolin: it took some revisions before I got them right so prefer to point you at start | |
| 10:48:37 | xiaolin | hrw: Thanks so much | |
| 10:50:41 | xiaolin | hrw: do you have time to review https://review.opendev.org/#/c/740151/ | |
| 10:52:10 | hrw | sure | |
| 10:54:49 | hrw | xiaolin: you do not use pflash on mips? | |
| 10:55:05 | elod | lyarwood: thanks for the patch! \o/[4~ I've fast-approved it >>> https://review.opendev.org/#/c/739608/ | |
| 10:56:42 | hrw | xiaolin: done | |
| 10:56:55 | lyarwood | elod: awesome thanks :) | |
| 10:57:10 | xiaolin | hrw: our KVM only support rom now | |
| 10:57:15 | lyarwood | elod: https://review.opendev.org/#/c/740193/ should also fix stable/queens btw | |
| 10:59:07 | hrw | xiaolin: comment comment then | |
| 10:59:31 | elod | lyarwood: thanks! let's wait for Rocky patch to merge then I'll +2+W that too :) | |
| 10:59:50 | sean-k-mooney | lyarwood: what branches are teh migration test broken on | |
| 10:59:58 | sean-k-mooney | ah also rocky? | |
| 11:00:29 | sean-k-mooney | i notice many of the rechecks i kicked off for some of my backports failed yesterday on the live migration job | |
| 11:00:42 | sean-k-mooney | havent had time to look into it yet | |
| 11:01:32 | sean-k-mooney | ERROR] /tmp/devstack-plugin-ceph/devstack/lib/ceph:1029 Supported for Ubuntu Xenial, Bionic or Focal. Not supported for other releases. | |
| 11:01:38 | sean-k-mooney | thats what ye are fixing? | |
| 11:01:54 | lyarwood | yes | |
| 11:02:11 | lyarwood | just taken a while as there were other issues with the ceph plugin we had to fix first | |
| 11:02:16 | sean-k-mooney | cool ill recheck those after it merges so | |
| 11:02:26 | lyarwood | https://review.opendev.org/#/c/739694/ | |
| 11:02:44 | sean-k-mooney | are tehre any other issue i should be aware of for rocky and queens that i should wait for | |
| 11:03:00 | lyarwood | sean-k-mooney: rocky should be GREEN once that lands | |
| 11:03:10 | lyarwood | sean-k-mooney: and queens once https://review.opendev.org/#/c/740193/ lands | |
| 11:03:12 | lyarwood | AFAIK | |
| 11:03:42 | sean-k-mooney | ok i have a number of backport against rock and queens that im trying to get off my outgouing queue but i can wait another while | |
| 11:04:04 | lyarwood | yeah shouldn't be long now | |
| 11:04:11 | lyarwood | I also have a load of stuff I want to rebase once these land | |
| 11:04:49 | sean-k-mooney | oh will i need to rebase i can but then i have too update the commit ids in train which i can do but effort :P | |
| 11:05:10 | lyarwood | sean-k-mooney: and this is why I hate the cherry-pick lines ;) | |
| 11:05:25 | lyarwood | sean-k-mooney: and yes you need to rebase | |
| 11:05:29 | sean-k-mooney | hehe stephenfin aggrees with you | |
| 11:05:59 | stephenfin | self-inflicted pain | |
| 11:06:24 | lyarwood | yarp | |
| 11:06:28 | sean-k-mooney | i normally just avoid backporting acrooss more then one or two branches but its still less painful to do it upstream then downstream | |
| 11:06:54 | sean-k-mooney | if i do it donwstream i also have to clone the bug across multiple releases | |
| 11:10:20 | elod | actually i think the rebase is only needed if there's a merge conflict :-o | |
| 11:10:48 | elod | otherwise zuul takes care of it | |
| 11:11:11 | sean-k-mooney | elod: that is my understandign too | |
| 11:12:16 | sean-k-mooney | although sometiems we get weird behavior for example as with the new cherry-pick checker but normally the zuul speculative merge is suffiecent | |
| 11:12:22 | gibi | cores: can someone send this through? https://review.opendev.org/#/c/725163/ It would unblock the python-novaclient gate | |
| 11:13:06 | sean-k-mooney | and also get once step closer to no more legacy jobs | |
| 11:13:42 | elod | sean-k-mooney: the new cherry-pick checker had a problem if the patch's parent was not the HEAD of the branch, but that is fixed already (in ussuri and train, where the check is merged so far) | |
| 11:14:10 | sean-k-mooney | elod: yep i saw the discussion on the topic | |
| 11:14:34 | sean-k-mooney | downstream our branches are named differently so we are figuring out how to handel that | |
| 11:15:10 | elod | oh :S | |
| 11:15:20 | sean-k-mooney | i think we are going to trun it off and replace it with a different one | |
| 11:15:39 | sean-k-mooney | so that if we import change to the script it wont confliect with our downstream changes | |
| 11:16:05 | sean-k-mooney | lyarwood: did you propsoe a patch to do that by the way? | |
| 11:17:21 | sean-k-mooney | elod: right now it just another reason to do more backports upstream since they can actully merge :) | |
| 11:17:34 | sean-k-mooney | well pass pep8 | |
| 11:17:45 | elod | sean-k-mooney: that's at least a good thing ;) | |
| 11:18:03 | lyarwood | sean-k-mooney: yeah we disabled it downstream for now | |
| 11:18:13 | sean-k-mooney | cool | |
| 11:18:15 | lyarwood | https://review.gerrithub.io/c/redhat-openstack/octario/+/497097 | |
| 11:19:14 | sean-k-mooney | oh we just comment it out | |
| 11:19:20 | sean-k-mooney | that works | |
| 11:19:47 | sean-k-mooney | its not the most horrid thing we do to the tox.ini | |
| 11:22:47 | elod | then I just quietly advertise that the cherry-pick check script is backported to stein and waiting for review :X o:) | |
| 11:46:19 | sean-k-mooney | im not a functional progaming person normally but its nice whe a refactoring turns a function that previously required mocks to test into a pure function of its inputs | |
| 12:07:58 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.PY2 and six.PY3 https://review.opendev.org/726512 | |
| 12:08:12 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.add_metaclass https://review.opendev.org/726565 | |
| 12:08:25 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.reraise https://review.opendev.org/726898 | |
| 12:21:04 | gibi | stephenfin: I'm pretty close to +A https://review.opendev.org/#/c/714701/12/nova/virt/hardware.py@1956 but it would be nice to get a nod from you too | |
| 12:21:19 | stephenfin | looking | |
| 12:21:43 | sean-k-mooney | isnt that stephens pathc | |
| 12:22:17 | gibi | sean-k-mooney: the explanation is not from Stephen | |
| 12:22:23 | sean-k-mooney | ah | |
| 12:22:44 | sean-k-mooney | i was like the fact he wrote it proably means he thinks its correct | |
| 12:23:03 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224 | |
| 12:23:33 | stephenfin | gibi: Yeah, so numa_topology is set to None on line 1813 https://review.opendev.org/#/c/714701/12/nova/virt/hardware.py@a1813 | |
| 12:23:38 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys https://review.opendev.org/727757 | |
| 12:23:46 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte https://review.opendev.org/727777 | |
| 12:23:47 | stephenfin | and it's not set to anything else until it's returned on line 1915 | |
| 12:23:50 | stephenfin | in the old code, this is | |
| 12:23:54 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types https://review.opendev.org/728094 | |