| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-07-09 | |||
| 07:57:08 | gibi | huaqiang: is this in the middle of the series? | |
| 07:57:55 | huaqiang | gibi: do you mean https://review.opendev.org/739349 | |
| 07:58:23 | huaqiang | for https://review.opendev.org/739349, yes it is, it belongs to bp/mixed-instance | |
| 07:58:25 | gibi | I mean https://review.opendev.org/#/c/728480/ | |
| 07:58:58 | gibi | I can review https://review.opendev.org/#/c/728480/ but I reviewd the ancestors of that patch in the series already | |
| 07:59:04 | huaqiang | my mistake | |
| 07:59:24 | huaqiang | https://review.opendev.org/#/c/728480/ belongs to bp/mixed-instances | |
| 07:59:43 | huaqiang | Stephen suggests to have your review, | |
| 08:00:22 | huaqiang | let me check | |
| 08:07:36 | gibi | huaqiang: sure I will try to look deeper into the series. I have feedback in https://review.opendev.org/#/c/714701 | |
| 08:07:47 | gibi | and in https://review.opendev.org/#/c/714703 | |
| 08:08:08 | gibi | and also alex_xu has feedback in that series | |
| 08:10:38 | brinzhang0 | gibi: do you have time to review the nova-cyborg patch? https://review.opendev.org/#/c/716186/13 | |
| 08:11:02 | brinzhang0 | gibi: and the cyborg evacuate support patch https://review.opendev.org/#/c/715326/15 | |
| 08:11:59 | brinzhang0 | the cyborg shelve/unshelve support depends on these patch, and these pataches are already to review, thanks | |
| 08:15:32 | huaqiang | gibi: sorry about that, I missed your comments even I go through some of my abandoned changes. | |
| 08:15:49 | huaqiang | gibi: can you have a look again :) | |
| 08:16:09 | huaqiang | gibi: get your message, thanks | |
| 08:20:56 | openstackgerrit | Wenping Song proposed openstack/nova-specs master: Add no user token when get Cyborg client https://review.opendev.org/740184 | |
| 08:22:42 | openstackgerrit | Wenping Song proposed openstack/nova-specs master: Add no user token when get Cyborg client https://review.opendev.org/740184 | |
| 08:29:32 | gibi | brinzhang0: if the cyborg patches are ready then please add them to the runway queue. At the momement I will focus on the 3 series that is currently in the 3 slots. | |
| 08:29:55 | gibi | huaqiang: ack I will look | |
| 08:30:10 | brinzhang0 | gibi: ok, I will add these to the runway queue | |
| 08:31:25 | gibi | brinzhang0: thanks | |
| 08:31:37 | brinzhang0 | gibi: np | |
| 08:32:01 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: Fix os_CODENAME detection and repo refresh during ceph tests https://review.opendev.org/739608 | |
| 08:32:02 | gibi | brinzhang0: also summer vacation time will soon arrives. I will take 3 weeks of during july - august | |
| 08:32:13 | gibi | s/of/off/ | |
| 08:32:34 | gibi | I guess others from EU will do similar things | |
| 08:32:40 | brinzhang0 | gibi: have a holiday ^ | |
| 08:32:49 | gibi | thanks :) | |
| 08:34:56 | lyarwood | elod: https://review.opendev.org/#/c/739608/ should finally fix stable/rocky | |
| 08:44:04 | stephenfin | gibi, elod, lyarwood: Can raise on the team meeting, but what do we think about adding the Backport-Candidate flag to Gerrit like oslo has done? https://review.opendev.org/#/c/740068/ | |
| 08:46:44 | lyarwood | stephenfin: OOoOOOoO shiny | |
| 08:46:58 | lyarwood | stephenfin: +1 from me if we can query on that flag | |
| 08:47:15 | lyarwood | that we must be able to | |
| 08:47:33 | stephenfin | https://review.opendev.org/#/q/label:Backport-Candidate%253D%252B2 | |
| 08:47:34 | stephenfin | Yup | |
| 08:47:39 | stephenfin | (label:Backport-Candidate=+2) | |
| 08:48:37 | gibi | stephenfin: how does this relate to the way we target bugs to series in launchpad? | |
| 08:48:50 | gibi | will we do duble accounting? | |
| 08:48:53 | stephenfin | gibi: what do you mean? | |
| 08:49:24 | stephenfin | oh, as in setting the affected series for a reported bug in LP? | |
| 08:49:36 | gibi | in launchpad I can go to a bug and target it to multpile series (Ussurit, Train...) this way showing that the bugfix needs to be backported to those releases | |
| 08:50:04 | gibi | this also shows _where_ to backport | |
| 08:50:04 | stephenfin | that would sound like double accounting, yes. I guess we could either check both, or decide on which one we'd prefer | |
| 08:50:50 | stephenfin | iiuc we only do that launchpad tracking for some bugs, so we could use the backport-candidate feature for everything, and then be more specific in launchpad if necessary | |
| 08:53:33 | gibi | correct, there are non-bugs that we backport | |
| 08:53:50 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/queens: Fix os_CODENAME detection and repo refresh during ceph tests https://review.opendev.org/740193 | |
| 08:53:52 | gibi | and launchpad does not help there | |
| 08:54:38 | gibi | do you have a good working example for a patch that is backported but would be strange to track it with an LP bug? | |
| 08:55:37 | stephenfin | I wasn't even being that specific. I meant bug reporters often don't set target versions in Launchpad, and I don't tend to set them when reviewing bugfixes | |
| 08:56:30 | stephenfin | But the ability to say "this looks like a fix we probably want to backport" from Gerrit does sound like something I'd use, if only because it doesn't involve context switching | |
| 08:57:34 | stephenfin | so tl;dr: this feels like something we'd collectively use far more, if that makes sense? | |
| 09:01:10 | gibi | stephenfin: I see, so the benefit of the new solution is that the recording of the information is closer to the place where the information is created. That definitely helps | |
| 09:01:42 | stephenfin | Yeah, that's a better way of saying what I'm trying to say :) | |
| 09:02:01 | xiaolin | lyarwood: Do you have time to review https://review.opendev.org/#/c/740151/ , I don not know how to change the branch and proposed a new one against branch master | |
| 09:02:11 | gibi | we can use the gerrit flag, to force a discusson of the question "how far to be backported?" and then the answer can be recorded in LP by assigning series | |
| 09:02:55 | lyarwood | xiaolin: I'll take a look today yes | |
| 09:03:33 | gibi | I'm not against the new flag, I feel it has some cost of re-learning the gerrit interface due to the extra flag a the reply button, but I see the benefit of the flag | |
| 09:03:44 | xiaolin | lyarwood: thanks | |
| 09:10:11 | stephenfin | gibi: I'm already doing that for oslo so not a massive deal for me, personally :) | |
| 09:10:50 | gibi | yeah, I can adapt too :) | |
| 09:31:07 | elod | stephenfin: that could help, yes, it's easy to see if a patch should be backported, in that way | |
| 09:31:44 | elod | stephenfin: i usually check the bugreport as well if a patch was marked to be backported to certain branches, too | |
| 09:32:21 | elod | stephenfin: unfortunately most of the time that detail is not filled in | |
| 09:34:53 | elod | stephenfin: so maybe it's worth adding that option :) | |
| 09:38:40 | hrw | morning | |
| 09:38:57 | hrw | https://1d9789842ee1597bfc07-adfe1c2e7945e3f1ebfe34ebeb2d7062.ssl.cf2.rackcdn.com/739800/2/check/kayobe-overcloud-centos8/c7c8c01/primary/kolla/nova/nova-compute.txt shows new nova issue | |
| 09:39:03 | hrw | 2020-07-08 16:44:28.078 6 ERROR nova File "/usr/lib/python3.6/site-packages/nova/virt/libvirt/utils.py", line 65, in <module> | |
| 09:39:06 | hrw | 2020-07-08 16:44:28.078 6 ERROR nova 'avx512vbmi': os_traits.HW_CPU_X86_AVX512VBMI, | |
| 09:39:09 | hrw | 2020-07-08 16:44:28.078 6 ERROR nova AttributeError: module 'os_traits' has no attribute 'HW_CPU_X86_AVX512VBMI' | |
| 09:43:57 | frickler | hrw: guess you either need an intermediate os_traits release or use it from git instead pypi | |
| 09:45:48 | hrw | or update to 2.4.0 | |
| 09:48:47 | lyarwood | yeah FWIW tripleo hit this as well and they just needed to pull in the new os-traits release | |
| 09:48:55 | lyarwood | that's AFAIK anyway | |
| 09:49:35 | hrw | weird as image says 2.4.0 os_traits. | |
| 09:49:41 | hrw | something to debug then | |
| 09:52:36 | bauzas | stephenfin: jumping late on your Backport-Candidate question, could you please explain the usage ? | |
| 09:53:10 | lyarwood | hrw: do you have a link to the build logs showing that? | |
| 09:53:53 | bauzas | stephenfin: if it's for telling "I think it's a good change for backporting it", then anyone can just bakcport it and leave the stable cores to look at it | |
| 09:54:08 | bauzas | I don't really see what it's helping | |
| 09:54:38 | hrw | lyarwood: https://1d9789842ee1597bfc07-adfe1c2e7945e3f1ebfe34ebeb2d7062.ssl.cf2.rackcdn.com/739800/2/check/kayobe-overcloud-centos8/c7c8c01/ is zuul job log dir | |
| 09:55:04 | hrw | lyarwood: docker kolla/centos-binary-nova-compute:master image used | |
| 09:55:05 | bauzas | stephenfin: and like gibi said, we already have both launchpad tags and series for stable | |
| 09:55:41 | hrw | yaawang: I did docker run image, python3, import os_traits and HW_CPU_X86_AVX512VBMI was there so wondering what is going on | |
| 09:56:13 | stephenfin | bauzas: You can just do the backport, but that means you have to remember to do it there and then | |
| 09:56:32 | stephenfin | which might be easier said than done, particularly if there are merge conflicts | |
| 09:57:00 | stephenfin | this is just a way for (core) reviewers to say "I think this should be backported" | |
| 09:57:16 | stephenfin | or, conversely, I think this should not be backported | |
| 09:57:27 | stephenfin | and then the actual backport can take place later | |
| 09:57:56 | hrw | stephenfin: 'Backport Candidate' options in gerrit you discuss? | |
| 09:58:03 | stephenfin | hrw: correct | |
| 09:58:17 | hrw | I like them. Use them in kolla | |
| 09:59:10 | stephenfin | So do I. Maybe you can answer the questions gibi and bauzas have? Namely, what it gives over setting the series metadata in Launchpad | |
| 10:00:54 | bauzas | mmm, I see your usecase then | |
| 10:01:03 | bauzas | it would be for people wanting to know what to backport ? | |
| 10:01:11 | bauzas | but honestly, who ? | |
| 10:01:19 | hrw | stephenfin bauzas: when I have fix for stable/* I have to get it into master and then u->t->s->r if needed. so I send for master and then comment with "backport needed" and say which branches | |
| 10:01:33 | hrw | so later it is visible which patches need backporting | |