Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-07-02
15:18:55 elod gmann lyarwood : actually I'm surprised that g-api is installed on subnode, because this patch removed it (at least I thought that): https://review.opendev.org/#/c/546765/
15:19:33 sean-k-mooney1 elod: i think glance wanted to test multi store backends or soemthing like that
15:20:27 sean-k-mooney1 elod: that is for zuulv3 jobs
15:20:36 sean-k-mooney1 the legacy jobs still install it
15:21:02 lyarwood https://review.opendev.org/#/q/312517d5101206b33d3c395d27ec93d385b7fd24 ah ha!
15:21:08 lyarwood of course Ian has already fixed this
15:22:30 lyarwood gmann: FWIW without this in stable/rocky all of the services are still using the pip installed uwsgi version
15:24:58 gmann elod: sean-k-mooney1 lyarwood if it needed in mutlistore then we also need uwsgi setup in subnode too but that can be from Victoria and all stable can remove g-api may be
15:25:28 sean-k-mooney1 gmann: its not strictly required fro multistore you can do that single node
15:25:57 sean-k-mooney1 gmann: apparently it was actully for grenade
15:26:05 sean-k-mooney1 not multistore
15:26:16 gmann grenade?
15:27:16 sean-k-mooney gmann: apparently glance were doing some testing in grenade that wanted to glance-api on the subnode
15:27:31 gmann ohk
15:27:42 sean-k-mooney but to be clear if the use the v3 grenade job they can contol that themselves
15:27:45 elod i found it on multinode only, but if glance team needs g-api on subnode, then maybe the easiest fix is just to use '$(which uwsgi)' in glance (and others)
15:28:08 gmann yeah and we have grenade zuulv3 till stable/train
15:28:53 lyarwood elod: yeah posting that now
15:28:56 sean-k-mooney well id devstack need to find the correct uwsgi to use we still might need to do the $(which...)
15:28:58 lyarwood https://review.opendev.org/739072
15:29:17 sean-k-mooney but they can at least contol if its enabled on the subnode trivially so we can disable it by defualt if we want too
15:30:42 elod lyarwood: thanks for the patch, looks good :]
15:30:50 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: DNM - Testing g-api on subnode fix https://review.opendev.org/739074
15:30:52 lyarwood ^ testing there
15:35:13 gmann lyarwood: thanks
15:40:45 openstackgerrit Lucio Seki proposed openstack/nova master: Implement extend_volume for libvirt NFS volume driver https://review.opendev.org/739077
15:56:58 gibi nova meeting starts in 3 minutes on #openstack-meeting-3
16:58:51 stephenfin We've got driver capabilities and those can optionally be reported as traits. Why would someone *not* want to report the trait?
17:00:39 elod melwitt: about subunit.parser: i've seen that only on stein (so far). do you think subunit 1.4.0 would make that dissappear?
17:01:35 melwitt elod: yes, stephenfin fixed a bug in it in 1.4.0. we're very familiar with the bug downstream 😝
17:02:15 melwitt so I was thinking maybe we could opt into it by bumping upper-constraints for it on the stein branch
17:02:58 elod melwitt: oh, i see. then I will try to see if that is possible to raise it to 1.4.0 in Stein (if i'm not mistaken it's only a problem with py35)
17:03:18 sean-k-mooney we are pretty familar with it upstram too considering how much pain it has caused around Feature Freaze for thae last few cycles
17:03:50 stephenfin sean-k-mooney: melwitt: You're welcome 🌟 ;)
17:04:01 sean-k-mooney elod: nope it was a proablem on py27 and several versions of py3 if i recall
17:04:02 melwitt elod: yeah I was thinking we could propose it to openstack/requirements upper-constraints. we can't bump lower bounds on stable but we can bump upper bounds
17:04:21 melwitt stephenfin: heh, gold star worthy indeed
17:04:49 elod melwitt: and crossing fingers that it won't break other constraints ;)
17:05:01 sean-k-mooney elod: basically the subunit parser bug can happen anytime the output of the test exceed the size of a single frame in the subunit protocol
17:05:50 sean-k-mooney elod: stephenfin found a tricky race in how it processed the io streams
17:05:52 melwitt elod: yeah... I'm not sure whether it will work out but I don't have any other ideas
17:06:11 stephenfin elod: https://github.com/testing-cabal/subunit/pull/40
17:07:22 elod sean-k-mooney melwitt stephenfin : nice! thanks for the details, now the picture is somewhat complete :]
17:08:13 elod i've added then the 'subunit raise to 1.4.0' to my TODOs :]
18:40:37 openstackgerrit Merged openstack/nova master: Fix cherry-pick check for merge patch https://review.opendev.org/738271
18:40:47 openstackgerrit Merged openstack/nova master: Fix user creation with GRANT in MySQL 8.0(Ubuntu Focal) https://review.opendev.org/738723
18:50:14 openstackgerrit sean mooney proposed openstack/nova master: lookup nic feature by pci address https://review.opendev.org/739131
18:53:08 sean-k-mooney melwitt: if you have time can you take a look at ^
18:53:28 melwitt ack
18:54:28 sean-k-mooney thanks im going to go have dinner. ill be deploying that and testing it on my sriov host tomorrow so ill adress any feedback then
#openstack-nova - 2020-07-03
01:18:19 openstackgerrit Sam Morrison proposed openstack/nova master: WIP: Lock down evacuate request spec to the same cell https://review.opendev.org/739157
02:32:58 openstackgerrit Kevin Zhao proposed openstack/nova master: [WIP] CI: add tempest-integrated-compute-aarch64 job https://review.opendev.org/714439
03:17:28 tony_su /quit
03:49:46 openstackgerrit Sam Morrison proposed openstack/nova master: Lock down evacuate request spec to the same cell https://review.opendev.org/739157
08:03:15 openstackgerrit Elod Illes proposed openstack/nova stable/ussuri: Fix cherry-pick check for merge patch https://review.opendev.org/739176
08:23:00 brinzhang_ gibi: good morning
08:24:51 brinzhang_ gibi: In addition to this simple upgrade document, where is there a more detailed record? For example, how to modify the configuration file, yum source configuration, etc.
08:25:01 brinzhang_ https://docs.openstack.org/nova/stein/user/upgrade.html
08:25:03 openstackgerrit Elod Illes proposed openstack/nova stable/train: Fix cherry-pick check for merge patch https://review.opendev.org/739177
08:44:50 gibi brinzhang_: I don't think we have such document in nova. I think the deployment engines (ansible, kolla, tripleo) does that for us
08:49:50 brinzhang_ gibi: yeah, I pinged kolla, and get some useful info, thanks ^
09:02:37 bauzas brinzhang_: we have installation docs that are related to the OS
09:02:51 bauzas eg. https://docs.openstack.org/nova/stein/install/controller-install.html
09:03:15 brinzhang_ bauzas: ack, thanks
09:03:23 bauzas but those docs are old
09:03:31 bauzas and I'm not sure they are all good
09:04:29 brinzhang_ bauzas: got it, and just as reference, if there are some place need to be updated, I think I can submit it
09:14:27 stephenfin gibi: I think I'm going to split up https://review.opendev.org/#/c/631363/ since it's rather hefty. Is that okay with you?
09:47:19 gibi stephenfin: sure
09:47:21 gibi thanks
10:03:08 priteau Hi Nova devs, could you confirm that nova-conductor doesn't need access to a policy file? I don't see any call to context.can() in its source code
10:03:30 openstackgerrit Balazs Gibizer proposed openstack/nova stable/train: Guard against missing image cache directory https://review.opendev.org/738455
10:05:39 gibi priteau: I think only the nova-api service needs the policy file but gmann is the best person to confirm it
10:08:15 priteau Based a comment in kolla-ansible, it looks like there is *one* occurence in code that makes it required by nova-compute: https://opendev.org/openstack/nova/src/commit/b72980960e62e05ad4dcd9af196105e3af0ac43f/nova/network/neutron.py#L605
10:08:37 sean-k-mooney stephenfin: im currently adressing the comments on the libvirt patch but over all are you ok with the way i adressed it. other then the normal style nits/typos i didnt really see any significant changes requested
10:09:56 gibi priteau: ohh, that sounds bad but most probably necessary
10:09:57 stephenfin sean-k-mooney: I agree with all the comments but yeah, the approach makes sense to me
10:10:39 sean-k-mooney cool ill be deploying it on my sriov systems shortly and then after i test it there ill push the update
10:12:23 sean-k-mooney hehe did you notice that the vm im currently using does not have ispell currently installed :P
10:30:08 stephenfin sean-k-mooney: I may have, yes :)
10:31:01 sean-k-mooney is the mypy check runable via tox? we have an env right
10:31:34 sean-k-mooney stephenfin: i was thinking that it would be nice to add it to the precommit config too the flake8 check in that did not run it
10:31:51 sean-k-mooney in a seperate patch obviously
10:32:12 stephenfin yeah, you can use 'tox -e mypy'
10:32:24 sean-k-mooney yep just found it
10:33:15 stephenfin adding it to pre-commit makes sense too, though I'm not sure if it'd work: pre-commit usually only checks the files you modified but we'd want to test all files listed in mypy-files.txt because of the interdependencies
10:33:56 sean-k-mooney i think you can disable that in the precomit config
10:34:11 sean-k-mooney but ya im not sure
10:34:16 stephenfin so long as we can do that for a single check
10:34:29 sean-k-mooney ya i think we could do it in the check definiton
10:34:30 stephenfin we don't want to run flake8 on every file everytime you commit. It's slooowwww
10:34:47 sean-k-mooney ya
10:38:27 sean-k-mooney i cant help thinking we should break up the libvirt driver.py file
10:38:46 stephenfin We _really_ need to
10:38:56 stephenfin it's far too big for its own good
10:38:57 sean-k-mooney partly because test file is 26K lines long
10:41:14 sean-k-mooney emacs promts me to ask if im sure i want to use python mode with it incase i have bad performance
10:41:39 sean-k-mooney it works fine more or less but still
10:44:36 openstackgerrit Sylvain Bauza proposed openstack/nova-specs master: Routed network scheduling spec https://review.opendev.org/733703
11:12:43 openstackgerrit sean mooney proposed openstack/nova master: lookup nic feature by pci address https://review.opendev.org/739131

Earlier   Later