| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-07-01 | |||
| 15:47:30 | openstackgerrit | Merged openstack/nova master: Extend is_ipv6_supported() to cover more error cases https://review.opendev.org/736167 | |
| 15:50:23 | stephenfin | bauzas: Thanks for that review. You'd probably also be interested in gibi's follow-up fix here https://review.opendev.org/#/c/737508/ | |
| 15:50:50 | bauzas | stephenfin: ack, thanks for helping me to go off some hardware discussion, my brain being fried ;) | |
| 15:50:57 | stephenfin | :P | |
| 15:51:08 | stephenfin | anytime, buddy | |
| 15:59:12 | bauzas | gibi: stephenfin: holding my +W on https://review.opendev.org/#/c/737508/3 just for saying I honestly feel we should document this | |
| 15:59:32 | bauzas | and not leave operators discovering it by themselves | |
| 15:59:39 | bauzas | but, a FUP for course | |
| 16:25:51 | stephenfin | bauzas: To be honest, I thought that was assumed and I can't find anywhere easy to slot it in :-\ | |
| 16:30:25 | bauzas | stephenfin: right, hence my main comment | |
| 16:30:33 | bauzas | anyway, you saw it, +Wing | |
| 16:50:02 | sean-k-mooney | while the libvirt driver could work on non linux hosts. it has been deployed on freebsd years ago that has never really been supported | |
| 16:50:56 | sean-k-mooney | we make assumtions about linux in the code to day so i doubt you could make it work on say window easily even if you wanted too | |
| 16:57:15 | lseki | lyarwood: oh, and the volume size started with 39M, but after doing some dd inside the vm it growed to 2G | |
| 16:59:23 | sean-k-mooney | lseki: so the qcow stayed sparse until we actuly wrote data too it | |
| 16:59:30 | sean-k-mooney | which is what we want right | |
| 16:59:35 | lseki | yes | |
| 17:00:56 | sean-k-mooney | so to summerise 1, we should modify the cinder nfs backend to only extend voluem if its not attached to a vm, 2 when we are using nfs voluem in nova we should skip calling qemu-image and jsut do a block resize via the qemu monitor command | |
| 17:01:36 | sean-k-mooney | lyarwood: ^ does that make sense too you? | |
| 17:04:02 | sean-k-mooney | lseki: for the ide case did you use the correct name? | |
| 17:04:24 | sean-k-mooney | i mean it wont be drive-virtio-disk0 right | |
| 17:04:43 | sean-k-mooney | it would be something like drive-ide-disk0 | |
| 17:05:06 | lseki | sean-k-mooney: I tried the one shown by dumpxml, which is simply `disk` | |
| 17:05:19 | lseki | let me try with `drive-ide-disk0` | |
| 17:06:30 | sean-k-mooney | well its just disk for virtio as well | |
| 17:06:32 | sean-k-mooney | <disk type='file' device='disk'> | |
| 17:06:46 | sean-k-mooney | i think you are looking for the alias element | |
| 17:06:47 | sean-k-mooney | <alias name='virtio-disk0'/ | |
| 17:09:15 | lseki | oh that's right, so I should use `drive-ide0-0-0` for ide | |
| 17:09:23 | lseki | yeah it works :-) | |
| 17:09:34 | sean-k-mooney | cool | |
| 17:09:47 | sean-k-mooney | so we can lookup the alais from the xml | |
| 17:09:56 | sean-k-mooney | i assume its jsut ide0-0-0 | |
| 17:10:06 | sean-k-mooney | and we need to prepend drive- | |
| 17:11:11 | lseki | yes | |
| 17:13:17 | sean-k-mooney | im not going to ask you to test ceph but it might be intersting to see if we could use this patteren for other drivers too and avoid the calll to qemu-img | |
| 17:13:26 | sean-k-mooney | that can be a step 3 | |
| 17:13:38 | sean-k-mooney | after 1 and 2 | |
| 17:13:49 | sean-k-mooney | whcih will fix your usecase | |
| 17:19:15 | lseki | so currently cinder nfs driver calls qemu-img resize to extend a volume, attached or not | |
| 17:19:15 | lseki | https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/nfs.py#L380 | |
| 17:19:15 | lseki | https://github.com/openstack/cinder/blob/master/cinder/image/image_utils.py#L408 | |
| 17:19:15 | lseki | the step 1 is to stop calling qemu-img resize if the volume is attached | |
| 17:22:04 | lseki | but regarding the step 2, I'm not familiar with nova code... is there some workflow we can modify to make it call qemu monitor command? | |
| 17:22:32 | sean-k-mooney | this might be in os-brick im not certin | |
| 17:22:56 | sean-k-mooney | lseki: stephenfin or lyarwood have looked at this more recently then i have | |
| 17:23:59 | sean-k-mooney | lseki: is there a bug for this | |
| 17:24:10 | sean-k-mooney | lseki: if so can you summerise this in a comment | |
| 17:24:18 | lseki | https://bugs.launchpad.net/cinder/+bug/1870367 | |
| 17:24:18 | openstack | Launchpad bug 1870367 in Cinder "Fail to extend attached volume using generic NFS driver" [High,In progress] - Assigned to Silvan Kaiser (2-silvan) | |
| 17:24:31 | lseki | yeah I'll add a comment there | |
| 17:25:42 | lyarwood | sean-k-mooney / lseki ; we already call blockResize in n-cpu | |
| 17:26:15 | sean-k-mooney | lyarwood: ok so we just need to not call qemu-img in cinder or nova when using nfs | |
| 17:26:25 | sean-k-mooney | and the volume is attached | |
| 17:26:57 | lyarwood | sean-k-mooney: we just need to remove the call in c-vol | |
| 17:27:01 | lyarwood | https://github.com/lyarwood/nova/blob/d4c857dfcb1ccfa5410de55671e69c722bbc990e/nova/virt/libvirt/driver.py#L2044-L2048 | |
| 17:27:05 | lyarwood | https://github.com/lyarwood/nova/blob/d4c857dfcb1ccfa5410de55671e69c722bbc990e/nova/virt/libvirt/guest.py#L811-L819 | |
| 18:03:02 | lseki | lyarwood / sean-k-mooney: is blockResize called always, no matter what c-vol did before? | |
| 18:15:35 | lseki | testing it in a stable/train devstack here... | |
| 18:27:00 | lyarwood | lseki: yes | |
| 18:34:04 | lseki | oh no | |
| 18:34:14 | lseki | https://www.irccloud.com/pastebin/hmybxXhk/ | |
| 18:49:35 | lseki | the driver being used is `LibvirtNFSVolumeDriver`, with parent `LibvirtBaseFileSystemVolumeDriver` and grandpa `LibvirtBaseVolumeDriver` | |
| 18:49:54 | lseki | none of them implement `extend_volume` :-( | |
| 18:54:53 | lseki | so it stops here https://github.com/lyarwood/nova/blob/d4c857dfcb1ccfa5410de55671e69c722bbc990e/nova/virt/libvirt/driver.py#L2100 before reaching `_resize_attached_volume` | |
| 19:05:41 | lseki | I implemented `LibvirtNFSVolumeDriver.extend_volume` that just returns `requested_size`, and then attached extend worked! | |
| 19:05:47 | lseki | 🎉 | |
| 19:05:47 | lseki | 🎉 | |
| 19:06:41 | lseki | I'll update the bug report and submit the patches for both cinder and nova | |
| 19:07:12 | lseki | lyarwood: sean-k-mooney thank you for helping me! | |
| 19:59:34 | openstackgerrit | Merged openstack/nova master: Prevent libvirt driver starting on non Linux platform https://review.opendev.org/737508 | |
| 21:56:25 | openstackgerrit | Merged openstack/nova master: Limit the number of concurrent snapshots https://review.opendev.org/736169 | |
| #openstack-nova - 2020-07-02 | |||
| 00:53:50 | openstackgerrit | Brin Zhang proposed openstack/nova master: Delete ARQs by UUID if Cyborg ARQ bind fails. https://review.opendev.org/716186 | |
| 00:54:03 | openstackgerrit | Brin Zhang proposed openstack/nova master: cyborg evacuate support https://review.opendev.org/715326 | |
| 00:54:18 | openstackgerrit | Brin Zhang proposed openstack/nova master: WIP: Cyborg shelve/unshelve support https://review.opendev.org/729563 | |
| 01:00:42 | openstackgerrit | Brin Zhang proposed openstack/nova master: Optimize _create_and_bind_arqs logic in conducor https://review.opendev.org/726564 | |
| 08:58:14 | masterpe | I want to live-migrate from qemu version 2.11.1 to 3.1.0. Is this possible? Or is it only possible via a cold-migration? | |
| 09:10:27 | lyarwood | masterpe: it should be possible, forward live migrations like that are a supported feature. | |
| 09:11:03 | masterpe | lyarwood: When I test it I get the error: "stream had I/O failure" | |
| 09:11:36 | masterpe | when the same nodes are both on version qemu version 2.11.1 it works fine. | |
| 09:15:06 | lyarwood | masterpe: kk well it's supported so that smells like an actual bug in 3.1.0, which underlying os & OpenStack distro are you using? | |
| 09:16:24 | masterpe | Ubuntu 18.04 and it is part of an upgrade from Rocky to Stein | |
| 09:23:17 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: objects: Introduce 'pcpuset' field for InstanceNUMACell https://review.opendev.org/714658 | |
| 09:23:17 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: notifications: add the pcpuset info to instance numa cell payload https://review.opendev.org/728480 | |
| 09:23:18 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: objects: Introduce the 'CPUAllocationPolicy.MIXED' enum https://review.opendev.org/716267 | |
| 09:23:18 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: libvirt: apply mixed instance CPU policy https://review.opendev.org/728481 | |
| 09:23:19 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: Validate CPU pinning configuration for mixed instance https://review.opendev.org/716268 | |
| 09:23:19 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: Calculate the CPU usage for mixed instance https://review.opendev.org/716269 | |
| 09:23:20 | openstackgerrit | Huaqiang Wang proposed openstack/nova master: scheduler: mixed instance CPU resource translating https://review.opendev.org/728482 | |
| 09:27:36 | lyarwood | masterpe: kk well I'd raise a bug with Ubuntu against QEMU, if they can prove it's an OpenStack issue we can then raise one against Nova. | |
| 09:28:49 | lyarwood | masterpe: bonus points if you try to reproduce this outside of OpenStack btw. | |
| 09:29:07 | lyarwood | https://bugs.launchpad.net/ubuntu/+source/qemu <- that's where you can raise the QEMU bug FWIW | |
| 09:32:21 | masterpe | https://gist.github.com/mpiscaer/9c50e4e6f81d004fc78bc282e910a458 is the log of the instance on qemu | |
| 09:33:51 | frickler | masterpe: is that the same as https://bugs.launchpad.net/cloud-archive/+bug/1882416 ? | |
| 09:33:51 | openstack | Launchpad bug 1882416 in Ubuntu Cloud Archive "virtio-balloon change breaks rocky -> stein live migrate" [Undecided,New] | |
| 09:35:24 | masterpe | Yes | |
| 09:35:49 | frickler | masterpe: then best try to talk to cpaelzer in #ubuntu-server | |
| 09:43:41 | masterpe | Qemu fix this issue in commit 2bbadb08ce272d65e1f78621002008b07d1e0f03, Thank you very much, this is something I can work with. | |
| 10:06:44 | openstackgerrit | Lee Yarwood proposed openstack/nova stable/rocky: fix scsi disk unit number of the attaching volume when cdrom bus is scsi https://review.opendev.org/730312 | |
| 10:08:53 | lyarwood | ops ignore that, just catching up on stable today and didn't check the ML first | |