Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-06-19
17:51:14 melwitt cause we'll end up here if the dir doesn't exist https://github.com/openstack/nova/blob/f5f7c2540150c7ee7640c834d5caec31b3f5a7ab/nova/virt/libvirt/imagecache.py#L366
17:52:11 dansmith er wait, maybe I'm inverting that in my head
17:52:47 melwitt it will return 0 disk usage if self.cache_dir_is_on_same_dev_as_instances_dir is False, right?
17:52:49 dansmith okay right right, I forgot how this ended up
17:52:58 dansmith we initially talked about reporting inventory for the cache disk itself,
17:53:03 melwitt else it will do the math on the cache dir
17:53:28 dansmith and this is the opposite where we reserve only if the cache is the _same_ disk, which I think is why we endded up checking the reverse condition instead of what we're looking for
17:54:05 dansmith so yeah, we need to bail if the directory doesn't exist because we're checking the cache_dir which might not exist yet
17:54:25 dansmith I still think the property shouldnt' explode if the directory doesn't exist,
17:54:44 dansmith but you're right, it'll still hit the same problem but a little later on
17:55:19 dansmith the logic is right, it just doesn't prevent us from hitting the same problem in the sum()
17:55:45 melwitt oh, ok, so the logic on exists() should not be inverted to remove the 'not'
17:56:44 dansmith no, because if it does not exist, the not will make that true, which will short-circuit and return true without evaluating the st_dev part
17:57:03 melwitt oh, right
17:58:29 dansmith I'll pull this down and make that change, just a sec
17:59:20 melwitt ok, cool
17:59:26 dansmith eff, just realized I didn't commit something I did earlier today unrelated
17:59:40 openstackgerrit Dan Smith proposed openstack/nova master: DNM: Try to make a glance multistore job https://review.opendev.org/734184
17:59:53 dansmith so another few days in the queue for me
18:00:33 melwitt heh :(
18:10:56 openstackgerrit Dan Smith proposed openstack/nova master: Guard against missing image cache directory https://review.opendev.org/736964
18:10:58 dansmith melwitt: ^
18:12:45 dansmith added comments to hopefully make it clearer why each thing is happening
18:14:14 melwitt looking ... ah yep, that is helpful
18:19:48 dansmith thanks. I was clearly focused on getting that property to return the right thing all the time and not realizing we'd be introducing a new vector to the error :)
20:43:10 mnaser just wanna put eyes on https://review.opendev.org/#/c/736370/ if/when possible :)
21:04:42 sean-k-mooney mnaser: form the title that makes sense
21:05:05 sean-k-mooney ill take a look on monday
21:05:21 sean-k-mooney actully its pretty short
21:07:53 mnaser sean-k-mooney: thank you!
21:18:08 sean-k-mooney melwitt: just finished reviewing https://review.opendev.org/#/c/736370/2 want to take a look?
21:18:39 sean-k-mooney mnaser: the only thing im not sure is do we want to have a release note or not.
21:19:43 sean-k-mooney mnaser: this would have failed anyway later so the only behavior change is that by failing in _validate_flavor_image_nostatus we now fail before creating a server record
21:20:08 sean-k-mooney so instead of ending up with a server in error state we just get an excption form spawn
21:21:37 sean-k-mooney which is better but as an operator would you want that called out in the release notes give the excption you are raising inherits form FlavorDiskTooSmall which can already casue the same behvoiur if the volume is less the min_gb
21:21:42 sean-k-mooney mnaser: ^
21:31:22 arjunbaindur hey, have a question about configuring PCI passthrough. We have a device that has 2 functions. On the hypervisor, the PCI address has it on same bus and same slot. When it shows up inside the VM, the PCI address has it under different slots
21:31:31 arjunbaindur for example, suppose device has two functions at 83:00.0 and 83:00.1
21:31:39 arjunbaindur Under the VM, the devices show up under different slots, for example 0:5.0 and 0:6.0
21:32:34 sean-k-mooney im guessing its a gpu with a second function for the audio encoder on the gpu?
21:32:38 arjunbaindur any idea how to get them to show up as two functions under the same slot
21:32:39 sean-k-mooney or a similar device
21:32:56 sean-k-mooney unfortunetly we do not have a way to do that currently
21:33:12 sean-k-mooney we did dicuss it breifly about 3-6 months ago
21:33:46 sean-k-mooney efffectivly we would need to modify the pci alisia to support multifuntion devices
21:34:46 sean-k-mooney such as allowing one pci aliase to refrence another and adding a multifuntion=true tag
21:35:17 sean-k-mooney so the parent alias would refence the child aliase and but or would have the multifunction=ture tag
21:36:13 sean-k-mooney arjunbaindur: i think on windows this can break the audio encoder on nvidga gpus since the driver is expecting it to be a second fuction on the same bus/slot
21:36:18 sean-k-mooney but on linux it works
21:36:34 sean-k-mooney im sure it would be an issue for other device that had the same toplogy
21:39:01 arjunbaindur to be specific, this is a Xilinx card
21:39:12 arjunbaindur https://www.xilinx.com/support/documentation/boards_and_kits/accelerator-cards/1_5/ug1301-getting-started-guide-alveo-accelerator-cards.pdf
21:39:57 arjunbaindur since the two devices show up under diff PCI slots, we arent able to install drivers
21:40:35 sean-k-mooney ah ok well its the same issue unfortunetly
21:40:48 sean-k-mooney are you trying to reproguam the aclerat using 1 fucntion
21:40:56 sean-k-mooney and consume it using the second
21:42:54 sean-k-mooney 32-64GB of ddr4 + and fpga and some qsfp ports. that looks like a pretty interesting card
21:43:14 sean-k-mooney arjunbaindur: are you trying to use this via cyborg or just novas pci passhtough
21:44:08 arjunbaindur just Nova PCI passthrough: followed this doc basically: https://docs.openstack.org/nova/rocky/admin/pci-passthrough.html
21:44:41 arjunbaindur Added the two PCI addresses for each function in the whitelist
21:44:42 sean-k-mooney ya so as i said we are missing the ablity to group multiple fucntion together form teh same device that are schulded togehter
21:45:07 arjunbaindur is there an upstream bug or anything to track this?
21:45:28 sean-k-mooney i was trying to find one. its not really a bug since it was never part of the orginial design
21:46:03 sean-k-mooney i suspcet this would need a short spec or maybe a specless blueprint
21:48:16 sean-k-mooney arjunbaindur: looking at the open blueprints no
21:48:37 sean-k-mooney so the feature you need is support for "multifunction pci device passthough"
21:49:17 sean-k-mooney if you want to file a blueprint for that and add the details of your specific usecase we could bring it up in the next meeting or dicsuss it here next week when more people are online
21:50:07 sean-k-mooney it has been asked for before and should not be too invasive to add but on the other hand not many people review the pci code so getting reviews might be the bigger stubleing block to addign this
21:51:06 sean-k-mooney its a cpablity i suspect cyborg will want eventually too so the libvirt driver work to supprot generintg the correct xml is likely to be need regardless of if we add the feature to novas pci pasthough
22:29:40 sean-k-mooney dansmith: it finally passed https://review.opendev.org/#/c/734184/ :)
22:31:04 sean-k-mooney dansmith: ah you modified devstack in the end https://review.opendev.org/#/c/736231
23:26:23 artom sean-k-mooney, if by some weirdness of circumstance you're still working: https://review.opendev.org/#/c/737052/2
23:32:41 sean-k-mooney im watching a c++ code review of command and conquer https://www.youtube.com/watch?v=Oee7gje-XRc&t=929s
23:33:02 sean-k-mooney but since my laptop is broken im using my work one
23:33:12 sean-k-mooney until i buy a new one
23:33:31 sean-k-mooney so ya you unabandonted that?
23:33:44 sean-k-mooney or is this a different fix
23:34:34 sean-k-mooney that is instead of https://review.opendev.org/#/c/737038/
23:36:34 sean-k-mooney artom: ah ok i see whats happening we are installing pacages via pip before devstack runs for crudini
23:36:43 sean-k-mooney so devstack has not allready installed pip
23:44:34 sean-k-mooney artom: so this is happing because of http://lists.openstack.org/pipermail/openstack-discuss/2020-June/015204.html
23:44:49 sean-k-mooney artom: so +2 from me the ci passes and the patch makes sense
23:46:32 artom I dunno what I expected
23:46:34 artom Thank you!
23:46:37 artom Also, you're a lunatic
23:46:51 sean-k-mooney for likeing c++
23:46:56 artom Sure, why not
23:47:15 sean-k-mooney or for having irc open on a different monitor while i watch youtube
23:48:05 artom That last part is almost reasonnable
23:48:16 dansmith sean-k-mooney: it didn't setup glance properly though, for some devstack reason I don't understand
23:48:24 dansmith so I'll have to work on that on monday
23:49:02 sean-k-mooney dansmith: ah ok i can take a look on monday too if you like the main issue is i dont know how to configure what you want to configure
23:49:10 sean-k-mooney dansmith: but let me know if i can help
23:49:32 dansmith sean-k-mooney: well, you can see what I've got in local.conf, and that didn't end up in glance-api.conf like it did before
23:49:47 dansmith but anyway, I can take a look and then come crawling to you, which'll make it even more sweet for you :)
23:50:00 sean-k-mooney :)
23:52:51 sean-k-mooney oh ya https://zuul.opendev.org/t/openstack/build/d083edcf35d649768506fbbf7dbbf64c/log/controller/logs/etc/glance/glance-api_conf.txt does not have the values but https://zuul.opendev.org/t/openstack/build/d083edcf35d649768506fbbf7dbbf64c/log/controller/logs/etc/glance/glance-image-import_conf.txt does
23:53:17 dansmith I gotta begin my weekend, later
23:53:25 sean-k-mooney dansmith: o/
23:59:04 sean-k-mooney dansmith: for what its worth i think your hitting a devstack bug since its in the local.conf correctly. so i think your zuul file is correct.

Earlier   Later