Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-05-22
12:51:46 openstackgerrit Elod Illes proposed openstack/nova stable/ussuri: remove support of oslo.messaging 9.8.0 warning message https://review.opendev.org/728055
12:56:26 jsuchome lyarwood: hey, just a humble ping with a request for a new review...
12:59:36 lyarwood jsuchome: ack looking
13:08:20 openstackgerrit Lee Yarwood proposed openstack/nova master: zuul: Make barbican-simple-crypto-devstack-tempest a non-voting check job https://review.opendev.org/730319
13:08:20 openstackgerrit Lee Yarwood proposed openstack/nova master: zuul: Make devstack-plugin-ceph-tempest-py3 a voting check job again https://review.opendev.org/730320
13:10:40 sean-k-mooney gibi: dansmith added https://github.com/openstack/nova/commit/04e79b5b7e18f033053d4057edc768281b91a4d7 to reserve migration for ussuri but we also merged https://github.com/openstack/nova/commit/75a2d600fc26beda78bdafd209e92f0bc9802927
13:10:55 sean-k-mooney https://github.com/openstack/nova/commit/75a2d600fc26beda78bdafd209e92f0bc9802927 is not on stable/ussuri however
13:11:12 sean-k-mooney do you know why we have 2 set of placeholder migration for ussuri
13:11:22 sean-k-mooney and why only one of them is in stable ussuri
13:12:12 sean-k-mooney is the commit message in https://github.com/openstack/nova/commit/75a2d600fc26beda78bdafd209e92f0bc9802927 just wrong and those are for victoria
13:14:29 gibi sean-k-mooney: good question
13:15:14 sean-k-mooney it add ussuri_placeholders = list(range(408, 413)) to the migration tests
13:15:40 sean-k-mooney but i would expect that to get run on stable/ussuri but i guess i dont really follow how this is ment to work
13:16:19 gibi I think only the commit message is missleading both patches are correct, they reserve db migration for bugfixes
13:16:43 sean-k-mooney right the patches are more or less idential
13:17:10 sean-k-mooney im just wondering what we expect to see on stable/ussuri
13:17:35 sean-k-mooney i see the place holder up to 072 https://github.com/openstack/nova/tree/stable/ussuri/nova/db/sqlalchemy/api_migrations/migrate_repo/versions
13:17:44 sean-k-mooney which were intoduced by dansmith
13:17:51 sean-k-mooney so i think that is correct
13:18:22 sean-k-mooney but if i look at his patch those are listed as train_placeholders = list(range(68, 73))
13:18:29 gibi when you want to backport a migraiton to ussuri you have to use one of the reserved migration from https://review.opendev.org/#/c/722546 if you want to add a new migration that is not backported then you have to use 078
13:19:25 sean-k-mooney right but what is confutin me is we are calling them train_placeholders in the tests
13:19:32 gibi train_placeholders means for me that such versions are reserved for migration that might need to be backported to train
13:20:06 sean-k-mooney ok that a different way to look at it
13:20:17 gibi when we started ussuri we reserved migrations for stable/train when we started V we reserved migration for stable/ussur
13:20:20 gibi i
13:20:45 sean-k-mooney but see that does not fully make sense to me
13:20:58 sean-k-mooney oh well maybe
13:21:13 sean-k-mooney when we do the backprot to stable usue it would start with 73?
13:21:40 sean-k-mooney which is hte first migration we reseved in the vicrotia cycle
13:21:50 sean-k-mooney for backport to ussuri
13:22:30 sean-k-mooney ok i think i understand how this work now
13:23:51 gibi cool
13:24:40 sean-k-mooney i still find it slightly backwards but i am now following at least
13:25:45 sean-k-mooney ii was expecteing each release to add backport slot for backport to that release but i was off by 1
13:33:15 openstackgerrit Balazs Gibizer proposed openstack/nova stable/train: Reserve DISK_GB resource for the image cache https://review.opendev.org/730324
13:34:26 openstackgerrit Balazs Gibizer proposed openstack/nova stable/train: Add admin doc information about image cache resource accounting https://review.opendev.org/730326
13:47:43 lyarwood sean-k-mooney: https://github.com/cirros-dev/cirros/issues/53 - something to be aware of in the future with cirros 0.5.0 and q35
13:47:48 mnaser https://review.opendev.org/#/c/729088/ if anyone wants to finish backporting it all the way back :)
13:48:21 sean-k-mooney lyarwood: aw you mean we cant keep using or normal 64mb nano images
13:48:49 sean-k-mooney lyarwood: is that memory the guest memory or host memoery
13:49:07 lyarwood sean-k-mooney: guest AFAICT
13:49:21 sean-k-mooney thats strange
13:49:31 sean-k-mooney using uefi should not affect the guest minium memeory
13:49:32 lyarwood sean-k-mooney: https://review.opendev.org/#/c/730307/ tbh we are also breaking to the nano flavor with 0.4.0 anyway
13:49:48 lyarwood due to*
13:50:05 sean-k-mooney lyarwood: you might as well just bump it to 128
13:50:25 sean-k-mooney we are tight on memory in the ci but not that tight
13:50:27 lyarwood I wasn't sure if that would bork some providers tbh
13:50:41 lyarwood yeah given the other change I'll move this to 128
13:50:54 sean-k-mooney it does not depend on the provider
13:51:03 sean-k-mooney all proviers provide an image with 8G of ram
13:51:17 sean-k-mooney unless you use a special node set with a different lable
13:51:52 lyarwood ack
13:52:32 sean-k-mooney but ya im still not sure why it would need more guest ram for uefi
13:53:11 sean-k-mooney i mean sure there are the uefi runtim services but they should not be consuming enough ram to be meaningful
14:28:36 openstackgerrit Balazs Gibizer proposed openstack/nova stable/rocky: Reproduce bug 1869050 https://review.opendev.org/730343
14:28:36 openstack bug 1869050 in OpenStack Compute (nova) rocky "migration of anti-affinity server fails due to stale scheduler instance info" [Low,In progress] https://launchpad.net/bugs/1869050
14:28:36 openstackgerrit Balazs Gibizer proposed openstack/nova stable/rocky: Update scheduler instance info at confirm resize https://review.opendev.org/730344
14:37:16 openstackgerrit Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301
14:38:09 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove unnecessary retrieval of Migration object https://review.opendev.org/730351
14:38:09 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove unused function parameters https://review.opendev.org/730352
14:38:38 jsuchome lyarwood: ok, addressed your notes except 2 things: 1. the error handling in case of failed write/verification (not really sure if your suggestion would make it better). and 2. I know nothingabout barbican :-(
14:40:07 openstackgerrit Dan Smith proposed openstack/nova-specs master: Add rbd-glance-multistore spec https://review.opendev.org/730126
14:45:01 lyarwood jsuchome: barbican-simple-crypto-devstack-tempest runs some additional image verification tests I'd like to see pass against your changes
14:45:44 lyarwood jsuchome: it's in the experimental queue I triggered earlier
14:47:34 jsuchome ah, I see
14:48:26 lyarwood jsuchome: could you trigger it again for your latest patchset?
14:48:33 lyarwood jsuchome: it should cancel the previous run
14:49:04 jsuchome done
14:49:15 lyarwood thanks
15:06:26 openstackgerrit Merged openstack/nova stable/rocky: Revert "nova shared storage: rbd is always shared storage" https://review.opendev.org/726863
15:06:32 openstackgerrit Merged openstack/nova stable/ussuri: Silence amqp heartbeat warning https://review.opendev.org/728054
15:36:33 openstackgerrit Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to 'nova.pci' https://review.opendev.org/676209
15:36:34 openstackgerrit Stephen Finucane proposed openstack/nova master: mypy: Add nova.cmd, nova.conf, nova.console https://review.opendev.org/705657
15:36:34 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: mypy: Add type annotations to top-level modules https://review.opendev.org/705658
15:40:54 openstackgerrit Stephen Finucane proposed openstack/nova master: Fix configure() called after DatabaseAtVersion fixture https://review.opendev.org/619723
15:47:51 openstackgerrit Stephen Finucane proposed openstack/nova master: Remove eventlet hub workaround for monotonic clock https://review.opendev.org/644237
15:47:51 openstackgerrit Stephen Finucane proposed openstack/nova master: Add missing test bindep on openssl https://review.opendev.org/644238
15:55:23 stephenfin lyarwood: I don't have the power to abandon these. Can you? https://review.opendev.org/#/q/topic:bug1840912+(status:open+OR+status:merged)
15:56:36 openstackgerrit Stephen Finucane proposed openstack/nova master: Cleanup libvirt test_mount unit tests https://review.opendev.org/692173
16:06:57 lyarwood stephenfin: done
16:07:02 stephenfin thanks
16:23:36 openstackgerrit Stephen Finucane proposed openstack/nova master: quota: remove get_quota_classes() driver method https://review.opendev.org/615615
16:23:37 openstackgerrit Stephen Finucane proposed openstack/nova master: quota: remove Context.quota_class https://review.opendev.org/615616
16:23:37 openstackgerrit Stephen Finucane proposed openstack/nova master: quota: remove FakeContext from quota unit tests https://review.opendev.org/615617
16:23:38 openstackgerrit Stephen Finucane proposed openstack/nova master: quota: remove _no_class tests https://review.opendev.org/615618
16:23:38 openstackgerrit Stephen Finucane proposed openstack/nova master: quota: clean up DbQuotaDriver unit tests https://review.opendev.org/615619
16:23:39 openstackgerrit Stephen Finucane proposed openstack/nova master: quota: rename arguments to clarify they are limits https://review.opendev.org/615633
16:30:37 openstackgerrit Stephen Finucane proposed openstack/nova master: quota: remove Context.quota_class https://review.opendev.org/615616
16:30:37 openstackgerrit Stephen Finucane proposed openstack/nova master: quota: remove FakeContext from quota unit tests https://review.opendev.org/615617
16:30:38 openstackgerrit Stephen Finucane proposed openstack/nova master: quota: remove _no_class tests https://review.opendev.org/615618
16:30:39 openstackgerrit Stephen Finucane proposed openstack/nova master: quota: clean up DbQuotaDriver unit tests https://review.opendev.org/615619
16:30:39 openstackgerrit Stephen Finucane proposed openstack/nova master: quota: rename arguments to clarify they are limits https://review.opendev.org/615633
16:45:50 openstackgerrit Stephen Finucane proposed openstack/nova master: Fix configure() called after DatabaseAtVersion fixture https://review.opendev.org/619723
17:20:37 openstackgerrit Merged openstack/nova stable/ussuri: remove support of oslo.messaging 9.8.0 warning message https://review.opendev.org/728055
17:24:10 openstackgerrit Andreas Jaeger proposed openstack/nova-specs master: Switch to newer openstackdocstheme and reno versions https://review.opendev.org/728611
17:24:50 openstackgerrit Andreas Jaeger proposed openstack/nova-specs master: Switch to newer openstackdocstheme and reno versions https://review.opendev.org/728611
17:30:50 openstackgerrit Andreas Jaeger proposed openstack/os-vif master: Switch to newer openstackdocstheme and reno versions https://review.opendev.org/728612
17:40:50 openstackgerrit Stephen Finucane proposed openstack/nova master: Add emulated TPM support to Nova https://review.opendev.org/631363

Earlier   Later