| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-05-13 | |||
| 11:42:21 | sean-k-mooney | if we dropped the value then we would cahgne form mixed to shared | |
| 11:42:28 | sean-k-mooney | that is wrong | |
| 11:42:53 | huaqiang | Yes. I don't allow change from a mixed to shared | |
| 11:42:59 | huaqiang | sound reasonable | |
| 11:43:20 | sean-k-mooney | i think what is being done for 1.5 and 1.6 in those patches is correct | |
| 11:44:26 | huaqiang | sean-k-mooney: Thanks | |
| 11:44:39 | huaqiang | It is clear for me. | |
| 11:45:48 | huaqiang | sean-k-mooney: another thing | |
| 11:46:07 | huaqiang | since v1.6 is not compatible with v1.5 | |
| 11:46:09 | huaqiang | should be bump the major version number? | |
| 11:46:10 | openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Re-proposes 'Proposal for a safer remote console with password authentication' https://review.opendev.org/719720 | |
| 11:46:31 | sean-k-mooney | we dont really use the major version number | |
| 11:46:36 | brinzhang_ | gibi: done, thanks | |
| 11:46:37 | huaqiang | s/should be/ should we/ | |
| 11:46:39 | sean-k-mooney | but we could i guess | |
| 11:47:02 | sean-k-mooney | that wone i would want dansmith to weigh in on as i dont know why we dont bump the major version | |
| 11:47:25 | sean-k-mooney | proably because its only conditionally incompatiable | |
| 11:47:28 | huaqiang | I'll leave it for revewer for designe | |
| 11:47:36 | huaqiang | s/designe/decision/ | |
| 11:47:50 | sean-k-mooney | e.g. if you are using shraed or dedicated we can backlevel it | |
| 11:48:10 | sean-k-mooney | so since it not a hard incompatiablity we dont need to modify the major version | |
| 11:48:15 | huaqiang | it true. | |
| 11:48:40 | huaqiang | ok, thanks | |
| 11:49:15 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.PY2 and six.PY3 https://review.opendev.org/726512 | |
| 11:49:29 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.add_metaclass https://review.opendev.org/726565 | |
| 11:49:35 | gibi | brtknr: thanks, +2 | |
| 11:49:44 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.reraise https://review.opendev.org/726898 | |
| 11:50:00 | brtknr | gibi: wp | |
| 11:50:07 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224 | |
| 11:50:09 | gibi | brtknr: sorry | |
| 11:50:29 | brtknr | np :) | |
| 11:52:53 | openstackgerrit | sean mooney proposed openstack/nova master: Provider Config File: YAML file loading and schema validation https://review.opendev.org/673341 | |
| 11:52:54 | openstackgerrit | sean mooney proposed openstack/nova master: Provider Config File: Function to further validate and retrieve configs https://review.opendev.org/676029 | |
| 11:52:54 | openstackgerrit | sean mooney proposed openstack/nova master: Provider Config File: Functions to merge provider configs to provider tree https://review.opendev.org/676522 | |
| 11:52:55 | openstackgerrit | sean mooney proposed openstack/nova master: Provider Config File: Enable loading and merging of provider configs https://review.opendev.org/693460 | |
| 11:53:42 | sean-k-mooney | gibi: that is just a strait rebae with the merge conflicts and pep8 issues resolved by the way so its basically the same as the previous version | |
| 11:54:51 | gibi | sean-k-mooney: thanks. you and tony_su should sync on who will work on that patch series | |
| 11:55:25 | sean-k-mooney | gibi: yep | |
| 11:56:57 | sean-k-mooney | tony_su: if you want to take it over and have time to adress https://review.opendev.org/#/c/676029/34/nova/tests/unit/compute/test_provider_config.py@174 that was the only open item form last cycle i belive | |
| 11:59:28 | sean-k-mooney | ok i have been awaked since 3:30 and working more or less since 4:30 so im going to take a break for a few hours. ill be back after i have lunch and relax for a bit | |
| 12:09:10 | gibi | sean-k-mooney: have a nice lunch | |
| 12:22:10 | jkulik | anybody else experiencing problems with querying /servers for multiple uuids? nova seems to only get one uuid for filtering. I guess the MultiDict used by webob.Request gets botched here https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L178 see http://paste.openstack.org/show/793512/ for some python-console fuu showing the problem | |
| 12:23:01 | jkulik | docs for the MultiDict stuff https://docs.pylonsproject.org/projects/webob/en/stable/reference.html#query-post-variables | |
| 12:28:12 | openstackgerrit | Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224 | |
| 12:29:25 | jkulik | should I just open a bug report if I fear something is broken instead of asking on IRC for someone to confirm? | |
| 12:30:16 | sean-k-mooney | jkulik: im not sure if this is actully supported | |
| 12:30:28 | jkulik | oh, down the line it's checked against a list | |
| 12:30:33 | jkulik | let me find that part again | |
| 12:31:43 | sean-k-mooney | jkulik: the servers endpoint only supprot one uuid https://docs.openstack.org/api-ref/compute/?expanded=show-server-details-detail#show-server-details | |
| 12:31:48 | sean-k-mooney | not a list of them | |
| 12:32:03 | sean-k-mooney | at least the server detials endpoint | |
| 12:32:41 | jkulik | index does support more in theory, though. it ends up here in the end https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L1849-L1854 | |
| 12:33:11 | jkulik | oh, I mean query params to /servers or /servers/detail | |
| 12:33:13 | sean-k-mooney | well the docs text is | |
| 12:33:34 | sean-k-mooney | right so its not supported for /servers/detail | |
| 12:33:49 | sean-k-mooney | well i guess it might be | |
| 12:34:03 | sean-k-mooney | the docs text reads | |
| 12:34:06 | sean-k-mooney | uuid (Optional) | |
| 12:34:08 | sean-k-mooney | ||
| 12:34:10 | sean-k-mooney | query | |
| 12:34:12 | sean-k-mooney | ||
| 12:34:14 | sean-k-mooney | string | |
| 12:34:16 | sean-k-mooney | ||
| 12:34:18 | sean-k-mooney | Filter the server list result by the UUID of the server. | |
| 12:34:20 | sean-k-mooney | This parameter is only valid when specified by administrators. If non-admin users specify this parameter, it is ignored. | |
| 12:34:23 | sean-k-mooney | so based on the docs we dont supprot it | |
| 12:34:35 | jkulik | it would explicitly state that's it supports a list? | |
| 12:34:41 | sean-k-mooney | it might be possibel but its not intended to work | |
| 12:35:13 | sean-k-mooney | it filters the list of servers by the uuid | |
| 12:35:13 | jkulik | (because for neutron ports "id", it looked the same but works) | |
| 12:35:20 | sean-k-mooney | it does not say it supports a list of uuids | |
| 12:35:40 | jkulik | sure, but the code has extra ifs for a list ;) | |
| 12:36:07 | jkulik | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2838-L2841 | |
| 12:36:11 | sean-k-mooney | jkulik: do we have api test for the list case | |
| 12:36:20 | jkulik | haven't checked. will do. | |
| 12:48:07 | jkulik | can't find any in the unit-tests at least. for a lot of other query-params, there are tests, but uuid doesn't seem to be in there. | |
| 12:49:21 | sean-k-mooney | jkulik: looking at the code if ti ever worke i suspect it was a nova v2 or nova v1 capablity that was never fully supproted and is not supproted anymore | |
| 12:50:07 | jkulik | looking at the code, it seems totally supported, if we would just convert the MultiDict's multiple entries to a list instead | |
| 12:50:41 | sean-k-mooney | https://github.com/openstack/nova/commit/3f35fe6a88672ea2ab7e080a55235c5cca45dc2c | |
| 12:51:07 | sean-k-mooney | that code is related to listing instance by ip | |
| 12:51:27 | sean-k-mooney | jkulik: its not for listing servers by uuid | |
| 12:51:59 | francoisp | lyarwood, bauzas hello, when you get a chance: https://review.opendev.org/#/c/726508/ (this time around for Queens) - thanks! | |
| 12:52:09 | bauzas | ack, will look | |
| 12:52:39 | sean-k-mooney | jkulik: we support a list there becasue you can have multiple servers with the same ip adress | |
| 12:52:56 | sean-k-mooney | but we dont support the uuid query arg being a list | |
| 12:53:13 | jkulik | sean-k-mooney, but is uses the uuid key out of search_opts which comes from the query-params | |
| 12:53:23 | jkulik | which cannot be a list because it's broken | |
| 12:53:39 | sean-k-mooney | jkulik: the uuid quey arg is not ment to be a list | |
| 12:53:55 | sean-k-mooney | it susing it here so you can filter by ip and uuid | |
| 12:53:59 | jkulik | my use-case would be retrieving infos for multiple servers I know the UUID of in one request btw. | |
| 12:54:03 | sean-k-mooney | the docs say uuid singualr | |
| 12:54:23 | sean-k-mooney | jkulik: yep which as far as im aware we do not support | |
| 12:54:28 | jkulik | sure. the docs say the same for "id" in ports, so I didn't think that's so important ;) | |
| 12:55:06 | jkulik | and since search_opts gets passed down to the db layer in the end, which also can support a list, we would just have to adjust that one line to make it work | |
| 12:55:09 | sean-k-mooney | gmann: your one of our api experst do you know if we have ever supported filtering server list by a list of uuids | |
| 12:55:32 | jkulik | but if it's not supposed to, that's fine, too. I just think the code would support it. | |
| 12:55:37 | sean-k-mooney | jkulik: there is a difference between things that work as a result of internal impemnstion details and what is actully supported | |
| 12:56:55 | jkulik | sean-k-mooney, thanks for looking at it :) | |
| 12:57:37 | sean-k-mooney | jkulik: this is the relevent spec for filtering https://specs.openstack.org/openstack/nova-specs/specs/ocata/implemented/add-whitelist-for-server-list-filter-sort-parameters.html | |
| 13:00:48 | sean-k-mooney | jkulik: so i think we suport filterign with a singel value but not lists or any advance queries. | |