| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-05-12 | |||
| 15:21:23 | lyarwood | tosky: the LM jobs? | |
| 15:21:50 | tosky | lyarwood: that one (and in general any job that requires to move from legacy to native zuulv3) | |
| 15:23:16 | lyarwood | tosky: http://lists.openstack.org/pipermail/openstack-discuss/2020-March/013207.html covers some of it, it's currently three jobs in one | |
| 15:23:51 | lyarwood | tosky: I ran out of time in U to break things up but feel free to poke the changes early in V if you have time before I get around to it | |
| 15:24:54 | tosky | lyarwood: sure - I will ping everyone with pending legacy jobs as part of the work on the community goal | |
| 15:25:09 | openstackgerrit | sean mooney proposed openstack/nova master: [DNM] ceph direct download testing https://review.opendev.org/727228 | |
| 15:25:29 | sean-k-mooney | ok well that is just push to have it there. it will do the excat same thing as lyarwood version | |
| 15:25:40 | sean-k-mooney | its just in nova rather then the devstack plugin | |
| 15:26:54 | lyarwood | tosky: ack understood thanks :) | |
| 15:31:13 | jsuchome | lyarwood: sean-k-mooney: thanks a lot ... so, where exactly do I set those nova+glance config values? under $NOVA_CPU_CONF for nova? And the one for glance? | |
| 15:32:49 | openstackgerrit | Jiri Suchomel proposed openstack/nova-specs master: Add spec for downloading images via RBD https://review.opendev.org/572805 | |
| 15:35:49 | lyarwood | jsuchome: glance should be configured automatically, we only had to add the two specific configurables your change is using in Nova as we disabled the configuration of Nova by the ceph devstack plugin. | |
| 15:36:57 | lyarwood | just corrected a mistake in my change, I'll check back in on it later. | |
| 15:38:06 | jsuchome | lyarwood: for glance I need DEFAULT.show_image_direct_url=true, are you telling me this is set by default? | |
| 15:38:43 | sean-k-mooney | im not sure its in the base job | |
| 15:38:48 | sean-k-mooney | so we might need to set that | |
| 15:38:57 | jsuchome | that's what I would expect | |
| 15:38:58 | dansmith | jsuchome: I think it must be, otherwise nova wouldn't be able to tell that the image is in the same rbd it is configured for, with the rbd backend | |
| 15:39:31 | jsuchome | I see, so you mean it already _is_ default for ceph jobs? | |
| 15:39:33 | dansmith | i.e. we already look at the locations field of the image, that's what you need right? | |
| 15:39:36 | dansmith | jsuchome: I expect | |
| 15:39:41 | sean-k-mooney | dansmith: we only have one cluser set up by the plugin so that would not be an issue we would see in teh gate | |
| 15:39:58 | dansmith | sean-k-mooney: if we look at the locations and require one that matches, it would | |
| 15:39:58 | jsuchome | yes, that's for location | |
| 15:39:59 | sean-k-mooney | i.e. it will always be the same | |
| 15:40:00 | dansmith | but I'm looking | |
| 15:40:33 | sean-k-mooney | i mean its not hard to add but ill chekc the parent jobs and see if we are doing it or not | |
| 15:41:02 | sean-k-mooney | or actully the plugin is likely where that would be set | |
| 15:41:22 | dansmith | https://zuul.opendev.org/t/openstack/build/fbd122f546684ffebdca5f2f73b6167c/log/controller/logs/etc/glance/glance-api_conf.txt | |
| 15:41:23 | jsuchome | lyarwood: sean-k-mooney: also this for nova conf: glance.allowed_direct_url_schemes = rbd ... as this is (was! and should not be anymore) deprecated option, I would not expect it to be set | |
| 15:41:33 | dansmith | show_multiple_locations = True | |
| 15:41:49 | sean-k-mooney | https://github.com/openstack/devstack-plugin-ceph/commit/62ea04c8d180c5419300ddc7784c5c46f9fcbdad | |
| 15:42:02 | dansmith | I think ^ is what we need for the check we do | |
| 15:42:12 | dansmith | not sure the difference between that and the show-direct-url one | |
| 15:42:19 | dansmith | because, AFAIK, the locations are the direct url | |
| 15:43:11 | dansmith | ah, | |
| 15:43:12 | jsuchome | so show_multiple_locations also implies the location info is present? | |
| 15:43:18 | dansmith | that commit implies that one impliesthe other | |
| 15:43:19 | dansmith | yeah | |
| 15:45:46 | sean-k-mooney | lyarwood's job is curerntly running https://zuul.openstack.org/stream/9b459dcfc0cd46d0a13ce5a5a1be2afe?logfile=console.log so we will know one way or another in about an hour | |
| 15:45:56 | sean-k-mooney | maybe too | |
| 15:46:00 | sean-k-mooney | *two | |
| 15:46:22 | sean-k-mooney | but if we need to add anything else we can do that quickly once its done | |
| 15:47:08 | jsuchome | well that allowed_direct_url_schemes is a must, we only fire the new download handler if it is set | |
| 15:47:35 | sean-k-mooney | so we need that in nova i can see if that is set by the plugin | |
| 15:48:17 | dansmith | it won't be | |
| 15:48:23 | dansmith | I thought lyarwood did it in his change | |
| 15:48:47 | lyarwood | sorry I missed that | |
| 15:48:56 | lyarwood | [glance]/allowed_direct_url_schemes=['rbd']? | |
| 15:49:10 | sean-k-mooney | ya i was about to ask the same https://opendev.org/openstack/nova/src/branch/master/nova/conf/glance.py#L64 | |
| 15:49:32 | dansmith | lyarwood: not sure what group, but yes, hang on | |
| 15:49:53 | sean-k-mooney | its in the glance group | |
| 15:49:59 | jsuchome | yep | |
| 15:50:27 | dansmith | if 'rbd' in CONF.glance.allowed_direct_url_schemes: | |
| 15:50:27 | sean-k-mooney | do we plan to turn this on by default | |
| 15:50:36 | dansmith | no | |
| 15:50:49 | jsuchome | it should be documented | |
| 15:50:56 | sean-k-mooney | ok we proably should remove the deprecation of that option in jsuchome patch | |
| 15:51:01 | sean-k-mooney | i assume it already does that | |
| 15:51:22 | dansmith | the spec says we will undeprecate it yes | |
| 15:51:28 | sean-k-mooney | k | |
| 15:51:39 | jsuchome | does it need a release note? | |
| 15:51:46 | dansmith | yes | |
| 15:51:56 | sean-k-mooney | the feature would even without the undeprecation | |
| 15:52:01 | sean-k-mooney | the same one can cover both | |
| 15:52:39 | jsuchome | ok, than it's another change for 574301 | |
| 15:53:18 | dansmith | jsuchome: I probably wouldn't pile that in there personally | |
| 15:56:48 | jsuchome | OK, another patch, no problem | |
| 15:57:03 | dansmith | jsuchome: at least for the moment, we can always squash | |
| 15:57:24 | dansmith | I think that by the time you get all the test stuff in this patch it will be plenty meaty | |
| 15:57:54 | dansmith | one could argue that it could go in my first patch to remove the plug point, but that just means it has two semi-related atomic changes | |
| 15:57:57 | dansmith | patches are cheap | |
| 15:58:30 | jsuchome | yeah, and for tommorrow I got to work on the tests, I can see they are not enough | |
| 15:58:38 | dansmith | cool | |
| 16:09:26 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: WIP: allow disabling image cache for raw images https://review.opendev.org/727261 | |
| 16:09:30 | gibi | dansmith, sean-k-mooney: I looked at how easy is to disable the image cache and this is my first stab on it (seem to work in devstack) ^^ | |
| 16:10:19 | gibi | I will have to disappear now but feedback is appreciated | |
| 16:11:12 | dansmith | gibi: I don't understand that | |
| 16:13:52 | sean-k-mooney | dansmith: i assumed it was just me :) | |
| 16:14:19 | sean-k-mooney | also i expected to not underdstand that when looking at that code | |
| 16:18:44 | dansmith | yeah | |
| 16:19:05 | dansmith | I'll have to get all dug-in to that code again to really be able to speak intelligently about it, | |
| 16:19:15 | dansmith | but that surely seems to be basically doing the same thing as above at first glance | |
| 16:22:01 | dansmith | sean-k-mooney: ah, maybe because this is the Flat implementation | |
| 16:22:30 | dansmith | but I really thought that it still cached even though it flattened the image before giving it to the instance, which this doesn't seem to change | |
| 16:23:32 | sean-k-mooney | dansmith: it is cached | |
| 16:23:37 | sean-k-mooney | we copy it | |
| 16:23:48 | sean-k-mooney | on line 598 | |
| 16:24:00 | sean-k-mooney | https://review.opendev.org/#/c/727261/1/nova/virt/libvirt/imagebackend.py@598 | |
| 16:24:08 | dansmith | yeah | |
| 16:24:15 | dansmith | I wonder if gibi tested this and we're missing something, or he's assuming something else | |
| 16:24:37 | sean-k-mooney | well this would also have to be done for qcow right | |
| 16:24:38 | dansmith | sean-k-mooney: we only copy if it doesn't exist, and he's passing self.path as the target | |
| 16:24:54 | dansmith | but, so does the "if generating" case above | |
| 16:25:32 | sean-k-mooney | right so if self.path whcih shoudl be the imnstance disk path does not exist | |
| 16:25:33 | dansmith | so I wonder if we're normally in Flat to grab the base image, and this makes for another case where we just download the image to our target when not caching and that somehow bypasses, | |
| 16:25:44 | sean-k-mooney | before we would take the else path and create a copy form the base path | |
| 16:25:46 | dansmith | but I think the call path to the caching is too loopy to tell that | |
| 16:26:10 | sean-k-mooney | i think this will actully work but only for the flat backend | |
| 16:26:10 | dansmith | disabling the image cache entirely is also somewhat of a way-too-big hammer to solve this problem | |