Posted	Nick	Remark
#openstack-nova - 2020-05-05
21:09:42	artom	With this dict that gives cell and mq status for all cells and mqs
21:09:45	artom	*his
21:09:47	zigo	Everyone keeps disturbing me and I can't read IRC properly! :)
21:10:04	zigo	Sorry then.
21:10:25	artom	No worries :)
21:16:31	openstackgerrit	Merged openstack/nova master: Remove future imports https://review.opendev.org/714675
23:45:22	openstackgerrit	Merged openstack/nova master: Follow-up for NUMA live migration functional tests https://review.opendev.org/724903
23:57:35	openstackgerrit	Artom Lifshitz proposed openstack/nova stable/ussuri: Functional tests for NUMA live migration https://review.opendev.org/725736
#openstack-nova - 2020-05-06
06:34:29	openstackgerrit	Jie Li proposed openstack/nova master: replace the "hide_hypervisor_id" to "hw:hide_hypervisor_id" https://review.opendev.org/722187
06:58:22	openstackgerrit	Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301
07:29:28	openstackgerrit	Jie Li proposed openstack/nova master: replace the "hide_hypervisor_id" to "hw:hide_hypervisor_id" https://review.opendev.org/722187
07:31:52	ignaziocassano1	Hello, I solved live migration issue on EMC iscsi driver for cinder. They did not write multipath.conf needs skip_kpartx yes
07:32:36	ignaziocassano1	Without this parameter when a vm migrate the map in use error is reported
07:36:18	bauzas	good morning Nova
07:40:00	brinzhang	good morning, bauzas ^^
08:32:37	openstackgerrit	Tony Su proposed openstack/nova-specs master: Re-propose provider-config-file spec for Victoria https://review.opendev.org/725788
08:59:24	aarents	good morning
09:00:22	aarents	gibi bauzas I added 2 topics in vptg etherpad, if we have time for this.
09:03:23	bauzas	aarents: ack, will look
09:03:31	bauzas	I need to do some reviews this week
09:06:01	kashyap	sean-k-mooney: stephenfin: Hi, do you recall if Nova enables IOThreads at all?
09:06:05	kashyap	I know we don't have a way to configure them
09:06:11	stephenfin	no, it doesn't
09:06:54	stephenfin	there's a TODO but for now it's emulator threads that we support offloading
09:07:08	kashyap	stephenfin: TODO in the code? Got a pointer? /me goes digging in driver.py
09:08:27	stephenfin	kashyap: https://github.com/openstack/nova/blob/20.1.0/nova/virt/libvirt/driver.py#L4892-L4907
09:09:33	kashyap	stephenfin: Oh yeah, I recall this bit; thanks!
09:09:57	kashyap	stephenfin: This is a low-hanging fruit to improve performance.
09:12:20	openstackgerrit	Huaqiang Wang proposed openstack/nova-specs master: Use PCPU and VCPU in one instance https://review.opendev.org/725801
09:12:46	kashyap	stephenfin: I'm going to file a proper upstream tracker / blueprint for it (after checking if one exists)
09:13:11	kashyap	Doh, it does exist - https://blueprints.launchpad.net/nova/+spec/libvirt-iothreads
09:27:26	kashyap	stephenfin: Oh, looking at Gerrit history, I see there was an attempt to enable IOThreads: https://review.opendev.org/#/c/230968/
09:27:36	kashyap	stephenfin: Err, wrong channel :)
09:56:26	openstackgerrit	Lee Yarwood proposed openstack/nova master: compute: Validate a BDMs disk_bus when provided https://review.opendev.org/724842
09:58:15	openstackgerrit	Lee Yarwood proposed openstack/nova master: docs: Add evacuation pre-conditions around the src host https://review.opendev.org/723853
10:01:14	openstackgerrit	Merged openstack/nova master: doc: Fix list rendering in cli/nova-status.rst https://review.opendev.org/724958
11:40:07	openstackgerrit	jayaditya gupta proposed openstack/nova master: Support for --force flag for nova-manage placement heal_allocations command https://review.opendev.org/715395
11:56:20	openstackgerrit	Jie Li proposed openstack/nova master: replace the "hide_hypervisor_id" to "hw:hide_hypervisor_id" https://review.opendev.org/722187
12:15:59	gibi	bauzas: what do you think? Now that RC2 is out should we remove the rc tag from the bug https://bugs.launchpad.net/nova/+bug/1875418 ?
12:15:59	openstack	Launchpad bug 1875418 in OpenStack Compute (nova) "Generated policy.json in Ussuri is broken by default" [High,In progress] - Assigned to Ghanshyam Mann (ghanshyammann)
12:16:13	bauzas	on a meeting but okay
12:22:26	gibi	bauzas: thanks
13:10:09	sean-k-mooney	kashyap: no we dont enable iotrheads
13:10:21	sean-k-mooney	kashyap: so all io is handeled by the emulator thread
13:11:17	sean-k-mooney	kashyap: didnt we decided it was not worth it to enable iothread since we did not want yet another thing to request and the recomendation from the qemu folks was to leave it set to 1
13:12:31	sean-k-mooney	if the instance was pinned and the emulator thread type was shared i could maybe see use spawning 1 io tread per cpu in the shared pool and pinning the io threads to the shared ppol the same way we pinn the emulator thread to float over teh shared pool.
13:12:43	sean-k-mooney	or perhaps shared pool -1 io threads
13:13:23	sean-k-mooney	but i dont think we should bother enableing them for floating vms and im not sure there would be a significant imporvment for pinned instnaces
13:31:23	openstackgerrit	Stephen Finucane proposed openstack/nova master: replace the "hide_hypervisor_id" to "hw:hide_hypervisor_id" https://review.opendev.org/722187
13:54:44	stephenfin	kashyap, sean-k-mooney: Yeah, I was pretty sure danpb or you (kashyap) had said that the benefits weren't justified and emulator thread offloading got us most of the way there
13:56:16	francoisp	lyarwood hello, when you have time: https://review.opendev.org/#/c/725272/ (for Rocky this time around) - thanks!
13:58:42	kashyap	sean-k-mooney: stephenfin: So this morning, QEMU Block Layer folks pinged me to discuss this
13:59:07	kashyap	sean-k-mooney: stephenfin: And they said they're going to publish benchmarks proving that it _is_ a well-worth to enable IOThreads by default
13:59:30	kashyap	sean-k-mooney: stephenfin: Let's wait for the documentation / blog post to come, I'll post it here, then we can discuss
14:00:10	kashyap	stephenfin: Your recollection is right; but for the past 2 years QEMU has done a tonne of rework in this area. So it worth it to revisit the topic
14:01:35	openstackgerrit	Takashi Kajinami proposed openstack/nova master: conf: Add three new '[libvirt] live_migration_*' options https://review.opendev.org/456571
14:03:54	openstackgerrit	Merged openstack/nova master: Remove stale nested backport from InstancePCIRequests https://review.opendev.org/721667
14:06:19	kashyap	stephenfin: sean-k-mooney: Also the enablement is not a mere value of 1 or -1, but a bit more rigorous approach based on minimum of (a) devices, (b) vCPUs, and (c) host CPUs.
14:06:41	openstackgerrit	Takashi Kajinami proposed openstack/nova master: conf: Add three new '[libvirt] live_migration_*' options https://review.opendev.org/456571
14:06:45	kashyap	Let's wait for the documentation series to show up.
14:27:23	openstackgerrit	Lee Yarwood proposed openstack/nova master: block_device: Use initialize APIs to refresh when reported as idempotent https://review.opendev.org/720769
14:42:03	openstackgerrit	Stephen Finucane proposed openstack/nova master: objects: Add migrate-on-load behavior for legacy NUMA objects https://review.opendev.org/724381
14:52:28	stephenfin	dansmith: Can you take a look at https://review.opendev.org/#/c/724381 again when you've a chance?
14:52:58	stephenfin	Also, I assume if that's the way we're going, I can abandon https://review.opendev.org/#/c/537414/
15:16:47	openstackgerrit	Takashi Kajinami proposed openstack/nova master: conf: Add three new '[libvirt] live_migration_*' options https://review.opendev.org/456571
15:17:47	openstackgerrit	Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301
16:44:26	stephenfin	bauzas: Looks like the multiple vGPU tests are a bit racey https://zuul.opendev.org/t/openstack/build/48123952eb1048efb76be65bb1893c99/console
16:44:30	stephenfin	*functional tests
16:44:50	openstackgerrit	Stephen Finucane proposed openstack/nova stable/ussuri: Remove stale nested backport from InstancePCIRequests https://review.opendev.org/725931
16:44:59	openstackgerrit	Stephen Finucane proposed openstack/nova stable/train: Remove stale nested backport from InstancePCIRequests https://review.opendev.org/725932
16:45:48	openstackgerrit	Stephen Finucane proposed openstack/nova stable/train: Remove stale nested backport from InstancePCIRequests https://review.opendev.org/725932
16:59:35	bauzas	stephenfin: ack, I'm off the keyboard now, but please revert the test_multiple_instance_create() method if you think it's racey a lot
17:18:26	openstackgerrit	Takashi Kajinami proposed openstack/nova master: conf: Add three new '[libvirt] live_migration_*' options https://review.opendev.org/456571
18:03:30	openstackgerrit	Takashi Kajinami proposed openstack/nova master: conf: Add four new '[libvirt] live_migration_*' options https://review.opendev.org/456571
21:50:47	zigo	artom: https://review.opendev.org/724684 +1 ? :)
22:12:14	artom	zigo, I guess? What did we agree to about docs?
22:12:24	artom	IIUC we're doing to document it in the project docs for now?
22:12:44	zigo	I don't remember TBH.
22:13:16	zigo	I was really busy yesterday having Keystone's latest security fix tested in Debian ... (now I can publicly talk about it...)
22:14:07	zigo	artom: What should I document exactly? That /healthcheck can be used?
22:14:13	zigo	How to disable it?
22:15:48	artom	zigo, so I would say release note at the very least (are you familiar with our reno tool?)
22:15:57	artom	zigo, and then something like https://docs.openstack.org/keystone/latest/admin/health-check-middleware.html
22:16:29	zigo	I did write some notes with reno in the past, though that skill is probably rusted...
22:16:31	zigo	:)
22:17:05	artom	zigo, also, I'd be weary of making you do more work before there's core consensus
22:17:20	artom	I'm just a random dev, my opinion holds less weight ;)
22:18:15	artom	OTOH, the attempt to reach consensus appears to be older than my daughter, so... :)
22:20:35	zigo	artom: How old is she? :)
22:20:44	artom	zigo, 6
22:20:48	zigo	Like mine...
22:21:04	zigo	Got an older boy too (he's 8).
22:21:22	artom	Our is 4
22:22:46	openstackgerrit	Thomas Goirand proposed openstack/nova master: Add a /healthcheck URL https://review.opendev.org/724684
22:22:49	zigo	Release note added.
22:23:15	zigo	I also did the same kind of work for Cinder and wrote a functional test there too! This time, on my own... :P
22:23:54	artom	\o/
22:23:58	artom	Transferable skills!
22:37:47	artom	zigo, replied, see review. Sorry no +1 yet :( And now, dinner :)
22:41:30	zigo	ok

Earlier   Later