| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-05-05 | |||
| 08:48:11 | gibi | bauzas: no problemo :) | |
| 08:48:24 | bauzas | gibi: well, it could be nice to have it | |
| 08:48:41 | bauzas | gibi: also I found why you can't +2 on stable/ussuri | |
| 08:48:55 | bauzas | not because you aren't nova-stable-corte | |
| 08:48:56 | bauzas | core* | |
| 08:49:17 | bauzas | but rather b/c the release mgmt team stopped changing ACLs | |
| 08:49:38 | bauzas | eg. https://github.com/openstack/project-config/commit/72b4071c8206586afa6a1ec2ec40f63a104c1550 | |
| 08:50:24 | gibi | I see. I did not know we had such rule changes in the past | |
| 08:50:44 | gibi | I'm fine not having a stable hat now. And so far we managed without it | |
| 08:51:34 | bauzas | gibi: fwiw, stephenfin proposed to just have nova-stable-core == nova-core | |
| 08:51:40 | bauzas | in the PTG etherpad | |
| 08:51:50 | bauzas | so we will discuss this in June anyway | |
| 08:52:14 | bauzas | (honestly, I'm +1 with this) | |
| 08:52:14 | gibi | bauzas: yepp, we can discuss that and I'm not having anything right now against a simpler structure | |
| 08:52:38 | bauzas | actually | |
| 08:52:50 | bauzas | nova-stable-core = nova-core + other people | |
| 08:53:09 | bauzas | (ie. just adding nova-core as a subteam for nova-stable-core) | |
| 08:54:08 | gibi | yepp | |
| 09:09:51 | bauzas | gibi: sent https://review.opendev.org/#/c/723884/ to the gate | |
| 09:10:14 | gibi | bauzas: ack, thanks. I will propose a backport to stable/ussuri after it merges | |
| 09:10:27 | bauzas | gibi: since this one was tagged for ussuri, yeah we could do a RC2 | |
| 09:10:34 | bauzas | gibi: that said, it's not a regression | |
| 09:10:46 | bauzas | gibi: so we could just merge it *after* RC1 | |
| 09:10:48 | gibi | yepp, I just want to have clean do in the release if possible | |
| 09:10:50 | bauzas | it's docs | |
| 09:10:58 | gibi | s/do/doc/ | |
| 09:11:09 | bauzas | so having it either for 20.0.0 or 20.0.1 doesn't change | |
| 09:11:21 | gibi | it changes when we release that. | |
| 09:11:30 | bauzas | not really, this is docs | |
| 09:11:37 | gibi | if we can add the doc in RC2 then it will be part of the next week release | |
| 09:11:48 | gibi | if not then the doc will be part of a later point release | |
| 09:11:51 | bauzas | gibi: say we merge it 1 second after GA | |
| 09:12:03 | bauzas | we won't need to tag a .z version | |
| 09:12:10 | bauzas | as it's a doc | |
| 09:12:59 | gibi | bauzas: do you mean it does not matter as the doc is alwas generated to the web from the tip of the stable branch? | |
| 09:16:13 | bauzas | gibi: what I mean is that the docs website will be changed by a zuul post pipeline once the change is merged | |
| 09:16:16 | bauzas | (AFAIK) | |
| 09:16:31 | bauzas | (I'm an infra specialist) | |
| 09:16:54 | gibi | OK, I think I see your point. Then I propose the RC2 release now | |
| 09:18:24 | bauzas | (the fact that the docs website is changed by a post pipeline without needing to tag a stable version) | |
| 09:18:25 | gibi | bauzas: https://review.opendev.org/725517 RC2 patch | |
| 09:18:32 | bauzas | ack thanks | |
| 09:18:38 | bauzas | we can do a RC3 anyway if needed | |
| 09:19:02 | gibi | OK | |
| 09:22:32 | bauzas | zigo: fwiw, zuul said +1 :p | |
| 09:22:37 | bauzas | zigo: https://review.opendev.org/#/c/724684/8 | |
| 09:32:21 | zigo | bauzas: Yeah, great, I'll fix the app thingy ! :) | |
| 09:33:41 | bauzas | zigo: I think that oslo.middleware now has the default backend to be disable_by_file | |
| 09:35:19 | openstackgerrit | Nalini Varshney proposed openstack/nova master: Add migration to make key field type VARBINARY in aggregate_metadata table, https://review.opendev.org/725522 | |
| 09:51:00 | stephenfin | bauzas: gibi: Care to push this dead-simple patch through? https://review.opendev.org/#/c/714675/ | |
| 09:51:35 | bauzas | stephenfin: still doing a bit of laundry ? | |
| 09:51:49 | stephenfin | it's a constant battle :( | |
| 09:53:00 | bauzas | just program the washing machine for 60 degrees | |
| 09:56:25 | bauzas | stephenfin: I also found https://github.com/openstack/nova/blob/master/tools/db/schema_diff.py#L45 | |
| 09:56:34 | bauzas | should we also change it ? I think so | |
| 09:56:57 | stephenfin | Yeah, we should. Don't know how I missed that. Lemme respin | |
| 09:57:34 | gibi | I missed the same thing as I grepped only in the nova/ subdir | |
| 09:58:32 | bauzas | unfortunately, we also support those tools :( | |
| 09:59:14 | bauzas | without saying, I also tested 'import __future__." | |
| 09:59:24 | bauzas | but nothing is using this way | |
| 10:00:45 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove future imports https://review.opendev.org/714675 | |
| 12:20:09 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Support for --force flag for nova-manage placement heal_allocations command https://review.opendev.org/715395 | |
| 12:31:11 | openstackgerrit | Merged openstack/python-novaclient master: Remove mock in lower-constraints.txt https://review.opendev.org/724956 | |
| 13:13:24 | openstackgerrit | Merged openstack/nova master: Add nested resource providers limit for multi create https://review.opendev.org/723884 | |
| 13:46:59 | openstackgerrit | Jiri Suchomel proposed openstack/nova master: WIP: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301 | |
| 13:46:59 | openstackgerrit | Jiri Suchomel proposed openstack/nova master: Remove deprecated nova.image.download hook https://review.opendev.org/725338 | |
| 13:50:07 | openstackgerrit | Merged openstack/nova master: Don't show upgr note for policy validation in V https://review.opendev.org/725226 | |
| 14:57:59 | openstackgerrit | Takashi Natsume proposed openstack/python-novaclient master: [WIP] Switch legacy Zuul jobs to native Zuul v3 jobs https://review.opendev.org/725163 | |
| 15:25:12 | bauzas | zigo: do you want me to propose a new revision for using a healthcheck app instead of a wsgi middleware ? | |
| 15:26:13 | zigo | bauzas: I know how to do it, but if you have time, that'd be great. I'm a bit swamped testing the fix for [censored-because-embargoed]. | |
| 15:26:23 | bauzas | kk | |
| 16:34:23 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add a /healthcheck URL https://review.opendev.org/724684 | |
| 16:34:53 | bauzas | zigo: been there, done that ^ | |
| 17:49:10 | artom | dansmith, o/ Could you look over the NUMA LM fup patch: https://review.opendev.org/#/c/724903/ ? | |
| 17:50:17 | dansmith | yup in a bit | |
| 17:56:56 | gmann | bauzas: zigo +1 on idea of healthcheck but there are few things we should discuss. like adding nova specific backends like DB checks, compute service checks etc. how about adding a spec for that so that we do not miss the things. | |
| 18:00:02 | gmann | added in PTG etherpad also. | |
| 18:32:48 | gmann | cores- this is ready. making py38 functional job on gate - https://review.opendev.org/#/c/725372/ | |
| 18:52:19 | dansmith | artom: I really hate the assertTrue($not_a_bool) and I thought we even had hacking rules to prevent tat | |
| 18:52:29 | dansmith | artom: wouldn't assert_is_instance be better? | |
| 18:53:02 | artom | dansmith, it would | |
| 18:53:29 | dansmith | artom: wanna change it real quick and I'll fast approve assuming stephenfin would be fine with it given it still fits the pattern he wanted? | |
| 18:53:55 | artom | dansmith, on it | |
| 18:54:02 | dansmith | thanks | |
| 19:02:34 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Follow-up for NUMA live migration functional tests https://review.opendev.org/724903 | |
| 19:02:43 | artom | dansmith, ^^ there we go | |
| 19:03:21 | artom | Hol'up, I did a stupid | |
| 19:04:51 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Follow-up for NUMA live migration functional tests https://review.opendev.org/724903 | |
| 19:05:14 | artom | OK, stupid un-did | |
| 19:05:21 | dansmith | didn't you miss a bunch? | |
| 19:05:58 | artom | Of assertTrues? | |
| 19:06:25 | artom | Did I? There are some left, but they're actually checking booleans | |
| 19:06:57 | dansmith | artom: but.. assertFalse should be assertIsNone, no? | |
| 19:08:45 | artom | That implies I'm capable of thinking for myself about the larger picture | |
| 19:09:24 | dansmith | aren't you just a small search-and-replace lamba function in the cloud somewhere? | |
| 19:10:02 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Follow-up for NUMA live migration functional tests https://review.opendev.org/724903 | |
| 19:10:32 | artom | :( | |
| 19:11:16 | artom | My inputs are beer and hugs, and my output is sadness | |
| 19:11:24 | dansmith | lol | |
| 19:12:25 | dansmith | artom: before I whack this, you agree that this jives with stephenfin's ask right? I don't want to be reverting his vote | |