Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-04-15
14:21:20 sean-k-mooney gibi: regarding https://bugs.launchpad.net/nova/+bug/1863038 nova should be seting the instanace.host to the ironic node uuid right and we should be setting the instance.host in the neutron port binding profie to
14:21:20 openstack Launchpad bug 1863038 in OpenStack Compute (nova) "Nova need to consider ironic node as 'host'" [Wishlist,Confirmed]
14:22:12 sean-k-mooney i can go check that but i would be suprised if we are pasing the comput node host instead of the hypervior host in the call to neutron
14:24:35 gibi I also would need to read the code to be sure about what we set node or host
14:27:25 sean-k-mooney looking at teh migration code we are using instance.host im looking now at some of the other code paths but we appear to be using instance.host in most case if not all
14:29:19 sean-k-mooney gibi: i guess allocate for instance delegates to the driver https://github.com/openstack/nova/blob/01da968978db8c01920616fe594bea6eda2cba57/nova/compute/manager.py#L1724
14:30:14 sean-k-mooney which for ironic retuns none https://github.com/openstack/nova/blob/01da968978db8c01920616fe594bea6eda2cba57/nova/virt/ironic/driver.py#L1795
14:30:47 gmann bauzas: correct, almost all of our admin_or_owner has this issue. founded and fixed in policy defaults work
14:32:11 bauzas gmann: I just rechecked the patch
14:33:09 sean-k-mooney gibi: they do the vif attach here https://github.com/openstack/nova/blob/01da968978db8c01920616fe594bea6eda2cba57/nova/virt/ironic/driver.py#L1545-L1546
14:33:52 gmann thanks
14:34:11 sean-k-mooney also using the uuid so this fells like either an ironic bug or not a bug at all that said i have not traced all the codepaths so there still could be a nova bug but i doubt it.
14:35:33 gibi sean-k-mooney: thanks for the analysis. I deferr this to the PTG discussion. It is clearly not a regression to deal with now
14:35:49 sean-k-mooney gibi: well im not sure the bug report is valid
14:36:11 sean-k-mooney e.g. i dont know if we actully are using the host it looks like we shoudl be useing the ironic node uuid
14:37:51 gibi sean-k-mooney: I think the reporter also said that for ironic case neutron gets the node uuid and try to use that as a host for the nova host aggregate API
14:39:36 sean-k-mooney well there is some weirdnes with host aggreates and ironic node
14:40:12 sean-k-mooney its not clear to me if we expect each compute serivce to be a member of the host aggreate or each compute/ironic node
14:41:03 sean-k-mooney i think in the ironic case we would want each fo the ironic nodes to be set as member of the hsot aggreate
14:41:19 sean-k-mooney since they can move between compute services
14:41:52 sean-k-mooney they code they linked too however is querying placment
14:41:54 sean-k-mooney https://github.com/openstack/neutron/blob/master/neutron/services/segments/plugin.py#L253
14:42:50 gibi sean-k-mooney: I think neutron creates a host aggregate that is then mapped to placement aggregate by nova and then neutron puts the IP RP to into that placement aggregate
14:43:15 gibi or something like that (it is pretty complicate)
14:43:30 sean-k-mooney gibi: neutron should be creating both a RP and hostaggreate makeing the RP a sharing resouce provider of ips
14:43:51 hrw bauzas: https://review.opendev.org/714425 (AMD SEV check) updated with tests
14:44:45 sean-k-mooney hrw: that looks like an optimiation
14:44:53 sean-k-mooney is this breaking something if so you shoudl file a bug
14:47:00 gibi sean-k-mooney: so for ironic neturon gets the node uuid for libvirt neutron gets the hostname and the neutron in both case use the given id as a member of an aggregate but in nova host aggregates works on compute host level not on compute node level
14:48:18 sean-k-mooney gibi: well this is all handeld at the compute manager level
14:48:33 sean-k-mooney for everythign other then ironic it gets the instance.host
14:48:37 gibi yepp
14:48:45 gibi this is the key difference
14:48:47 sean-k-mooney for ironic it gets the node uuid
14:48:57 sean-k-mooney the instance.host shoudl be the node uuid
14:49:05 sean-k-mooney in the ironic case
14:49:09 sean-k-mooney so it shoudl be the same
14:49:28 gibi yepp, but I don't think you can add a node to a nova host aggregate
14:49:35 gibi you can only add a host there
14:50:04 sean-k-mooney isnint instance.host always set to the hypervior hostname
14:50:35 sean-k-mooney so i think the neutron code only ever works in that case because for non ironic host the hypervior hostname and compute service host are the same
14:50:51 gibi yepp, that could be the case
14:51:24 hrw sean-k-mooney: it does not break anything. just looks weird when on aarch64 host I see checks of x86 features in log
14:51:39 sean-k-mooney hrw: its not an x86 feature
14:51:45 sean-k-mooney its not part of the instuction set
14:51:50 sean-k-mooney its an AMD extention
14:51:56 hrw sean-k-mooney: AMD SVE is not aarch64 feature as well ;D
14:52:12 sean-k-mooney yes but its incrrect to call it x86
14:52:44 hrw sean-k-mooney: when you run 'lscpu' it is listed in features. along with 'I can run KVM' which is not part of ISA iirc too
14:53:29 sean-k-mooney sure but the feature are not instuctionsets
14:53:56 sean-k-mooney several of the security flaws are listed as "features" too
14:54:31 sean-k-mooney anyway if you file a bug for that patch im +1 on it
14:54:51 hrw sean-k-mooney: looking at history of amd64/x86-64/x64 it is sometimes hard to notice who copied who ;D
14:56:20 sean-k-mooney well that is irrelevent to this conversation but x64 was itainiaum amd64 is the 64 bit extentison amd developed and x86_64 is the name for x86 with the amd64 extnetions intel licened form amd
14:56:21 hrw sean-k-mooney: ok
14:56:39 hrw ia64 was itanium. x64 is ms name for x86-64/amd64
14:57:13 sean-k-mooney ah yep correct
14:58:03 hrw my previous (x86-64) laptop has 'Intel Itanium Inside' sticker on it - for pure fun of it
15:02:15 melwitt gibi, slaweq: we need to merge the train backport in order to see the bug disappear because grenade runs train first, then upgrades to ussuri https://review.opendev.org/718934
15:03:08 gibi melwitt: bahh, you are correct. /o\ putting the bug back to FixReleased state
15:04:30 melwitt and that patch was stuck behind https://review.opendev.org/719120 but that merged, so it is good to review now
15:04:51 gibi elod, lyarwood: could you please look at ^^ ?
15:07:40 openstackgerrit Marcin Juszkiewicz proposed openstack/nova master: libvirt: check for AMD SEV only on x86-64 https://review.opendev.org/714425
15:07:52 hrw sean-k-mooney: bug created, linked
15:08:55 elod gibi melwitt : this one, right? https://review.opendev.org/#/c/718934/ anyway, looking
15:09:17 gibi elod: yepp, that one, thanks
15:14:37 lyarwood gibi / melwitt ; ack done
15:16:01 gibi lyarwood: thnks
15:27:40 openstackgerrit Ghanshyam Mann proposed openstack/nova stable/stein: Use placement stable version for functional job https://review.opendev.org/719121
15:34:39 gibi bauzas: releasing bug triage lock as I'm leaving for today
15:34:51 bauzas gibi: ack, will continue then
15:35:08 bauzas gibi: I triaged a couple of in-progress, nothing crucial
15:35:09 melwitt stephenfin: fyi brief discussion from yesterday on the possibility of bringing back the ability to show user_data in the cli with a switch http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2020-04-14.log.html#t2020-04-14T22:59:39
15:35:41 gibi bauzas: thanks. nothing RC blocking on my side either
15:54:09 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in servers attributes policies https://review.opendev.org/719730
15:54:33 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing remaining servers policies https://review.opendev.org/720104
15:54:41 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in remaining servers Policies https://review.opendev.org/720106
15:54:50 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in remaining servers policies https://review.opendev.org/720116
16:16:17 openstackgerrit Merged openstack/nova master: fup: Remove the use of the term `unstable rescue` INFO logs https://review.opendev.org/718451
16:16:24 openstackgerrit Merged openstack/nova master: fup: Add missing docstrings from get_rescue_device|bus diskinfo funcs https://review.opendev.org/718464
16:24:25 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: libvirt: Calculate disk_over_committed for raw instances https://review.opendev.org/718964
16:28:39 gmann melwitt: lyarwood stein backport is ready now (train is merges) - https://review.opendev.org/#/c/719121/
16:29:32 openstackgerrit Merged openstack/nova master: libvirt: Change UEFI check to handle AArch64 better https://review.opendev.org/714311
16:29:58 melwitt gmann: I thought you were gonna re-cherry-pick that one from the train change and remove the conflict note from the commit message?
16:32:18 hrw yay ;D
16:32:53 gmann melwitt: there was conflict form train also due to deps url
16:33:10 melwitt gmann: haha oh
16:33:30 gmann due to git.openstack.org and opendev.org
16:33:53 melwitt nevermind then
16:35:18 hrw does https://review.opendev.org/#/c/712607/ needs another 7h recheck?
16:38:29 openstackgerrit Lee Yarwood proposed openstack/nova master: fup: Fix [workarounds]/rbd_volume_local_attach config docs https://review.opendev.org/718100
16:39:08 lyarwood stephenfin: ^ no idea how that ended up in merge conflict, can you +W that again if it's still okay?
16:41:46 sean-k-mooney huh i taught that already merged honestly
16:42:12 openstackgerrit Marcin Juszkiewicz proposed openstack/nova master: [WIP] CI: add tempest-integrated-compute-aarch64 job https://review.opendev.org/714439
16:42:14 sean-k-mooney oh it did this is just a fix up for the config
16:49:34 stephenfin melwitt: I saw that, but wasn't sure what the conclusion was
16:50:27 melwitt stephenfin: no conclusion yet, wanted to see what you thought about it
16:50:47 melwitt since you had removed the user_data, what you thought about adding it back but by flag only
16:51:51 stephenfin Realistically I don't think we'd ever want that information included in raw format as part of the show command, but we clearly want it somehow. How about a new command?
16:54:27 melwitt I guess that seems heavier than what I was imagining. to just have it be like nova show --include-user-data or something like that

Earlier   Later