| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-04-15 | |||
| 01:58:30 | brinzhang_ | In _cleanup_when_reschedule_fails()[1] we clean the arqs if _create_and_bind_arqs() failed, but I think we just only clean it at L847 if the _create_and_bind_arqs() failed [3]. If we add "compute_utils.delete_arqs_if_needed(context, instance)"[2] in _cleanup_when_reschedule_fails()[1], once we call _cleanup_when_reschedule_fails() it will be cleanup arqs with dp name in instance's flavor, I think that will increase Nova's call to Cyborg (by | |
| 01:58:30 | brinzhang_ | cyborgclinet), right? | |
| 01:58:43 | brinzhang_ | [1]https://opendev.org/openstack/nova/src/branch/master/nova/conductor/manager.py#L582 | |
| 01:58:51 | brinzhang_ | [2]https://opendev.org/openstack/nova/src/branch/master/nova/conductor/manager.py#L598 | |
| 01:58:57 | brinzhang_ | [3]https://opendev.org/openstack/nova/src/branch/master/nova/conductor/manager.py#L848-L849 | |
| 01:59:16 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in remaining servers policies https://review.opendev.org/720116 | |
| 02:00:24 | brinzhang_ | IMO, if I am correct, I think we should move "compute_utils.delete_arqs_if_needed(context, instance)"[2] to the right place, i.e., when _create_and_bind_arqs() failed | |
| 02:05:00 | gmann | johnthetubaguy: i replied on server policies comments and finished the remaining one. please check. my worried is to allow host attr for project that is why i kept them system-admin for now | |
| 02:20:21 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix follow up comments on policy work https://review.opendev.org/717835 | |
| 02:23:37 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Use oslo policy flag to disable default change warning instead of all https://review.opendev.org/717884 | |
| 03:10:20 | openstackgerrit | Merged openstack/nova master: Introduce scope_types in quota set Policies https://review.opendev.org/719317 | |
| 03:44:48 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix server actions to be system and project scoped https://review.opendev.org/720123 | |
| 05:56:03 | openstackgerrit | Merged openstack/nova master: Add new default roles in server group policies https://review.opendev.org/717175 | |
| 06:35:39 | openstackgerrit | Merged openstack/nova master: Add new default roles in quota sets policies https://review.opendev.org/719361 | |
| 06:45:13 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add doc for policy new defaults https://review.opendev.org/720129 | |
| 07:05:38 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix server actions to be system and project scoped https://review.opendev.org/720123 | |
| 07:25:21 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in remaining servers policies https://review.opendev.org/720116 | |
| 07:37:10 | bauzas | good morning Nova | |
| 07:38:52 | gibi | bauzas: good morning | |
| 07:39:52 | bauzas | gibi: good news, now that I'm done with the last series I had to work on, I'll do upstream bug triage today \o/ | |
| 07:40:37 | bauzas | it's been a while | |
| 07:42:18 | bauzas | gibi: stephenfin: sean-k-mooney: lyarwood: since you reviewed the vGPU multiple types series, you could be interested in that quite easy series for fixing cold migration issues for vGPUs | |
| 07:42:45 | bauzas | tl;dr: that's just adding a new argument to resize virt methods and just calling a new method | |
| 07:42:59 | bauzas | the main review is just for the functional test | |
| 07:43:08 | gibi | bauzas: \o/ | |
| 07:43:43 | gibi | bauzas: hit me with the link | |
| 07:44:01 | bauzas | gibi: https://review.opendev.org/#/c/712741 and below | |
| 07:44:47 | gibi | thanks | |
| 07:44:55 | bauzas | gibi: thanks for you :p | |
| 07:45:18 | gibi | bauzas: I'm looking at https://bugs.launchpad.net/nova/+bug/1868033 so you can skip that | |
| 07:45:18 | openstack | Launchpad bug 1868033 in OpenStack Compute (nova) "Booting instance with pci_device fails during rocky->stein live upgrade" [High,New] | |
| 07:45:27 | bauzas | gibi: ack | |
| 07:48:44 | bauzas | 103 bugs... :( | |
| 07:54:12 | gibi | and I already triaged couple of yesterday :) | |
| 07:54:23 | gibi | at least we won't be bored | |
| 07:59:22 | bauzas | gibi: yeah, my main worries go to find some potential bugs that are Ussuri regressions | |
| 08:10:10 | bauzas | gibi: heh, from what I can see, nothing really changes from my day-to-day internal bug triage https://bugs.launchpad.net/nova/+bug/1777608 | |
| 08:10:10 | openstack | Launchpad bug 1777608 in OpenStack Compute (nova) "Nova compute calls plug_vifs unnecessarily for ironic nodes in init_host" [Medium,New] | |
| 08:10:22 | bauzas | gibi: sorry if you feel getting trampled by OSP :p | |
| 08:11:48 | gibi | :) | |
| 08:18:34 | bauzas | lyarwood: looks a valid bug, do you confirm ? | |
| 08:18:38 | bauzas | whoops | |
| 08:18:42 | bauzas | lyarwood: https://bugs.launchpad.net/nova/+bug/1871861 | |
| 08:18:42 | openstack | Launchpad bug 1871861 in OpenStack Compute (nova) "Share the snapshot of volume-backed instance to other tenant, but can not build instance with this image." [Undecided,New] | |
| 08:23:27 | nightmare_unreal | sean-k-mooney: I saw your comments/review here : https://review.opendev.org/#/c/715395/ . I have added my draft, what do you suggest ? | |
| 08:23:37 | nightmare_unreal | Thanks | |
| 08:23:43 | lyarwood | bauzas: looking | |
| 08:23:58 | bauzas | lyarwood: tl;dr: glance allowed to share an image | |
| 08:24:18 | bauzas | lyarwood: another tenant can take this image to build an volume-baked instance | |
| 08:24:30 | bauzas | lyarwood: but this fails miserably | |
| 08:24:44 | lyarwood | bauzas: yeah the issue is it's not an image, it's just a metadata store pointing to the volume snapshot that's in the other tenant still | |
| 08:25:08 | bauzas | but then a cinder bug, correct ? | |
| 08:25:24 | bauzas | we just get the metadata from cinder, nope ? | |
| 08:25:37 | lyarwood | bauzas: yeah it's a cinder feature bug | |
| 08:25:58 | lyarwood | well, between glance and cinder at least | |
| 08:25:58 | bauzas | lyarwood: thanks, I'm done with this bug | |
| 08:26:14 | bauzas | we're talking about upstream bug triage | |
| 08:26:23 | bauzas | I just want the cinder folks to look at it | |
| 08:26:39 | lyarwood | tbh there might be a way of forcing the data to actually end up in glance | |
| 08:26:46 | lyarwood | ack yeah | |
| 08:26:55 | lyarwood | I'll take a look quickly but I'll leave it to them if I can't find anything | |
| 08:34:09 | johnthetubaguy | lyarwood: do cinder do volume snapshot sharing between tenants? | |
| 08:34:33 | johnthetubaguy | (or get glance to copy it, I guess) | |
| 08:36:43 | bauzas | johnthetubaguy: I feel this bug will potentially require a cross-project effort in order to get fixed | |
| 08:36:52 | bauzas | (but there could be duplicates) | |
| 08:36:55 | johnthetubaguy | bauzas: sounds like it | |
| 08:37:19 | johnthetubaguy | I mean, I actually don't think nova should do anything here, but I would say that :P | |
| 08:37:31 | lyarwood | johnthetubaguy: yeah I was thinking you could force the upload into glance to workaround | |
| 08:38:02 | johnthetubaguy | lyarwood: I was thinking glance forces an upload into cinder for the additional project, but either way I guess | |
| 08:38:57 | lyarwood | that could also work, at least c-api/c-vol can offload things to the backends that way | |
| 08:41:29 | bauzas | johnthetubaguy: feel free to add nova as a related project to the bug then ;) | |
| 08:41:47 | bauzas | johnthetubaguy: I only marked cinder, but obviously glance and maybe nova could be added | |
| 08:58:54 | bauzas | gibi: I've seen you started to look at https://bugs.launchpad.net/nova/+bug/1871583 | |
| 08:58:54 | openstack | Launchpad bug 1871583 in OpenStack Compute (nova) "Migrate the instance, the destination host is not specified. When the "destination host" == " source host" , will set the instance's state error." [Undecided,New] - Assigned to Qiu Fossen (fossen123) | |
| 08:59:44 | bauzas | gibi: I'm confused with the exception | |
| 09:01:03 | bauzas | gibi: so, libvirt doesn't support resizing to the same host | |
| 09:01:56 | bauzas | hence the exception | |
| 09:02:12 | bauzas | anyway, nevermind | |
| 09:02:18 | bauzas | I think what to triage | |
| 09:02:22 | bauzas | what/how | |
| 09:06:48 | slaweq | gibi: hi | |
| 09:07:06 | slaweq | gibi: I was hoping that when https://review.opendev.org/#/c/717662/ will be merged, we will be good with grenade jobs finally | |
| 09:07:29 | slaweq | gibi: but I saw job from yesterday which failed again https://7ad29d1b700c1da60ae0-1bae5319fe4594ade335a46ad1c3bcc9.ssl.cf2.rackcdn.com/717083/5/check/neutron-grenade-multinode/2be9497/logs/grenade.sh.txt | |
| 09:07:50 | slaweq | gibi: can You maybe take a look if that is some new issue or still the same? | |
| 09:07:54 | slaweq | thx in advance | |
| 09:14:48 | hrw | https://review.opendev.org/#/c/712607/ has two +2, has +W, has +1 from zuul. needs recheck to go to gate? | |
| 09:16:55 | bauzas | hrw: looking | |
| 09:17:13 | hrw | bauzas: thx | |
| 09:18:01 | hrw | bauzas: I am looking at rebasing https://review.opendev.org/#/c/714439/ on top of 712607 and https://review.opendev.org/#/c/714311/ but without changing them again. | |
| 09:21:50 | bauzas | hrw: okay, so two things | |
| 09:22:02 | bauzas | hrw: yes you need to recheck 712607 | |
| 09:22:31 | bauzas | hrw: and if you rebase 714439 on top of ^, then 712607 will also be checked | |
| 09:23:01 | bauzas | hrw: do you know http://zuul.openstack.org/status ? | |
| 09:23:17 | hrw | bauzas: yes. I even wrote userscript for it | |
| 09:23:33 | hrw | just not familar with nova jobs | |
| 09:23:40 | bauzas | all cool then, you can see what goes into th check pipeline | |
| 09:23:44 | bauzas | the* | |
| 09:24:06 | bauzas | hrw: nothing really here is related to nova jobs, it's just zuul ordering | |
| 09:24:23 | bauzas | (and gerrit) | |
| 09:24:23 | hrw | bauzas: can you look at https://review.opendev.org/#/c/714425/ too? simple 'check for SEV only on x86' patch | |