| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-04-13 | |||
| 14:06:38 | gmann | alex_xu: ping, if you are online ? | |
| 14:06:50 | alex_xu | gmann: yea, i'm here | |
| 14:07:19 | gmann | alex_xu: can you please review this to unblock gate. \ - https://review.opendev.org/#/c/719318/ | |
| 14:07:43 | alex_xu | gmann: let me check | |
| 14:07:57 | gmann | alex_xu: thanks. its doc job fix | |
| 14:08:30 | alex_xu | gmann: yea, it is pretty simple, so jsut +w | |
| 14:08:45 | gmann | alex_xu: yeah. thanks. | |
| 14:08:50 | alex_xu | gmann: np | |
| 15:21:27 | openstackgerrit | Merged openstack/nova master: doc: Fix term mismatch warnings in glossary https://review.opendev.org/719318 | |
| 16:24:18 | openstackgerrit | Ghanshyam Mann proposed openstack/nova stable/train: Use placement stable version for functional job https://review.opendev.org/719120 | |
| 16:25:07 | openstackgerrit | Ghanshyam Mann proposed openstack/nova stable/stein: Use placement stable version for functional job https://review.opendev.org/719121 | |
| 16:25:28 | openstackgerrit | Ivaylo Mitev proposed openstack/nova master: VMware: Attach volumes using adapter type from instance https://review.opendev.org/616599 | |
| 16:47:22 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in flavor extra specs policy https://review.opendev.org/719603 | |
| 16:59:02 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in flavor access policy https://review.opendev.org/719607 | |
| 17:10:54 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Use oslo policy flag to disable default change warning instead of all https://review.opendev.org/717884 | |
| 20:43:00 | melwitt | johnthetubaguy: heya, just a note to revisit this policy API patch that you had -2 in the past https://review.opendev.org/676688 | |
| 21:07:30 | openstackgerrit | Ghanshyam Mann proposed openstack/nova stable/train: Use placement stable version for functional job https://review.opendev.org/719120 | |
| #openstack-nova - 2020-04-14 | |||
| 09:55:30 | bauzas | gibi: stephenfin: I'm out of ideas for a problem I have with mocking a privsep helper | |
| 09:55:56 | stephenfin | got it on Gerrit? | |
| 09:56:08 | bauzas | stephenfin: in https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L64 | |
| 09:56:24 | bauzas | stephenfin: there, I'm amending the fake connection to add a mdev | |
| 09:56:53 | bauzas | stephenfin: but as you can see, all the computes have the same fake connection https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L71 | |
| 09:57:26 | bauzas | stephenfin: so, I should modify https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L56-L68 to look at which compute to modify | |
| 09:57:57 | bauzas | stephenfin: but given I'm faking privsep https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L45-L47 | |
| 09:58:06 | bauzas | stephenfin: I can't know which compute was for | |
| 09:58:17 | bauzas | :( | |
| 09:58:33 | bauzas | I only know the parent PCI ID | |
| 09:59:57 | stephenfin | I think you need to keep track of individual fake connections like we do in the 'start_computes' function https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/base.py#L138-L152 | |
| 10:01:06 | bauzas | stephenfin: sure, but then how to know which fake connection to modify then ? | |
| 10:01:24 | bauzas | I mean in https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L56 | |
| 10:01:45 | bauzas | both compute have the exact same PCI IDs | |
| 10:01:54 | bauzas | computes* | |
| 10:02:17 | stephenfin | ah, yes, gotcha | |
| 10:02:34 | bauzas | 'self' is not the compute driver... | |
| 10:02:55 | gibi | does the fake connection know hostname? | |
| 10:03:11 | gibi | or nodename | |
| 10:03:17 | bauzas | yes | |
| 10:03:21 | bauzas | that's easy | |
| 10:03:30 | gibi | then you can branch based on that | |
| 10:03:37 | bauzas | but again, I don't know which compute was calling https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L56 | |
| 10:04:01 | bauzas | eg. if you create an instance for compute 1 and then compute2 | |
| 10:04:20 | bauzas | then both calls to https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L56 will have the same arguments | |
| 10:04:44 | bauzas | so, _create_mdev() wouldn't know which fake connection to modify | |
| 10:05:17 | gibi | can we have different pci ids per compute? | |
| 10:06:08 | stephenfin | It's very hacky, but you could intercept a higher call and set some attribute to say "compute node N is now attempting to create an mdev" | |
| 10:06:14 | bauzas | gibi: well, we could... but I think it would be a large change then :( | |
| 10:06:34 | bauzas | stephenfin: I can try this | |
| 10:06:55 | bauzas | tbh, I tried to discuss with you to find another solution | |
| 10:07:03 | bauzas | but you told me the two ones I was thinking | |
| 10:07:09 | bauzas | and both of them are difficult :p | |
| 10:07:11 | bauzas | anyway | |
| 10:07:22 | bauzas | I can try to resize to the same host | |
| 10:07:37 | bauzas | (for testing what I want) | |
| 10:07:45 | bauzas | but that won't fix the problem | |
| 10:07:50 | bauzas | anyway, thanks | |
| 10:38:53 | stephenfin | johnthetubaguy: could you help me understand why we are changing the scope types for the create policy here? https://review.opendev.org/#/c/717175/9/nova/policies/server_groups.py | |
| 10:46:18 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP/DNM zuul: Attempt to migrate and break up the nova-live-migration job https://review.opendev.org/711604 | |
| 11:08:18 | openstackgerrit | jayaditya gupta proposed openstack/nova master: Support for --force flag for nova-manage placement heal_allocations command https://review.opendev.org/715395 | |
| 13:06:13 | openstackgerrit | Merged openstack/nova master: workarounds: Add option to disable native LUKSv1 decryption by QEMU https://review.opendev.org/708030 | |
| 13:06:20 | openstackgerrit | Merged openstack/nova master: Add test coverage of existing keypairs policies https://review.opendev.org/718604 | |
| 13:06:28 | openstackgerrit | Merged openstack/nova master: Introduce scope_types in keypairs https://review.opendev.org/718609 | |
| 13:06:36 | openstackgerrit | Merged openstack/nova master: Add test coverage of existing quota sets policies https://review.opendev.org/719128 | |
| 13:06:50 | openstackgerrit | Merged openstack/nova master: Add test coverage of existing quota class policies https://review.opendev.org/719095 | |
| 13:06:58 | openstackgerrit | Merged openstack/nova master: Introduce scope_types in quota class Policies https://review.opendev.org/719096 | |
| 13:07:06 | openstackgerrit | Merged openstack/nova master: Add new default roles in keypairs policies https://review.opendev.org/718619 | |
| 13:07:16 | openstackgerrit | Merged openstack/nova master: Pass the actual target in keypairs policy https://review.opendev.org/718621 | |
| 13:07:40 | openstackgerrit | Merged openstack/nova master: api: Allow custom traits https://review.opendev.org/718461 | |
| 13:25:49 | openstackgerrit | Merged openstack/nova master: Use placement stable version for functional job https://review.opendev.org/719119 | |
| 13:51:38 | aarents | Hi there, lyarwood I put few examples on associated bug https://bugs.launchpad.net/nova/+bug/1872082 ( https://review.opendev.org/#/c/719008 ) | |
| 13:51:38 | openstack | Launchpad bug 1872082 in OpenStack Compute (nova) "available disk on compute may be lightly overestimated in some cases" [High,In progress] - Assigned to Alexandre arents (aarents) | |
| 13:59:26 | lyarwood | aarents: yeah sorry missed the RAW example | |
| 14:01:01 | aarents | lyarwood: np | |
| 14:08:15 | lyarwood | aarents: so I think the RAW behaviour is actually a bug due to the way we call fallocate | |
| 14:08:44 | lyarwood | aarents: I think it's writing out a block of zero's at the start | |
| 14:09:01 | lyarwood | aarents: as we aren't using -d | |
| 14:10:08 | gmann | stephenfin: replied for SG scope things- https://review.opendev.org/#/c/717175/9/nova/policies/server_groups.py@36 | |
| 14:10:20 | gmann | stephenfin: please check if that make sense, it is same for POST servers also | |
| 14:11:10 | lyarwood | aarents: https://paste.centos.org/view/90da78f0 for example | |
| 14:11:23 | lyarwood | aarents: I think your change is still good FWIW | |
| 14:11:34 | lyarwood | aarents: but we should also fix our call to fallocate | |
| 14:13:32 | aarents | lyarwood: exact for -d , seems necessary | |
| 14:18:39 | lyarwood | aarents: actually -d is wrong | |
| 14:21:55 | openstackgerrit | Merged openstack/nova master: Add new default roles in tenant tenant usage policies https://review.opendev.org/717587 | |
| 14:22:03 | openstackgerrit | Merged openstack/nova master: Add test coverage of existing server topology policies https://review.opendev.org/717524 | |
| 14:22:33 | nightmare_unreal | how can I get migration ID when migrating an instance ? When I run the live migration cmd from CLI i don't get any output | |
| 14:24:03 | gibi | brinzhang_, sean-k-mooney, dansmith: regarding cyborg-nova integration: can I close the bp and there will be a new bp for Victoria? Does https://review.opendev.org/#/c/716186 needs to be handled as a bug? | |
| 14:24:36 | dansmith | gibi: yes and yes, IMHO | |
| 14:25:11 | gibi | dansmith: OK. I will wait for brinzhang_ to comment too and I will ask him to file the bug too | |
| 14:25:34 | dansmith | ack | |
| 14:26:18 | sean-k-mooney | gibi: yep agree with dansmith | |
| 14:26:24 | gibi | sean-k-mooney: cool | |
| 14:26:59 | sean-k-mooney | speaking of ill go file said bug before i get distracted | |
| 14:27:14 | gibi | sean-k-mooney: thanks | |
| 14:33:33 | sean-k-mooney | gibi: should i mark this as rc potential or shoudl we just treat it as a normal bugfix that we will backport after ussuri is released as normal. | |
| 14:33:58 | stephenfin | gmann: Thanks for the explanation. Would it be possible edit the commit message to include that information there? | |
| 14:34:57 | gibi | sean-k-mooney: what is the worst case issue by that bug? | |
| 14:35:42 | gmann | stephenfin: sure, doing. | |
| 14:36:36 | sean-k-mooney | if we create the ARQ and fail to clean them up becasue binding fail then we leak the arq. since its not bound i think its just leaking a db recored. i need to double check that | |
| 14:37:45 | sean-k-mooney | gibi: https://bugs.launchpad.net/nova/+bug/1872730 | |
| 14:37:45 | openstack | Launchpad bug 1872730 in OpenStack Compute (nova) "Delete ARQs for an instance when the instance is deleted only delete bound arqs" [High,Triaged] | |