| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-04-09 | |||
| 09:19:23 | bauzas | CC me* | |
| 09:19:31 | bauzas | I can still ask gerrit to find me all +Wd tho | |
| 09:19:37 | bauzas | actually, nevermind, I'll work this way | |
| 09:19:39 | gibi | bauzas: also there is the novaclient release patch that needs an update when 2.87 lands https://review.opendev.org/#/c/718260/ | |
| 09:20:13 | gibi | and thank you | |
| 09:20:29 | bauzas | gibi: fill an etherpad for tracking if you feel I could loose anything | |
| 09:20:38 | gibi | bauzas: I'm on it :) | |
| 09:20:42 | bauzas | cool | |
| 09:21:47 | bauzas | stephenfin: I thought placement wasn't accepting dashes for trait names ? | |
| 09:23:18 | bauzas | shit, can't find the regex on the placement api-ref for reference | |
| 09:23:26 | stephenfin | bauzas: I thought so too, but I checked the regex and they are | |
| 09:23:30 | stephenfin | Sec, lemme drag it out | |
| 09:24:30 | stephenfin | bauzas: https://github.com/openstack/placement/blob/master/placement/schemas/common.py#L27 | |
| 09:24:31 | bauzas | stephenfin: just held a procedural -1 | |
| 09:24:41 | stephenfin | We have a similar regex somewhere in nova | |
| 09:24:43 | bauzas | stephenfin: but then it could be nova regex | |
| 09:24:50 | bauzas | yeah, I was thinking of so | |
| 09:25:09 | stephenfin | bauzas: yeah, here https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L57 | |
| 09:25:10 | bauzas | because when I wanted to create a custom trait for nvidia-11, I got fucked up | |
| 09:25:37 | stephenfin | hyphens are perfectly fine based on those | |
| 09:26:05 | bauzas | I'm then confused | |
| 09:26:17 | bauzas | lemme provide a DNM based on my func test | |
| 09:26:35 | bauzas | and you'll see that CUSTOM_NVIDIA-11 isn't a thing accepted | |
| 09:26:42 | bauzas | that had to be upper cases btw. | |
| 09:26:45 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM testing enforce new defaults flag https://review.opendev.org/717945 | |
| 09:27:04 | bauzas | stephenfin: man, we're bikeshedding on a regex while this should be documented on the api-ref... | |
| 09:27:09 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Temporarily skip TestNovaMigrationsMySQL https://review.opendev.org/718629 | |
| 09:27:56 | dtantsur | morning folks! we seem to be seeing guru meditations in grenade jobs (at least) https://zuul.opendev.org/t/openstack/build/638527be7aba44b59bb37c71dffe4a4a/log/logs/screen-n-cpu.txt#15859 | |
| 09:28:00 | gibi | lyarwood: ^^ | |
| 09:28:26 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Revert "Temporarily skip TestNovaMigrationsMySQL" https://review.opendev.org/718630 | |
| 09:32:45 | bauzas | gibi: +Wd the skippest test | |
| 09:32:48 | lyarwood | bauzas++ got there ahead of me | |
| 09:32:55 | gibi | thanks folks! | |
| 09:35:08 | stephenfin | lyarwood: comment on https://review.opendev.org/#/c/718464/ | |
| 09:35:11 | kashyap | lyarwood: What does the term "storage live migration" mean to you? | |
| 09:35:18 | kashyap | (In terms of Nova) | |
| 09:35:34 | kashyap | For me, there are two ways to read it: | |
| 09:35:55 | kashyap | (1) Live migration without shared storage (also confusingly called "live block migration") | |
| 09:36:16 | kashyap | (2) Migrating only the storage from src to dest, while the VM itself is running on src. | |
| 09:37:25 | lyarwood | 2, moving storage between backends while the instance stays in place, something we only support through volume migration and retype. | |
| 09:37:53 | lyarwood | stephenfin: looking | |
| 09:38:03 | kashyap | lyarwood: Right, it's the thing that's based on "swap volume". | |
| 09:38:44 | lyarwood | kashyap: yeah indeed | |
| 09:39:03 | kashyap | lyarwood: Thx. (Context: trying to answer a docs person) | |
| 09:40:53 | kashyap | lyarwood: I'd guess this doc is good enough about 'cinder retype', yeah? -- https://docs.openstack.org/cinder/rocky/contributor/migration.html | |
| 09:43:05 | lyarwood | https://docs.openstack.org/cinder/latest/contributor/migration.html but yeah | |
| 09:45:38 | kashyap | Thx | |
| 09:49:32 | bauzas | gibi: I really appreciate your help on my series btw. given how you're overloaded | |
| 09:49:41 | bauzas | I mean, i saw your comments | |
| 09:49:45 | bauzas | and I appreciated them | |
| 09:50:00 | gibi | bauzas: I think I can finish the test review before lunch :) | |
| 09:50:07 | bauzas | tbh, I'll remember this cycle for my whole life | |
| 09:50:16 | gibi | crazy times | |
| 09:50:30 | bauzas | just because of the lockdown with kids hitting me every 5 mins for questions | |
| 09:51:22 | bauzas | me, Sylvain Bauza, software engineer, teacher, IT support folk for my spouse, legal advisor, parent of 2 kids | |
| 09:52:12 | gibi | but it is a great achievement that you can manage all these | |
| 09:52:21 | bauzas | (legal advisor because we have to consider every time we go out whether it's a legally accepted reason) | |
| 10:12:17 | kashyap | Can anyone remind me: does Nova distnguish between these two suspend-related power states: S3 (standby) and S4 (hibernate) | |
| 10:15:03 | openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Add missing docstrings from get_rescue_device|bus diskinfo funcs https://review.opendev.org/718464 | |
| 10:15:50 | gibi | bauzas: small issue in https://review.opendev.org/#/c/717975/11/nova/tests/functional/libvirt/test_vgpu.py@173 but overall looks good | |
| 10:15:58 | kashyap | Nope, we don't: https://docs.openstack.org/api-guide/compute/server_concepts.html | |
| 10:19:52 | bauzas | gibi: <3 with love | |
| 10:23:31 | openstackgerrit | Merged openstack/python-novaclient master: Microversion 2.85: Change volume-update CLI https://review.opendev.org/712651 | |
| 10:28:59 | openstackgerrit | Merged openstack/nova master: Convert delete_on_termination from string to boolean https://review.opendev.org/718387 | |
| 10:30:31 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the target in os-services APIs policy https://review.opendev.org/676688 | |
| 10:31:42 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the target in os-services APIs policy https://review.opendev.org/676688 | |
| 10:40:01 | sean-k-mooney | bauzas: the hypens need to be converted to _ | |
| 10:42:54 | sean-k-mooney | bauzas: https://github.com/openstack/os-traits/blob/master/os_traits/__init__.py#L140-L156 | |
| 10:43:26 | sean-k-mooney | kashyap: yes | |
| 10:43:50 | sean-k-mooney | kashyap: suspend/resume is suspend to disk, pause/unpause is suspend to ram | |
| 10:44:20 | sean-k-mooney | kashyap: so not qutie the same as s3 vs s4 | |
| 10:44:44 | sean-k-mooney | but for pause we just stop the execution fo the qemu cpu without stoping the full qemu proces | |
| 10:45:07 | sean-k-mooney | where as suspend does a libvirt managed save dumping guest ram to a file on disk | |
| 10:45:45 | sean-k-mooney | from a guest os perspecitive its more or less looks the same unless you have pci passthough deivces | |
| 10:48:21 | bauzas | sean-k-mooney: ahah, thanks for the explanation ! | |
| 10:49:25 | bauzas | now I understand, I could have asked to create a trait like 'custom_nvidia-11' but then normalize_name() would ask Placement to create trait named 'CUSTOM_NVIDIA_11') | |
| 10:49:37 | sean-k-mooney | you can just take the mdev type and call that function and it should work | |
| 10:49:43 | sean-k-mooney | yes | |
| 10:50:17 | bauzas | I could even provide a name like 'custom_foo?.%^', it would just do 'CUSTOM_FOO____' | |
| 10:50:19 | sean-k-mooney | which means in your flavor you need to use 'CUSTOM_NVIDIA_11' or you will get no results form placement | |
| 10:50:52 | bauzas | sean-k-mooney: yeah, ok, good point | |
| 10:51:05 | bauzas | sean-k-mooney: I'm afraid placement api-ref doesn't mention it | |
| 10:51:20 | bauzas | not talking of the normalization | |
| 10:51:28 | sean-k-mooney | the vaild chariters | |
| 10:51:32 | bauzas | yup | |
| 10:51:39 | bauzas | this would clarify the expectations | |
| 10:51:46 | sean-k-mooney | so i think it wont normalise on your behalf | |
| 10:51:52 | bauzas | you could do whatever you want, but ask placement the right things | |
| 10:51:53 | sean-k-mooney | it will reject the creation fo the trait? | |
| 10:52:04 | bauzas | sean-k-mooney: that's the whole point, I dunno | |
| 10:52:26 | sean-k-mooney | ya i have never tried to check honestly | |
| 10:52:31 | bauzas | I dunno whether Placement API is strict with naming or just allows anything to come by and normalize it | |
| 10:52:44 | bauzas | with the latter, I have concerns | |
| 10:52:47 | bauzas | this is not RESTful | |
| 10:53:11 | bauzas | if I'm creating an object, I'm expecting the output of the creation is identical to the object I passed | |
| 10:53:21 | bauzas | from a semantics perspective | |
| 10:53:28 | bauzas | (or idempotent if you prefer) | |
| 10:55:27 | sean-k-mooney | they dont actully have a test case for it but from the doc text i would expect you will get a 400 | |
| 10:55:29 | sean-k-mooney | https://github.com/openstack/placement/blob/master/placement/tests/functional/gabbits/traits.yaml#L17-L34 | |
| 10:56:41 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Functional test with pGPUs https://review.opendev.org/717975 | |