Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-04-08
17:04:02 openstackgerrit Merged openstack/nova master: Support live migration with vpmem https://review.opendev.org/687856
17:04:05 bauzas stephenfin: actually, looking at your comments and trying to get the main problems so I could fix them while you sleep
17:04:20 bauzas you said caching
17:04:31 bauzas but we already cache it per se
17:04:31 stephenfin yeah, for the call to '_get_supported_vgpu_types'
17:05:09 bauzas stephenfin: well, we now lookup self.supported_vgpu_types
17:05:15 sean-k-mooney if you need to cache things use functool.lru_cache decorator
17:05:18 bauzas which is instanciated at startup
17:06:06 stephenfin bauzas: you're right. Sorry, I missed that /o\
17:06:44 bauzas stephenfin: no worries I'll address your comments tho
17:07:29 stephenfin cool. Happy to toggle when there's a follow up
17:07:29 bauzas stephenfin: I just provided a mapping table lookup method for getting the vgpu type, that's probably what confused you
17:07:33 sean-k-mooney bauzas: you did comment about not wanting to check the config too many times in a respocnc too lee which confused me a bit as ya its only don on agent start
17:07:56 bauzas sean-k-mooney: the comment was on the previous patch IIRC
17:08:02 bauzas unless I'm wrong
17:08:02 sean-k-mooney yes
17:08:18 sean-k-mooney but i have had that in my mind while reviing the followup
17:08:23 bauzas ok, so, the previous patch calls self._get_supported_types N times
17:08:42 sean-k-mooney e.g. that was something you were were concerned about so i am watching for that
17:08:56 bauzas but this patch introduces some startup call that instanciates an object in the driver
17:09:11 bauzas that's not really a cached object
17:09:18 bauzas ie. we don't need to update it
17:09:29 bauzas we just read it once at startup, that's it
17:09:45 sean-k-mooney yep which is fine
17:09:50 bauzas (and that's how folks I tried to avoid the known issue of cache invalidation)
17:11:21 sean-k-mooney yep but use to reiterate if people feel they need cacheing of functions now that we can depend on being python 3 we shoudl use https://docs.python.org/3/library/functools.html#functools.lru_cache
17:11:50 bauzas sean-k-mooney: gtk
17:12:38 bauzas ah, interesting
17:12:51 sean-k-mooney there is a backport in cachetools which is technically in the requirements repo but i never felt there was a justification for using it in nova as an extra dep
17:12:54 bauzas but I wouldn't use it for simple dicts
17:13:23 bauzas yeah, it's intended for large dicts with high access rate
17:13:35 bauzas hence the name FWIW
17:14:04 bauzas sean-k-mooney: and honestly, maybe just worth it for nova-api
17:14:30 sean-k-mooney there are other places where it makes sense
17:14:53 sean-k-mooney if we ever think maybe we should add a cache and go to add a maunal modle level dict
17:14:59 sean-k-mooney we shoudl see if this can be used instead
17:16:42 sean-k-mooney for example this would be good for caching the pci whitelist parsing
17:17:14 sean-k-mooney we currently parse it over and over again in the periodics but we dont have too
17:17:53 sean-k-mooney its not a muteable config option but the patches to intoduced that were consider too trival to merge for the extra code of doing it manallly
17:18:07 sean-k-mooney jsut adding a decorator however is much lighter weight
17:25:17 bauzas sean-k-mooney: maybe, at least just having some object in memory isn't crazy
17:25:46 bauzas sean-k-mooney: I was more talking about using this lib, which is intended for high frequency rates, which isn't the case
17:26:45 sean-k-mooney bauzas: https://pypi.org/project/cachetools/ that one
17:27:11 bauzas ah ok
17:27:25 sean-k-mooney it would have been perfect for https://review.opendev.org/#/c/599071/
17:27:28 bauzas (like the two other nights)
17:27:38 sean-k-mooney bauzas: o/
17:27:42 bauzas gosh, I missed working upstream...
17:29:23 sean-k-mooney i shoudl really go back and replace that and the other memorize decoratos at some point
17:55:18 openstackgerrit melanie witt proposed openstack/nova master: Reset the cell cache for database access in Service https://review.opendev.org/717662
17:56:22 melwitt dansmith: finally updated ^ I spun around for awhile trying to find a way to restart the func test nova-api service (OSAPIFixture) before concluding that it doesn't leverage the WSGIService in any way. so I instead used the OSMetadataServer fixture
18:49:01 openstackgerrit Merged openstack/nova master: Correct server topology policy check_str https://review.opendev.org/717525
19:32:05 openstackgerrit Merged openstack/nova master: Separate update and swap volume policies https://review.opendev.org/711194
19:32:20 openstackgerrit Merged openstack/nova master: Fix server metadata policy to be admin_or_owner https://review.opendev.org/717189
19:32:27 openstackgerrit Merged openstack/nova master: Add test coverage of existing server metadata policies https://review.opendev.org/717182
19:32:35 openstackgerrit Merged openstack/nova master: Introduce scope_types in server metadata https://review.opendev.org/717215
19:32:43 openstackgerrit Merged openstack/nova master: Add new default roles in server metadata policies https://review.opendev.org/717255
19:50:16 openstackgerrit Merged openstack/nova master: Add release notes for Cyborg-Nova integration. https://review.opendev.org/716185
20:16:57 melwitt gibi: I had to respin https://review.opendev.org/717662 to add a cache clearing to WSGIService, if you could pls re-review when you get a chance
21:57:16 openstackgerrit Sylvain Bauza proposed openstack/nova master: Support different vGPU types per pGPU https://review.opendev.org/715490
21:57:16 openstackgerrit Sylvain Bauza proposed openstack/nova master: Functional test with pGPUs https://review.opendev.org/717975
22:28:27 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server policies https://review.opendev.org/718348
23:50:24 lbragstad gmann https://review.opendev.org/#/c/717943/2 looks good to me - i tested it locally
#openstack-nova - 2020-04-09
00:02:31 gmann lbragstad: thanks. i will update with the nova test result on that
00:13:02 gmann brinzhang: you planning to add these tests in follow up right? - https://review.opendev.org/#/c/693828/25/nova/tests/unit/api/openstack/compute/test_volumes.py@1342
00:13:32 brinzhang gmann: yes
00:13:41 gmann ok, thanks
00:13:46 brinzhang gmann: but will be later, after FF
00:13:58 brinzhang I remember this patch need to add FUP
00:22:56 openstackgerrit Brin Zhang proposed openstack/python-novaclient master: Microversion 2.85: Change volume-update CLI https://review.opendev.org/712651
00:23:27 brinzhang gmann: I update the microversion 2.85 novalcient comment by stephenfin, pls review again, thanks
00:52:38 openstackgerrit Brin Zhang proposed openstack/python-novaclient master: Microversion 2.85: Change volume-update CLI https://review.opendev.org/712651
01:28:52 openstackgerrit Brin Zhang proposed openstack/nova master: FUP: add missing test for PUT volume attachments API https://review.opendev.org/718589
01:30:28 brinzhang gmann: follow up your comments in https://review.opendev.org/#/c/718589/
01:39:35 openstackgerrit Merged openstack/python-novaclient master: Make 'server list --config-drive' a boolean option https://review.opendev.org/718349
02:06:45 huaqiang ls
02:25:57 openstackgerrit Ghanshyam Mann proposed openstack/nova master: DNM testing enforce new defaults flag https://review.opendev.org/717945
02:34:52 openstackgerrit Merged openstack/nova master: Add new default roles in server password policies https://review.opendev.org/717417
03:01:09 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Disable warning for policies changing default check_str https://review.opendev.org/717884
03:01:44 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Disable warning for policies changing default check_str https://review.opendev.org/717884
03:21:59 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in tenant tenant usage policies https://review.opendev.org/717587
04:11:27 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-console-auth-tokens policies https://review.opendev.org/706689
04:24:02 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-console-auth-tokens policies https://review.opendev.org/706689
04:24:36 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the actual target in os-console-auth-tokens policy https://review.opendev.org/706690
04:25:17 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-aggregates policies https://review.opendev.org/701654
04:57:53 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-aggregates policies https://review.opendev.org/701654
05:02:55 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the actual target in os-aggregates policy https://review.opendev.org/701656
05:10:08 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix servers policy for admin_or_owner https://review.opendev.org/718501
05:26:55 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server policies https://review.opendev.org/718348
05:36:15 openstackgerrit Ghanshyam Mann proposed openstack/nova master: DNM testing enforce new defaults flag https://review.opendev.org/717945
06:07:00 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server policies https://review.opendev.org/718348
07:01:47 openstackgerrit Merged openstack/nova master: api: Add framework for extra spec validation https://review.opendev.org/704643
07:09:17 gibi good morning
07:19:42 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing keypairs policies https://review.opendev.org/718604
07:20:28 openstackgerrit Guo Jingyu proposed openstack/nova master: WIP: nova supports password encrypted VNC https://review.opendev.org/622336
07:24:42 gibi brinzhang_: hi! are you working on a follow up for https://review.opendev.org/#/c/712651/ ?
07:28:18 brinzhang_ gibi: yeah, it can be follow up, but not now
07:28:28 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix servers policy for admin_or_owner https://review.opendev.org/718501
07:29:28 gibi brinzhang_: ack
07:29:30 bauzas gibi: fwiw, I updated my vgpu series based on stephenfin's feedback https://review.opendev.org/#/c/715489/

Earlier   Later