| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-04-08 | |||
| 14:02:05 | gibi | this should fail as 'boo' is not int, but it is accepted | |
| 14:02:14 | gibi | haven't checked the latest ps | |
| 14:03:05 | gibi | pulling it now | |
| 14:03:22 | stephenfin | gimme a few | |
| 14:05:16 | openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Add missing docstrings from get_rescue_device|bus diskinfo funcs https://review.opendev.org/718464 | |
| 14:06:07 | sean-k-mooney | gibi: are you useing the correct microversion | |
| 14:06:29 | gibi | sean-k-mooney: I'm using the functional test env | |
| 14:06:47 | gibi | sean-k-mooney: and that sets it to 2.86 | |
| 14:06:49 | sean-k-mooney | right well it might not be using the latest microverions | |
| 14:06:53 | sean-k-mooney | ah ok | |
| 14:06:56 | sean-k-mooney | https://review.opendev.org/#/c/704643/23/nova/api/validation/extra_specs/resources.py | |
| 14:07:03 | sean-k-mooney | so the valu is defiend as an int | |
| 14:07:16 | gibi | there are a bunch of tests alreay there that works as expected | |
| 14:07:36 | gibi | something is wrong with the parameterized namespaced keys | |
| 14:07:47 | sean-k-mooney | its possible that boo is being treated as hex | |
| 14:08:08 | sean-k-mooney | actully proably not | |
| 14:08:51 | gibi | yepp, it accepts not-an-int as well | |
| 14:09:06 | stephenfin | gibi: s/resource/resources/ | |
| 14:09:29 | gibi | /o\ | |
| 14:09:55 | sean-k-mooney | stephenfin: should your typo chekcing not catch that :P | |
| 14:10:11 | stephenfin | nope, it's an unknown namespace :) | |
| 14:10:25 | gibi | stephenfin: you are right. resources works as expected | |
| 14:10:30 | sean-k-mooney | ... oh because we are droping ?validation | |
| 14:10:31 | openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Allow custom traits https://review.opendev.org/718461 | |
| 14:12:37 | openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM - Test stable device rescue tests with BFV instances https://review.opendev.org/710050 | |
| 14:13:11 | openstackgerrit | Lee Yarwood proposed openstack/nova master: DNM test stable rescue tempest/devstack changes https://review.opendev.org/700815 | |
| 14:21:07 | gmann | stephenfin: on extra spec tempest failure. new validation is with microversion right? and old microversion keep accepting the invalid things as they were ? | |
| 14:21:22 | stephenfin | gmann: Correct | |
| 14:22:04 | gmann | in that case tempest should not fail | |
| 14:22:36 | stephenfin | Oh, does Tempest default to the oldest microversion? | |
| 14:23:02 | stephenfin | Somewhat related, that change is actually not critical now since we've changed how validation works. Now we only care about known namespaces (e.g. 'hw:') | |
| 14:23:20 | gmann | yeah, 2.1 is default | |
| 14:23:58 | stephenfin | Ah, I wonder if one of the gate jobs was setting a higher default because I thought I saw failures early on | |
| 14:24:21 | stephenfin | before we changed to the current namespace-only model, that is | |
| 14:25:01 | gmann | i do not think we have any job run with latest. all microversion tests are with cap. | |
| 14:25:43 | gmann | but uncapped tests can be run with any microversion via configuration. so your change lgtm overall. I was curious if nova code is blocked due to tempest things | |
| 14:31:04 | gmann | stephenfin: +A on tempest fix. | |
| 14:32:20 | aarents | Hi there, I'm wondering if someone can evaluate this: https://review.opendev.org/#/c/717037 it's about a space available calucation issue during host periodic task | |
| 14:32:27 | gmann | stephenfin: can you review this policy warning things on olso.policy - https://review.opendev.org/#/c/717879/2 | |
| 14:37:24 | gmann | gibi: stephenfin : RE on config-drive things. sorry i could have hold +W. not allowing that filter for now or just allow as bool (what stephenfin proposal) make more sense. | |
| 14:38:06 | gibi | gmann: no worries | |
| 14:38:10 | openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Make 'server list --config-drive' a boolean option https://review.opendev.org/718349 | |
| 14:38:17 | stephenfin | gmann: Good timing :) ^ | |
| 14:38:23 | stephenfin | Looking at that oslo patch now | |
| 14:38:33 | gmann | thanks. checking.. | |
| 14:39:14 | bauzas | aarents: we're very close to FF, could you please ping us this one on Friday ? | |
| 14:39:49 | aarents | bauzas: sure | |
| 14:40:14 | gibi | bauzas: will you work on this Friday? | |
| 14:40:34 | bauzas | gibi: yup, our bank holiday is usually Monday | |
| 14:40:42 | bauzas | (only I mean) | |
| 14:40:46 | bauzas | gibi: you ? | |
| 14:40:56 | bauzas | Friday and Monday ? | |
| 14:40:58 | gibi | interesting we have both Friday and Monday off due to easter | |
| 14:41:48 | bauzas | heh, of course France only has a very few PTO days | |
| 14:41:55 | bauzas | poor of us | |
| 14:42:58 | stephenfin | :P | |
| 14:43:02 | gibi | :P | |
| 14:43:07 | aarents | :) | |
| 14:43:18 | bauzas | wait for May, dudes, wait for May... | |
| 14:43:51 | lyarwood | ha | |
| 14:44:09 | bauzas | actually, that makes a good call, Easter makes difficult any potential exception we could make | |
| 14:44:20 | bauzas | as it would differ for at least 2 working days | |
| 14:44:33 | bauzas | haven't realized that | |
| 14:48:43 | gmann | gibi: stephenfin how about not exposing non-working option --no-config-drive https://review.opendev.org/#/c/718349/3/novaclient/v2/shell.py@1561 | |
| 14:49:23 | gmann | or we should say something about non-working in help message so that users would get false un-filtered servers list | |
| 14:49:38 | stephenfin | gmann: That depends on whether we want to fix that filter with a microversion or not | |
| 14:50:12 | gmann | exactly, that is why i was thinking about not exposing as we do not know solution yet. | |
| 14:50:51 | gmann | and we may left that option always non-working for older version. | |
| 14:51:20 | stephenfin | Hmm, fair point. I think it's okay to keep it but I also see your point. I'll let someone else decide | |
| 14:51:36 | gmann | and we end up fix without microversion then we can always add as part of current bug fix | |
| 14:51:57 | gmann | +1. yeah. | |
| 14:53:57 | bauzas | sean-k-mooney: FWIW, got comments on https://review.opendev.org/#/c/716185/6 | |
| 14:54:05 | gmann | lbragstad: did you get chance to test the new flag of new defaults switch - https://review.opendev.org/#/c/717943/2 | |
| 14:54:17 | bauzas | sean-k-mooney: since it's already sent to the gate, I left a +1 to not fuck gibi's and lyarwood's stats :p | |
| 14:54:35 | lbragstad | gmann i have an environment up - i should be able to do it today | |
| 14:54:51 | gmann | lbragstad: i tried to simulate it on nova but somehow due to our fake_policy things for tests not letting me or something i am missing - https://review.opendev.org/#/c/717945/ | |
| 14:54:59 | gmann | lbragstad: great thanks a lot. | |
| 14:56:37 | bauzas | sean-k-mooney: -1 on https://review.opendev.org/#/c/716186/6 | |
| 14:56:47 | bauzas | is Sundar no longer around ? | |
| 14:56:56 | bauzas | who from the cyborg team can handover this ? | |
| 14:57:22 | gmann | stephenfin: should i fix those nits if you are here to re+2 on this ? otherwise do not want to lose that +2- https://review.opendev.org/#/c/717879/2 | |
| 14:57:22 | sean-k-mooney | bauzas: im taking over his nova work | |
| 14:57:36 | sean-k-mooney | i can go file a bug report and add the bug link | |
| 14:57:39 | bauzas | please | |
| 14:57:41 | sean-k-mooney | bauzas: were you ok with the code | |
| 14:57:51 | stephenfin | gmann: yes, if you can fix them, I'm okay to re +2 | |
| 14:58:03 | bauzas | sean-k-mooney: from what I've seen, yes | |
| 14:58:36 | bauzas | sean-k-mooney: maybe just one question, can _delete_arqs_by_uuid() raise some Exception ? | |
| 14:58:38 | sean-k-mooney | cool ill see if i can adress your other commens in a seperate follow up patch | |
| 14:58:56 | sean-k-mooney | bauzas: yes | |
| 14:59:06 | bauzas | from what i've seen, we just call the API and treat the error | |
| 14:59:22 | bauzas | oh, _call_cyborg can return an exception ? | |
| 14:59:36 | sean-k-mooney | basically i can rais an exception for auth issue or normal network issues | |
| 14:59:59 | sean-k-mooney | e.g. since ita an api requst cyborg could be dead | |
| 15:00:05 | bauzas | OK, I just wonder whether this would trample the user if we got an exception in the meantime | |
| 15:00:21 | sean-k-mooney | i dont think so | |
| 15:00:35 | sean-k-mooney | maybe but i dont think it will | |
| 15:00:38 | bauzas | correct, but then we need to handle it to return AcceleratorRequestOpFailed correctly then | |
| 15:00:59 | gmann | stephenfin: done - https://review.opendev.org/#/c/717879/ | |
| 15:01:12 | bauzas | sean-k-mooney: I wouldn't usually worry by exception handling on nova-computes, but here we talk of the API | |