Posted	Nick	Remark
#openstack-nova - 2020-04-08
02:05:01	openstackgerrit	Brin Zhang proposed openstack/nova master: Separate update and swap volume policies https://review.opendev.org/711194
02:05:15	brinzhang_	gmann: done, pls review again, thanks
02:06:10	openstackgerrit	Brin Zhang proposed openstack/nova master: Separate update and swap volume policies https://review.opendev.org/711194
02:18:57	openstackgerrit	Huaqiang Wang proposed openstack/nova master: mark mixed policy as ready, bump compute service version https://review.opendev.org/716271
02:18:58	openstackgerrit	Huaqiang Wang proposed openstack/nova master: libvirt/hardware: refactor numa_get_constraints https://review.opendev.org/718294
02:18:58	openstackgerrit	Huaqiang Wang proposed openstack/nova master: Setup 'mixed' instance through 'PCPU' and 'VCPU' resource https://review.opendev.org/713355
02:18:59	openstackgerrit	Huaqiang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936
02:21:20	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add new default roles in server group policies https://review.opendev.org/717175
02:25:40	openstackgerrit	Huaqiang Wang proposed openstack/nova master: computer: validate cpu pinning configuration for mixed instance https://review.opendev.org/716268
02:25:41	openstackgerrit	Huaqiang Wang proposed openstack/nova master: Calculate the pinned and unpinned CPU usage for mixed instance https://review.opendev.org/716269
02:25:41	openstackgerrit	Huaqiang Wang proposed openstack/nova master: mark mixed policy as ready, bump compute service version https://review.opendev.org/716271
02:25:42	openstackgerrit	Huaqiang Wang proposed openstack/nova master: libvirt/hardware: refactor numa_get_constraints https://review.opendev.org/718294
02:25:42	openstackgerrit	Huaqiang Wang proposed openstack/nova master: Setup 'mixed' instance through 'PCPU' and 'VCPU' resource https://review.opendev.org/713355
02:25:43	openstackgerrit	Huaqiang Wang proposed openstack/nova master: metadata: export the vCPU IDs that are pinning on the host CPUs https://review.opendev.org/688936
02:25:57	openstackgerrit	Brin Zhang proposed openstack/nova master: Separate update and swap volume policies https://review.opendev.org/711194
03:20:43	openstackgerrit	melanie witt proposed openstack/nova master: Reset the cell cache for database access in Service https://review.opendev.org/717662
03:34:33	openstackgerrit	Merged openstack/python-novaclient master: Microversion 2.83 - Add more filters for the nova list command https://review.opendev.org/713089
04:10:35	openstackgerrit	Brin Zhang proposed openstack/python-novaclient master: Microversion 2.84 - action event fault details https://review.opendev.org/714561
04:10:55	openstackgerrit	Brin Zhang proposed openstack/python-novaclient master: Microversion 2.85: Change volume-update CLI https://review.opendev.org/712651
04:11:13	openstackgerrit	Brin Zhang proposed openstack/python-novaclient master: Microversion 2.86 - Extra spec validation https://review.opendev.org/718057
04:11:30	openstackgerrit	Brin Zhang proposed openstack/python-novaclient master: Microversion 2.87 - Stable device boot from volume rescue https://review.opendev.org/714956
04:17:36	brinzhang_	alex_xu, gmann, gibi: I rebased the novalient merge conflict patch https://review.opendev.org/#/c/714561/9, need +A again, thanks
04:52:35	openstackgerrit	Qiu Fossen proposed openstack/nova master: The instance is volume backed and power state is PAUSED，shelve the instance failed https://review.opendev.org/711609
04:52:35	openstackgerrit	Qiu Fossen proposed openstack/nova master: The instance is volume backed and power state is PAUSED，shelve the instance failed https://review.opendev.org/711609
06:22:53	huaqiang	a
06:45:37	openstackgerrit	Merged openstack/python-novaclient master: Microversion 2.84 - action event fault details https://review.opendev.org/714561
06:55:04	bauzas	good morning Nova
07:17:31	alex_xu	gibi: would you like to take a look those patches https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/use-pcpu-and-vcpu-in-one-instance, the refactor patches from stephenfin looks good now
07:37:56	gibi	stephenfin: did you see that https://review.opendev.org/#/c/713089/ merged last night?
07:38:18	gibi	stephenfin: do you think we should do something about it?
07:40:58	brinzhang	gibi: although we merged that patch, but the config_drive issue also exist, what do you want to plan to do?
07:42:54	gibi	brinzhang: there is a Nova API bug regarding config_drive filtering, that I don't want to solve this week due to FF and due to the fact that it would need a bigger API change to make it consistent across the API. Regarding the client side, the client now works as a pass through which is not wrong but stephenfin argued for a bit nicer CLI interface
07:43:40	gibi	alex_xu: I will try but no promisses
07:44:02	alex_xu	gibi: thanks
07:45:14	brinzhang	gibi: ok, I left some comment in bug 1871409, and I looked your chat records, yes, it's a bigger change
07:45:15	openstack	bug 1871409 in OpenStack Compute (nova) "cannot filter the list servers to show only those that does not have config drive" [Medium,In progress] https://launchpad.net/bugs/1871409 - Assigned to Balazs Gibizer (balazs-gibizer)
07:45:40	brinzhang	gibi: we are decide to completed this in gmann's next cleanup api?
07:45:53	gibi	brinzhang: no, we only added it to the list
07:47:02	brinzhang	gibi: ok, thanks, got it, if need my help that I can.
07:47:50	gibi	brinzhang: thanks. I would not rush on that as config_driver filtering is broken at least in the last 3 years and nobody filed a bug
07:48:16	gibi	so we will take the time to figure out how we want to fix it
07:49:38	brinzhang_	gibi: Yes, we rarely use config_drive to filter servers too.
07:54:33	brinzhang_	gibi: the bp/destroy-instance-with-datavolume separate patch updated and the novaclient also update, if you have time today, pls review again, I am sorry to add your work, thanks.
08:00:13	gibi	brinzhang_: I have comment about the unit test https://review.opendev.org/#/c/711194
08:01:11	gibi	now I will look at the client patch
08:01:24	brinzhang_	gibi: thanks, will update
08:05:09	brinzhang_	gibi: the test case that I missed the api_version=2.85, and I will add d-o-t to the request body, and set 2.85 in request
08:09:12	bauzas	gibi: morning, FWIW I worked last night on the functional test, even if it's still a WIP, we verify whether traits work for two pGPUs https://review.opendev.org/#/c/717975/8/nova/tests/functional/libvirt/test_vgpu.py@214
08:09:29	bauzas	and Zuul says +1 :p
08:10:30	bauzas	(WIP because I need to update some tests for the fakelibvirt)
08:12:35	gibi	bauzas: morning. ack
08:16:02	openstackgerrit	Brin Zhang proposed openstack/nova master: Separate update and swap volume policies https://review.opendev.org/711194
08:16:13	brinzhang_	gibi: the test update done, thanks
08:19:22	gibi	brinzhang_: could you quickly fix this nit? then I will +2 https://review.opendev.org/#/c/711194/18/nova/tests/unit/policies/test_volumes.py@199
08:19:40	bauzas	stephenfin: fwiw, left comments on https://review.opendev.org/#/c/708436/ but I'm mostly +2
08:20:34	gibi	brinzhang_: two nits actually
08:20:36	openstackgerrit	Brin Zhang proposed openstack/nova master: Separate update and swap volume policies https://review.opendev.org/711194
08:21:46	gibi	brinzhang_: thanks
08:22:45	openstackgerrit	Brin Zhang proposed openstack/nova master: Separate update and swap volume policies https://review.opendev.org/711194
08:22:46	brinzhang_	gibi: yes, that caused for me, I am sorry to that unexpected errors.
08:23:03	bauzas	stephenfin: also I wonder whether we should document the fact that some keys having namespaces would be strictly validated
08:23:16	bauzas	stephenfin: inhttps://review.opendev.org/#/c/710037/
08:24:26	brinzhang_	gibi: maybe you should +2 again, I missed your +2, my network is not very good
08:24:33	gibi	brinzhang_: done :)
08:24:45	brinzhang_	gibi: thanks
08:29:02	bauzas	stephenfin: also, please help me, I don't get how you autodoc https://6319631a8afc7845c7f6-af2016a5632320f910deb9dcbf495ac6.ssl.cf2.rackcdn.com/710037/13/check/openstack-tox-docs/eb7469b/docs/configuration/extra-specs.html
08:29:07	brinzhang_	gibi: about the base patch of bp/destroy-instance-with-datavolume, I have some nits and lack some test case pre v2.85 need to follow up, and I will do that tomorrow, that I am not forget ^^
08:29:46	gibi	brinzhang_: if there is only nits and test then such change can go in after FF
08:30:32	bauzas	stephenfin: I mean, i understood this was done by https://review.opendev.org/#/c/710037/13/doc/ext/extra_specs.py
08:30:36	brinzhang_	gibi: ok, thanks for remind, that's better for me
08:31:31	bauzas	stephenfin: actually, nevermind I found it
08:43:27	stephenfin	bauzas: cool, let me know if you still have issues with it. I wrote a good guide for the Sphinx doc on this thing https://www.sphinx-doc.org/en/master/development/tutorials/recipe.html
08:43:46	stephenfin	though it's a bit more complicated than what we're doing
08:46:43	openstackgerrit	Lee Yarwood proposed openstack/nova master: api: Introduce microverion 2.87 allowing boot from volume rescue https://review.opendev.org/701430
08:46:44	openstackgerrit	Lee Yarwood proposed openstack/nova master: compute: Extract _get_bdm_image_metadata into nova.utils https://review.opendev.org/705212
08:46:44	openstackgerrit	Lee Yarwood proposed openstack/nova master: libvirt: Support boot from volume stable device instance rescue https://review.opendev.org/701431
08:46:45	openstackgerrit	Lee Yarwood proposed openstack/nova master: libvirt: Break up get_disk_mapping within blockinfo https://review.opendev.org/714962
08:47:06	lyarwood	stephenfin: ^ I did need the API samples after all for my microversion
08:47:18	stephenfin	how come?
08:47:31	stephenfin	why didn't I? :-\
08:48:25	bauzas	stephenfin: not really, I don't want to hold this
08:49:11	lyarwood	stephenfin: my functional tests in nova/tests/functional/api_sample_tests/test_rescue.py are rerunning the sample tests against the microversion, slightly over the top but meh.
08:50:25	gibi	stephenfin: do you feel that we need to do someting with the way 2.83 client support merged during the night? https://review.opendev.org/#/c/713089/
08:51:02	stephenfin	gibi: We don't *have* to, but I'm drafting the patch now to see if it makes sense :)
08:51:38	gibi	stephenfin: that patch would be top of the current merged solution or would revert the current solution first?
08:51:51	stephenfin	I think on top would be wisest?
08:52:23	gibi	stephenfin: yeah, I'm not too affraid of doing a breaking CLI change as nobody consumed the patch we merged during the night yet
08:52:38	stephenfin	Yeah, exactly
08:52:47	stephenfin	Catch it before it's released
08:53:05	gibi	stephenfin: release will happen tomorrow night so we have some time
08:53:55	gibi	stephenfin: I'm really glad that you have the time to tinker with that client patch, I feel a bit overwhelmed due to FF
08:56:00	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server policies https://review.opendev.org/718348
08:56:15	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server policies https://review.opendev.org/718348
08:59:33	openstackgerrit	Stephen Finucane proposed openstack/python-novaclient master: Make 'server list --config-drive' a boolean option https://review.opendev.org/718349
08:59:40	stephenfin	gibi: Yeah, I just want to nip this one in the bud before it gets released and that's not possible
09:02:22	johnthetubaguy	what is the REST API bug?
09:02:32	bauzas	gibi: stephenfin: hum, just catching-up but I feel this somehow has to be cleared in between us : https://review.opendev.org/#/c/713089/
09:03:03	openstackgerrit	Stephen Finucane proposed openstack/python-novaclient master: Make 'server list --config-drive' a boolean option https://review.opendev.org/718349
09:03:04	bauzas	gibi: stephenfin: FWIW, we should ask not to merge nova api changes unless there are novaclient patches in Depends-ON
09:03:29	johnthetubaguy	bauzas: really we should ask for openstack cli right?

Earlier   Later