| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-04-06 | |||
| 17:16:21 | gmann | yeah there is but that only control scope_type checks not the deprecated old rules | |
| 17:16:22 | lbragstad | kind of - but we didn't expect to use that option to adjust deprecation behavior | |
| 17:16:59 | melwitt | oh I see | |
| 17:17:39 | gmann | or we can do with new flag which we can keep it for future usual policy changes also | |
| 17:17:51 | lbragstad | but i can understand the usecase where deployers want to opt into the new policy system without having to write "new" defaults back into the policy file to get around noisy logs and the logical OR in oslo.policy | |
| 17:18:10 | gmann | so when enforce_scope if true by default or we remvoe that in future we can keep new flag for deprecation things always | |
| 17:18:50 | lbragstad | i guess that's the part i'd like to walk through, does it make sense to reuse that option or do we need something new? | |
| 17:20:11 | bnemec | I think they're separate things. enforce_scope is a temporary thing while everyone gets their policies scope-ready, this new deprecation flag is something that we would keep indefinitely because it will have use any time a policy is deprecated for any reason. | |
| 17:20:23 | gmann | IMO, something new make sense for considering the future cases | |
| 17:21:37 | bnemec | Also, I should note that we are past all of the freeze dates that apply to oslo.policy, so whatever we do it needs to be ASAP so we can request an FFE. | |
| 17:22:41 | gmann | bnemec: yeah that is what i was thinking yesterday and about to ask if oslo.policy is already released ? | |
| 17:24:48 | sean-k-mooney | stephenfin: ill review the new version you pushed. i think i can live with that compromise but im not entirely sure its an improvemnt | |
| 17:25:05 | bnemec | Yeah, that ship has sailed. Our last planned feature release (which was an FFE itself) happened Friday. | |
| 17:25:11 | gmann | ok | |
| 17:25:50 | bnemec | I think this is worth an FFE, but it's no longer up to me alone. | |
| 17:26:02 | gmann | I (or if lbragstad want to do) can propose that if all agree on that ? | |
| 17:28:23 | lbragstad | gmann i'm happy to review if you push something up | |
| 17:30:09 | gmann | lbragstad: ok. I will try to push that today. | |
| 17:50:57 | openstackgerrit | Merged openstack/nova stable/rocky: Unplug VIFs as part of cleanup of networks https://review.opendev.org/715404 | |
| 18:11:53 | openstackgerrit | Sasha Andonov proposed openstack/nova master: rbd_utils: increase _destroy_volume timeout https://review.opendev.org/705764 | |
| 18:22:53 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix new context comparison workaround in base tests class https://review.opendev.org/717825 | |
| 18:26:04 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix new context comparison workaround in base tests class https://review.opendev.org/717825 | |
| 18:59:51 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix misc comments on policy work https://review.opendev.org/717835 | |
| 21:01:14 | openstackgerrit | Lee Yarwood proposed openstack/nova master: workarounds: Add option to disable native LUKSv1 decryption by QEMU https://review.opendev.org/708030 | |
| 21:01:15 | openstackgerrit | Lee Yarwood proposed openstack/nova master: workarounds: Add option to locally attach RBD volumes on compute hosts https://review.opendev.org/708029 | |
| 21:13:32 | openstackgerrit | Merged openstack/nova master: Disable the policy warning temporary https://review.opendev.org/717802 | |
| 21:40:24 | sean-k-mooney | melwitt: regarding the oslo.policy cahnge. if we cant deliver that via a FFE is the plan to leave the deprecation warning disabled or do something slighly hacky like monky patch oslo.policy to do what we want for ussuri | |
| 21:41:07 | sean-k-mooney | melwitt: i know we have monkeypatched other libs in the past but i would feel weired doing it to oslo so i assume it would be left disabled | |
| 21:44:13 | melwitt | sean-k-mooney: yeah, I'm thinking about the same thing and I am not sure. I would think leave it disabled in the worst case scenario of not being able to solve it in oslo.policy via FFE. but I know that leaves us in a bind too wrt to any policy name changes that are also occurring | |
| 21:44:25 | melwitt | gmann: did you have any thoughts on this yet, what do we do if we can't get the oslo.policy stuff figured out? ^ | |
| 21:49:25 | gmann | melwitt: I will push both things on oslo side today if those cannot be merged due to any reason, then i think we left with no option than keep it disabled. | |
| 21:50:53 | gmann | we are saying to support the old defaults by 2 cycles at least so existing deployement are not going to break immediately which mean no-warning things also not so bad | |
| 21:58:56 | melwitt | gmann: ack thanks | |
| 21:59:39 | melwitt | that's true we have some time to sort it out from that perspective | |
| 23:14:13 | sean-k-mooney | gmann: the oslo team are currently asking for an FFE for some libs so if we want to get this in we should ask them to include it in that FFE | |
| 23:16:04 | gmann | sean-k-mooney: yeah, I am working on changes and will ask FFE | |
| 23:41:35 | openstackgerrit | Luigi Toscano proposed openstack/nova master: zuul: Switch to the Zuulv3 grenade job https://review.opendev.org/704364 | |
| #openstack-nova - 2020-04-07 | |||
| 00:05:01 | brinzhang | dansmith: Could you please update the separate update and seap volume policies patch? https://review.opendev.org/#/c/711194/ , I seem not get the logical what would you want to do, although I read the chat history of gmann and you. | |
| 00:07:25 | brinzhang | gibi: I dont know whois Victor Coutellier, I have two patches of microversion 2.84 and v2.85 rebased on v2.83 https://review.opendev.org/#/c/713089/ , it is very close to April 9th, I hope he can update ASAP | |
| 00:12:52 | gmann | brinzhang: he was new to nova side, not sure if he is aware of deadline. | |
| 00:13:22 | gmann | brinzhang: is more changes requied on his patch? | |
| 00:13:38 | gmann | i have not looked into review comments yet | |
| 00:16:24 | gmann | if those are not too much, we can help him by fixng those | |
| 00:26:34 | brinzhang | gmann: Got it, if so, I will looked into | |
| 00:26:36 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Disable warning for policies changing default check_str https://review.opendev.org/717884 | |
| 00:26:45 | brinzhang | gmann: thanks | |
| 00:27:49 | gmann | brinzhang: thanks. | |
| 00:28:28 | melwitt | alex_xu: heya, could you pls revisit these 2 patches you have reviewed before, they are about removing the "" to "/" redirect in nova api for version discovery https://review.opendev.org/685180 | |
| 00:28:45 | alex_xu | melwitt: I will try it today | |
| 00:28:50 | melwitt | and allowing unauthenticated for version discover | |
| 00:28:54 | melwitt | thanks alex_xu | |
| 00:29:01 | alex_xu | np | |
| 00:49:14 | gmann | lbragstad: should I make the changes of operators flag to new system in this or separate ? -https://review.opendev.org/#/c/717879/1 | |
| 00:50:11 | gmann | lbragstad: the disable warning flag we need as separate so that we can disable the warning from now itself not based on new-system-flag | |
| 00:51:36 | lbragstad | gmann oh - sorry, i didn't realize you were going to put that functionality behind a separate flag | |
| 00:52:30 | gmann | lbragstad: if under same flag then warning keep logging until operator switch to new system. | |
| 00:53:44 | lbragstad | yeah - ok | |
| 00:54:05 | lbragstad | so - a separate flag to opt out of the logical OR, right? | |
| 00:54:11 | gmann | yeah | |
| 00:54:23 | gmann | which will be config option with default to false | |
| 00:55:08 | lbragstad | got it, ok | |
| 01:51:59 | brinzhang_ | gmann: https://review.opendev.org/#/c/713089/7/novaclient/v2/shell.py with these filter parameters, need to add start_version="2.83" tag to limit the non-admin user to filter, right? | |
| 01:52:33 | brinzhang_ | I saw Victor Coutellier missed that limit | |
| 01:56:43 | gmann | brinzhang_: i do not think we need the start_version because 2.83 is to only enabling these filters for non-admin. they are allowed filter for admin since starting. | |
| 01:58:54 | brinzhang_ | gmann: if so, we cannt limit non-admin request these parameters, I think | |
| 02:01:06 | gmann | brinzhang_: from client side, non-admin will get API error like not allowed if request is with < 2.83 | |
| 02:01:23 | brinzhang_ | gmann: and https://review.opendev.org/#/c/713089/7/novaclient/v2/shell.py@1664 if the config_drive reqeust False, it will be changed to None, and in https://review.opendev.org/#/c/713089/7/novaclient/v2/servers.py@892 will be skip request config_drive | |
| 02:02:12 | brinzhang_ | gmann: Ok, thanks, I missed that return error message, it ok not limit start_version | |
| 02:03:38 | gmann | yeah, because client side do not enforce the permission things and rely on server side error. | |
| 02:04:38 | brinzhang_ | gmann: what do you think this is an issue? https://review.opendev.org/#/c/713089/7/novaclient/v2/shell.py@1664 if the config_drive reqeust False, it will be changed to None, and in https://review.opendev.org/#/c/713089/7/novaclient/v2/servers.py@892 will be skip request config_drive | |
| 02:05:03 | brinzhang_ | I think we cannot filter by config_drive=False | |
| 02:05:56 | brinzhang_ | but if I changed the config_drive = False, it will be change a required parameter will filter instances :( | |
| 02:08:20 | openstackgerrit | Merged openstack/nova master: Repro bug 1845530: versioned discovery is authed https://review.opendev.org/685180 | |
| 02:08:22 | openstack | bug 1845530 in OpenStack Compute (nova) "Versioned discovery endpoint should not require authentication" [Medium,In progress] https://launchpad.net/bugs/1845530 - Assigned to Eric Fried (efried) | |
| 02:10:19 | gmann | brinzhang_: None is not allowed value but False should be | |
| 02:10:49 | gmann | bt i have not checked that changes in detail. i can check tomorrow. | |
| 02:11:01 | brinzhang_ | gmann: yes, https://review.opendev.org/#/c/713089/7/novaclient/v2/servers.py@892 seems not correct | |
| 02:11:10 | brinzhang_ | gmann: ok, thanks | |
| 02:49:27 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.83 - Add more filters for the nova list command https://review.opendev.org/713089 | |
| 04:05:39 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: DNM testing enforce new defaults flag https://review.opendev.org/717945 | |
| 04:14:31 | openstackgerrit | norman shen proposed openstack/nova master: Update connection info in pre_live_migration https://review.opendev.org/717597 | |
| 04:26:13 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.83 - Add more filters for the nova list command https://review.opendev.org/713089 | |
| 04:55:24 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix server tags policy to be admin_or_owner https://review.opendev.org/717947 | |
| 04:56:08 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server tags policies https://review.opendev.org/717425 | |
| 05:00:08 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server tags policies https://review.opendev.org/717425 | |
| 05:06:47 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in server tags policy https://review.opendev.org/717948 | |
| 05:07:55 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing server tags policies https://review.opendev.org/717425 | |
| 05:08:10 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in server tags policy https://review.opendev.org/717948 | |
| 05:28:14 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in server tags policies https://review.opendev.org/717954 | |
| 07:17:45 | bauzas | good morning Nova | |
| 07:22:53 | lyarwood | morning | |
| 07:33:33 | openstackgerrit | Guo Jingyu proposed openstack/nova master: WIP: nova supports password encrypted VNC https://review.opendev.org/622336 | |
| 07:58:54 | gibi | bauzas: started reading the vgpu patches | |
| 07:59:08 | gibi | bauzas: I have an imediate feedback about the compute service startup sequence https://review.opendev.org/#/c/715489/6/nova/virt/libvirt/driver.py@791 | |
| 08:01:06 | gibi | at the momemnt I'm not sure how this affect the patch but could be a problem ^^ | |
| 08:04:39 | lyarwood | stephenfin: https://review.opendev.org/#/c/708436/17 - Stupid question, so this doesn't need doc/api_samples and nova/tests/functional/api_sample_tests/api_samples/ updates as you're not changing request/responses in this microversion right? | |
| 08:05:13 | lyarwood | stephenfin: asking as I've added them in https://review.opendev.org/#/c/701430/ assuming we needed to do this regardless, if we don't I can rm -rf this from that change. | |
| 08:05:34 | bauzas | gibi: looking | |
| 08:06:02 | bauzas | gibi: FWIW, I can upload a DNM patch to see how to create pGPUs | |
| 08:06:43 | brinzhang_ | gibi: and I think there is an issue inline, but I dont have time to search how to fix it, so I add TODO in test case. The issue is filter by config_drive=False, cannt get the servers, because if we request config=False, that will be changed to None, that will be ignored | |