Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-04-06
15:08:39 johnthetubaguy stephenfin: I think that is a yes, to prevent the most obvious typos
15:08:40 bauzas we should ask for some return
15:08:57 johnthetubaguy stephenfin: or rather, for the user to know things are validated if its in a known namespace
15:09:48 stephenfin johnthetubaguy: okay, in that case do we need to continue to provide a way to disable validation in case there are people there with e.g. 'hw:something_custom' right now?
15:09:54 johnthetubaguy stephenfin: bonus, we would only need a microversion to add a new namespace
15:10:03 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Remove MIN_LIBVIRT_MULTIATTACH https://review.opendev.org/710238
15:10:10 johnthetubaguy stephenfin: I think we would just drop that flag for now, and see how people take it
15:10:44 johnthetubaguy I like the simpler API of there being a list of validated namespaces
15:10:59 johnthetubaguy stops all the mess of migrating people towards "custom" something
15:11:26 stephenfin okay, so unless our hand was forced we'd be essentially saying "you need to change this if you ever want to use this microversion"
15:12:03 johnthetubaguy I think so, yes
15:12:44 johnthetubaguy well, you can use the new API version to add your new key, and delete the old bad key
15:12:46 stephenfin Cool. Last one. Do we still need strict in this model (or that parameter in general), seeing as we are effectively strict for all recognized namespaces
15:12:58 johnthetubaguy I don't think so
15:13:03 johnthetubaguy at least not to start with
15:13:09 stephenfin Okay, so I can drop that parameter
15:13:25 johnthetubaguy you could typo the namespace... but, hey, at least we are helping you more now
15:13:52 stephenfin That all works for me. gibi, bauzas, sean-k-mooney, dansmith: any significant concerns with that before I do the needful ^ ?
15:14:25 stephenfin (last 15 lines or so of scrollback)
15:14:59 openstackgerrit Lee Yarwood proposed openstack/python-novaclient master: Microversion 2.86 - Stable device boot from volume rescue https://review.opendev.org/714956
15:15:08 johnthetubaguy stephenfin: for completeness, the old microversions are still unchanged, no validation at all there
15:15:22 stephenfin Yeah, agreed
15:16:25 johnthetubaguy sorry that all took so long, but I think what we have at the end is better
15:16:43 johnthetubaguy and easier to document and use :)
15:16:49 sean-k-mooney ill read back in a few minutes.
15:17:13 lyarwood stephenfin: ah, both of us are going for 2.86 again, want me to move to 2.87?
15:17:45 stephenfin lyarwood: Yup :) Your call but it might make sense
15:18:55 lyarwood stephenfin: yup no issues, I wasn't paying attention
15:20:42 bauzas stephenfin: pardon my French but I may have misunderstood the agreement in between you and johnthetubaguy
15:21:14 bauzas what's the outcome when it's said "drop this flag" ? drop the microversion ?
15:21:39 stephenfin keep the microversion, but drop the '?validate' argument
15:21:50 bauzas and the default being ?
15:22:12 bauzas permissive as I can understand crom 'I don't think so' from johnthetubaguy ?
15:22:17 bauzas from*
15:22:32 stephenfin strict for all known namespaces (hw:, os:, vmware:, ...)
15:22:39 stephenfin don't care for anything outside that set
15:24:09 bauzas I'm cool with this
15:24:15 bauzas stephenfin: ^
15:24:30 bauzas no upgrade impact, pretty clear
15:24:47 bauzas stull leaves nothing unchanged except for already-defined namespaces
15:24:50 bauzas that works for me
15:59:35 gibi stephenfin: and if you have out of tree hw:xxx key then add a custom validator?
15:59:46 gibi or use the old microversion
15:59:59 stephenfin yes
16:00:16 gibi so custom validators can add to in-tree name spaces?
16:00:55 stephenfin they shouldn't but they could, yes
16:00:58 gibi OK
16:01:15 stephenfin we just prevent overriding specific extra specs e.g. 'hw:cpu_policy'
16:01:33 gibi OK, cannot override in-tree defined validators
16:01:51 melwitt gmann: we have a minor emergency regarding the policy warning logging (see the -infra channel). it's melting the logstrash indexing
16:02:05 gibi what if I have namespaced out of tree keys today? like ericsson:awesome_feature_flag ?
16:02:28 stephenfin nothing happens until you add a validator
16:02:35 stephenfin we ignore all unknown namespaces
16:02:40 gibi OK, make sense
16:02:50 openstackgerrit John Garbutt proposed openstack/nova master: Update quota_class APIs for db and api limits https://review.opendev.org/712143
16:02:51 stephenfin (and those without namespaces, fwiw)
16:03:12 openstackgerrit John Garbutt proposed openstack/nova master: Add stub unified limits driver https://review.opendev.org/712137
16:03:23 openstackgerrit John Garbutt proposed openstack/nova master: Assert quota related API behavior when noop https://review.opendev.org/712140
16:03:30 gibi stephenfin, johnthetubaguy: seems like a good idea.
16:03:35 openstackgerrit John Garbutt proposed openstack/nova master: Make unified limits APIs return reserved of 0 https://review.opendev.org/712141
16:03:47 openstackgerrit John Garbutt proposed openstack/nova master: Add logic to enforce local api and db limits https://review.opendev.org/712139
16:03:59 openstackgerrit John Garbutt proposed openstack/nova master: Enforce api and db limits https://review.opendev.org/712142
16:04:16 openstackgerrit John Garbutt proposed openstack/nova master: Update quota_class APIs for db and api limits https://review.opendev.org/712143
16:05:31 johnthetubaguy melwitt: oops :/
16:05:43 johnthetubaguy probably means the same for our users
16:05:49 melwitt yeah :( we were just talking about this the other day but I didn't realize how intense it is
16:06:03 johnthetubaguy does it mean almost every API call?
16:06:14 johnthetubaguy or just a massive storm on restart?
16:06:23 melwitt we need to get it removed asap. we were already talking to gmann about it and he was cool with removing it and doing a reno-only announcement re: policy changes
16:06:41 johnthetubaguy melwitt: is there a patch up?
16:06:45 melwitt looks like every API call
16:07:05 johnthetubaguy yeah, that isn't right :/
16:07:46 melwitt no not that I know of, no patch yet
16:14:45 openstackgerrit Alexandre arents proposed openstack/nova master: Calculate disk_over_committed for raw instances https://review.opendev.org/717037
16:14:52 johnthetubaguy its probably all system only API calls... as our tests probably don't have a system admin user yet
16:16:10 openstackgerrit Stephen Finucane proposed openstack/nova master: api: Add microversion for extra spec validation https://review.opendev.org/708436
16:16:11 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Add documentation for flavor extra specs https://review.opendev.org/710037
16:16:11 openstackgerrit Stephen Finucane proposed openstack/nova master: Drop concept of '?validation' parameter https://review.opendev.org/717789
16:16:12 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Move description of groups to document itself https://review.opendev.org/717790
16:16:12 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Add 'nova' domain and include extra specs in it https://review.opendev.org/717791
16:16:45 stephenfin johnthetubaguy: I think that matches up with what you were expecting ^
16:17:06 stephenfin gibi: Also, I retooled the docs. It's _much_ nicer now (we can cross-reference!)
16:17:31 gibi stephenfin: will look but sounds awesome!
16:19:47 openstackgerrit John Garbutt proposed openstack/nova master: Update limit APIs https://review.opendev.org/712707
16:23:56 gibi bauzas: o/ sorry I could not get to the vgpu series of yours
16:24:01 gibi maybe tomorrow
16:24:08 bauzas gibi: thanks and no worries
16:24:33 bauzas gibi: in the meantime, I'll write to provide a func change for seeing the behaviour
16:24:42 openstackgerrit John Garbutt proposed openstack/nova master: Update quota sets APIs https://review.opendev.org/712749
16:24:45 gibi bauzas: thanks
16:29:55 openstackgerrit John Garbutt proposed openstack/nova master: Tell oslo.limit how to count nova resources https://review.opendev.org/713301
16:33:32 openstackgerrit John Garbutt proposed openstack/nova master: Enforce resource limits using oslo.limit https://review.opendev.org/615180
16:40:52 melwitt johnthetubaguy: I wonder if we should revert https://review.opendev.org/701624 for now? or is there some other way to approach this cc gmann
16:41:00 gibi do somebody know the irc nick of the owner of https://review.opendev.org/#/c/713089/ ? we would need to release the novaclient this week and patches are blocked on this
16:43:01 melwitt gibi: looks like it might be alisterle https://launchpad.net/~alistarle
16:43:41 gibi melwitt: thenk I will try to ping him when he is up
16:43:56 johnthetubaguy melwitt: are we sure we know what is causing the logs, I think it might be the scope chagnes
16:44:14 openstackgerrit John Garbutt proposed openstack/nova master: Add legacy limits and usage to unified limits https://review.opendev.org/713498
16:44:14 openstackgerrit John Garbutt proposed openstack/nova master: Update quota apis with keystone limits and usage https://review.opendev.org/713499
16:44:15 openstackgerrit John Garbutt proposed openstack/nova master: Add reno for unified limits https://review.opendev.org/715271

Earlier   Later