Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-04-02
12:58:39 alex_xu sean-k-mooney: this is where id coming from https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/routes.py#L820
13:00:12 sean-k-mooney ah i see ya we proably shoucl change that to <resouce>_id for all of the usages and add a hacking check.
13:00:33 sean-k-mooney that is a seperate change however so ill remove my -1
13:00:46 sean-k-mooney this is an existing bug
13:02:43 openstackgerrit Huaqiang Wang proposed openstack/nova master: Introduce the 'CPUAllocationPolicy.MIXED' enum https://review.opendev.org/716267
13:02:43 openstackgerrit Huaqiang Wang proposed openstack/nova master: hardware: Add support for 'hw:cpu_dedicated_mask' extra spec https://review.opendev.org/714706
13:02:44 openstackgerrit Huaqiang Wang proposed openstack/nova master: Introduce 'pcpuset' field for InstanceNUMACell https://review.opendev.org/716984
13:19:44 artom stephenfin, could you take a look at the bottom patch in the NUMA LM series? Dan Smith is +2, if you agree, we can at least get the first 2 patches in that series in the gate
13:19:54 stephenfin sure
13:20:06 artom The rest can wait until after FF I guess, since there are probably more important series to review
13:20:26 artom stephenfin, err, link: https://review.opendev.org/#/c/714228/2
13:21:43 bauzas sean-k-mooney: that's a correct assumption, I prevent such thing (supporting multiple types concurrently for *each* pGPU)
13:22:38 sean-k-mooney bauzas: ok. well that is not limitation of mdevs just of the nova/nvida usage
13:22:52 sean-k-mooney bauzas: that is fine for now in anycase
13:22:53 bauzas sean-k-mooney: like I also doesn't want to support yet asking for multiple allocations using groups
13:23:16 bauzas i limit to only one allocation for the VGPU resource class
13:23:25 bauzas I mean, people can ask VGPU>1
13:23:29 bauzas (of course)
13:23:40 bauzas but not with numbered request groups
13:23:45 sean-k-mooney ya that is fine
13:24:04 sean-k-mooney i dont think we shoudl use numbered request groups in teh flavor anyway so im fine with that
13:24:50 bauzas I don't return an exception for this
13:24:54 bauzas I just take the first one
13:25:25 sean-k-mooney that could be an improvement to add as a followup
13:25:39 sean-k-mooney bauzas: its documented which is the important thing
13:25:46 bauzas yup
13:28:21 bauzas sean-k-mooney: yeah I know the mdev framework does that
13:28:41 bauzas (I mean having multiple vGPU types per pGPU=
13:29:13 bauzas but then if you create one mdev with the nvidia driver, then automatically and magically the available instances of vGPU for the other types turn to 0 :D
13:29:28 bauzas (at least GRID10 AFAIK)
13:30:23 bauzas anyway, rushing to finish my change so that I can decently review stephenfin's extra spec validation thingies https://review.opendev.org/#/c/704643/20
13:53:36 openstackgerrit jayaditya gupta proposed openstack/nova master: Support for nova-manage placement heal_allocations --cell https://review.opendev.org/714459
13:54:57 nightmare_unreal mriedem: if you get some time can you see this : https://review.opendev.org/#/c/714459/ . I can't seem to figure out the issue with the unit test case I wrote. Thank you :) . I have fixed rest of the points you mentioned
14:15:16 mriedem nightmare_unreal: this? "Exception: This test uses methods that set internal oslo_db state, but it does not claim to use the database. This will conflict with the setup of tests that do use the database and cause failures later."
14:15:40 mriedem that means the unit test class is using NoDBTestCase or whatever it's called, which means something in the test is trying to make a database connection and isn't allowed,
14:16:10 mriedem so either move that test to the functional test class where there is a DB connection, or you have to mock out the DB call to raise the NotFound error or whatever for the test
14:16:46 mriedem your test can mock objects.CellMapping.get_by_uuid to raise CellMappingNotFound
14:17:59 mriedem @mock.patch('nova.objects.CellMapping.get_by_uuid', side_effect=exception.CellMappingNotFound('uuid')
14:18:05 mriedem something like that as a decorator to the test case method
14:20:19 openstackgerrit Merged openstack/nova master: Combine the limits policies in single place https://review.opendev.org/715678
14:28:28 nightmare_unreal Thanks !!
14:35:11 openstackgerrit jayaditya gupta proposed openstack/nova master: Support for nova-manage placement heal_allocations --cell https://review.opendev.org/714459
14:35:37 dansmith brinzhang_: are you working on feedback on the PUT patch?
14:41:43 francoisp stephenfin, just to draw your attention, I answered your last question on https://review.opendev.org/#/c/669674/10 - thanks!
14:42:03 stephenfin ack
14:48:26 openstackgerrit Alexandre arents proposed openstack/nova master: Calculate over_committed_disk_size for raw instances https://review.opendev.org/717037
15:38:22 gmann melwitt: that is correct. I need to propose some ideas on warning disable on oslo side what discussed with lbragstad. But yes all these are planed before FF. I am hoping to finish the policy things first by this Sat or Sunday.
15:50:16 gibi nova meeting starts in 10 minutes on #openstack-meeting-3
15:50:41 bauzas melwitt: sorry I didn't had time yet to review your nova-manage patches, is it still worth it given the -W ?
15:50:51 dansmith gibi: fyi, I'm running final tests on a change to that PUT patch to address just the critical bits of alex_xu's review
15:50:53 bauzas but of course I'll do it if you want
15:51:23 dansmith didn't get a response from brinzhang_ so I assume he's not working on it right now
15:52:58 gibi dansmith: ack. thanks
15:58:18 gmann dansmith: gibi also we need to add schema tests coverage for None to verify those things.
15:59:27 dansmith gmann: I'm changing how those checks work, which might mean not
15:59:47 dansmith device_name appears to be nullable at least, in the schema and in the db
16:00:02 dansmith the others are all separate definitions I think
16:01:06 gmann yeah, other does not allow None from schema only device do.
16:01:53 openstackgerrit Huaqiang Wang proposed openstack/nova master: Introduce 'pcpuset' field for InstanceNUMACell https://review.opendev.org/716984
16:02:45 openstackgerrit Balazs Gibizer proposed openstack/nova master: Fix assertEqual param order in Accelerator tests https://review.opendev.org/717069
16:02:46 openstackgerrit Balazs Gibizer proposed openstack/nova master: Stabilize functional tests https://review.opendev.org/717070
16:04:18 openstackgerrit Dan Smith proposed openstack/nova master: Allow PUT volume attachments API to modify delete_on_termination https://review.opendev.org/693828
16:04:52 dansmith gmann: ^
16:05:08 gmann thanks checking
16:08:00 tosky for stable maintainers: this last review should remove any reference to legacy-tempest-dsvm-full-devstack-plugin-nfs (then we are doing the same in Cinder): https://review.opendev.org/#/c/714958/
16:08:14 gmann dansmith: do not we nee do check dot with old value vefore change - https://review.opendev.org/#/c/693828/25..26/nova/api/openstack/compute/volumes.py@460
16:08:17 gmann before
16:08:54 dansmith gmann: why? we sad that if you PUT with no changes it's not an error right?
16:09:37 dansmith technically BDM should not be doing a db save if there are no changes, but not all objects do that properly.. but either way, no reason to just add more to the conditional really
16:10:12 gmann dansmith: yeah but when we add policy in next patch that become difficult to handle on "update request" vs "no change means not update request"
16:10:29 dansmith gmann: I don't follow
16:11:08 gmann in case of "swap + update" - we consider request is for update only when value is changed right. if value is same then we need to consider no update request and it is onyl swap
16:11:45 gmann in that case, how we can check the update policy so that that policy is being checked only when request is update (means value change)
16:12:02 dansmith in 2.85 we should only consider it a swap if volumeId is changed
16:12:17 gmann but we support swap + update together also
16:12:23 dansmith i.e. only check the stricter policy if volumeId is changed, otherwise we check the regular PUT policy
16:12:24 gmann >2.85
16:12:55 dansmith the swap policy should imply you can also change the other values right?
16:12:58 gmann yeah and checking regular PUT policy when value is same is wrong.
16:13:11 dansmith I disagre
16:13:32 gmann we want to allow update for non-admin
16:13:36 dansmith if volumeId is changed, we check the swap policy, else check PUT policy
16:13:59 gmann let me rephrase
16:14:23 dansmith in this patch it's all one policy, and the next patch splits them into two
16:16:38 gmann ok, we can discuss in next patch but there question was - we should not check the PUT policy if request is swap only not update.
16:16:56 openstackgerrit Huaqiang Wang proposed openstack/nova master: Introduce 'pcpuset' field for InstanceNUMACell https://review.opendev.org/714658
16:17:08 gmann knowing it is 'not update' is only done by if value is changed
16:17:25 dansmith gmann: and like I said, I think >=2.85, we should only ever consider something a swap if the volumeId changed, otherwise it's a put, even if *nothing* changed
16:18:29 gmann dansmith: that is question actually. if nothing changes should we consider that as update request ? especially when we allow people to replicate the PUT and change only volumeId fir swap
16:18:51 gmann if do so then we endup checking two (PUT and SWAP) policy for swap
16:19:27 dansmith I strongly feel that going forward this should behave like a regular PUT, where you can PUT with no changes all the time,
16:19:38 dansmith and only check the swap policy if you're actually changing the volume
16:19:45 dansmith I don't see how anything else makes sense
16:21:44 gmann dansmith: yeah +1 on 'only check the swap policy if you're actually changing the volume'. but this became hard to implement with no value check of dot.
16:22:00 gmann i think if you rebase the policy patch then it will be clear.
16:22:28 dansmith okay I don't see what the value of dot has to do with which policy gets checked
16:22:38 gmann policy stuff is a challenge here
16:22:50 bauzas gibi: if you don' mind, I would appreciate https://blueprints.launchpad.net/nova/+spec/vgpu-multiple-types to be targeted for ussuri-3
16:23:08 dansmith gmann: do you not agree that if you have swap permissions, you should also be able to change dot?
16:23:09 bauzas the patches in question are small

Earlier   Later