| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-03-30 | |||
| 07:23:50 | bauzas | I'd appreciate if you could review those soon | |
| 08:41:33 | nightmare_unreal | hey like we have assertFlavorMatchesAllocation() do we have opposite of it ? | |
| 08:41:44 | nightmare_unreal | like where assertflavor not match | |
| 08:50:57 | openstackgerrit | John Garbutt proposed openstack/nova master: Add stub unified limits driver https://review.opendev.org/712137 | |
| 09:32:25 | luyao | stephenfin: Hi, your comments are addressed. :) https://review.opendev.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/support-live-migration-with-virtual-persistent-memory | |
| 09:56:00 | openstackgerrit | jayaditya gupta proposed openstack/nova master: Support for --overwrite flag for nova-manage placement heal_allocations command Closes-Bug:#1868997 https://review.opendev.org/715395 | |
| 10:18:35 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: FUP for Add a placement audit command https://review.opendev.org/715797 | |
| 10:18:55 | bauzas | stephenfin: thanks for noting the pep8 issue. fixed ^ | |
| 10:20:15 | openstackgerrit | Andreas Jaeger proposed openstack/nova-specs master: Update hacking for Python3 https://review.opendev.org/715650 | |
| 10:21:28 | openstackgerrit | Andreas Jaeger proposed openstack/os-vif master: Update hacking for Python3 https://review.opendev.org/715651 | |
| 10:32:34 | gibi | bauzas: hi! Does https://review.opendev.org/#/c/715797/ solves the bug 1793569 or we need other things still? | |
| 10:32:35 | openstack | bug 1793569 in OpenStack Compute (nova) "Add placement audit commands" [Wishlist,In progress] https://launchpad.net/bugs/1793569 - Assigned to Sylvain Bauza (sylvain-bauza) | |
| 10:33:08 | bauzas | gibi: just a FUP | |
| 10:33:21 | bauzas | gibi: the one that fixes the issue is https://review.opendev.org/#/c/670112/14 | |
| 10:33:27 | bauzas | hence the Related-Bug | |
| 10:33:44 | gibi | bauzas: bah, you are right. my bad | |
| 10:33:47 | bauzas | just in case people want to backport the fixes | |
| 10:33:57 | bauzas | they could merge both | |
| 10:34:23 | gibi | I just looked at the bug and saw that it is still open then found the FUP | |
| 10:34:33 | gibi | but now I see that the main patch is still on the gate | |
| 10:35:50 | bauzas | np | |
| 10:37:30 | openstackgerrit | Guo Jingyu proposed openstack/nova master: WIP: nova supports password encrypted VNC https://review.opendev.org/622336 | |
| 10:42:52 | openstackgerrit | Guo Jingyu proposed openstack/nova master: WIP: nova supports password encrypted VNC https://review.opendev.org/622336 | |
| 11:30:19 | stephenfin | bauzas: done | |
| 11:47:22 | gibi | gmann: I have a question in https://review.opendev.org/#/c/715071/2 | |
| 12:01:34 | openstackgerrit | Merged openstack/nova master: Add a placement audit command https://review.opendev.org/670112 | |
| 12:01:40 | openstackgerrit | Merged openstack/nova master: Add instance actions v284 samples test https://review.opendev.org/706251 | |
| 12:01:47 | openstackgerrit | Merged openstack/nova master: Add test coverage of existing instance usage log policies https://review.opendev.org/715080 | |
| 12:37:56 | bauzas | stephenfin: ta | |
| 13:22:18 | openstackgerrit | Merged openstack/nova master: Introduce scope_types in os-instance-usage-audit-log https://review.opendev.org/715082 | |
| 13:33:51 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use scatter/gather in HostAPI.compute_node_get https://review.opendev.org/686442 | |
| 13:42:23 | gmann | gibi: checking | |
| 13:42:29 | gibi | gmann: hu | |
| 13:42:30 | gibi | hi | |
| 13:42:49 | gibi | I might miss some stlying thing in those policy descriptions | |
| 13:44:22 | gmann | gibi: let me check generated doc. | |
| 13:48:29 | gmann | gibi: it is generated multiline - https://4ea5dff2d36d88968673-539e9689cff44bf991ce02b5200fbfd6.ssl.cf5.rackcdn.com/715071/2/check/openstack-tox-docs/fcd5a65/docs/configuration/policy.html | |
| 13:48:39 | gmann | gibi: let me fix that. thanks for catching that | |
| 13:48:42 | dansmith | brinzhang_: are you working on the changes to that set or should I? | |
| 13:50:28 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-hypervisors policies https://review.opendev.org/715071 | |
| 13:50:31 | gibi | gmann: thanks. fyi, there is more than one such wrap in the hypervisor patch | |
| 13:51:11 | gmann | gibi: ^^ did but i need to rebase it for test_policy. | |
| 13:51:26 | gibi | gmann: ack | |
| 14:00:50 | hrw | morning | |
| 14:02:29 | hrw | why openstack cli has to be so weird | |
| 14:03:35 | hrw | 'nova volume-attach' but no 'openstack volume attach'. 'openstack volume list' but no 'nova volume-list' | |
| 14:03:38 | hrw | argh | |
| 14:14:32 | dansmith | gibi: 2.84 got taken since friday, so I have to rebase and re-version that set again | |
| 14:14:45 | dansmith | gibi: I think it'd be good to work on lining those up to avoid that churn | |
| 14:16:11 | gibi | dansmith: ack. I won't start rebasing other's patches top of each other as I don't know which patch should be the bottom. | |
| 14:17:10 | dansmith | gibi: even if we just identify all the people competing for numbers and order them so we don't keep rebasing and re-versioning until we're closer would be helpful | |
| 14:20:12 | gibi | I see: https://review.opendev.org/#/c/708436/ and https://review.opendev.org/#/c/701430/ and https://review.opendev.org/#/c/693828/ as API changes. But lyarwood's patch is still on 2.83 | |
| 14:20:57 | gibi | dansmith: as far as I see stephenfin's https://review.opendev.org/#/c/708436/ patch is up to date and I'm +2 of if some other can can review then that can be the next | |
| 14:21:16 | gibi | nvm | |
| 14:21:20 | gibi | 2.85 is the next | |
| 14:21:25 | dansmith | yeah, that's out of date now | |
| 14:21:28 | gibi | so none of the current API patches is up to date | |
| 14:21:29 | dansmith | and I just started on 2.85 | |
| 14:21:37 | dansmith | argh | |
| 14:22:32 | gibi | stephenfin, lyarwood : do you plan to update your patches to 2.85 soon? | |
| 14:22:35 | dansmith | gibi: should I keep reversioning for 2.85 or do you want one of those to go first? | |
| 14:22:55 | stephenfin | gibi: Yeah, I'm respinning it at the moment | |
| 14:23:13 | stephenfin | lyarwood is out 'til Friday though so I guess his will be a while | |
| 14:23:27 | gibi | stephenfin: ack, then you and dansmith are up for the 2.85 | |
| 14:23:53 | stephenfin | how ready is your patch, dansmith? | |
| 14:24:01 | gibi | dansmith: stephenfin would need a second core (besides me) to merge on 2.85 | |
| 14:24:43 | dansmith | stephenfin: slightly less than yours I imagine, since it was already +2, but it's fairly close I think | |
| 14:27:45 | stephenfin | okay, I'll push this now so | |
| 14:27:46 | openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add framework for extra spec validation https://review.opendev.org/704643 | |
| 14:27:47 | openstackgerrit | Stephen Finucane proposed openstack/nova master: api: Add microversion 2.84, extra spec validation https://review.opendev.org/708436 | |
| 14:27:47 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Add documentation for flavor extra specs https://review.opendev.org/710037 | |
| 14:27:58 | stephenfin | and go review that PUT volume attachments patch | |
| 14:28:04 | gibi | stephenfin: you have nothing to loose if you already made the change to 2.85 | |
| 14:29:21 | stephenfin | gibi: Yup, fair. That second patch needs your +2 _yet again_ so :( | |
| 14:29:54 | gibi | I have to drop offline untill 16:00 UTC but I will be back | |
| 14:46:17 | gmann | dansmith: replied on volumeId as optional comment- https://review.opendev.org/#/c/693828/20/nova/api/openstack/compute/volumes.py@447 | |
| 14:46:40 | gmann | dansmith: what if request is for both swap as well as update delete flag ? | |
| 14:46:52 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add new default roles in os-instance-usage-audit-log policies https://review.opendev.org/715085 | |
| 14:46:52 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Pass the actual target in os-instance-usage-audit-log policy https://review.opendev.org/715089 | |
| 14:46:52 | gmann | i think that is brinzhang_ question also ? but not sur | |
| 14:46:54 | gmann | sure | |
| 14:49:31 | dansmith | gmann: okay got it | |
| 15:14:33 | dansmith | artom: around? | |
| 15:19:47 | artom | dansmith, sup | |
| 15:19:55 | openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: Feature matrix: update AArch64 information https://review.opendev.org/715979 | |
| 15:20:30 | hrw | few new entries. mostly volumes related | |
| 15:20:32 | dansmith | artom: if I wanted to support changing a volume attachment tag, I'd need to make a call to the compute node? I haven't looked at all, but what is the procedure when volume attach specifies a tag? | |
| 15:20:55 | dansmith | artom: could I reasonably just change it on the BDM and expect the virt driver to pick it up on the next reboot or something? | |
| 15:20:59 | artom | dansmith, I believe just saving the new tag to the DB is enough | |
| 15:21:04 | dansmith | oh? | |
| 15:21:28 | artom | Lemme refresh my memory on how we actually build metadata | |
| 15:22:04 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing hypervisors policies https://review.opendev.org/715029 | |
| 15:22:20 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in os-hypervisors https://review.opendev.org/715036 | |
| 15:23:08 | openstackgerrit | Marcin Juszkiewicz proposed openstack/nova master: Feature matrix: update AArch64 information https://review.opendev.org/715979 | |
| 15:23:08 | hrw | missed 'nova boot' | |
| 15:24:55 | artom | dansmith, ah, no, we have to call down to the virt driver to rebuild the instance metadata | |
| 15:25:13 | dansmith | okay, that's what I thought | |
| 15:29:53 | gmann | hrw: firs example is from python-novaclient which is python client only for nova (from starting) and has cmd like volume-attach etc. every project has their separate python client. Now we have new unified CLI for the whole openstack which is openstackclient and making all project CLI in standard way for example 'openstack volume attach'. | |
| 15:30:36 | gmann | not all project has finished the new client migration so both are maintained for now. | |
| 15:38:09 | hrw | gmann: I am aware of migration. it started in ocata times or earlier iirc ;D | |