| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-03-27 | |||
| 11:32:55 | tkajinam | sean-k-mooney, I think that is a valid option, though then we should remove deprecated mark about live_migration_uri, IMO. | |
| 11:33:49 | sean-k-mooney | tkajinam: i think its to late for that at this point. the removal has been underway for a while. i just never liked the intoduction of all the other parmaters | |
| 11:34:50 | tkajinam | sean-k-mooney, I see | |
| 11:36:47 | stephenfin | sean-k-mooney: The existing parameter is hard to template | |
| 11:37:01 | sean-k-mooney | not really with jinja | |
| 11:37:05 | stephenfin | and has been the cause of multiple bug reports in TripleO at least | |
| 11:38:14 | sean-k-mooney | i fully expect this to not reduce any bugs | |
| 11:38:39 | sean-k-mooney | they will still happen and now operators will have to learn a new way to configure the config | |
| 11:39:29 | sean-k-mooney | with that said i know why this is being done | |
| 11:40:07 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/stein: Functional test for UnexpectedDeletingTaskStateError https://review.opendev.org/715399 | |
| 11:40:08 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/stein: Unplug VIFs as part of cleanup of networks https://review.opendev.org/715400 | |
| 11:41:27 | sean-k-mooney | just because this nessary it does not mean i like it :) | |
| 11:52:07 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: Functional test for UnexpectedDeletingTaskStateError https://review.opendev.org/715403 | |
| 11:52:08 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: Unplug VIFs as part of cleanup of networks https://review.opendev.org/715404 | |
| 11:53:09 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/queens: Functional test for UnexpectedDeletingTaskStateError https://review.opendev.org/715405 | |
| 11:53:10 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/queens: Unplug VIFs as part of cleanup of networks https://review.opendev.org/715406 | |
| 12:10:03 | openstackgerrit | Merged openstack/nova master: Delete ARQs for an instance when the instance is deleted. https://review.opendev.org/673735 | |
| 12:15:54 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Integrate mypy https://review.opendev.org/676208 | |
| 12:15:54 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Update and correct typing information https://review.opendev.org/714694 | |
| 12:15:55 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Add typing information https://review.opendev.org/714695 | |
| 12:15:55 | openstackgerrit | Stephen Finucane proposed openstack/nova master: tests: Split instance NUMA object tests https://review.opendev.org/714696 | |
| 12:15:56 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Replace 'cpu_pinning_requested' helper https://review.opendev.org/714697 | |
| 12:15:56 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Don't consider overhead CPUs for unpinned instances https://review.opendev.org/714698 | |
| 12:15:57 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Remove handling of pre-Train compute nodes https://review.opendev.org/714699 | |
| 12:15:57 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Add validation for 'cpu_realtime_mask' https://review.opendev.org/468203 | |
| 12:15:58 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Tweak the 'cpu_realtime_mask' handling slightly https://review.opendev.org/461456 | |
| 12:15:58 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Rework 'get_realtime_constraint' https://review.opendev.org/714700 | |
| 12:15:59 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Invert order of NUMA topology generation https://review.opendev.org/714701 | |
| 12:39:24 | nightmare_unreal | what does greynade-py3 checks/do ? | |
| 12:39:34 | nightmare_unreal | i am getting failure for that on review.openstack | |
| 12:58:48 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Remove '_numa_fit_instance_cell_with_pinning' https://review.opendev.org/714703 | |
| 13:27:46 | openstackgerrit | jayaditya gupta proposed openstack/nova master: Support for --overwrite flag for nova-manage placement heal_allocations command https://review.opendev.org/715395 | |
| 13:44:21 | dansmith | gibi: ack, I'll start on that | |
| 13:44:58 | gibi | dansmith: thanks | |
| 13:45:03 | gibi | and good morning | |
| 13:45:21 | dansmith | gibi: 'mornin' | |
| 13:45:33 | dansmith | gibi: am I seeing this right that these are not in a related stack? | |
| 13:45:51 | dansmith | er, wait, maybe there are just some that are outside the stack | |
| 13:45:56 | gibi | there is at least a separate patch that renames the existing update policy | |
| 13:46:16 | dansmith | okay I started on that and yeah, okay | |
| 13:46:17 | gibi | this is the policy rename https://review.opendev.org/#/c/715356/ | |
| 13:46:48 | gibi | the rest is in a stack starting at https://review.opendev.org/#/c/693828/19 | |
| 13:46:59 | dansmith | yep, I got it | |
| 13:47:09 | dansmith | this needs a microversion rebase anyway | |
| 13:47:29 | dansmith | gibi: it might be good to start lining up any other patches that have a microversion so we're not spending lots of time re-versioning things | |
| 13:47:45 | gibi | true, and good point | |
| 13:48:12 | owalsh | sean-k-mooney: hey, re https://bugs.launchpad.net/nova/+bug/1677913 | |
| 13:48:14 | openstack | Launchpad bug 1677913 in OpenStack Compute (nova) "percent must be escaped in live_migration_uri" [Low,In progress] - Assigned to Stephen Finucane (stephenfinucane) | |
| 13:48:14 | gibi | at least I haven't approved any new microversion bumping patch today | |
| 13:49:01 | owalsh | sean-k-mooney: problem is that nova is doing string interpolation e.g uri % dest | |
| 13:49:22 | owalsh | which is fine for qemu+ssh://%s:123/ | |
| 13:49:26 | sean-k-mooney | owalsh: yes but you should not be url encoding extra params unless they are unsupportd | |
| 13:49:35 | sean-k-mooney | e.g. once that libvirt does not know about | |
| 13:49:50 | owalsh | sean-k-mooney: and url endeded extra params contain % | |
| 13:49:52 | sean-k-mooney | if they are part of the standard set you dont need to encode them | |
| 13:50:21 | sean-k-mooney | owalsh: then ooo should have escaped them properly | |
| 13:50:46 | owalsh | sean-k-mooney: nope, we had to double escape them | |
| 13:51:09 | owalsh | i.e %% so the nova sting interpolation replaces it with a single % | |
| 13:51:10 | sean-k-mooney | owalsh: so you had to put 4 % | |
| 13:51:26 | sean-k-mooney | owalsh: yes im saying that is the correct thing to do | |
| 13:51:58 | sean-k-mooney | owalsh: nova reuired you to provide a vail python sting that will be interperalted | |
| 13:52:10 | sean-k-mooney | so ooo should have escaped the % | |
| 13:53:45 | sean-k-mooney | owalsh: looking at the standard extra paramater i dont think any of them shoudl reuire a % | |
| 13:53:47 | sean-k-mooney | https://libvirt.org/uri.html#Remote_URI_parameters | |
| 13:53:54 | sean-k-mooney | which one was ooo trying to use | |
| 13:53:55 | dansmith | gibi: gmann it looks like the put expects the client to remove the 'device' from the put? meaning if it does a get on the thing, then it has to remove 'device' before it can put that back... | |
| 13:54:28 | dansmith | gibi: gmann that makes no sense to me, but hopefully it's okay to change that in the new microversion to just be ignored so you can get/put the thing REST-style? | |
| 13:54:35 | owalsh | sean-k-mooney: erm, it's been years.. probably ssh key path | |
| 13:54:50 | sean-k-mooney | owalsh: why would that contain a % | |
| 13:55:30 | sean-k-mooney | while technically legal in a file name it would not be common or expect practic to see a % in a path | |
| 13:55:38 | owalsh | sean-k-mooney: libvirt docs say "Note that parameter values must be URI-escaped" | |
| 13:55:50 | sean-k-mooney | no read the full sentence | |
| 13:56:07 | owalsh | pretty sure it means all parameter values | |
| 13:56:19 | sean-k-mooney | Any others are passed unmodified through to the back end | |
| 13:56:44 | sean-k-mooney | it only applies to the parmater not supproted in the table below as far as i know | |
| 13:57:14 | owalsh | that would be weird TBH, not a valid uri | |
| 13:57:27 | gibi | dansmith: I think that is an artifact of the implementation, the device gets automatically calculated | |
| 13:57:27 | sean-k-mooney | a uri is not a url | |
| 13:57:32 | gmann | dansmith: volume attachment PUT right ? | |
| 13:57:35 | nightmare_unreal | mriedem: ping | |
| 13:57:39 | sean-k-mooney | they do not have the same constratits on formating | |
| 13:58:26 | dansmith | gibi: I know in create, but on update you should be able to GET, modify, PUT, without having to delete things.. things that aren't update-able that are unchanged are just retained | |
| 13:58:28 | dansmith | gmann: yes | |
| 13:58:42 | gmann | dansmith: yeah we restrict it on schema side- https://github.com/openstack/nova/blob/e78343dcff7feb0975ffd10ff41ab4368611c285/nova/api/openstack/compute/schemas/volumes.py#L95 | |
| 13:59:01 | owalsh | sean-k-mooney: wasn't just ooo that hit this FWIW, I'll try to dig up the info from back then | |
| 13:59:27 | dansmith | gmann: exactly.. I'm saying we should add that back in in the new microversion | |
| 13:59:28 | gibi | dansmith: you are right about the generic PUT behavior. However I'm not sure if there is a swap volume nova will keep the device name the same | |
| 13:59:54 | dansmith | gibi: I know, you can't *change* it, you should just be allowed to pass it | |
| 14:00:28 | gibi | it might be that you pass the same value in via PUT (swap case) but as a result the value of the device field changes by nova | |
| 14:00:41 | dansmith | sure, fine | |
| 14:00:47 | dansmith | but right now, it's not allowed by schema | |
| 14:01:06 | dansmith | so in the new microversion I want it to be allowed, just not change-able, so you can PUT what you GET | |
| 14:01:37 | mriedem | allowing a field that you can't change in a PUT request is weird | |
| 14:01:48 | dansmith | eh? | |
| 14:02:11 | dansmith | that's the whole point of PUT, that you're PUTting the whole thing back, otherwise it'd be a PATCH | |
| 14:02:11 | gibi | so if cinder will not provide the device then nova will reject? | |
| 14:02:18 | dansmith | gibi: no,we can keep it optional | |
| 14:02:26 | gibi | dansmith: OK, in that case I'm fine | |
| 14:02:30 | gibi | with the change | |
| 14:02:35 | dansmith | cool | |