| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-03-26 | |||
| 20:17:30 | dansmith | ah okay, I haven't really gotten to that patch at all | |
| 20:17:33 | dansmith | so... good :) | |
| 20:17:44 | sean-k-mooney | so that works at least although the respocne code still looks wrong to me | |
| 20:17:54 | sean-k-mooney | it should proably be a 400 or 409 | |
| 20:22:29 | dansmith | I thought we agreed on 403? | |
| 20:22:45 | sean-k-mooney | we proably did | |
| 20:23:08 | sean-k-mooney | i just find 403 forbiden which is normaly used for auth issues confusing | |
| 20:23:33 | sean-k-mooney | i would expect to get 403 if i did not have enough permission to do something not because its unsupported | |
| 20:26:15 | dansmith | IIRC, 401 means "authorization required" and 403 means "not permitted" - the latter which may or may not be because of insufficient or missing credentials | |
| 20:26:40 | sean-k-mooney | https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/403 | |
| 20:26:49 | dansmith | "401 Unauthorized: If the request already included Authorization credentials, then the 401 response indicates that authorization has been refused for those credentials. 403 Forbidden: The server understood the request, but is refusing to fulfill it" | |
| 20:27:19 | dansmith | "tied to the application logic" | |
| 20:27:36 | sean-k-mooney | ya it gives us leway to use it this way | |
| 20:27:45 | dansmith | "such as (but not limited to) insufficient rights" | |
| 20:28:10 | sean-k-mooney | im just used to thinking about it as related to authorisation | |
| 20:28:33 | melwitt | zzzeek: I've been tracing the gate bug situation with DNM debug logging and the latest thing I found is that this call to _create_session never returns https://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/enginefacade.py#L657-L658 any ideas how or why that could happen? | |
| 20:28:35 | dansmith | I think a lot of things don't use 401 and 403 properly, so it's common to not have a gut feeling about the difference | |
| 20:33:13 | sean-k-mooney | so this is interesting GET /placement/allocation_candidates?limit=1000&resources=DISK_GB%3A1%2CMEMORY_MB%3A64%2CVCPU%3A1&root_required=COMPUTE_ACCELERATORS%2C%21COMPUTE_STATUS_DISABLED | |
| 20:33:45 | sean-k-mooney | the placement request for the evacuate gets teh trait added by the prefilter | |
| 20:33:52 | sean-k-mooney | but not the resouce requests | |
| 20:37:22 | dansmith | yeah, that's weird... that means the prefilter is seeing the device profile in the flavor | |
| 20:37:29 | sean-k-mooney | yep | |
| 20:37:51 | sean-k-mooney | im not seeing any attepmet to update teh ARQ | |
| 20:38:28 | sean-k-mooney | did we move to putting the resouce groups form the device profile into the request spec | |
| 20:38:59 | melwitt | gmann: I have a followup patch here related to the new policy rule I added earlier in the cycle, would appreciate your review https://review.opendev.org/713295 | |
| 20:44:15 | sean-k-mooney | interesting the "requested_resources" is null http://paste.openstack.org/show/791213/ | |
| 20:48:58 | sean-k-mooney | we do populate the accel_info in the resouces https://review.opendev.org/#/c/631244/69/nova/compute/manager.py@2604 | |
| 20:50:10 | sean-k-mooney | but i guess we never save that sice we call save on line 2570 | |
| 20:53:08 | sean-k-mooney | actully saving the instance in not important | |
| 21:46:17 | openstackgerrit | Merged openstack/nova master: nova-net: Remove unused parameters https://review.opendev.org/703974 | |
| 21:46:18 | sean-k-mooney | dansmith: found the issue i think. https://github.com/openstack/nova/blob/9d212738bec63d7490998a2840598d790a3c94fc/nova/conductor/manager.py#L1121-L1128 | |
| 23:05:46 | openstackgerrit | sean mooney proposed openstack/nova master: [WIP] cyborg evacuate support https://review.opendev.org/715326 | |
| 23:48:25 | gmann | melwitt: +1. lgtm | |
| 23:48:40 | melwitt | thanks | |
| #openstack-nova - 2020-03-27 | |||
| 00:24:10 | openstackgerrit | Brin Zhang proposed openstack/nova master: Expose instance action event details out of the API https://review.opendev.org/694430 | |
| 00:24:11 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add instance actions v284 samples test https://review.opendev.org/706251 | |
| 00:27:56 | gmann | brinzhang_: thanks, lgtm. though you are racing on 2.84 with stephenfin. let's see who win. | |
| 00:28:53 | brinzhang_ | gmann: np, thanks for concerning this | |
| 00:52:10 | brinzhang_ | gibi, stephenfin: instance action events patch updated done. https://review.opendev.org/#/c/694430/ | |
| 00:53:13 | openstackgerrit | Merged openstack/nova master: Create and bind Cyborg ARQs. https://review.opendev.org/631244 | |
| 01:05:03 | gmann | johnthetubaguy: how about making GET flavor access default to @ instead of admin-only. we cannot verify the owner in this API so anyone trying this API and not having the access to flavor will anyway get 404. changing to admin as i proposed currently will disallow the tenants who have access to flavor - https://review.opendev.org/#/c/713697/3/nova/policies/flavor_access.py@68 | |
| 01:06:58 | gmann | johnthetubaguy: keeping @ will keep existing deployment working as it is and also does not show flavor-access info to all who does not have access. | |
| 01:34:30 | openstackgerrit | Kevin Zhao proposed openstack/nova master: fix scsi disk unit number of the attaching volume when cdrom bus is scsi https://review.opendev.org/712607 | |
| 02:07:25 | openstackgerrit | Merged openstack/nova master: Pass accelerator requests to each virt driver from compute manager. https://review.opendev.org/698581 | |
| 02:09:07 | brinzhang_ | gmann: Can I push a new to change the os-volume-attachment:update policy to os-volume-attachment:swap policy for swap volume api? | |
| 02:09:47 | brinzhang_ | gmann: and I would update the releasenote message with update attachments API changes | |
| 02:10:36 | gmann | brinzhang_: you mean to do in this ? https://review.opendev.org/#/c/711194/7 | |
| 02:11:09 | brinzhang_ | gmann: I dont want to change this in the update attachments API, it will looks complex | |
| 02:11:12 | brinzhang_ | gmann: yes | |
| 02:11:38 | gmann | brinzhang_: yeah that is fine. but functional tests you are merging right ? | |
| 02:11:45 | brinzhang_ | The 2 point you said | |
| 02:12:02 | brinzhang_ | gmann: maybe not merge the functional tests | |
| 02:12:04 | gmann | api-ref and functional sample test change we should do while changing code | |
| 02:12:58 | gmann | policy change is ok to do in separate as it change the other polciy also but api-ref and functional tests we do together with code change to get the complete picture in same patch | |
| 02:13:09 | brinzhang_ | To be honest, doing this function from scratch will waste my double time. I started thinking that now Dansmith insists, and I regret that I didn't insist on doing so at the time. | |
| 02:13:55 | brinzhang_ | gmann: ok, I can consinder merge the functional tests to the api change | |
| 02:14:27 | brinzhang_ | s/Dansmith/dansmith/ | |
| 02:15:56 | brinzhang_ | gmann: I think the PS32 what I should next to do https://review.opendev.org/#/c/580336/32/specs/ussuri/approved/destroy-instance-with-datavolume.rst | |
| 02:16:26 | brinzhang_ | Although I haven't finished all the reviews | |
| 02:16:52 | gmann | brinzhang_: yeah that way. but do not worry about spec update. we can do that later once code is done | |
| 02:17:54 | brinzhang_ | gmann: yeah, I will try my best, try not to postpone | |
| 02:20:11 | gmann | brinzhang_: if i remember that is 1. making volumeId in request as optional 2. if it is present and different then url volume_id perform swap operation OR if not present or same as url volume_id then update the delete flag. | |
| 02:21:03 | brinzhang_ | gmann: yes, that's the same as wrote in PS32 of its SPEC | |
| 02:21:13 | gmann | ok. | |
| 03:47:31 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-hypervisors policies https://review.opendev.org/715071 | |
| 03:48:28 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Pass the actual target in os-hypervisors policy https://review.opendev.org/715074 | |
| 06:08:34 | openstackgerrit | Kevin Zhao proposed openstack/nova master: fix scsi disk unit number of the attaching volume when cdrom bus is scsi https://review.opendev.org/712607 | |
| 06:29:05 | openstackgerrit | Kevin Zhao proposed openstack/nova master: fix scsi disk unit number of the attaching volume when cdrom bus is scsi https://review.opendev.org/712607 | |
| 06:49:29 | openstackgerrit | Brin Zhang proposed openstack/nova master: Change policy name of swap volume API https://review.opendev.org/715356 | |
| 06:53:43 | openstackgerrit | Kevin Zhao proposed openstack/nova master: fix scsi disk unit number of the attaching volume when cdrom bus is scsi https://review.opendev.org/712607 | |
| 07:41:14 | gibi | sean-k-mooney: thanks for checking the os-vif repo. Do we need to mark somehow that the previous release is the final one for Ussuir? | |
| 07:46:02 | aarents | Hi! lyarwood: if you have some time today: https://review.opendev.org/#/c/696084/ | |
| 08:05:36 | openstackgerrit | Merged openstack/nova master: Compose accelerator PCI devices into domain XML in libvirt driver. https://review.opendev.org/631245 | |
| 08:14:22 | gibi | brinzhang_: thanks for the update on https://review.opendev.org/#/c/694430 I have on suggestion for the policy doc wording. If you can quickly respin then I'm +2 right away | |
| 08:18:29 | brinzhang_ | gibi: yeah, I will update that | |
| 08:18:43 | gibi | brinzhang_: thanks | |
| 08:19:52 | gibi | brinzhang_: I see that you saw the result of the yesterday's discusson on the PATCH v.s. PUT. If you need any help to make this change happen then let me know | |
| 08:20:40 | openstackgerrit | Brin Zhang proposed openstack/nova master: Expose instance action event details out of the API https://review.opendev.org/694430 | |
| 08:21:32 | brinzhang_ | gibi: done, thanks | |
| 08:23:35 | brinzhang_ | gibi: I'm not sure if I can make it in the near future. I'm full next week. I understand what dansmith said, that's what I wrote in SPEC's PS32. Of course I would be happy if someone is willing to help update. | |
| 08:24:26 | gibi | brinzhang_: thanks I'm +2 on the event details patch | |
| 08:24:43 | brinzhang_ | gibi: If no one can help, I will try to complete it ASAP. | |
| 08:25:44 | gibi | brinzhang_: ack. If you can make the update then we can review with dansmith if you cannot then I think dansmith is willing to do the update but then we need to bring in another core to review | |
| 08:26:32 | brinzhang_ | gibi: I know this. | |
| 08:28:43 | brinzhang_ | gibi: I think gmann, stephenfin, alex_xu and you can review quickly | |
| 08:29:56 | brinzhang_ | gibi: I don't want the feature freeze to not complete it because I don't have time to do it. | |
| 08:30:12 | brinzhang_ | So expose this risk early. | |
| 08:30:23 | gibi | thanks for being honest | |
| 08:30:30 | gibi | about the risk | |
| 08:30:38 | gibi | I will talk to dansmith when he is up today | |
| 08:31:52 | gibi | as I understand you think it would be better if he (or somebody else) takes over the patch | |
| 08:32:01 | brinzhang_ | thanks gibi | |
| 08:34:04 | brinzhang_ | gibi: Yes, as dansmith said, this change is not difficult, it just takes time and I can take the time to review it together. | |
| 08:59:37 | openstackgerrit | Luyao Zhong proposed openstack/nova master: support live migration with vpmem https://review.opendev.org/687856 | |
| 08:59:37 | openstackgerrit | Luyao Zhong proposed openstack/nova master: partial support for live migration with specific resources https://review.opendev.org/715362 | |
| 09:47:30 | openstackgerrit | jayaditya gupta proposed openstack/nova master: Support for nova-manage placement heal_allocations --cell https://review.opendev.org/714459 | |
| 10:19:57 | openstackgerrit | John Garbutt proposed openstack/nova master: Add legacy limits and usage to unified limits https://review.opendev.org/713498 | |
| 10:20:15 | openstackgerrit | John Garbutt proposed openstack/nova master: Update quota apis with keystone limits and usage https://review.opendev.org/713499 | |
| 10:21:00 | openstackgerrit | John Garbutt proposed openstack/nova master: Add reno for unified limits https://review.opendev.org/715271 | |
| 11:08:49 | sean-k-mooney | gibi: i dont think so. at least not currently. the release team will propose a patch to all the project after the first rc is out to bump all the releases for the stable branch creation | |