Posted	Nick	Remark
#openstack-nova - 2020-03-24
15:22:27	sean-k-mooney	ok ill be afk for about an hour or so. bbl
15:31:03	gibi	lyarwood, stephenfin: is this a bugfix or a feature? https://review.opendev.org/#/c/696834
15:32:19	stephenfin	gibi: It's probably closer to a feature. We couldn't do this before and now we can
15:32:57	stephenfin	Should there be a specless blueprint? I didn't think of that
15:34:44	stephenfin	alex_xu: Think you could look at this? https://review.opendev.org/#/c/666915/
15:37:24	gibi	stephenfin: would be nice to track it somehow. I'm OK to have a specless bp as the impl basically done and only affects the libvirt driver
15:37:42	gibi	this is a bit of paperwork I know
15:39:09	openstackgerrit	Luigi Toscano proposed openstack/nova stable/pike: Remove exp legacy-tempest-dsvm-full-devstack-plugin-nfs https://review.opendev.org/702061
15:50:42	openstackgerrit	Merged openstack/nova-specs master: Move 'live migration with vpmems' spec https://review.opendev.org/708229
16:08:16	tosky	oh, the last nova-live-migration fix is finally fine on stable/pike: it just needs another +2 (and a +w)! https://review.opendev.org/#/c/713036/
16:20:27	openstackgerrit	Merged openstack/nova master: Enforce os-traits/SUPPORTED_STORAGE_BUSES sync https://review.opendev.org/709233
16:27:23	openstackgerrit	John Garbutt proposed openstack/nova master: Update quota_class APIs for db and api limits https://review.opendev.org/712143
16:36:20	dansmith	kinda seems like the openstack sdk test is failing a lot
16:36:28	dansmith	I didn't see that mentioned on the recent gate bug thread
16:37:03	dansmith	it has failed a couple times in a row with a bunch of missing packages
16:38:09	dansmith	ah, known mirror failure which might be fixed now
16:43:48	openstackgerrit	Stephen Finucane proposed openstack/nova master: hardware: Add validation for 'cpu_realtime_mask' https://review.opendev.org/468203
16:43:48	openstackgerrit	Stephen Finucane proposed openstack/nova master: hardware: Tweak the 'cpu_realtime_mask' handling slightly https://review.opendev.org/461456
16:43:49	openstackgerrit	Stephen Finucane proposed openstack/nova master: hardware: Update and correct typing information https://review.opendev.org/714694
16:43:49	openstackgerrit	Stephen Finucane proposed openstack/nova master: libvirt: Add typing information https://review.opendev.org/714695
16:43:50	openstackgerrit	Stephen Finucane proposed openstack/nova master: tests: Split instance NUMA object tests https://review.opendev.org/714696
16:43:50	openstackgerrit	Stephen Finucane proposed openstack/nova master: objects: Replace 'cpu_pinning_requested' helper https://review.opendev.org/714697
16:43:51	openstackgerrit	Stephen Finucane proposed openstack/nova master: hardware: Don't consider overhead CPUs for unpinned instances https://review.opendev.org/714698
16:43:51	openstackgerrit	Stephen Finucane proposed openstack/nova master: hardware: Remove handling of pre-Train compute nodes https://review.opendev.org/714699
16:43:52	openstackgerrit	Stephen Finucane proposed openstack/nova master: hardware: Rework 'get_realtime_constraint' https://review.opendev.org/714700
16:43:52	openstackgerrit	Stephen Finucane proposed openstack/nova master: hardware: Invert order of NUMA topology generation https://review.opendev.org/714701
16:43:53	openstackgerrit	Stephen Finucane proposed openstack/nova master: hardware: 'numa_fit_instance_to_host' requires 'limits' argument https://review.opendev.org/714702
16:43:53	openstackgerrit	Stephen Finucane proposed openstack/nova master: hardware: Remove '_numa_fit_instance_cell_with_pinning' https://review.opendev.org/714703
16:43:54	openstackgerrit	Stephen Finucane proposed openstack/nova master: WIP! objects: Add 'CPUAllocationPolicy.MIXED' enum https://review.opendev.org/714704
16:43:54	openstackgerrit	Stephen Finucane proposed openstack/nova master: WIP! objects: Add 'InstanceNUMACell.pcpuset' field https://review.opendev.org/714705
16:43:54	stephenfin	huaqiang: ^
16:43:55	openstackgerrit	Stephen Finucane proposed openstack/nova master: WIP! hardware: Add support for 'hw:cpu_dedicated_mask' extra spec https://review.opendev.org/714706
16:43:55	openstackgerrit	Stephen Finucane proposed openstack/nova master: WIP! hardware: Start configuring 'InstanceNUMACell.pcpuset' https://review.opendev.org/714707
16:53:48	openstackgerrit	John Garbutt proposed openstack/nova master: Update limit APIs https://review.opendev.org/712707
16:53:49	openstackgerrit	John Garbutt proposed openstack/nova master: Update quota sets APIs https://review.opendev.org/712749
17:07:43	sean-k-mooney	stephenfin: im going to rebase https://review.opendev.org/#/c/666915/24 since its in merge conflict
17:07:58	stephenfin	sean-k-mooney: go for it
17:30:28	openstackgerrit	sean mooney proposed openstack/nova master: libvirt: Use domain capabilities to get supported device models https://review.opendev.org/666915
17:30:29	openstackgerrit	sean mooney proposed openstack/nova master: Add transform_image_metadata request filter https://review.opendev.org/665775
17:49:56	openstackgerrit	Merged openstack/nova stable/pike: nova-live-migration: Wait for n-cpu services to come up after configuring Ceph https://review.opendev.org/713036
17:53:59	openstackgerrit	John Garbutt proposed openstack/nova master: Tell oslo.limit how to count nova resources https://review.opendev.org/713301
18:18:13	openstackgerrit	Elod Illes proposed openstack/nova stable/pike: pike-only: remove broken non-voting ceph jobs https://review.opendev.org/700072
18:33:42	openstackgerrit	Elod Illes proposed openstack/nova stable/pike: Init HostState.failed_builds https://review.opendev.org/669538
20:11:06	openstackgerrit	Lee Yarwood proposed openstack/nova stable/pike: Improve metadata server performance with large security groups https://review.opendev.org/697523
20:14:34	lyarwood	melwitt: https://review.opendev.org/#/q/I77ebada015f6522a300be4fa043fb8676458402b - could you hit this if you have time today?
20:14:59	melwitt	lyarwood: sure
20:15:13	lyarwood	melwitt: https://review.opendev.org/#/q/I8af2ad741ca08c3d88efb9aa817c4d1470491a23 - and this if you wouldn't mind
20:15:34	melwitt	sure
20:16:17	lyarwood	thanks :)
20:17:12	melwitt	np
23:15:19	alex_xu	dansmith: thanks
#openstack-nova - 2020-03-25
00:54:23	openstackgerrit	Brin Zhang proposed openstack/python-novaclient master: Microversion 2.83 - action event fault details https://review.opendev.org/714561
00:58:13	openstackgerrit	Merged openstack/nova stable/pike: rt: only map compute node if we created it https://review.opendev.org/676463
00:58:29	openstackgerrit	Brin Zhang proposed openstack/nova master: Expose instance action event details out of the API https://review.opendev.org/694430
00:58:29	openstackgerrit	Brin Zhang proposed openstack/nova master: Add instance actions v283 samples test https://review.opendev.org/706251
00:58:59	brinzhang_	stephenfin, gibi: updated done of bp/action-event-fault-details https://review.opendev.org/694430
01:05:38	openstackgerrit	Merged openstack/nova stable/pike: pike-only: remove broken non-voting ceph jobs https://review.opendev.org/700072
01:11:52	brinzhang_	dansmith: Did you see my reply in https://review.opendev.org/#/c/693828/?
01:21:23	brinzhang_	sean-k-mooney: I left some comments in https://review.opendev.org/#/c/631244/69/nova/accelerator/cyborg.py@214, can you check again? if it's true, I think that can be don by follow up.
01:34:48	gmann	brinzhang_: one comment on policy check for older version - https://review.opendev.org/694430
01:36:04	brinzhang_	gmann: will check
01:40:38	brinzhang_	gmann: https://review.opendev.org/#/c/694430/11/nova/api/openstack/compute/instance_actions.py@187 it does not many impact as before, right?
01:41:43	gmann	brinzhang_: one more comment on policy name
01:42:10	gmann	brinzhang_: you mean for request with <2.83 ?
01:42:31	brinzhang_	but that can reduce to judgement the policy,
01:42:57	gmann	yeah, with <2.83 we anyhow will not show the 'details' field so no need to check policy things also
01:44:01	brinzhang_	ok, I will change to your write
01:44:34	brinzhang_	change The value will be ``null`` for old records. to The value will be ``null`` for older version. is it ok?
01:45:26	openstackgerrit	melanie witt proposed openstack/nova master: DNM: try to get some debug info for bug 1844929 https://review.opendev.org/701478
01:45:27	openstack	bug 1844929 in OpenStack Compute (nova) "grenade jobs failing due to "Timed out waiting for response from cell" in scheduler" [High,Confirmed] https://launchpad.net/bugs/1844929
01:46:27	gmann	brinzhang_: that is I am confuse, older version you mean API version ?
01:46:44	gmann	because for older microversion we are not showing the field itself.
01:46:47	brinzhang_	yes, before microversion 2.83
01:47:32	gmann	ok, then you can remove that line as that field is present in response only after 2.83. if request if with <2.83 then 'details' itself is not present
01:48:02	brinzhang_	ok
01:48:19	brinzhang_	remove this line
01:48:32	gmann	your api-ref change reflect that this field is new in 2.83
01:48:40	gmann	+1
02:05:00	openstackgerrit	Brin Zhang proposed openstack/nova master: Expose instance action event details out of the API https://review.opendev.org/694430
02:05:00	openstackgerrit	Brin Zhang proposed openstack/nova master: Add instance actions v283 samples test https://review.opendev.org/706251
02:05:12	brinzhang_	gmann: done, thanks
02:05:51	brinzhang_	because of the policy name changes, I have tested in my local, it works fine.
02:08:38	openstackgerrit	Brin Zhang proposed openstack/nova master: Expose instance action event details out of the API https://review.opendev.org/694430
02:08:59	openstackgerrit	Brin Zhang proposed openstack/nova master: Add instance actions v283 samples test https://review.opendev.org/706251
02:11:39	openstackgerrit	melanie witt proposed openstack/nova master: DNM: try to get some debug info for bug 1844929 https://review.opendev.org/701478
02:11:41	openstack	bug 1844929 in OpenStack Compute (nova) "grenade jobs failing due to "Timed out waiting for response from cell" in scheduler" [High,Confirmed] https://launchpad.net/bugs/1844929
02:20:40	gmann	brinzhang_: after reading the 2.62 changes, i think we do not need the new policy. we already have existing policy which can control the info from non-admin. commented on spec also
02:20:56	gmann	let's wait for sean-k-mooney reply. https://review.opendev.org/#/c/694430/13/nova/policies/instance_actions.py@52
02:22:28	gmann	i think sean-k-mooney concern was we should not pass these info to non-admin which is controlled via existing policy also, like host info in 'events' - https://github.com/openstack/nova/blob/f454e1dec9580abf4605e071bdd678a40f492a49/nova/api/openstack/compute/instance_actions.py#L170
02:35:06	brinzhang_	gmann: I cannot open github, you mean the https://review.opendev.org/#/c/694430/13/nova/api/openstack/compute/instance_actions.py@172
02:35:35	brinzhang_	gmann: the show_host = api_version_request.is_supported(req, '2.62')?
02:35:37	gmann	brinzhang_: yeah, show_host with 2.62
02:37:25	gmann	brinzhang_: let's wait for sean-k-mooney reply before changes in case something i missed
02:37:50	brinzhang_	gmann: the .BASE_POLICY_NAME % 'events' is a rule_admin policy
02:37:54	openstackgerrit	Merged openstack/nova stable/train: libvirt: Provide the backing file format when creating qcow2 disks https://review.opendev.org/710788
02:38:34	brinzhang_	gmann: ok, let sean-k-mooney check again
02:40:41	gmann	yeah event policy is admin by default
02:42:07	brinzhang_	so show_host can be shown for an admin user, I think the details policy (SYSTEM_READER) is suitable for now.
02:44:46	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing flavor_manage policies https://review.opendev.org/714814
02:47:00	openstackgerrit	Brin Zhang proposed openstack/nova-specs master: [Trivial] Remove note for the implementation https://review.opendev.org/714817

Earlier   Later