Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-03-18
19:41:29 gmann https://github.com/openstack/nova/blob/c9f5b583b6072f542d1757e35fd6305b9698496a/nova/api/openstack/compute/flavor_access.py#L50-L75
19:41:44 sean-k-mooney gmann: right so if you use an older microversion then what happens
19:42:13 gmann with older than 2.7 yes you can add.
19:42:39 sean-k-mooney i suspect horizon is using older then 2.7
19:42:52 sean-k-mooney why did we make that change?
19:43:27 gmann well, public means for everyone so we do not really need to add access things right
19:44:05 sean-k-mooney gmann: basicaly i tought we effectivly deprecated is_public and ignored it
19:44:21 sean-k-mooney gmann: so if you use falvor acess it effectivly became private
19:44:32 sean-k-mooney excpet to the tenants listed
19:46:00 sean-k-mooney gmann: if that is not the case then i agree that this should be mutable in the flavor api
19:46:34 sean-k-mooney you cant really gracefully retire a flavor othersize.
19:47:22 sean-k-mooney it looks like it was change as a result of this bug https://bugs.launchpad.net/nova/+bug/1361476
19:47:22 openstack Launchpad bug 1361476 in OpenStack Compute (nova) "flavor access create should check public/private first" [Low,Fix released] - Assigned to Sergey Nikitin (snikitin)
19:47:51 gmann humm, but will change in is_public on embedded instances effect like make that flavor stale. the reason we do not allow flavor modification on other parameters.
19:48:14 sean-k-mooney my expectation is that if a flaovr is public and i add a tenatn via os-flavor-access then any tenant other then those listed via flavor access would not see it
19:48:48 sean-k-mooney gmann: is public on the embeded instance has no meaning
19:49:03 gmann and keep is_public same ?
19:49:03 sean-k-mooney so i dont think its an issue
19:49:13 gmann listing flavor?
19:49:17 sean-k-mooney yes
19:49:30 sean-k-mooney so my expectation is is_public would still be public/true
19:49:35 sean-k-mooney and flavor list would not list
19:49:37 sean-k-mooney it
19:49:53 sean-k-mooney unless you were in the tenant on the access list or an admin
19:50:30 sean-k-mooney so basicaly i think https://bugs.launchpad.net/nova/+bug/1361476 was invalid
19:50:30 openstack Launchpad bug 1361476 in OpenStack Compute (nova) "flavor access create should check public/private first" [Low,Fix released] - Assigned to Sergey Nikitin (snikitin)
19:51:05 gmann i mean we have is_public in list flavor filters if anyone listing by their instance's flavor is_public flag
19:51:09 sean-k-mooney well actully maybe not
19:51:49 sean-k-mooney gmann: can you say that again
19:52:45 sean-k-mooney looking at the bug i would expect "nova flavor-access-list --flavor 1" to work but i would not expect the flavor to be in "openstack flavor list" unless you were in a tenant with acess or an admin
19:52:47 gmann i mean will is_public change the flavor signature or not? even that does not make any change in real configueation but still a attribute in flavor user facing dict
19:53:27 sean-k-mooney is_public only changes if you can see the flaovr or not
19:53:48 sean-k-mooney so i think that is just metadata about the flaovr
19:53:51 sean-k-mooney not a part of it
19:54:04 gmann yeah. kind of.
19:54:14 sean-k-mooney kind of like the description wich we allow to be udpated
19:54:15 gmann or we just remove this flag.
19:54:49 sean-k-mooney i think the only benift to it is the defualt polciy
19:55:04 sean-k-mooney e.g. should it be visable by default or not
19:55:26 sean-k-mooney but i certenly dont think we should be blocking the use of the flaovr acess api based on it
19:56:00 sean-k-mooney i would be ok with removing it too but im not sure how others would feel
19:56:35 sean-k-mooney e.g. do operators use it frequently. if soo i think it should be kept and mutable. if not remove and just use flavor acess api for this
19:56:42 gmann ok, even list public flavor on list access is not wrong which is why that bug did the change in add access
19:57:18 gmann sorry, need to go for lunch, ttyl
19:57:27 sean-k-mooney no worries
19:57:36 sean-k-mooney im going for food too
19:59:06 noonedeadpunk it was pretty interesting discussion. Like I thought it is a bit more simple than it is
19:59:43 sean-k-mooney well the code is simple to change but it has several other implications obvirously
20:00:09 sean-k-mooney noonedeadpunk: this is why we generally require a spec for api changes as this type of discussion normally happens when we dig into it
20:00:57 noonedeadpunk yeah and it is fair
20:01:47 noonedeadpunk will try to write down it as it seems that some patching is required anyway
20:36:16 gmann yeah, spec can be better idea to discuss if something we miss. sean-k-mooney proposal looks ok to me for now.
20:50:56 openstackgerrit Merged openstack/nova master: Lowercase ironic driver hash ring and ignore case in cache https://review.opendev.org/711680
21:00:23 openstackgerrit melanie witt proposed openstack/nova stable/train: Lowercase ironic driver hash ring and ignore case in cache https://review.opendev.org/713739
21:36:52 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP gate: Ensure n-cpu is stopped on the subnode during evacuation https://review.opendev.org/713674
23:36:56 alex_xu dansmith: artom, thanks for the review https://review.opendev.org/#/c/687856/15/nova/compute/manager.py@8346, I reply that, but yes, we tried differnt options, and back and forward many times ourselve, looking for suggestion :)
#openstack-nova - 2020-03-19
00:08:09 artom alex_xu, sure, I'll take another look tomorrow
00:18:47 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in os-flavor-access policies https://review.opendev.org/713697
01:05:18 openstackgerrit Merged openstack/nova master: Refine and introduce correct parameters for test_get_guest_config_numa_host_instance_topo_cpu_pinning https://review.opendev.org/713351
01:18:24 openstackgerrit melanie witt proposed openstack/nova master: DNM: try to get some debug info for bug 1844929 https://review.opendev.org/701478
01:18:24 openstack bug 1844929 in OpenStack Compute (nova) "grenade jobs failing due to "Timed out waiting for response from cell" in scheduler" [High,Confirmed] https://launchpad.net/bugs/1844929
01:30:08 openstackgerrit Brin Zhang proposed openstack/nova master: Add new default roles in os-instance-actions policies https://review.opendev.org/706470
01:36:41 openstackgerrit Brin Zhang proposed openstack/nova master: Add new default roles in os-instance-actions policies https://review.opendev.org/706470
04:39:48 openstackgerrit melanie witt proposed openstack/nova master: Synchronize sqlalchemy models with migrations for alembic 1.4.1 https://review.opendev.org/713778
07:10:11 openstackgerrit Kevin Zhao proposed openstack/nova master: fix scsi disk unit number of the attaching volume when cdrom bus is scsi https://review.opendev.org/712607
08:02:18 gibi good morning nova
08:03:45 gibi stephenfin: hi! dansmith +2 all over the qos remaining patches, could you check back to those? https://review.opendev.org/#/q/topic:bp/support-move-ops-with-qos-ports-ussuri
08:04:32 gibi stephenfin: the major change since you looked at is a compute service version check in the API
08:05:16 gibi to ensure the computes are on Ussuri version before we start moving the servers around as the feauture needs support from the compute service
08:05:37 gibi due to the PCI claim magic
08:55:53 openstackgerrit Lee Yarwood proposed openstack/nova master: gate: Ensure subnode is fenced during evacuation testing https://review.opendev.org/713674
08:56:29 nightmare_unreal hello is there specific channel for python-openstackclient
09:00:34 brinzhang_ It seems there is not, you can send to ML, and add [openstackclient] [your_project] tag
09:00:46 brinzhang_ nightmare_unreal
09:28:29 nightmare_unreal thanks
09:43:11 luyao dansmith, artom: Thanks for your comments on https://review.opendev.org/#/c/687856, I replied on them, and thanks for alex_xu helping me clarifying.
09:43:29 frickler nightmare_unreal: brinzhang_: #openstack-sdks
09:44:23 luyao artom: FYI. I also run your live migration functional tests on top of my patch, they all passed
10:20:48 openstackgerrit Arthur Dayne proposed openstack/nova master: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/682772
10:22:43 openstackgerrit Arthur Dayne proposed openstack/nova master: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/682772
10:30:41 openstackgerrit Merged openstack/nova master: nova-live-migration: Wait for n-cpu services to come up after configuring Ceph https://review.opendev.org/713035
11:01:12 lyarwood wow it finally landed
11:01:47 openstackgerrit Lee Yarwood proposed openstack/nova master: gate: Ensure subnode is fenced during evacuation testing https://review.opendev.org/713674
11:03:14 openstackgerrit Lee Yarwood proposed openstack/nova master: nova-live-migration: Ensure subnode is fenced during evacuation testing https://review.opendev.org/713674
11:03:15 lyarwood ^ sorry just trying to get this some additional runs before review to ensure we don't need the VIF timeout again
11:03:54 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: nova-live-migration: Wait for n-cpu services to come up after configuring Ceph https://review.opendev.org/713836
11:04:12 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: nova-live-migration: Wait for n-cpu services to come up after configuring Ceph https://review.opendev.org/713837
11:05:43 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: Replace ansible --sudo with --become in live_migration/hooks scripts https://review.opendev.org/713839
11:05:43 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: nova-live-migration: Wait for n-cpu services to come up after configuring Ceph https://review.opendev.org/713840
11:07:44 kashyap lyarwood: Why sorry?
11:07:52 kashyap lyarwood: You're doing the donkey work, people better be grateful ;-)
11:08:05 kashyap I mean to say it in a _good sense_, BTW!
11:10:42 lyarwood thanks :)
11:10:48 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: Stop setting glance_api_version in cinder.conf in nova-live-migration https://review.opendev.org/713843
11:10:48 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: Replace ansible --sudo with --become in live_migration/hooks scripts https://review.opendev.org/713844
11:10:49 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: nova-live-migration: Wait for n-cpu services to come up after configuring Ceph https://review.opendev.org/713845
11:15:14 openstackgerrit Lee Yarwood proposed openstack/nova stable/pike: nova-live-migration: Wait for n-cpu services to come up after configuring Ceph https://review.opendev.org/713036
11:15:15 openstackgerrit Lee Yarwood proposed openstack/nova stable/pike: Replace ansible --sudo with --become in live_migration/hooks scripts https://review.opendev.org/713848
11:34:23 openstackgerrit Lee Yarwood proposed openstack/nova master: nova-live-migration: Ensure subnode is fenced during evacuation testing https://review.opendev.org/713674
11:34:42 brinzhang_ damsmith: I have replied your question in https://review.opendev.org/#/c/693828/

Earlier   Later