| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-03-10 | |||
| 14:09:11 | lyarwood | brinzhang: for stable/pike we might want to make the LM job NV tbh unless anyone steps up to fix it | |
| 14:09:21 | brinzhang | lyarwood: Maybe vif plug has some influence, let's take a look | |
| 14:10:33 | brinzhang | lyarwood: For stable / pike, I agree with you. | |
| 14:11:26 | sean-k-mooney | we skipped this on master https://review.opendev.org/#/c/663405/ | |
| 14:14:21 | sean-k-mooney | https://review.opendev.org/#/c/667177/ i think is the final fix | |
| 14:14:28 | sean-k-mooney | we went back and fort a few times | |
| 14:14:53 | brinzhang | sean-k-mooney: this is in stable/stein, right? so from stable/stein we skip to test the migration | |
| 14:15:41 | brinzhang | sean-k-mooney: oh..sorry, that's vif-plug issue | |
| 14:16:25 | sean-k-mooney | ya but that should already be on rock too | |
| 14:16:34 | sean-k-mooney | https://review.opendev.org/#/c/670648/2 | |
| 14:17:29 | dansmith | I wonder if it's time to consider dropping the vmware driver? http://lists.openstack.org/pipermail/openstack-discuss/2020-March/013066.html | |
| 14:17:30 | sean-k-mooney | right so ^ is marked as a partial fix for https://bugs.launchpad.net/nova/+bug/1813789 | |
| 14:17:30 | openstack | Launchpad bug 1813789 in OpenStack Compute (nova) "Evacuate test intermittently fails with network-vif-plugged timeout exception" [Medium,In progress] - Assigned to Artom Lifshitz (notartom) | |
| 14:18:44 | sean-k-mooney | dansmith: well one devstack failure is proably not enough but if we have no idea how to fix it an no one responds the maybe | |
| 14:19:15 | artom | sean-k-mooney, that patch was very specific to revert resize tho | |
| 14:19:23 | sean-k-mooney | it would help if they had included the compute agent patch | |
| 14:19:29 | dansmith | sean-k-mooney: point being that was a week ago with no answer | |
| 14:19:42 | dansmith | sean-k-mooney: and I don't even know who to point them to these days | |
| 14:19:59 | sean-k-mooney | artom: yes it was but i think there were other cases too | |
| 14:20:16 | artom | sean-k-mooney, yeah, but IIRC those were a different cause? | |
| 14:20:17 | sean-k-mooney | dansmith: ya i would say cdent but ya | |
| 14:20:22 | artom | I don't think we ever dug into those | |
| 14:20:48 | sean-k-mooney | artom: probably i just remember this being really hairy to untangel | |
| 14:20:55 | artom | sean-k-mooney, that it as | |
| 14:20:56 | dansmith | sean-k-mooney: and no vmware CI reporting lately, that I've seen | |
| 14:20:56 | artom | *was | |
| 14:21:37 | sean-k-mooney | dansmith: i guess we could propose deprecation if its not fix by ussuring and drop it in Victoria? | |
| 14:21:45 | sean-k-mooney | *ussuri | |
| 14:22:05 | sean-k-mooney | dansmith: we have to give 1 cycle notice right | |
| 14:22:37 | dansmith | sean-k-mooney: yeah, all I mean by "consider dropping" is starting the clock | |
| 14:23:22 | sean-k-mooney | ya did we ever follow through on the xen support | |
| 14:23:54 | sean-k-mooney | was it xen we talked about one of the other dirvers a few months ago right | |
| 14:26:09 | dansmith | yep, it's been deprecated and warning on startup for a while | |
| 14:26:13 | dansmith | don't think I've heard anything from anyone | |
| 14:26:40 | dansmith | Well, only since september I guess.. maybe that's too soon still | |
| 14:28:40 | dansmith | I guess we did merge a trivial log message fix to xenapi in January | |
| 14:28:47 | dansmith | hardly indicates heavy usage though :) | |
| 14:29:51 | dansmith | quality warning has been in place since May 2019 | |
| 14:30:24 | dansmith | last actual change was Feb 2019, but from canonical which may or may not indicate actual usage, just a failed test or something | |
| 14:34:48 | lyarwood | stephenfin: https://review.opendev.org/#/c/706900/ - could you hit this again when you have time? | |
| 14:35:47 | sean-k-mooney | dansmith: ya well we could always move it out of tree, into a repo in the x namespace and if people care they can use it or step up to support it for xen | |
| 14:36:01 | dansmith | -2 on that plan :) | |
| 14:36:13 | dansmith | it's in the git tree if they want to find it | |
| 14:36:13 | sean-k-mooney | i know you hate out of tree drivers | |
| 14:36:36 | sean-k-mooney | well i was wondering should we be removing it form in tree | |
| 14:37:08 | sean-k-mooney | i assume that was what you were evenutally proposing for vmware if we start the clock and no one steps up | |
| 14:38:33 | mordred | people still use xen? | |
| 14:39:36 | dansmith | mordred: no, that's the point :) | |
| 14:39:56 | dansmith | sean-k-mooney: removing it from the tree does't remove it from the git history and previous releases | |
| 14:40:03 | dansmith | sean-k-mooney: and it's likely not working now anyway | |
| 14:40:37 | mordred | yeah - I agree with dansmith - it's always there - if new people want to work on it, they can always start with a revert patch reverting the removal | |
| 14:41:00 | mordred | doesn't need an x/ repo | |
| 14:41:57 | sean-k-mooney | dansmith: oh that is what you ment by it being in git | |
| 14:42:06 | sean-k-mooney | dansmith: ok that makes more sense | |
| 14:42:52 | sean-k-mooney | mordred: i think one of the issue with the xenserver driver is that it relise on python 2 | |
| 14:43:34 | sean-k-mooney | mordred: libvirt/xen does not have that limitaion as far as i am aware but the xen direct driver definetly had issues with python 3 elast year | |
| 14:44:57 | sean-k-mooney | lyarwood: the privsep discussion has come up a bunch of times. be we did not want to change how we use privsep until we had finished the rootwrap removal | |
| 14:47:17 | sean-k-mooney | lyarwood: the hacking check i was refing too was the one that require you to do "import nova.privsep.x" instead of from nova.privsep import x | |
| 14:47:35 | sean-k-mooney | so that when you use a privaldaged function it must be fully spelled out | |
| 14:48:43 | lyarwood | sean-k-mooney: kk wasn't aware of the previous discussion then or I've conveniently forgtten them :) | |
| 14:50:14 | sean-k-mooney | lyarwood: nova currently only has 1 privsep context which basically give all privladged calls full root permissions | |
| 14:50:17 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/privsep/__init__.py | |
| 14:50:38 | sean-k-mooney | so the way we currently use it provides very little securtiy benifit | |
| 14:50:39 | openstackgerrit | Dan Smith proposed openstack/nova master: Deprecate the vmwareapi driver https://review.opendev.org/712101 | |
| 14:52:22 | lyarwood | sean-k-mooney: I can follow up and tighten this up under https://review.opendev.org/#/q/topic:bug/1861071_followups but for the intital bugfix series that I want to backport I'd like to avoid as much churn as possible tbh | |
| 14:52:51 | sean-k-mooney | lyarwood: what we should be doing is creating multiple context with a limited set of permission and only granting the permissions that are needed. | |
| 14:53:30 | sean-k-mooney | ya that is fair. i think we should be considring this a potential blueprint/work item for victoria at this point | |
| 14:54:02 | sean-k-mooney | i would prefer not to propagate more examples of the patteren but i agree wew should not mix this with the bug fix | |
| 14:56:11 | lyarwood | sean-k-mooney: kk thanks, I'll try to take a swing at that later this week and tbh that work will bleed into the V release anyway at this point. | |
| 14:58:58 | sean-k-mooney | lyarwood: ya im debating if we should defer it to a dedicated effort | |
| 14:59:03 | sean-k-mooney | like the nova-net removal | |
| 15:01:21 | lyarwood | sean-k-mooney: ah understood | |
| 15:03:21 | mriedem | vmware ci hasn't reported reliably in forever | |
| 15:03:58 | dansmith | mriedem: yeah I was going to point out that it doesn't report on this patch as evidence, assuming it doesn't | |
| 15:04:07 | dansmith | I haven't seen it report on vmware-touching patches in a while | |
| 15:04:54 | mriedem | heh, i haven't seen vmware touching patches in awhile | |
| 15:05:33 | dansmith | well, some things that touch all the drivers should have gotten a report | |
| 15:06:02 | mriedem | the vmware ci just hasn't worked in a couple of years | |
| 15:06:27 | mriedem | i think they got the band together long enough to make it work for the live migration patch because i said i wouldn't +2 it otherwise (and it needed to be multinode and show it passing live migrate) | |
| 15:06:30 | mriedem | but after that... | |
| 15:06:54 | mriedem | the xen driver was deprecated in train so it's probably too early to drop that in ussuri yeah? V at the earliest i'd think. | |
| 15:07:05 | mriedem | since anyone using xen isn't likely upgrading much these days anyway... | |
| 15:09:39 | openstackgerrit | Dan Smith proposed openstack/nova master: Deprecate the vmwareapi driver https://review.opendev.org/712101 | |
| 15:09:45 | mriedem | i'm happy to give a tenured +2 on ^ though :) | |
| 15:10:26 | dansmith | mriedem: yeah I commented on the xenapi driver a little earlier | |
| 15:10:42 | dansmith | seems like we should probably wait until V for that, just to be squeaky clean, even though I doubt anyone cares anymore | |
| 15:10:43 | mriedem | pep8 pass on that line you had to wrap? | |
| 15:10:56 | mriedem | someone will care 1 year after it's already deleted :/ | |
| 15:11:05 | mriedem | "care" | |
| 15:12:22 | mriedem | dansmith: i think you've got a pep8 error | |
| 15:12:24 | mriedem | line too long | |
| 15:12:47 | dansmith | mriedem: do I? | |
| 15:12:51 | mriedem | it was 79 before | |
| 15:12:57 | dansmith | fast8: commands succeeded | |
| 15:13:03 | mriedem | oh, well i'll +2 then | |
| 15:55:23 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/train: Fix os-keypairs pagination links https://review.opendev.org/711895 | |
| 15:56:52 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/stein: Fix os-keypairs pagination links https://review.opendev.org/711896 | |
| 15:58:13 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: Fix os-keypairs pagination links https://review.opendev.org/711898 | |
| 16:06:32 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Pass allocations to virt drivers when resizing https://review.opendev.org/589085 | |
| 16:06:33 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Pass allocations to virt drivers when reverting resize https://review.opendev.org/712118 | |