| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-02-21 | |||
| 02:19:34 | brinzhang | alex_xu, gibi: I was update the spec for PTACH API, please review | |
| 02:57:12 | openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Support re-configure deleted_on_termination in server https://review.opendev.org/580336 | |
| 02:58:56 | brinzhang | alex_xu: thanks, updated | |
| 09:57:34 | openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: setup.cfg: Various Python 3 fixes https://review.opendev.org/708824 | |
| 09:57:35 | openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: tox: Configure 'ignore_basepython_conflict' https://review.opendev.org/708830 | |
| 09:57:35 | openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Remove six https://review.opendev.org/708831 | |
| 09:57:36 | openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Bump to hacking 2.x https://review.opendev.org/708832 | |
| 09:57:36 | openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: trivial: Remove 'u' prefix from string https://review.opendev.org/709080 | |
| 09:57:37 | openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Random cleanups https://review.opendev.org/709081 | |
| 10:45:50 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Remove native LUKS compat code https://review.opendev.org/669121 | |
| 11:30:12 | happyhemant | Hi folks, I am creating instance in openstack with SRIOV, hugepages and cpu pinning. Creation of instance works with only SRIOV. Similarly with cpu-pinning and hugepage and without SRIOV works as well. But creating instance together with SRIOV, cpu-pinning and hugepages does not work. I found some logs in nova conductor and scheduler have a look to those if anybody can help would be really appreciated | |
| 11:30:45 | happyhemant | nova-scheduler logs https://www.irccloud.com/pastebin/KqD8zxqU/nova-scheduler%20 | |
| 11:31:42 | happyhemant | nova-conductor logs https://www.irccloud.com/pastebin/e580zd4R/nova-conductor | |
| 12:12:42 | Tony31 | hi nova team. When scheduling an instance via Horizon I can select `availability zone`. Is this availability zone information passed to Cinder? I would like to select a specific cinder backend with nova availability zone. I have tried setting the cinder `backend_availability_zone` to match the nova AZ but I am unable to get a match. I have enabled | |
| 12:12:43 | Tony31 | in Cinder `scheduler_default_filters = AvailabilityZoneFilter` which i had found in the docs is already enabled by default. Could anyone help nudge me in the right direction? | |
| 13:47:10 | redrobot | Hello, Nova friends! I would appreciate reviews on this updated bugfix patch: https://review.opendev.org/#/c/679502/ | |
| 14:07:02 | openstackgerrit | Ivaylo Mitev proposed openstack/nova master: Faults from cell DB missing in GET /servers/detail https://review.opendev.org/699176 | |
| 15:29:03 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support unshelve with qos ports https://review.opendev.org/704759 | |
| 15:29:04 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enable unshelve with qos ports https://review.opendev.org/705475 | |
| 15:31:01 | efried | gibi, alex_xu, brinzhang: Where are we on the delete-on-termination spec? Do we need to defer? | |
| 15:31:04 | gibi | stephenfin: I had to resolve a merge conflict so I lost your +2 on https://review.opendev.org/#/c/704759/ Could you plug it back? | |
| 15:31:47 | gibi | efried: as far as I understand gmann is OK to have PATCH or a POST with a different action and alex_xu does not like the idea of PATCH | |
| 15:31:52 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Merge qos related renos for Ussuri https://review.opendev.org/706766 | |
| 15:32:11 | gibi | efried: I don't see that alex_xu and gmann agreed on a compromise | |
| 15:32:13 | brinzhang | I want to look gibi and alex_xu, if they are agree with this patch, I will be ok whether defer or pass | |
| 15:33:18 | brinzhang | gibi: I was disscussed with alex_xu on wechat, he is ok for PTACH | |
| 15:33:50 | gibi | brinzhang: OK. Then we have an agreement. Let me quickly re-read the spec but then I'm +2 on it | |
| 15:34:08 | brinzhang | gibi: thanks | |
| 15:35:20 | gibi | done. I'm +2 | |
| 15:36:20 | brinzhang | gibi: cool, alex_xu maybe busy from afternoon, gmann are you around? | |
| 15:37:30 | brinzhang | efried: Is this need another +2 for it, that you can +1W ? | |
| 15:39:14 | efried | brinzhang: We definitely need two +2s. And since alex_xu was one of the crucial voices in the process, I think one of them should be his. | |
| 15:40:48 | efried | brinzhang: I would value gmann's +1 for sure, but we need alex_xu to make it go. | |
| 15:41:23 | brinzhang | efried: sure, hope alex_xu is not sleeping :) | |
| 15:41:41 | brinzhang | efried: I will ping him now | |
| 15:47:20 | brinzhang | efried: I think alex_xu is sleeping, I know our team are considering to cut spec in U release because of mriedem and you away, if so, I agree defer this. I am glad to meet this feature has a solution that everyone can agree on. | |
| 15:48:07 | efried | brinzhang: Okay. I'll give it to the end of my day and defer if we haven't heard back from alex_xu. Thanks for understanding. | |
| 15:48:23 | brinzhang | gibi, alex_xu, gmann, sean-k-mooney: thanks, and if gmann would like to +1, I will be happy :) | |
| 15:48:50 | gibi | efried: agree | |
| 15:49:03 | brinzhang | efried, gibi: thanks | |
| 15:49:08 | gibi | brinzhang: thanks | |
| 16:02:55 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/train: Reproduce bug 1862633 https://review.opendev.org/709166 | |
| 16:02:55 | openstack | bug 1862633 in OpenStack Compute (nova) "unshelve leak allocation if update port fails" [Medium,Fix released] https://launchpad.net/bugs/1862633 - Assigned to Balazs Gibizer (balazs-gibizer) | |
| 16:02:55 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/train: Clean up allocation if unshelve fails due to neutron https://review.opendev.org/709167 | |
| 16:16:27 | stephenfin | gibi: done | |
| 16:16:34 | gibi | stephenfin: thank you | |
| 16:28:10 | sean-k-mooney | gibi: there are potentially other issues with unshelve. we have an open dowsntream bug report that sugges we do not correclty handel neutron sriov deivce on unshelve | |
| 16:28:42 | gibi | sean-k-mooney: could be. this bug was come up when I added qos support for unshelve | |
| 16:28:42 | sean-k-mooney | gibi: basicaly i thinke we do the claim and port update after we regenerate the xml on queens | |
| 16:29:14 | sean-k-mooney | so i think we have an odering issue in that code in generall but not sure if its still a thing on master | |
| 16:31:57 | gibi | sean-k-mooney: there is a FIXME in the code https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6497 | |
| 16:32:04 | gibi | but that is about error handling + cleanup | |
| 16:32:22 | gibi | the port update happens before we call driver.spawn | |
| 16:32:36 | gibi | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6474-L6480 | |
| 16:33:47 | gibi | the problem might be that we update the port before the instance_claim | |
| 16:35:56 | gibi | but I lack the brain power on this Friday evening to dig this further | |
| 17:07:33 | openstackgerrit | Mark Goddard proposed openstack/nova master: Add functional regression test for bug 1853009 https://review.opendev.org/695012 | |
| 17:07:33 | openstack | bug 1853009 in OpenStack Compute (nova) "Ironic node rebalance race can lead to missing compute nodes in DB" [Undecided,In progress] https://launchpad.net/bugs/1853009 - Assigned to Mark Goddard (mgoddard) | |
| 17:07:33 | openstackgerrit | Mark Goddard proposed openstack/nova master: Clear rebalanced compute nodes from resource tracker https://review.opendev.org/695187 | |
| 17:07:33 | openstackgerrit | Mark Goddard proposed openstack/nova master: Invalidate provider tree when compute node disappears https://review.opendev.org/695188 | |
| 17:07:34 | openstackgerrit | Mark Goddard proposed openstack/nova master: Prevent deletion of a compute node belonging to another host https://review.opendev.org/694802 | |
| 17:07:34 | openstackgerrit | Mark Goddard proposed openstack/nova master: Fix inactive session error in compute node creation https://review.opendev.org/695189 | |
| 17:09:26 | prometheanfire | how goes the alembic-1.4.0 testing? | |
| 17:12:11 | sean-k-mooney | gibi: ya i think that is the issue. we updated the port before the instnace claim, and therefor when we generate the xml by retirivng the pci_slot form the neutron port bidning details it uses the old adress | |
| 17:13:42 | sean-k-mooney | gibi: anyway i just wanted you to be aware of that. im not expectiing your change to fix it | |
| 17:31:34 | Sundar | dansmith: In response to your comments/questions on rescheduling, is https://review.opendev.org/#/c/631244/62/nova/conductor/manager.py@839 the only piece left? Are there additional places to create/bind ARQs? | |
| 17:32:00 | dansmith | Sundar: for reschedule, that should be it | |
| 17:42:00 | efried | prometheanfire: I didn't get back to it yesterday, but it's here: https://review.opendev.org/708706 | |
| 17:42:00 | efried | Really, I need dansmith to look and see if the results mean we need a migration or not. | |
| 17:53:13 | openstackgerrit | Merged openstack/nova stable/stein: Enhance service restart in functional env https://review.opendev.org/703103 | |
| 17:53:19 | openstackgerrit | Merged openstack/nova master: trivial: Fetch 'Service' objects once when building AZs https://review.opendev.org/705653 | |
| 17:53:27 | openstackgerrit | Merged openstack/nova master: trivial: Bump minimum version of websockify https://review.opendev.org/705654 | |
| 17:53:31 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Report storage bus traits https://review.opendev.org/666914 | |
| 17:53:32 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Use domain capabilities to get supported device models https://review.opendev.org/666915 | |
| 17:53:32 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Add transform_image_metadata request filter https://review.opendev.org/665775 | |
| 17:59:14 | prometheanfire | efried_afk: thanks | |
| 17:59:36 | prometheanfire | efried_afk: that's my review, I was asking if nova had a review to fix :D | |
| 18:16:19 | dansmith | prometheanfire: he meant this: https://review.opendev.org/#/c/708707/1 | |
| 18:16:30 | dansmith | and, it failed grenade on the base, so no useful data | |
| 18:27:06 | prometheanfire | ah, fun, thanks | |
| 19:04:19 | openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Name Enums https://review.opendev.org/708707 | |
| 19:32:16 | openstackgerrit | Merged openstack/nova stable/train: Print help if nova-manage subcommand is not specified https://review.opendev.org/702637 | |
| 19:37:41 | efried | prometheanfire: sorry, yeah, what dansmith said. Looks like the base patch is in merge conflict atm, Ima rebase it so we can recheck the sniffer. | |
| 19:39:45 | efried | done and done | |
| 19:40:05 | efried | dansmith: was the unit test failure anything significant? | |
| 19:40:19 | dansmith | efried: it's complaining that the model doesn't match the schema, | |
| 19:40:37 | dansmith | potentially because sqlite reports generated enum names, or doesn't support setting them or something | |
| 19:40:44 | efried | right, I wasn't sure whether that indicated we need a migration or not | |
| 19:40:46 | dansmith | but, cross that bridge later if we decide we need to do this | |
| 19:40:50 | efried | okay | |
| 19:41:00 | efried | like, maybe figure out what name sqlite autogenerates and use that? | |
| 19:42:26 | dansmith | oh, I just re-looked.. those are the postgres tests complaining | |
| 19:42:27 | dansmith | not the sqlite ones | |
| 19:42:32 | dansmith | I keep not seeing "postgres" | |
| 19:42:55 | dansmith | so yeah, have to make them match or teach the test not to care or something | |
| 20:25:21 | openstackgerrit | Eric Fried proposed openstack/nova master: Enforce os-traits/SUPPORTED_STORAGE_BUSES sync https://review.opendev.org/709233 | |
| 21:01:48 | Sundar | dansmith: For the rescheduling part, https://review.opendev.org/#/c/631244/62/nova/conductor/manager.py@839, the call to _create_and_bind_arqs() must return the ARQs, so that they may be passed to build_and_run_instance(). The change to return the ARQs happens in a later patch -- the obe that bumps up RPCAPI: | |
| 21:01:49 | Sundar | https://review.opendev.org/#/c/631244/62/nova/conductor/manager.py@839 | |
| 21:02:10 | Sundar | Sorry, https://review.opendev.org/#/c/704227/14/nova/conductor/manager.py@1661 | |
| 21:03:01 | Sundar | Shall we do the create/bind for the rescheduling as a followup to 'Bump PCPI' patch? | |