| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-02-20 | |||
| 12:58:39 | gibi | sean-k-mooney: for the local cache I think we can support that but we might not need to commit to it yet as there are os-brick and cinder dependencies to be implemnted first | |
| 12:58:42 | sean-k-mooney | ah righit i just comemnted on the spec ill add mine | |
| 12:58:57 | sean-k-mooney | gibi: ya | |
| 12:59:15 | sean-k-mooney | gibi: i think cinder were planning to approve there FFE today before the nova meeting | |
| 12:59:18 | gibi | sean-k-mooney: for the delte on terminate I saw an API problem raised from gmann that wasnot resolved | |
| 12:59:55 | sean-k-mooney | ah i did not know he had raised an issue | |
| 13:01:39 | gibi | sean-k-mooney: I'm trying to find the description of the problem | |
| 13:01:43 | sean-k-mooney | gibi: ya so i realy dont know hwy we dont just support setting delete on terminate via a put to /servers/{server_id}/os-volume_attachments/{volume_id} | |
| 13:02:27 | gibi | sean-k-mooney: https://review.opendev.org/#/c/580336/28/specs/ussuri/approved/destroy-instance-with-datavolume.rst@43 | |
| 13:02:39 | sean-k-mooney | ^ was the open question i had. i assume PUT to that endpoing is how we trigger swap volumn? | |
| 13:02:49 | gibi | sean-k-mooney: because that PUT is for swap volume not for updating existing volume | |
| 13:03:22 | sean-k-mooney | ya that is what i was assuming | |
| 13:03:58 | sean-k-mooney | so we are just modifying the put then so that it only swaps the value if you alter the volume id | |
| 13:04:00 | gibi | so we made a suboptimal decision in the past to use PUT as swap and now we have no good place to implement a simple update as PUT is already used | |
| 13:04:06 | sean-k-mooney | which is why it is no optional in the spefc | |
| 13:04:24 | sean-k-mooney | gibi: well we could use patch | |
| 13:04:43 | gibi | sean-k-mooney: I could accept to have a conditional swap as you described above | |
| 13:04:49 | gibi | sean-k-mooney: I'm not sure gmann likes that | |
| 13:05:04 | sean-k-mooney | right well the spec currently had the conditional swap | |
| 13:05:20 | sean-k-mooney | was useing PATCH discussed? | |
| 13:06:20 | sean-k-mooney | PATCH is intended for a partial update where you jsut sent the data to be updated so PATCH would just contain delete_on_terminate=True|False in the body and use the volumn id for the url | |
| 13:06:38 | sean-k-mooney | gmann: ^ would you be ok with that? | |
| 13:06:55 | sean-k-mooney | gmann: it would allow put to be kept just for swap volumn | |
| 13:07:15 | gibi | sean-k-mooney: as far as I remember PATCH was not discussed | |
| 13:07:15 | sean-k-mooney | *volume | |
| 13:07:28 | gibi | sean-k-mooney: I looked at the current version of the spec. I'm OK wiht the conditional swap | |
| 13:09:01 | gibi | but I would not like to +2 the patch without hearing back from gmann | |
| 13:09:13 | sean-k-mooney | sure | |
| 13:34:17 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/pike: Mask the token used to allow access to consoles https://review.opendev.org/708876 | |
| 13:35:05 | openstackgerrit | Balazs Gibizer proposed openstack/nova stable/pike: Mask the token used to allow access to consoles https://review.opendev.org/708876 | |
| 13:35:20 | openstackgerrit | Victor Coutellier proposed openstack/nova master: Non-Admin user can filter their instances by more filters https://review.opendev.org/701609 | |
| 13:47:32 | efried | stephenfin: regarding vTPM, is it something you would have time and desire to do? | |
| 13:50:55 | gmann | gibi: sean-k-mooney sounds good to me. my main concern is not to over-scope the existing swap API which makes our API hard/confusing to use. PATCH option looks good to me | |
| 13:51:00 | gibi | stephenfin: if you do the vTPM you can sign me up to review your patches | |
| 13:51:30 | gibi | gmann: so the current conditional PUT is not good for you but a separate PATCH would be good. | |
| 13:52:36 | gmann | gibi: yeah. because i also looked and none of the existing API i find suitable where we can add this feature. | |
| 13:53:05 | stephenfin | efried: Someone needs to do it, so yeah | |
| 13:53:12 | gibi | gmann: noted. Could you state that in the review with a -1? | |
| 13:53:15 | gmann | and as long as we keep that API very clear about updating only nova related/owned bits of volume not proxy to cinder | |
| 13:53:19 | stephenfin | I mean, I should have the bandwidth. It's just the reviews I'd need | |
| 13:53:23 | gmann | gibi: sure. | |
| 13:53:32 | gibi | gmann: thanks | |
| 13:53:35 | stephenfin | Story of my OpenStack life :) | |
| 13:54:09 | gibi | :) | |
| 13:55:16 | efried | stephenfin: okay, thanks for that. johnthetubaguy said it was important, and obviously jroll and the vmg folk want it, so... | |
| 13:56:38 | sean-k-mooney | efried: stephenfin for what its worth we want vtpm downstream as a medium to long term feature | |
| 13:57:01 | efried | sean-k-mooney: "we" == RH? | |
| 13:57:10 | kashyap | I think it might be the "royal we" :D | |
| 13:57:19 | stephenfin | in this case yeah | |
| 13:57:30 | sean-k-mooney | yep, we as in redhat. we dont need it in the next release but we expect customer two ask for it in the future | |
| 13:57:43 | efried | noted | |
| 13:58:03 | efried | Nova meeting in #openstack-meeting in ~2 mins | |
| 13:58:55 | sean-k-mooney | we have spoke to some goverment funded organisation in the eu where they were considering making tpm supprot a requirement in some cases. but its will be a whiel before anything like that comes into effect | |
| 14:00:42 | efried | lyarwood: fyi there's an agenda item to follow up about rocky EM | |
| 14:02:19 | lyarwood | efried: yup still not found time to do it sorry | |
| 14:02:26 | lyarwood | efried: rocky is at least passing now | |
| 14:02:36 | efried | no worries, just wanted an update for the record, will ask again officially :) | |
| 14:19:15 | openstackgerrit | Merged openstack/nova master: Use tempest-full-py3 as base job https://review.opendev.org/708548 | |
| 14:21:37 | openstackgerrit | Merged openstack/nova stable/ocata: Use stable constraint for Tempest pinned stable branches https://review.opendev.org/706872 | |
| 14:44:34 | jroll | stephenfin: <3 thanks for picking that up | |
| 14:51:58 | alex_xu | gmann: gibi lyarwood sean-k-mooney, I guess we need to show the 'delete_on_termination' in GET method also, otherwise I don't know how the user know the current value for delete_on_termination. | |
| 14:52:06 | alex_xu | brinzhang__: ^ | |
| 14:52:40 | sean-k-mooney | am yes we could add that in the same microverion bump | |
| 14:52:55 | alex_xu | for PATCH, I just feel our existing PUT is behavior like PATCH, now we add another PATCH, then we add another mess :) | |
| 14:52:57 | brinzhang__ | alex_xu: agree, if the volume was speficied delete_on_termination, it shuold show | |
| 14:53:38 | alex_xu | I also remember ironic's patch method use json-patch in the body, gmann do you know is there any defintion from the api-wg for the patch's body? | |
| 14:53:42 | sean-k-mooney | alex_xu: well PUT required the entire resoce to be updated. its not sematiclly correct to only set some filed in a PUT | |
| 14:53:53 | sean-k-mooney | partail updates should have been using PATCH | |
| 14:54:15 | alex_xu | sean-k-mooney: oh, yea, right. | |
| 14:54:19 | sean-k-mooney | so the current way we use PUT for swap volume is not correct | |
| 14:54:29 | alex_xu | right | |
| 14:54:30 | sean-k-mooney | but we cant really change that at this point | |
| 14:54:35 | gmann | alex_xu: GET server has that. | |
| 14:55:32 | gmann | https://github.com/openstack/nova/blob/08b98d75cf4b77563e373709a84685f7d0b72ba3/nova/api/openstack/compute/views/servers.py#L716 | |
| 14:55:43 | gmann | i think that is from microversion 2.3 | |
| 14:55:43 | sean-k-mooney | kevinz: hi do you want to talk about arm testing here or on #openstack-qa | |
| 14:56:08 | sean-k-mooney | #openstack-qa might be better to let the volume discussion happen here | |
| 14:56:11 | alex_xu | oh, wait | |
| 14:56:28 | alex_xu | gmann: brinzhang__ we already return that 2.79 | |
| 14:56:34 | kevinz | sean-k-mooney: OK, we can talk at qa channel | |
| 14:57:21 | gmann | alex_xu: yeah - https://github.com/openstack/nova/blob/08b98d75cf4b77563e373709a84685f7d0b72ba3/nova/api/openstack/compute/views/servers.py#L350 | |
| 14:57:46 | brinzhang__ | alex_xu: yeah, it in microversion 2.3 | |
| 14:59:13 | brinzhang__ | gmann: alex_xu said in https://docs.openstack.org/api-ref/compute/?expanded=create-console-detail,show-console-connection-information-detail,list-all-major-versions-detail,show-details-of-specific-api-version-detail,list-servers-detail,create-server-detail,create-multiple-servers-detail,list-servers-detailed-detail,show-server-details-detail,update-server-detail,delete-server-detail,add-associate-floating-ip-addfloati | |
| 14:59:14 | brinzhang__ | ngip-action-deprecated-detail,add-security-group-to-a-server-addsecuritygroup-action-detail,change-administrative-password-changepassword-action-detail,confirm-resized-server-confirmresize-action-detail,create-server-back-up-createbackup-action-detail,create-image-createimage-action-detail,lock-server-lock-action-detail,pause-server-pause-action-detail,reboot-server-reboot-action-detail,rebuild-server-rebuild-action-d | |
| 14:59:14 | brinzhang__ | etail,remove-disassociate-floating-ip-removefloatingip-action-deprecated-detail,remove-security-group-from-a-server-removesecuritygroup-action-detail,rescue-server-rescue-action-detail,resize-server-resize-action-detail,resume-suspended-server-resume-action-detail,revert-resized-server-revertresize-action-detail,start-server-os-start-action-detail,stop-server-os-stop-action-detail,suspend-server-suspend-action-detail, | |
| 14:59:19 | brinzhang__ | unlock-server-unlock-action-detail,unpause-server-unpause-action-detail,unrescue-server-unrescue-action-detail,add-associate-fixed-ip-addfixedip-action-deprecated-detail,remove-disassociate-fixed-ip-removefixedip-action-deprecated-detail,force-delete-server-forcedelete-action-detail,restore-soft-deleted-instance-restore-action-detail,show-console-output-os-getconsoleoutput-action-detail,shelve-server-shelve-action-det | |
| 14:59:24 | brinzhang__ | ail,shelf-offload-remove-server-shelveoffload-action-detail,unshelve-restore-shelved-server-unshelve-action-detail,trigger-crash-dump-in-server-detail,get-rdp-console-os-getrdpconsole-action-deprecated-detail,get-serial-console-os-getserialconsole-action-deprecated-detail,get-spice-console-os-getspiceconsole-action-deprecated-detail,inject-network-information-injectnetworkinfo-action-detail,migrate-server-migrate-acti | |
| 14:59:29 | brinzhang__ | on-detail,live-migrate-server-os-migratelive-action-detail,reset-networking-on-a-server-resetnetwork-action-detail,reset-server-state-os-resetstate-action-detail,evacuate-server-evacuate-action-detail,list-security-groups-by-server-detail,show-server-diagnostics-detail,list-ips-detail,show-ip-details-detail,list-all-metadata-detail,create-or-update-metadata-items-detail,replace-metadata-items-detail,show-metadata-item | |
| 14:59:34 | brinzhang__ | -details-detail,create-or-update-metadata-item-detail,delete-metadata-item-detail,list-actions-for-server-detail,show-server-action-details-detail,list-port-interfaces-detail,create-interface-detail,show-port-interface-details-detail,detach-interface-detail,show-server-password-detail,clear-admin-password-detail,list-volume-attachments-for-an-instance-detail,attach-a-volume-to-an-instance-detail,show-a-detail-of-a-vol | |
| 14:59:39 | brinzhang__ | ume-attachment-detail,update-a-volume-attachment-detail,detach-a-volume-from-an-instance-detail,list-flavors-detail,create-flavor-detail,list-flavors-with-details-detail,show-flavor-details-detail,update-flavor-description-detail,delete-flavor-detail,list-flavor-access-information-for-given-flavor-detail,add-flavor-access-to-tenant-addtenantaccess-action-detail,remove-flavor-access-from-tenant-removetenantaccess-actio | |
| 14:59:41 | alex_xu | :) | |
| 14:59:46 | brinzhang__ | n-detail,list-extra-specs-for-a-flavor-detail,create-extra-specs-for-a-flavor-detail,show-an-extra-spec-for-a-flavor-detail,update-an-extra-spec-for-a-flavor-detail,delete-an-extra-spec-for-a-flavor-detail,list-keypairs-detail,create-or-import-keypair-detail,show-keypair-details-detail,delete-keypair-detail,show-rate-and-absolute-limits-detail,list-agent-builds-detail,create-agent-build-detail,update-agent-build-detai | |
| 14:59:51 | brinzhang__ | l,delete-agent-build-detail,list-aggregates-detail,create-aggregate-detail,show-aggregate-details-detail,update-aggregate-detail,delete-aggregate-detail,add-host-detail,remove-host-detail,create-or-update-aggregate-metadata-detail,request-image-pre-caching-for-aggregate-detail,create-assisted-volume-snapshots-detail,delete-assisted-volume-snapshot-detail,get-availability-zone-information-detail,get-detailed-availabili | |
| 14:59:56 | brinzhang__ | ty-zone-information-detail,list-hypervisors-detail,list-hypervisors-details-detail,show-hypervisor-statistics-detail,show-hypervisor-details-detail,show-hypervisor-uptime-detail,search-hypervisor-detail,list-hypervisor-servers-detail,list-server-usage-audits-detail,list-usage-audits-before-specified-time-detail,list-migrations-detail,id320-detail,show-migration-details-detail,force-migration-complete-action-force-comp | |
| 15:00:01 | brinzhang__ | lete-action-detail,delete-abort-migration-detail,show-a-quota-detail,update-quotas-detail,revert-quotas-to-defaults-detail,list-default-quotas-for-tenant-detail,show-the-detail-of-quota-detail,show-the-quota-for-quota-class-detail,create-or-update-quotas-for-quota-class-detail,list-server-groups-detail,create-server-group-detail,show-server-group-details-detail,delete-server-group-detail,list-tags-detail,replace-tags- | |
| 15:00:06 | brinzhang__ | detail,delete-all-tags-detail,check-tag-existence-detail,add-a-single-tag-detail,delete-a-single-tag-detail,list-compute-services-detail,disable-scheduling-for-a-compute-service-detail,disable-scheduling-for-a-compute-service-and-log-disabled-reason-detail,enable-scheduling-for-a-compute-service-detail,update-forced-down-detail,update-compute-service-detail,delete-compute-service-detail,list-tenant-usage-statistics-fo | |
| 15:00:13 | brinzhang__ | r-all-tenants-detail,show-usage-statistics-for-tenant-detail,run-events-detail,show-server-topology-detail,list-extensions-detail,show-extension-details-detail,list-networks-detail,create-network-detail,add-network-detail,show-network-details-detail,delete-network-detail,associate-host-detail,disassociate-network-detail,disassociate-host-detail,disassociate-project-detail,list-volumes-detail,create-volume-detail,list- | |
| 15:00:18 | brinzhang__ | volumes-with-details-detail,show-volume-details-detail,delete-volume-detail,list-snapshots-detail,create-snapshot-detail,list-snapshots-with-details-detail,show-snapshot-details-detail,delete-snapshot-detail,list-images-detail,list-images-with-details-detail,show-image-details-detail,delete-image-detail,list-image-metadata-detail,create-image-metadata-detail,update-image-metadata-detail,show-image-metadata-item-detail | |
| 15:00:23 | brinzhang__ | ,create-or-update-image-metadata-item-detail,delete-image-metadata-item-detail,list-bare-metal-nodes-detail,show-bare-metal-node-details-detail,list-project-networks-detail,create-project-network-detail,show-project-network-details-detail,delete-project-network-detail,list-floating-ip-pools-detail,list-floating-ip-addresses-detail,create-allocate-floating-ip-address-detail,show-floating-ip-address-details-detail,delet | |
| 15:00:28 | brinzhang__ | e-deallocate-floating-ip-address-detail,list-security-groups-detail,create-security-group-detail,show-security-group-details-detail,update-security-group-detail,delete-security-group-detail,create-security-group-rule-detail,delete-security-group-rule-detail,list-hosts-detail,show-host-details-detail,update-host-status-detail,reboot-host-detail,shut-down-host-detail,start-host-detail,create-root-certificate-detail,show | |