| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-02-19 | |||
| 18:00:09 | sean-k-mooney | i might get the job done later tonight if not ill do it in the morning i dont think it will take too much to get right | |
| 18:00:29 | dansmith | cool | |
| 18:00:44 | dansmith | we're missing a lot of replies to comments from sundar at this point | |
| 18:00:56 | dansmith | like most of the patches have a -1 on them looking for change or clarification | |
| 18:03:23 | sean-k-mooney | ya i need to set some time aside to also go through the patch chain and actully review them but i have been relying on you, gibi and erric to to that mostly and just commeinting if i know the anser and i happend to see the gerrit email notification | |
| 18:05:05 | dansmith | yeah, I'm not sure more comments will help right now, | |
| 18:05:33 | dansmith | so it might be good to hold off and focus on things we can fix, like what you're doing | |
| 18:05:55 | dansmith | I don't want to push Sundar so much that the queue of feedback seems insurmountable before he has to move on | |
| 18:06:10 | sean-k-mooney | ya makes sense | |
| 18:06:11 | dansmith | the more layers of feedback the harder it is to take action sometimes | |
| 18:07:06 | dansmith | anybody know how the reference a task in a story in a commit message? | |
| 18:07:20 | TheJulia | dansmith: task: | |
| 18:07:22 | TheJulia | and number | |
| 18:07:24 | dansmith | thanks | |
| 18:36:11 | bauzas | folks, I'm becoming crazy | |
| 18:36:20 | bauzas | (py37) [sbauza@sbauza nova]$ stestr run | |
| 18:36:21 | bauzas | usage: stestr [-h] [--config-dir DIR] [--config-file PATH] [--debug] | |
| 18:36:21 | bauzas | [--log-config-append PATH] [--log-date-format DATE_FORMAT] | |
| 18:36:21 | bauzas | [--log-dir LOG_DIR] [--log-file PATH] [--nodebug] | |
| 18:36:21 | bauzas | [--nouse-journal] [--nouse-json] [--nouse-syslog] | |
| 18:36:21 | bauzas | [--nowatch-log-file] [--syslog-log-facility SYSLOG_LOG_FACILITY] | |
| 18:36:23 | bauzas | [--use-journal] [--use-json] [--use-syslog] [--version] | |
| 18:36:24 | bauzas | [--watch-log-file] [--remote_debug-host REMOTE_DEBUG_HOST] | |
| 18:36:25 | bauzas | [--remote_debug-port REMOTE_DEBUG_PORT] | |
| 18:36:26 | bauzas | stestr: error: unrecognized arguments: run | |
| 18:36:28 | bauzas | WTF?!!!! | |
| 18:36:47 | bauzas | stestr can't recognize the first argument | |
| 18:36:56 | bauzas | like if argparse wasn't correctly working | |
| 18:43:57 | sean-k-mooney | i guess its because its a postional arg | |
| 18:44:33 | sean-k-mooney | so the non postional arg parser was able to construct but if you had an eeror later it might not be able to finsih construction the rest | |
| 18:45:20 | bauzas | I can litterally run something by doing stestr, then launching the 'run' command | |
| 18:45:54 | sean-k-mooney | what happens if you do stestr --help | |
| 18:46:07 | sean-k-mooney | does it print the command list | |
| 18:46:30 | bauzas | nope | |
| 18:46:50 | bauzas | just the options list | |
| 18:46:53 | sean-k-mooney | ok so the run command is proably fine but one of the others is broken | |
| 18:48:02 | sean-k-mooney | it should print this http://paste.openstack.org/show/789762/ | |
| 18:48:40 | bauzas | sean-k-mooney: in order to run tests, I have to, like I said, just type 'stestr' in the venv, and then once I'm having the (stestr) invite, ask for 'run <mytests>' | |
| 18:49:05 | sean-k-mooney | ya i understand | |
| 18:50:08 | bauzas | actually, I got the same with -h | |
| 18:50:19 | bauzas | I get the command list | |
| 18:50:24 | sean-k-mooney | oh ok | |
| 18:50:55 | sean-k-mooney | by tox or stestr run jsut fail unless you drop into the interactive shell | |
| 18:52:44 | bauzas | correct | |
| 18:52:53 | bauzas | a single tox -epy27 even doesn't work | |
| 18:53:01 | bauzas | without any posargs | |
| 18:53:18 | bauzas | I'm just one second before tableflipping, literally | |
| 18:53:21 | sean-k-mooney | ill see if i can repoduce | |
| 18:53:36 | sean-k-mooney | where you testing a patch or will this happen on master? | |
| 18:53:42 | bauzas | I'm on a branch | |
| 18:53:51 | bauzas | but I rebased | |
| 18:53:55 | bauzas | from master | |
| 18:54:00 | bauzas | and nothing changes | |
| 18:54:10 | sean-k-mooney | ok ill just try and recreate a tox enve with master | |
| 18:54:24 | sean-k-mooney | tox -epy27 wont work on master by the way | |
| 18:54:39 | sean-k-mooney | we dont allow nova to install on 27 anymore | |
| 18:57:17 | bauzas | whoops, s/py27/37 of course | |
| 18:57:19 | sean-k-mooney | "tox -e py37 -r" to recreate the env is workifn fine for me with master | |
| 18:57:33 | sean-k-mooney | you could try doing "stestr -v run" | |
| 18:57:34 | bauzas | holy shit | |
| 18:57:37 | sean-k-mooney | to get verbose output | |
| 18:57:47 | sean-k-mooney | it might tell you what is wrong | |
| 18:58:11 | bauzas | sean-k-mooney: nope http://paste.openstack.org/show/789764/ | |
| 18:58:58 | sean-k-mooney | wait what | |
| 18:59:25 | sean-k-mooney | why is is login sqlacheme form nova.db.sqlalchemy.api | |
| 18:59:34 | bauzas | no idea | |
| 18:59:37 | sean-k-mooney | is it doing a local import | |
| 18:59:47 | sean-k-mooney | are you in nova/nova | |
| 18:59:56 | sean-k-mooney | if so can you go up one level | |
| 18:59:56 | bauzas | I am | |
| 19:00:01 | bauzas | ah no | |
| 19:00:07 | bauzas | i'm in the root repo | |
| 19:00:14 | sean-k-mooney | ya ok | |
| 19:00:24 | bauzas | (py37) [sbauza@sbauza nova]$ pwd | |
| 19:00:25 | bauzas | /home/sbauza/git/openstack/nova | |
| 19:00:30 | sean-k-mooney | ya | |
| 19:00:44 | sean-k-mooney | so it should not be a local import issue with your current directory | |
| 19:01:03 | bauzas | I recreated the venv so many times... | |
| 19:01:47 | sean-k-mooney | i never actully got food when i said i would so im going to go get it now. if you push the chagne somewhere ill try and run it when i get back | |
| 19:02:04 | bauzas | yeah I need to drop too | |
| 19:02:07 | bauzas | but I'm about to quite | |
| 19:02:08 | bauzas | quit | |
| 19:02:12 | bauzas | frankly | |
| 19:02:29 | bauzas | that's making me maaaad | |
| 19:02:34 | bauzas | anyway, good dinner | |
| 19:04:10 | sean-k-mooney | bauzas: i would just push hte patch let teh gate check it and clone a new copy of the repo in the morning | |
| 19:04:22 | sean-k-mooney | just too make sure that its clean | |
| 19:05:51 | sean-k-mooney | bauzas: oh you proably have a local file for opertunistic db testign configured | |
| 19:06:04 | sean-k-mooney | i forget how to configure that but there is a way | |
| 19:09:18 | sean-k-mooney | or maybe that is just a thing in sqlalcemey migrate https://opendev.org/x/sqlalchemy-migrate/src/branch/master/test_db.cfg | |
| 19:12:24 | openstackgerrit | Eric Fried proposed openstack/nova master: Follow-up: Add delete_on_termination to volume-attach API https://review.opendev.org/680655 | |
| 19:13:53 | sean-k-mooney | ya i guess its hard coded https://github.com/openstack/nova/blob/e20d529dbf656ddcacb7ab3497a6c71e89985f50/nova/tests/unit/db/test_migrations.py#L17-L33 | |
| 19:37:21 | efried | stephenfin: did those | |
| 20:27:41 | bauzas | sean-k-mooney: nope I didn't configured it | |
| 20:45:06 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Provide the backing file format when creating qcow2 disks https://review.opendev.org/708745 | |
| 20:53:47 | bauzas | sean-k-mooney: mmm, cloning nova on another local repo seems to work | |
| 20:54:14 | sean-k-mooney | bauzas: ya you must have a local file or something in that copy which is messign it up | |
| 20:54:25 | bauzas | possibly | |
| 20:54:32 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP libvirt: Provide the backing file format when creating qcow2 disks https://review.opendev.org/708745 | |
| 21:04:08 | spatel | sean-k-mooney: do you thing ksmd is good for openstack ? its using 40% cpu on my compute node. | |