Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-02-17
13:21:28 gibi stephenfin: sure, give me a sec
13:21:51 gibi stephenfin: http://paste.openstack.org/show/789642/
13:22:21 gibi stephenfin: are nova uses old oslo.serialization that is not py37 compatible?
13:23:11 sean-k-mooney it would seam that we are mixing byte and text strings somehwere
13:23:22 sean-k-mooney but this would have broken on py3.5
13:23:33 sean-k-mooney so its not a py 3.7 thing
13:26:56 gibi sean-k-mooney: right. but the combination for byte and str seems to happen in codecs which is stdlib
13:27:23 sean-k-mooney right so we are expecting to pass in a string
13:27:36 stephenfin gibi: looking at the source, it seems we attempt to decode whatever file we get to utf-8
13:27:37 sean-k-mooney and its expecting bytes?
13:27:46 stephenfin but I don't know why that's no okay
13:28:06 sean-k-mooney you mean https://github.com/openstack/oslo.serialization/blob/master/oslo_serialization/jsonutils.py#L255-L276
13:28:20 stephenfin at meetings for the day but I'll take a look over the week
13:37:16 stephenfin bauzas: You think you could take a look at this today? https://review.opendev.org/#/c/662522/
13:41:14 bauzas stephenfin: ok, will look today
13:57:06 gibi hm. If I change the test to load the content of the file first and then call jsonutils.loads() then it works
13:57:09 gibi with open(schema_file) as f:
13:57:11 gibi data = f.read()
13:57:14 gibi schema = jsonutils.loads(data)
14:07:39 openstackgerrit Brian Rosmaita proposed openstack/nova master: Reject boot request for unsupported images https://review.opendev.org/707738
14:28:13 openstackgerrit Brian Rosmaita proposed openstack/nova master: Absolutely-non-inheritable image properties https://review.opendev.org/708126
15:04:15 openstackgerrit Artom Lifshitz proposed openstack/nova master: func tests: move _run_periodics() into own mixin https://review.opendev.org/705545
15:04:15 openstackgerrit Artom Lifshitz proposed openstack/nova master: tests: work around malformed serial XML https://review.opendev.org/705546
15:04:16 openstackgerrit Artom Lifshitz proposed openstack/nova master: Functional tests for NUMA live migration https://review.opendev.org/672595
15:04:17 openstackgerrit Artom Lifshitz proposed openstack/nova master: NUMA LM: Add func test for bug 1845146 https://review.opendev.org/687404
15:04:17 openstack bug 1845146 in OpenStack Compute (nova) train "NUMA aware live migration failed when vCPU pin set" [High,Fix committed] https://launchpad.net/bugs/1845146 - Assigned to Dan Smith (danms)
15:14:10 openstackgerrit Brian Rosmaita proposed openstack/nova master: Absolutely-non-inheritable image properties https://review.opendev.org/708126
15:21:10 openstackgerrit Brian Rosmaita proposed openstack/nova master: Reject boot request for unsupported images https://review.opendev.org/707738
15:23:35 artom So I guess something Fedora-specific is wrong with the stable/queens func tests?
15:24:01 artom Because locally I don't get the same failure as https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_c05/707887/1/check/nova-tox-functional-py35/c05109a/testr_results.html
15:34:53 rosmaita alex_xu: gmann: need your opinion on whether https://review.opendev.org/#/c/707738/ will require a microversion bump
15:38:46 sean-k-mooney artom: the functional tests should not be os specific nor should any of the other tests really
15:40:10 artom sean-k-mooney, I know, which is why it's so weird
15:40:14 artom In any case, it's a moot point
15:40:28 artom Because turns out my backport isn't applicable, and I got the root cause completely wrong
15:40:44 artom So back to square 1 for me, and I really don't feel like log diving
15:40:48 artom But no choice :(
15:42:56 openstackgerrit Eric Fried proposed openstack/nova-specs master: Fixed minor suggestions https://review.opendev.org/708058
15:43:35 openstackgerrit Eric Fried proposed openstack/nova-specs master: Fixed minor suggestions https://review.opendev.org/708058
16:04:38 openstackgerrit Merged openstack/nova master: Support large network queries towards neutron https://review.opendev.org/704520
16:06:00 bauzas stephenfin: FWIW, have a comment https://review.opendev.org/#/c/662522/17
16:06:17 bauzas stephenfin: just tell me when you see it and then I'll +W it
16:07:08 stephenfin bauzas: Do you mean something more than I provided? https://review.opendev.org/#/c/662522/17/nova/tests/functional/libvirt/test_numa_servers.py
16:07:31 sean-k-mooney efried: regarding https://review.opendev.org/#/c/706276/ i can remove the changes related to the one ussuri spec that got pulled in but for the removal of the template, looking at the other releases we keep it in the root of the specs folder an remove it in the approve/implemented folder
16:07:32 bauzas stephenfin: oh my bad
16:07:43 bauzas stephenfin: lemme look at it
16:08:20 bauzas (for some reason, I only saw the L169 modification)
16:08:35 sean-k-mooney efried: so i think removing the template is correct and the only issue with the auto generated patch was the spec that got finished in ussuri
16:09:26 bauzas stephenfin: +W
16:10:47 sean-k-mooney yay :) it will be nice to have ^ merged
16:11:59 sean-k-mooney also very much https://review.opendev.org/#/c/663382/
16:20:09 openstackgerrit sean mooney proposed openstack/nova-specs master: move implemented spec for train https://review.opendev.org/706276
16:22:01 sean-k-mooney efried: ^ i fixed the incorrect spec but left the deletion of the symlinks to the template. the teamplate is still n the root spec folder i just wont be listed in teh set of specs on the specs site under specific release
16:30:14 stephenfin bauzas: Thanks :)
16:30:36 bauzas stephenfin: again, apologies for missing it
16:30:45 stephenfin it's all good
16:31:02 stephenfin least we know you and gibi think alike (he suggested adding it in the first place) ;)
16:31:45 sean-k-mooney stephenfin: i have given up on unit test being enough anythime i go near numa at this point
16:32:12 sean-k-mooney i just always assume a new functional test will be needed
16:34:21 stephenfin agreed
16:36:56 efried sean-k-mooney: Technically the reason to never delete anything without providing a redirect is in case there's a link to the old thing somewhere in the wild.
16:37:12 efried For a template for $release I'm not super worried about it, really.
16:37:29 efried but it's the Right Thing To Do
16:45:06 efried sean-k-mooney: Cross-cell resize needs to not be moved to implemented for Train. So since a respin is needed, might as well add those redirects.
16:45:51 efried For that matter, I'm really not convinced we need those templates in the directories in the first place. Maybe starting in V we can just drop them and just have specs/victoria-template.rst
16:46:15 efried or actually I would prefer specs/victoria/template.rst
17:02:00 sean-k-mooney efried: sorry was in a meeting just saw your comments ya ill make those changes manually so and update the script in a seperate change
17:02:55 sean-k-mooney efried: and ya we dont need the templates in the directories
17:03:13 sean-k-mooney i think they were there to make copying them 1% simpler
17:23:57 efried melwitt: there's no code for nova-audit yet, right?
17:24:46 dansmith gibi: I saw you +2d the bottom patch of the cyborg stuff but there's only +2s three patches up the stack
17:25:20 dansmith gibi: are you comfortable with the whole stack now? I haven't circled back on all the resched stuff yet, but should I?
17:25:40 dansmith sean-k-mooney: I don't suppose you've poked at the resched/move operations with the latest patch set yet have you?
17:30:15 efried brinzhang: Are you taking over https://review.opendev.org/#/c/623120/ (safer remote console with password authentication)?
17:30:40 efried More specifically the code here https://review.opendev.org/#/c/622336/ (last updated in May)
17:39:17 openstackgerrit Merged openstack/nova-specs master: FUP for NUMA Topology spec https://review.opendev.org/708088
17:39:18 openstackgerrit Merged openstack/nova-specs master: Fixed minor suggestions https://review.opendev.org/708058
17:39:48 sean-k-mooney dansmith: no i have not. would you like me to prioitise that
17:40:22 dansmith sean-k-mooney: well, I just figured since you had been doing testing with that stuff it'd be easier sooner than later
17:41:14 dansmith I suppose we can get on with the set without knowing that and fix it later if it doesn't work it's just one of those things where if we're not going to be able to gate on it normally, it could just never get tested/fixed
17:42:50 sean-k-mooney ok well i deploy 2 vms later today and set up the multi node env with the fake driver.
17:44:51 dansmith sean-k-mooney: yeah doing it with the fake driver seems enough to make sure the plumbing is good at least
17:45:19 sean-k-mooney cool ill do that so.
17:45:22 dansmith sean-k-mooney: is it possible that hacking some multi-node-ness on top of the tempest test patch in this set would be worthwhile for gating?
17:45:53 sean-k-mooney well i can just run the standard tempest multinode test with a cyborg flavor
17:46:15 sean-k-mooney i could proably hack up an experimtal job to do that
17:46:24 sean-k-mooney but im not sure if that is worth it or not
17:46:38 sean-k-mooney i guess i could add tests to the plugin
17:54:17 efried lyarwood: virt-bfv-instance-rescue -- what state is this code in? Would you say ready for review?
17:54:29 efried https://review.opendev.org/#/q/topic:bp/virt-bfv-instance-rescue+status:open
17:59:37 openstackgerrit Merged openstack/nova master: Recalculate 'RequestSpec.numa_topology' on resize https://review.opendev.org/662522
18:06:23 efried kashyap: What's the state of https://review.opendev.org/#/q/topic:bp/allow-secure-boot-for-qemu-kvm-guests+status:open ?
18:10:55 gibi dansmith: I will check the cyborg series tomorrow
18:30:45 openstackgerrit Eric Fried proposed openstack/nova-specs master: Move 'live migration with vpmems' spec https://review.opendev.org/708229
18:37:37 efried lyarwood: what about this one https://review.opendev.org/#/q/topic:bp/virt-rescue-stable-disk-devices+status:open
18:41:21 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing evacuate policies https://review.opendev.org/708230
18:41:32 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of existing evacuate policies https://review.opendev.org/708230
18:41:41 efried dustinc: checking in on provider config.
18:49:53 melwitt efried: no code yet
18:49:59 efried thx

Earlier   Later